From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Zhang, Qiang" <Qiang.Zhang@windriver.com>
Cc: Markus Elfring <markus.elfring@web.de>, Tejun Heo <tj@kernel.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: 回复: [PATCH v5] workqueue: Remove unnecessary kfree() call
Date: Thu, 28 May 2020 09:57:03 +0000 [thread overview]
Message-ID: <20200528095703.GH30374@kadam> (raw)
In-Reply-To: <DM6PR11MB3257D6E7E93A518392502809FF8E0@DM6PR11MB3257.namprd11.prod.outlook.com>
Guys, the patch is wrong. The kfree is harmless when this is called
from destroy_workqueue() and required when it's called from
pwq_unbound_release_workfn(). Lai Jiangshan already explained this
already. Why are we still discussing this?
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Zhang, Qiang" <Qiang.Zhang@windriver.com>
Cc: Markus Elfring <markus.elfring@web.de>, Tejun Heo <tj@kernel.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: 回复: [PATCH v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq()
Date: Thu, 28 May 2020 12:57:03 +0300 [thread overview]
Message-ID: <20200528095703.GH30374@kadam> (raw)
In-Reply-To: <DM6PR11MB3257D6E7E93A518392502809FF8E0@DM6PR11MB3257.namprd11.prod.outlook.com>
Guys, the patch is wrong. The kfree is harmless when this is called
from destroy_workqueue() and required when it's called from
pwq_unbound_release_workfn(). Lai Jiangshan already explained this
already. Why are we still discussing this?
regards,
dan carpenter
next prev parent reply other threads:[~2020-05-28 9:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 7:57 [PATCH v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq() qiang.zhang
2020-05-27 8:20 ` Markus Elfring
2020-05-27 8:20 ` Markus Elfring
[not found] ` <DM6PR11MB32573F3884A864ECD586235EFF8E0@DM6PR11MB3257.namprd11.prod.outlook.com>
2020-05-28 1:44 ` 回复: [PATCH v5] workqueue: Remove unnecessar =?gb2312?B?eSBrZnJlZSgpIGN Zhang, Qiang
2020-05-28 1:44 ` 回复: [PATCH v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq() Zhang, Qiang
2020-05-28 9:57 ` Dan Carpenter [this message]
2020-05-28 9:57 ` Dan Carpenter
2020-05-28 10:38 ` 回复: [PATCH v5] workqueue: Remove unnecessary kfree() call Tejun Heo
2020-05-28 10:38 ` 回复: [PATCH v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq() Tejun Heo
2020-05-28 11:00 ` [v5] " Markus Elfring
2020-05-28 11:00 ` Markus Elfring
2020-05-28 14:40 ` Markus Elfring
2020-05-28 14:40 ` Markus Elfring
2020-05-28 12:08 ` 回复: [PATCH v5] workqueue: Remove unnecessary =?UTF-8?B?IGtmc Lai Jiangshan
2020-05-28 12:08 ` 回复: [PATCH v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq() Lai Jiangshan
2020-05-28 12:25 ` 回复: [PATCH v5] workqueue: Remove unnecessary kfree() call Dan Carpenter
2020-05-28 12:25 ` 回复: [PATCH v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq() Dan Carpenter
2020-05-28 13:27 ` 回复: [PATCH v5] workqueue: Remove unnecessary =?UTF-8?B?IGtmc Lai Jiangshan
2020-05-28 13:27 ` 回复: [PATCH v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq() Lai Jiangshan
2020-05-28 14:03 ` 回复: [PATCH v5] workqueue: Remove unnecessary kfree() call Tejun Heo
2020-05-28 14:03 ` 回复: [PATCH v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq() Tejun Heo
2020-05-28 14:45 ` [v5] " Markus Elfring
2020-05-28 14:45 ` Markus Elfring
2020-05-28 14:06 ` 回复: [PATCH v5] workqueue: Remove unnecessary kfree() call Dan Carpenter
2020-05-28 14:06 ` 回复: [PATCH v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq() Dan Carpenter
2020-05-28 15:25 ` [v5] " Markus Elfring
2020-05-28 15:25 ` Markus Elfring
2020-05-28 15:02 ` Markus Elfring
2020-05-28 15:02 ` Markus Elfring
2020-05-28 15:02 ` Markus Elfring
2020-05-28 15:02 ` Markus Elfring
2020-05-27 13:52 ` [PATCH v5] " Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528095703.GH30374@kadam \
--to=dan.carpenter@oracle.com \
--cc=Qiang.Zhang@windriver.com \
--cc=jiangshanlai@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.elfring@web.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.