From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2 3/6] lockdep: Change hardirq{s_enabled, _context} to per-cpu variables
Date: Fri, 29 May 2020 12:12:31 +0800 [thread overview]
Message-ID: <202005291202.Ccansc3E%lkp@intel.com> (raw)
In-Reply-To: <20200528140946.831087909@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 7213 bytes --]
Hi Peter,
I love your patch! Yet something to improve:
[auto build test ERROR on tip/auto-latest]
[cannot apply to tip/locking/core tip/x86/asm linus/master tip/x86/core v5.7-rc7 next-20200528]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Peter-Zijlstra/x86-entry-lockdep-Improve-IRQ-state-tracking/20200528-222257
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 4e052965f46b6fd9641d79bf10208eac2631475f
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
In file included from arch/sparc/include/asm/percpu_64.h:11,
from arch/sparc/include/asm/percpu.h:5,
from include/linux/irqflags.h:17,
from include/asm-generic/cmpxchg-local.h:6,
from arch/sparc/include/asm/cmpxchg_64.h:111,
from arch/sparc/include/asm/cmpxchg.h:5,
from arch/sparc/include/asm/atomic_64.h:12,
from arch/sparc/include/asm/atomic.h:5,
from include/linux/atomic.h:7,
from include/asm-generic/bitops/lock.h:5,
from arch/sparc/include/asm/bitops_64.h:52,
from arch/sparc/include/asm/bitops.h:5,
from include/linux/bitops.h:29,
from include/linux/kernel.h:12,
from include/asm-generic/bug.h:19,
from arch/sparc/include/asm/bug.h:25,
from include/linux/bug.h:5,
from include/linux/page-flags.h:10,
from kernel/bounds.c:10:
>> arch/sparc/include/asm/trap_block.h:54:39: error: 'NR_CPUS' undeclared here (not in a function)
54 | extern struct trap_per_cpu trap_block[NR_CPUS];
| ^~~~~~~
make[2]: *** [scripts/Makefile.build:100: kernel/bounds.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1149: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:180: sub-make] Error 2
vim +/NR_CPUS +54 arch/sparc/include/asm/trap_block.h
19f0fa3fb3499d8c David S. Miller 2009-04-01 9
19f0fa3fb3499d8c David S. Miller 2009-04-01 10 /* Trap handling code needs to get at a few critical values upon
19f0fa3fb3499d8c David S. Miller 2009-04-01 11 * trap entry and to process TSB misses. These cannot be in the
19f0fa3fb3499d8c David S. Miller 2009-04-01 12 * per_cpu() area as we really need to lock them into the TLB and
19f0fa3fb3499d8c David S. Miller 2009-04-01 13 * thus make them part of the main kernel image. As a result we
19f0fa3fb3499d8c David S. Miller 2009-04-01 14 * try to make this as small as possible.
19f0fa3fb3499d8c David S. Miller 2009-04-01 15 *
19f0fa3fb3499d8c David S. Miller 2009-04-01 16 * This is padded out and aligned to 64-bytes to avoid false sharing
19f0fa3fb3499d8c David S. Miller 2009-04-01 17 * on SMP.
19f0fa3fb3499d8c David S. Miller 2009-04-01 18 */
19f0fa3fb3499d8c David S. Miller 2009-04-01 19
19f0fa3fb3499d8c David S. Miller 2009-04-01 20 /* If you modify the size of this structure, please update
19f0fa3fb3499d8c David S. Miller 2009-04-01 21 * TRAP_BLOCK_SZ_SHIFT below.
19f0fa3fb3499d8c David S. Miller 2009-04-01 22 */
19f0fa3fb3499d8c David S. Miller 2009-04-01 23 struct thread_info;
19f0fa3fb3499d8c David S. Miller 2009-04-01 24 struct trap_per_cpu {
19f0fa3fb3499d8c David S. Miller 2009-04-01 25 /* D-cache line 1: Basic thread information, cpu and device mondo queues */
19f0fa3fb3499d8c David S. Miller 2009-04-01 26 struct thread_info *thread;
19f0fa3fb3499d8c David S. Miller 2009-04-01 27 unsigned long pgd_paddr;
19f0fa3fb3499d8c David S. Miller 2009-04-01 28 unsigned long cpu_mondo_pa;
19f0fa3fb3499d8c David S. Miller 2009-04-01 29 unsigned long dev_mondo_pa;
19f0fa3fb3499d8c David S. Miller 2009-04-01 30
19f0fa3fb3499d8c David S. Miller 2009-04-01 31 /* D-cache line 2: Error Mondo Queue and kernel buffer pointers */
19f0fa3fb3499d8c David S. Miller 2009-04-01 32 unsigned long resum_mondo_pa;
19f0fa3fb3499d8c David S. Miller 2009-04-01 33 unsigned long resum_kernel_buf_pa;
19f0fa3fb3499d8c David S. Miller 2009-04-01 34 unsigned long nonresum_mondo_pa;
19f0fa3fb3499d8c David S. Miller 2009-04-01 35 unsigned long nonresum_kernel_buf_pa;
19f0fa3fb3499d8c David S. Miller 2009-04-01 36
19f0fa3fb3499d8c David S. Miller 2009-04-01 37 /* Dcache lines 3, 4, 5, and 6: Hypervisor Fault Status */
19f0fa3fb3499d8c David S. Miller 2009-04-01 38 struct hv_fault_status fault_info;
19f0fa3fb3499d8c David S. Miller 2009-04-01 39
19f0fa3fb3499d8c David S. Miller 2009-04-01 40 /* Dcache line 7: Physical addresses of CPU send mondo block and CPU list. */
19f0fa3fb3499d8c David S. Miller 2009-04-01 41 unsigned long cpu_mondo_block_pa;
19f0fa3fb3499d8c David S. Miller 2009-04-01 42 unsigned long cpu_list_pa;
19f0fa3fb3499d8c David S. Miller 2009-04-01 43 unsigned long tsb_huge;
19f0fa3fb3499d8c David S. Miller 2009-04-01 44 unsigned long tsb_huge_temp;
19f0fa3fb3499d8c David S. Miller 2009-04-01 45
19f0fa3fb3499d8c David S. Miller 2009-04-01 46 /* Dcache line 8: IRQ work list, and keep trap_block a power-of-2 in size. */
19f0fa3fb3499d8c David S. Miller 2009-04-01 47 unsigned long irq_worklist_pa;
19f0fa3fb3499d8c David S. Miller 2009-04-01 48 unsigned int cpu_mondo_qmask;
19f0fa3fb3499d8c David S. Miller 2009-04-01 49 unsigned int dev_mondo_qmask;
19f0fa3fb3499d8c David S. Miller 2009-04-01 50 unsigned int resum_qmask;
19f0fa3fb3499d8c David S. Miller 2009-04-01 51 unsigned int nonresum_qmask;
5a5488d3bb9a23d9 David S. Miller 2009-04-01 52 unsigned long __per_cpu_base;
19f0fa3fb3499d8c David S. Miller 2009-04-01 53 } __attribute__((aligned(64)));
19f0fa3fb3499d8c David S. Miller 2009-04-01 @54 extern struct trap_per_cpu trap_block[NR_CPUS];
f05a68653e56ca2f Sam Ravnborg 2014-05-16 55 void init_cur_cpu_trap(struct thread_info *);
f05a68653e56ca2f Sam Ravnborg 2014-05-16 56 void setup_tba(void);
19f0fa3fb3499d8c David S. Miller 2009-04-01 57 extern int ncpus_probed;
9d53caec84c7c570 Jane Chu 2017-07-11 58 extern u64 cpu_mondo_counter[NR_CPUS];
19f0fa3fb3499d8c David S. Miller 2009-04-01 59
:::::: The code at line 54 was first introduced by commit
:::::: 19f0fa3fb3499d8c5fb861933959f546d05fc202 sparc64: Move trap_block[] definitions into a new header file.
:::::: TO: David S. Miller <davem@davemloft.net>
:::::: CC: David S. Miller <davem@davemloft.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 62441 bytes --]
next prev parent reply other threads:[~2020-05-29 4:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 14:05 [PATCH v2 0/6] x86/entry,lockdep: Improve IRQ state tracking Peter Zijlstra
2020-05-28 14:05 ` [PATCH v2 1/6] x86/entry: Clarify irq_{enter,exit}_rcu() Peter Zijlstra
2020-05-28 14:05 ` [PATCH v2 2/6] x86/entry: Rename trace_hardirqs_off_prepare() Peter Zijlstra
2020-05-28 14:05 ` [PATCH v2 3/6] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables Peter Zijlstra
2020-05-29 3:55 ` [PATCH v2 3/6] lockdep: Change hardirq{s_enabled, _context} " kbuild test robot
2020-05-29 4:12 ` kbuild test robot [this message]
2020-05-29 16:16 ` [PATCH v2 3/6] lockdep: Change hardirq{s_enabled,_context} " Peter Zijlstra
2020-05-29 19:38 ` Peter Zijlstra
2020-05-28 14:05 ` [PATCH v2 4/6] lockdep: Remove lockdep_hardirq{s_enabled,_context}() argument Peter Zijlstra
2020-05-28 14:05 ` [PATCH v2 5/6] lockdep: Prepare for NMI IRQ state tracking Peter Zijlstra
2020-05-28 14:05 ` [PATCH v2 6/6] x86/entry: Fix NMI vs " Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202005291202.Ccansc3E%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.