All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 3/4] net: add a new bind_add method
Date: Fri, 29 May 2020 13:06:55 -0300	[thread overview]
Message-ID: <20200529160655.GJ2491@localhost.localdomain> (raw)
In-Reply-To: <20200529120943.101454-4-hch@lst.de>

On Fri, May 29, 2020 at 02:09:42PM +0200, Christoph Hellwig wrote:
> The SCTP protocol allows to bind multiple address to a socket.  That
> feature is currently only exposed as a socket option.  Add a bind_add
> method struct proto that allows to bind additional addresses, and
> switch the dlm code to use the method instead of going through the
> socket option from kernel space.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>

Even though checkpatch complained about bad alignment here:
> +static int sctp_bind_add(struct sock *sk, struct sockaddr *addrs,
> +		int addrlen)



WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Vlad Yasevich <vyasevich@gmail.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	David Laight <David.Laight@aculab.com>,
	linux-sctp@vger.kernel.org, linux-kernel@vger.kernel.org,
	cluster-devel@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH 3/4] net: add a new bind_add method
Date: Fri, 29 May 2020 16:06:55 +0000	[thread overview]
Message-ID: <20200529160655.GJ2491@localhost.localdomain> (raw)
In-Reply-To: <20200529120943.101454-4-hch@lst.de>

On Fri, May 29, 2020 at 02:09:42PM +0200, Christoph Hellwig wrote:
> The SCTP protocol allows to bind multiple address to a socket.  That
> feature is currently only exposed as a socket option.  Add a bind_add
> method struct proto that allows to bind additional addresses, and
> switch the dlm code to use the method instead of going through the
> socket option from kernel space.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>

Even though checkpatch complained about bad alignment here:
> +static int sctp_bind_add(struct sock *sk, struct sockaddr *addrs,
> +		int addrlen)

WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Vlad Yasevich <vyasevich@gmail.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	David Laight <David.Laight@aculab.com>,
	linux-sctp@vger.kernel.org, linux-kernel@vger.kernel.org,
	cluster-devel@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH 3/4] net: add a new bind_add method
Date: Fri, 29 May 2020 13:06:55 -0300	[thread overview]
Message-ID: <20200529160655.GJ2491@localhost.localdomain> (raw)
In-Reply-To: <20200529120943.101454-4-hch@lst.de>

On Fri, May 29, 2020 at 02:09:42PM +0200, Christoph Hellwig wrote:
> The SCTP protocol allows to bind multiple address to a socket.  That
> feature is currently only exposed as a socket option.  Add a bind_add
> method struct proto that allows to bind additional addresses, and
> switch the dlm code to use the method instead of going through the
> socket option from kernel space.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>

Even though checkpatch complained about bad alignment here:
> +static int sctp_bind_add(struct sock *sk, struct sockaddr *addrs,
> +		int addrlen)

  reply	other threads:[~2020-05-29 16:06 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-29 12:09 [Cluster-devel] remove kernel_setsockopt v4 Christoph Hellwig
2020-05-29 12:09 ` Christoph Hellwig
2020-05-29 12:09 ` Christoph Hellwig
2020-05-29 12:09 ` [Cluster-devel] [PATCH 1/4] sctp: add sctp_sock_set_nodelay Christoph Hellwig
2020-05-29 12:09   ` Christoph Hellwig
2020-05-29 12:09   ` Christoph Hellwig
2020-05-29 16:05   ` [Cluster-devel] " Marcelo Ricardo Leitner
2020-05-29 16:05     ` Marcelo Ricardo Leitner
2020-05-29 16:05     ` Marcelo Ricardo Leitner
2020-05-29 18:09   ` [Cluster-devel] " David Teigland
2020-05-29 18:09     ` David Teigland
2020-05-29 18:09     ` David Teigland
2020-05-29 12:09 ` [Cluster-devel] [PATCH 2/4] sctp: refactor sctp_setsockopt_bindx Christoph Hellwig
2020-05-29 12:09   ` Christoph Hellwig
2020-05-29 12:09   ` Christoph Hellwig
2020-05-29 16:05   ` [Cluster-devel] " Marcelo Ricardo Leitner
2020-05-29 16:05     ` Marcelo Ricardo Leitner
2020-05-29 16:05     ` Marcelo Ricardo Leitner
2020-06-01  8:27     ` [Cluster-devel] " David Laight
2020-06-01  8:27       ` David Laight
2020-06-01  8:27       ` David Laight
2020-05-29 12:09 ` [Cluster-devel] [PATCH 3/4] net: add a new bind_add method Christoph Hellwig
2020-05-29 12:09   ` Christoph Hellwig
2020-05-29 12:09   ` Christoph Hellwig
2020-05-29 16:06   ` Marcelo Ricardo Leitner [this message]
2020-05-29 16:06     ` Marcelo Ricardo Leitner
2020-05-29 16:06     ` Marcelo Ricardo Leitner
2020-05-29 12:09 ` [Cluster-devel] [PATCH 4/4] net: remove kernel_setsockopt Christoph Hellwig
2020-05-29 12:09   ` Christoph Hellwig
2020-05-29 12:09   ` Christoph Hellwig
2020-05-29 12:27   ` [Cluster-devel] " David Laight
2020-05-29 12:27     ` David Laight
2020-05-29 12:29     ` [Cluster-devel] " 'Christoph Hellwig'
2020-05-29 12:29       ` 'Christoph Hellwig'
2020-05-29 12:29       ` 'Christoph Hellwig'
2020-05-29 16:10   ` [Cluster-devel] " Marcelo Ricardo Leitner
2020-05-29 16:10     ` Marcelo Ricardo Leitner
2020-05-29 16:10     ` Marcelo Ricardo Leitner
2020-05-29 20:11 ` [Cluster-devel] remove kernel_setsockopt v4 David Miller
2020-05-29 20:11   ` David Miller
2020-05-29 20:11   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200529160655.GJ2491@localhost.localdomain \
    --to=marcelo.leitner@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.