All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: robh@kernel.org, kernel@puri.sm, Anson.Huang@nxp.com,
	devicetree@vger.kernel.org, shawnguo@kernel.org,
	s.hauer@pengutronix.de, angus@akkea.ca,
	linux-kernel@vger.kernel.org, linux-imx@nxp.com,
	kernel@pengutronix.de, mchehab@kernel.org, festevam@gmail.com,
	agx@sigxcpu.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] arm64: dts: Add a device tree for the Librem5 phone
Date: Fri, 29 May 2020 18:28:50 +0200	[thread overview]
Message-ID: <20200529162850.GC3709@amd> (raw)
In-Reply-To: <20200514155737.12160-1-martin.kepplinger@puri.sm>


[-- Attachment #1.1: Type: text/plain, Size: 1342 bytes --]

Hi!

> From: "Angus Ainslie (Purism)" <angus@akkea.ca>
> 
> Add a devicetree description for the Librem 5 phone. The early batches
> that have been sold are supported as well as the mass-produced device
> available later this year, see https://puri.sm/products/librem-5/
> 
> This boots to a working console with working WWAN modem, wifi usdhc,
> IMU sensor device, proximity sensor, haptic motor, gpio keys, GNSS and LEDs.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>


> +		blue {
> +			label = "phone:blue:front";
> +			label = "phone:green:front";
> +			label = "phone:red:front";

Droid 4 uses "status-led:{red,green,blue}". Could this use same
naming?

> +			label = "lm3560:flash";
> +			label = "lm3560:torch";

This is one LED, right? I'm pretty sure we don't want lm3560 in the
name... "main-camera:flash" would be better. Even better would be
something that's already in use.

> +			label = "white:backlight_cluster";

Make this ":backlight", please. Again, we want something that's
already used.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: robh@kernel.org, kernel@puri.sm, shawnguo@kernel.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, linux-imx@nxp.com, mchehab@kernel.org,
	Anson.Huang@nxp.com, agx@sigxcpu.org, angus@akkea.ca,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] arm64: dts: Add a device tree for the Librem5 phone
Date: Fri, 29 May 2020 18:28:50 +0200	[thread overview]
Message-ID: <20200529162850.GC3709@amd> (raw)
In-Reply-To: <20200514155737.12160-1-martin.kepplinger@puri.sm>

[-- Attachment #1: Type: text/plain, Size: 1342 bytes --]

Hi!

> From: "Angus Ainslie (Purism)" <angus@akkea.ca>
> 
> Add a devicetree description for the Librem 5 phone. The early batches
> that have been sold are supported as well as the mass-produced device
> available later this year, see https://puri.sm/products/librem-5/
> 
> This boots to a working console with working WWAN modem, wifi usdhc,
> IMU sensor device, proximity sensor, haptic motor, gpio keys, GNSS and LEDs.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>


> +		blue {
> +			label = "phone:blue:front";
> +			label = "phone:green:front";
> +			label = "phone:red:front";

Droid 4 uses "status-led:{red,green,blue}". Could this use same
naming?

> +			label = "lm3560:flash";
> +			label = "lm3560:torch";

This is one LED, right? I'm pretty sure we don't want lm3560 in the
name... "main-camera:flash" would be better. Even better would be
something that's already in use.

> +			label = "white:backlight_cluster";

Make this ":backlight", please. Again, we want something that's
already used.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  parent reply	other threads:[~2020-05-29 16:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14 15:57 [PATCH 1/2] arm64: dts: Add a device tree for the Librem5 phone Martin Kepplinger
2020-05-14 15:57 ` Martin Kepplinger
2020-05-14 15:57 ` [PATCH 2/2] MAINTAINERS: Add Purism Librem 5 section to the list Martin Kepplinger
2020-05-14 15:57   ` Martin Kepplinger
2020-05-27  9:40   ` Marco Felsch
2020-05-27  9:40     ` Marco Felsch
2020-05-27 19:40     ` Martin Kepplinger
2020-05-27 19:40       ` Martin Kepplinger
2020-05-25  8:47 ` [PATCH 1/2] arm64: dts: Add a device tree for the Librem5 phone Martin Kepplinger
2020-05-25  8:47   ` Martin Kepplinger
2020-05-26 11:39 ` Daniel Baluta
2020-05-26 11:39   ` Daniel Baluta
2020-05-27  9:35 ` Marco Felsch
2020-05-27  9:35   ` Marco Felsch
2020-06-02 15:44   ` Martin Kepplinger
2020-06-02 15:44     ` Martin Kepplinger
2020-05-29 16:28 ` Pavel Machek [this message]
2020-05-29 16:28   ` Pavel Machek
2020-05-29 18:07   ` Pavel Machek
2020-05-29 18:07     ` Pavel Machek
2020-05-29 18:20     ` Martin Kepplinger
2020-05-29 18:20       ` Martin Kepplinger
2020-05-31 15:36   ` Guido Günther
2020-05-31 15:36     ` Guido Günther

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200529162850.GC3709@amd \
    --to=pavel@ucw.cz \
    --cc=Anson.Huang@nxp.com \
    --cc=agx@sigxcpu.org \
    --cc=angus@akkea.ca \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=kernel@puri.sm \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.kepplinger@puri.sm \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.