From: Jason Gunthorpe <jgg@ziepe.ca>
To: Colin King <colin.king@canonical.com>
Cc: Lijun Ou <oulijun@huawei.com>, Wei Hu <huwei87@hisilicon.com>,
Weihang Li <liweihang@huawei.com>,
Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] RDMA/hns: remove duplicate assignment to pointer raq
Date: Fri, 29 May 2020 18:20:36 +0000 [thread overview]
Message-ID: <20200529182036.GA11361@ziepe.ca> (raw)
In-Reply-To: <20200528150427.420624-1-colin.king@canonical.com>
On Thu, May 28, 2020 at 04:04:27PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer raq is being assigned twice. Fix this by removing
> one of the redundant assignments.
>
> Fixes: 14ba87304bf9 ("RDMA/hns: Remove redundant type cast for general pointers")
> Addressses-Coverity: ("Evaluation order violation")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-next
Thanks,
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Colin King <colin.king@canonical.com>
Cc: Lijun Ou <oulijun@huawei.com>, Wei Hu <huwei87@hisilicon.com>,
Weihang Li <liweihang@huawei.com>,
Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] RDMA/hns: remove duplicate assignment to pointer raq
Date: Fri, 29 May 2020 15:20:36 -0300 [thread overview]
Message-ID: <20200529182036.GA11361@ziepe.ca> (raw)
In-Reply-To: <20200528150427.420624-1-colin.king@canonical.com>
On Thu, May 28, 2020 at 04:04:27PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer raq is being assigned twice. Fix this by removing
> one of the redundant assignments.
>
> Fixes: 14ba87304bf9 ("RDMA/hns: Remove redundant type cast for general pointers")
> Addressses-Coverity: ("Evaluation order violation")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-next
Thanks,
Jason
next prev parent reply other threads:[~2020-05-29 18:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 15:04 [PATCH][next] RDMA/hns: remove duplicate assignment to pointer raq Colin King
2020-05-28 15:04 ` Colin King
2020-05-29 7:26 ` oulijun
2020-05-29 7:26 ` oulijun
2020-05-29 18:20 ` Jason Gunthorpe [this message]
2020-05-29 18:20 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529182036.GA11361@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=colin.king@canonical.com \
--cc=dledford@redhat.com \
--cc=huwei87@hisilicon.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=liweihang@huawei.com \
--cc=oulijun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.