All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/selftests/mm: reduce per-function stack usage
@ 2020-05-29 20:15 ` Arnd Bergmann
  0 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2020-05-29 20:15 UTC (permalink / raw)
  To: David Airlie, Daniel Vetter, Christian König, Nirmoy Das,
	Chris Wilson
  Cc: linux-kernel, dri-devel, kbuild test robot, Arnd Bergmann,
	Tvrtko Ursulin

The check_reserve_boundaries() function has a large array on the stack,
over 500 bytes. It gets inlined into __igt_reserve, which has multiple
other large structures as well but stayed just under the stack size
warning limit of 1024 bytes until one more member got added to struct
drm_mm_node, causing a warning:

drivers/gpu/drm/selftests/test-drm_mm.c:371:12: error:
stack frame size of 1032 bytes in function '__igt_reserve' [-Werror,-Wframe-larger-than=]

As far as I can tell, this is not nice but will not be called from
a context that is already low for the kernel stack, so just annotate
the inner function as noinline_for_stack to ensure that each function
by itself stays under the warning limit.

Fixes: 0cdea4455acd ("drm/mm: optimize rb_hole_addr rbtree search")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/selftests/test-drm_mm.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/selftests/test-drm_mm.c b/drivers/gpu/drm/selftests/test-drm_mm.c
index 9aabe82dcd3a..30108c330db8 100644
--- a/drivers/gpu/drm/selftests/test-drm_mm.c
+++ b/drivers/gpu/drm/selftests/test-drm_mm.c
@@ -323,9 +323,8 @@ static bool expect_reserve_fail(struct drm_mm *mm, struct drm_mm_node *node)
 	return false;
 }
 
-static bool check_reserve_boundaries(struct drm_mm *mm,
-				     unsigned int count,
-				     u64 size)
+static noinline_for_stack bool
+check_reserve_boundaries(struct drm_mm *mm, unsigned int count, u64 size)
 {
 	const struct boundary {
 		u64 start, size;
-- 
2.26.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-05-30  2:35 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-29 20:15 [PATCH] drm/selftests/mm: reduce per-function stack usage Arnd Bergmann
2020-05-29 20:15 ` Arnd Bergmann
2020-05-29 20:26 ` Chris Wilson
2020-05-29 20:43   ` Arnd Bergmann
2020-05-29 20:43     ` Arnd Bergmann
2020-05-29 21:36     ` Chris Wilson
2020-05-29 20:34 ` [Intel-gfx] [PATCH] compact-test-array Chris Wilson
2020-05-29 22:20 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for compact-test-array Patchwork
2020-05-29 22:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-05-30  2:35 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.