All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH net] net: dsa: sja1105: fix port mirroring for P/Q/R/S
Date: Sat, 30 May 2020 03:33:46 +0800	[thread overview]
Message-ID: <202005300337.jkabGc4k%lkp@intel.com> (raw)
In-Reply-To: <20200527164006.1080903-1-olteanv@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 6546 bytes --]

Hi Vladimir,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]
[also build test WARNING on sparc-next/master linus/master v5.7-rc7 next-20200529]
[cannot apply to net/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Vladimir-Oltean/net-dsa-sja1105-fix-port-mirroring-for-P-Q-R-S/20200528-004418
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git dc0f3ed1973f101508957b59e529e03da1349e09
config: parisc-allyesconfig (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

drivers/net/dsa/sja1105/sja1105_static_config.c:105:8: warning: no previous prototype for 'sja1105pqrs_avb_params_entry_packing' [-Wmissing-prototypes]
105 | size_t sja1105pqrs_avb_params_entry_packing(void *buf, void *entry_ptr,
|        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/dsa/sja1105/sja1105_static_config.c:149:8: warning: no previous prototype for 'sja1105pqrs_general_params_entry_packing' [-Wmissing-prototypes]
149 | size_t sja1105pqrs_general_params_entry_packing(void *buf, void *entry_ptr,
|        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/sja1105/sja1105_static_config.c:198:8: warning: no previous prototype for 'sja1105_l2_forwarding_entry_packing' [-Wmissing-prototypes]
198 | size_t sja1105_l2_forwarding_entry_packing(void *buf, void *entry_ptr,
|        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/sja1105/sja1105_static_config.c:230:8: warning: no previous prototype for 'sja1105pqrs_l2_lookup_params_entry_packing' [-Wmissing-prototypes]
230 | size_t sja1105pqrs_l2_lookup_params_entry_packing(void *buf, void *entry_ptr,
|        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/sja1105/sja1105_static_config.c:252:8: warning: no previous prototype for 'sja1105et_l2_lookup_entry_packing' [-Wmissing-prototypes]
252 | size_t sja1105et_l2_lookup_entry_packing(void *buf, void *entry_ptr,
|        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/sja1105/sja1105_static_config.c:266:8: warning: no previous prototype for 'sja1105pqrs_l2_lookup_entry_packing' [-Wmissing-prototypes]
266 | size_t sja1105pqrs_l2_lookup_entry_packing(void *buf, void *entry_ptr,
|        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/sja1105/sja1105_static_config.c:342:8: warning: no previous prototype for 'sja1105pqrs_mac_config_entry_packing' [-Wmissing-prototypes]
342 | size_t sja1105pqrs_mac_config_entry_packing(void *buf, void *entry_ptr,
|        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/sja1105/sja1105_static_config.c:461:8: warning: no previous prototype for 'sja1105_vl_lookup_entry_packing' [-Wmissing-prototypes]
461 | size_t sja1105_vl_lookup_entry_packing(void *buf, void *entry_ptr,
|        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/sja1105/sja1105_static_config.c:511:8: warning: no previous prototype for 'sja1105_vlan_lookup_entry_packing' [-Wmissing-prototypes]
511 | size_t sja1105_vlan_lookup_entry_packing(void *buf, void *entry_ptr,
|        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/sja1105/sja1105_static_config.c:542:8: warning: no previous prototype for 'sja1105_retagging_entry_packing' [-Wmissing-prototypes]
542 | size_t sja1105_retagging_entry_packing(void *buf, void *entry_ptr,
|        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/sja1105pqrs_general_params_entry_packing +149 drivers/net/dsa/sja1105/sja1105_static_config.c

   145	
   146	/* TPID and TPID2 are intentionally reversed so that semantic
   147	 * compatibility with E/T is kept.
   148	 */
 > 149	size_t sja1105pqrs_general_params_entry_packing(void *buf, void *entry_ptr,
   150							enum packing_op op)
   151	{
   152		const size_t size = SJA1105PQRS_SIZE_GENERAL_PARAMS_ENTRY;
   153		struct sja1105_general_params_entry *entry = entry_ptr;
   154	
   155		sja1105_packing(buf, &entry->vllupformat, 351, 351, size, op);
   156		sja1105_packing(buf, &entry->mirr_ptacu,  350, 350, size, op);
   157		sja1105_packing(buf, &entry->switchid,    349, 347, size, op);
   158		sja1105_packing(buf, &entry->hostprio,    346, 344, size, op);
   159		sja1105_packing(buf, &entry->mac_fltres1, 343, 296, size, op);
   160		sja1105_packing(buf, &entry->mac_fltres0, 295, 248, size, op);
   161		sja1105_packing(buf, &entry->mac_flt1,    247, 200, size, op);
   162		sja1105_packing(buf, &entry->mac_flt0,    199, 152, size, op);
   163		sja1105_packing(buf, &entry->incl_srcpt1, 151, 151, size, op);
   164		sja1105_packing(buf, &entry->incl_srcpt0, 150, 150, size, op);
   165		sja1105_packing(buf, &entry->send_meta1,  149, 149, size, op);
   166		sja1105_packing(buf, &entry->send_meta0,  148, 148, size, op);
   167		sja1105_packing(buf, &entry->casc_port,   147, 145, size, op);
   168		sja1105_packing(buf, &entry->host_port,   144, 142, size, op);
   169		sja1105_packing(buf, &entry->mirr_port,   141, 139, size, op);
   170		sja1105_packing(buf, &entry->vlmarker,    138, 107, size, op);
   171		sja1105_packing(buf, &entry->vlmask,      106,  75, size, op);
   172		sja1105_packing(buf, &entry->tpid2,        74,  59, size, op);
   173		sja1105_packing(buf, &entry->ignore2stf,   58,  58, size, op);
   174		sja1105_packing(buf, &entry->tpid,         57,  42, size, op);
   175		sja1105_packing(buf, &entry->queue_ts,     41,  41, size, op);
   176		sja1105_packing(buf, &entry->egrmirrvid,   40,  29, size, op);
   177		sja1105_packing(buf, &entry->egrmirrpcp,   28,  26, size, op);
   178		sja1105_packing(buf, &entry->egrmirrdei,   25,  25, size, op);
   179		sja1105_packing(buf, &entry->replay_port,  24,  22, size, op);
   180		return size;
   181	}
   182	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 61666 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: Vladimir Oltean <olteanv@gmail.com>, davem@davemloft.net
Cc: kbuild-all@lists.01.org, andrew@lunn.ch, f.fainelli@gmail.com,
	vivien.didelot@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: sja1105: fix port mirroring for P/Q/R/S
Date: Sat, 30 May 2020 03:33:46 +0800	[thread overview]
Message-ID: <202005300337.jkabGc4k%lkp@intel.com> (raw)
In-Reply-To: <20200527164006.1080903-1-olteanv@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 6443 bytes --]

Hi Vladimir,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]
[also build test WARNING on sparc-next/master linus/master v5.7-rc7 next-20200529]
[cannot apply to net/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Vladimir-Oltean/net-dsa-sja1105-fix-port-mirroring-for-P-Q-R-S/20200528-004418
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git dc0f3ed1973f101508957b59e529e03da1349e09
config: parisc-allyesconfig (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

drivers/net/dsa/sja1105/sja1105_static_config.c:105:8: warning: no previous prototype for 'sja1105pqrs_avb_params_entry_packing' [-Wmissing-prototypes]
105 | size_t sja1105pqrs_avb_params_entry_packing(void *buf, void *entry_ptr,
|        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/dsa/sja1105/sja1105_static_config.c:149:8: warning: no previous prototype for 'sja1105pqrs_general_params_entry_packing' [-Wmissing-prototypes]
149 | size_t sja1105pqrs_general_params_entry_packing(void *buf, void *entry_ptr,
|        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/sja1105/sja1105_static_config.c:198:8: warning: no previous prototype for 'sja1105_l2_forwarding_entry_packing' [-Wmissing-prototypes]
198 | size_t sja1105_l2_forwarding_entry_packing(void *buf, void *entry_ptr,
|        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/sja1105/sja1105_static_config.c:230:8: warning: no previous prototype for 'sja1105pqrs_l2_lookup_params_entry_packing' [-Wmissing-prototypes]
230 | size_t sja1105pqrs_l2_lookup_params_entry_packing(void *buf, void *entry_ptr,
|        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/sja1105/sja1105_static_config.c:252:8: warning: no previous prototype for 'sja1105et_l2_lookup_entry_packing' [-Wmissing-prototypes]
252 | size_t sja1105et_l2_lookup_entry_packing(void *buf, void *entry_ptr,
|        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/sja1105/sja1105_static_config.c:266:8: warning: no previous prototype for 'sja1105pqrs_l2_lookup_entry_packing' [-Wmissing-prototypes]
266 | size_t sja1105pqrs_l2_lookup_entry_packing(void *buf, void *entry_ptr,
|        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/sja1105/sja1105_static_config.c:342:8: warning: no previous prototype for 'sja1105pqrs_mac_config_entry_packing' [-Wmissing-prototypes]
342 | size_t sja1105pqrs_mac_config_entry_packing(void *buf, void *entry_ptr,
|        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/sja1105/sja1105_static_config.c:461:8: warning: no previous prototype for 'sja1105_vl_lookup_entry_packing' [-Wmissing-prototypes]
461 | size_t sja1105_vl_lookup_entry_packing(void *buf, void *entry_ptr,
|        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/sja1105/sja1105_static_config.c:511:8: warning: no previous prototype for 'sja1105_vlan_lookup_entry_packing' [-Wmissing-prototypes]
511 | size_t sja1105_vlan_lookup_entry_packing(void *buf, void *entry_ptr,
|        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/sja1105/sja1105_static_config.c:542:8: warning: no previous prototype for 'sja1105_retagging_entry_packing' [-Wmissing-prototypes]
542 | size_t sja1105_retagging_entry_packing(void *buf, void *entry_ptr,
|        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/sja1105pqrs_general_params_entry_packing +149 drivers/net/dsa/sja1105/sja1105_static_config.c

   145	
   146	/* TPID and TPID2 are intentionally reversed so that semantic
   147	 * compatibility with E/T is kept.
   148	 */
 > 149	size_t sja1105pqrs_general_params_entry_packing(void *buf, void *entry_ptr,
   150							enum packing_op op)
   151	{
   152		const size_t size = SJA1105PQRS_SIZE_GENERAL_PARAMS_ENTRY;
   153		struct sja1105_general_params_entry *entry = entry_ptr;
   154	
   155		sja1105_packing(buf, &entry->vllupformat, 351, 351, size, op);
   156		sja1105_packing(buf, &entry->mirr_ptacu,  350, 350, size, op);
   157		sja1105_packing(buf, &entry->switchid,    349, 347, size, op);
   158		sja1105_packing(buf, &entry->hostprio,    346, 344, size, op);
   159		sja1105_packing(buf, &entry->mac_fltres1, 343, 296, size, op);
   160		sja1105_packing(buf, &entry->mac_fltres0, 295, 248, size, op);
   161		sja1105_packing(buf, &entry->mac_flt1,    247, 200, size, op);
   162		sja1105_packing(buf, &entry->mac_flt0,    199, 152, size, op);
   163		sja1105_packing(buf, &entry->incl_srcpt1, 151, 151, size, op);
   164		sja1105_packing(buf, &entry->incl_srcpt0, 150, 150, size, op);
   165		sja1105_packing(buf, &entry->send_meta1,  149, 149, size, op);
   166		sja1105_packing(buf, &entry->send_meta0,  148, 148, size, op);
   167		sja1105_packing(buf, &entry->casc_port,   147, 145, size, op);
   168		sja1105_packing(buf, &entry->host_port,   144, 142, size, op);
   169		sja1105_packing(buf, &entry->mirr_port,   141, 139, size, op);
   170		sja1105_packing(buf, &entry->vlmarker,    138, 107, size, op);
   171		sja1105_packing(buf, &entry->vlmask,      106,  75, size, op);
   172		sja1105_packing(buf, &entry->tpid2,        74,  59, size, op);
   173		sja1105_packing(buf, &entry->ignore2stf,   58,  58, size, op);
   174		sja1105_packing(buf, &entry->tpid,         57,  42, size, op);
   175		sja1105_packing(buf, &entry->queue_ts,     41,  41, size, op);
   176		sja1105_packing(buf, &entry->egrmirrvid,   40,  29, size, op);
   177		sja1105_packing(buf, &entry->egrmirrpcp,   28,  26, size, op);
   178		sja1105_packing(buf, &entry->egrmirrdei,   25,  25, size, op);
   179		sja1105_packing(buf, &entry->replay_port,  24,  22, size, op);
   180		return size;
   181	}
   182	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 61666 bytes --]

  parent reply	other threads:[~2020-05-29 19:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-27 16:40 [PATCH net] net: dsa: sja1105: fix port mirroring for P/Q/R/S Vladimir Oltean
2020-05-29  2:56 ` kbuild test robot
2020-05-29  2:56   ` kbuild test robot
2020-05-29 19:33 ` kbuild test robot [this message]
2020-05-29 19:33   ` kbuild test robot
2020-05-29 23:45 ` David Miller
2020-05-30 10:33   ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202005300337.jkabGc4k%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.