From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
jejb@linux.ibm.com, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] scsi: cumana_2: Fix different dev_id between 'request_irq()' and 'free_irq()'
Date: Sat, 30 May 2020 09:43:38 +0000 [thread overview]
Message-ID: <20200530094338.GE1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200530073555.577414-1-christophe.jaillet@wanadoo.fr>
On Sat, May 30, 2020 at 09:35:55AM +0200, Christophe JAILLET wrote:
> The dev_id used in 'request_irq()' and 'free_irq()' should match.
> So use 'host' in both cases.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
This is itself wrong. cumanascsi_2_intr() requires "info" as the devid.
Either cumanascsi_2_intr() needs changing to use shost_priv(host) along
with this change, or free_irq() needs changing to use "info".
Likely the same for the other patches, I haven't looked.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC for 0.8m (est. 1762m) line in suburbia: sync at 13.1Mbps down 424kbps up
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-arm-kernel@lists.infradead.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: cumana_2: Fix different dev_id between 'request_irq()' and 'free_irq()'
Date: Sat, 30 May 2020 10:43:38 +0100 [thread overview]
Message-ID: <20200530094338.GE1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200530073555.577414-1-christophe.jaillet@wanadoo.fr>
On Sat, May 30, 2020 at 09:35:55AM +0200, Christophe JAILLET wrote:
> The dev_id used in 'request_irq()' and 'free_irq()' should match.
> So use 'host' in both cases.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
This is itself wrong. cumanascsi_2_intr() requires "info" as the devid.
Either cumanascsi_2_intr() needs changing to use shost_priv(host) along
with this change, or free_irq() needs changing to use "info".
Likely the same for the other patches, I haven't looked.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC for 0.8m (est. 1762m) line in suburbia: sync at 13.1Mbps down 424kbps up
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
jejb@linux.ibm.com, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] scsi: cumana_2: Fix different dev_id between 'request_irq()' and 'free_irq()'
Date: Sat, 30 May 2020 10:43:38 +0100 [thread overview]
Message-ID: <20200530094338.GE1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200530073555.577414-1-christophe.jaillet@wanadoo.fr>
On Sat, May 30, 2020 at 09:35:55AM +0200, Christophe JAILLET wrote:
> The dev_id used in 'request_irq()' and 'free_irq()' should match.
> So use 'host' in both cases.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
This is itself wrong. cumanascsi_2_intr() requires "info" as the devid.
Either cumanascsi_2_intr() needs changing to use shost_priv(host) along
with this change, or free_irq() needs changing to use "info".
Likely the same for the other patches, I haven't looked.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC for 0.8m (est. 1762m) line in suburbia: sync at 13.1Mbps down 424kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-30 9:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-30 7:35 [PATCH] scsi: cumana_2: Fix different dev_id between 'request_irq()' and 'free_irq()' Christophe JAILLET
2020-05-30 7:35 ` Christophe JAILLET
2020-05-30 7:35 ` Christophe JAILLET
2020-05-30 9:43 ` Russell King - ARM Linux admin [this message]
2020-05-30 9:43 ` Russell King - ARM Linux admin
2020-05-30 9:43 ` Russell King - ARM Linux admin
2020-05-30 10:41 ` Marion & Christophe JAILLET
2020-05-30 10:41 ` Marion & Christophe JAILLET
2020-05-30 10:41 ` Marion & Christophe JAILLET
2020-06-25 20:47 ` Christophe JAILLET
2020-06-25 20:47 ` Christophe JAILLET
2020-06-25 20:47 ` Christophe JAILLET
2020-06-25 23:10 ` Russell King - ARM Linux admin
2020-06-25 23:10 ` Russell King - ARM Linux admin
2020-06-25 23:10 ` Russell King - ARM Linux admin
2020-06-27 3:09 ` Martin K. Petersen
2020-06-27 3:09 ` Martin K. Petersen
2020-06-27 3:09 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200530094338.GE1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=christophe.jaillet@wanadoo.fr \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.