From: Dan Carpenter <dan.carpenter@oracle.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: linus.walleij@linaro.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, haojian.zhuang@gmail.com,
linux-gpio@vger.kernel.org, daniel@zonque.org,
Robert Jarzmik <robert.jarzmik@free.fr>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken
Date: Mon, 01 Jun 2020 18:31:02 +0000 [thread overview]
Message-ID: <20200601183102.GS30374@kadam> (raw)
In-Reply-To: <a2e34c9a-676f-d83f-f395-7428af038c16@wanadoo.fr>
On Mon, Jun 01, 2020 at 01:31:23PM +0200, Christophe JAILLET wrote:
> Le 01/06/2020 à 10:58, Robert Jarzmik a écrit :
> > Christophe JAILLET <christophe.jaillet@wanadoo.fr> writes:
> >
> > > Commit 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration")
> > > has turned a 'pinctrl_register()' into 'devm_pinctrl_register()' in
> > > 'pxa2xx_pinctrl_init()'.
> > > However, the corresponding 'pinctrl_unregister()' call in
> > > 'pxa2xx_pinctrl_exit()' has not been removed.
> > >
> > > This is not an issue, because 'pxa2xx_pinctrl_exit()' is unused.
> > > Remove it now to avoid some wondering in the future and save a few LoC.
> > >
> > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
> >
> > Would be even a better patch with a :
> > Fixes: 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration")
>
> I was wondering it was was needed in this case.
> The patch does not really fix anything, as the function is unused. Or it
> fixes things on a theoretical point of view.
There is no concensus... We should call a vote on this at Kernel
Summit. :P
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>,
daniel@zonque.org, haojian.zhuang@gmail.com,
linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken
Date: Mon, 1 Jun 2020 21:31:02 +0300 [thread overview]
Message-ID: <20200601183102.GS30374@kadam> (raw)
In-Reply-To: <a2e34c9a-676f-d83f-f395-7428af038c16@wanadoo.fr>
On Mon, Jun 01, 2020 at 01:31:23PM +0200, Christophe JAILLET wrote:
> Le 01/06/2020 à 10:58, Robert Jarzmik a écrit :
> > Christophe JAILLET <christophe.jaillet@wanadoo.fr> writes:
> >
> > > Commit 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration")
> > > has turned a 'pinctrl_register()' into 'devm_pinctrl_register()' in
> > > 'pxa2xx_pinctrl_init()'.
> > > However, the corresponding 'pinctrl_unregister()' call in
> > > 'pxa2xx_pinctrl_exit()' has not been removed.
> > >
> > > This is not an issue, because 'pxa2xx_pinctrl_exit()' is unused.
> > > Remove it now to avoid some wondering in the future and save a few LoC.
> > >
> > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
> >
> > Would be even a better patch with a :
> > Fixes: 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration")
>
> I was wondering it was was needed in this case.
> The patch does not really fix anything, as the function is unused. Or it
> fixes things on a theoretical point of view.
There is no concensus... We should call a vote on this at Kernel
Summit. :P
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: linus.walleij@linaro.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, haojian.zhuang@gmail.com,
linux-gpio@vger.kernel.org, daniel@zonque.org,
Robert Jarzmik <robert.jarzmik@free.fr>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken
Date: Mon, 1 Jun 2020 21:31:02 +0300 [thread overview]
Message-ID: <20200601183102.GS30374@kadam> (raw)
In-Reply-To: <a2e34c9a-676f-d83f-f395-7428af038c16@wanadoo.fr>
On Mon, Jun 01, 2020 at 01:31:23PM +0200, Christophe JAILLET wrote:
> Le 01/06/2020 à 10:58, Robert Jarzmik a écrit :
> > Christophe JAILLET <christophe.jaillet@wanadoo.fr> writes:
> >
> > > Commit 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration")
> > > has turned a 'pinctrl_register()' into 'devm_pinctrl_register()' in
> > > 'pxa2xx_pinctrl_init()'.
> > > However, the corresponding 'pinctrl_unregister()' call in
> > > 'pxa2xx_pinctrl_exit()' has not been removed.
> > >
> > > This is not an issue, because 'pxa2xx_pinctrl_exit()' is unused.
> > > Remove it now to avoid some wondering in the future and save a few LoC.
> > >
> > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
> >
> > Would be even a better patch with a :
> > Fixes: 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration")
>
> I was wondering it was was needed in this case.
> The patch does not really fix anything, as the function is unused. Or it
> fixes things on a theoretical point of view.
There is no concensus... We should call a vote on this at Kernel
Summit. :P
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-01 18:31 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 7:37 [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken Christophe JAILLET
2020-05-31 7:37 ` Christophe JAILLET
2020-05-31 7:37 ` Christophe JAILLET
2020-06-01 8:58 ` Robert Jarzmik
2020-06-01 8:58 ` Robert Jarzmik
2020-06-01 8:58 ` Robert Jarzmik
2020-06-01 11:31 ` Christophe JAILLET
2020-06-01 11:31 ` Christophe JAILLET
2020-06-01 11:31 ` Christophe JAILLET
2020-06-01 18:31 ` Dan Carpenter [this message]
2020-06-01 18:31 ` Dan Carpenter
2020-06-01 18:31 ` Dan Carpenter
2020-06-03 22:08 ` Linus Walleij
2020-06-03 22:08 ` Linus Walleij
2020-06-03 22:08 ` Linus Walleij
2020-06-04 8:31 ` Dan Carpenter
2020-06-04 8:31 ` Dan Carpenter
2020-06-04 8:31 ` Dan Carpenter
2020-06-04 9:17 ` Joe Perches
2020-06-04 9:17 ` Joe Perches
2020-06-04 9:17 ` Joe Perches
2020-06-04 9:52 ` Julia Lawall
2020-06-04 9:52 ` Julia Lawall
2020-06-04 9:52 ` Julia Lawall
2020-06-04 10:00 ` Joe Perches
2020-06-04 10:00 ` Joe Perches
2020-06-04 10:00 ` Joe Perches
2020-06-04 10:33 ` Julia Lawall
2020-06-04 10:33 ` Julia Lawall
2020-06-04 10:33 ` Julia Lawall
2020-06-04 11:08 ` Joe Perches
2020-06-04 11:08 ` Joe Perches
2020-06-04 11:08 ` Joe Perches
2020-06-04 11:42 ` Julia Lawall
2020-06-04 11:42 ` Julia Lawall
2020-06-04 11:42 ` Julia Lawall
2020-06-04 12:30 ` Dan Carpenter
2020-06-04 12:30 ` Dan Carpenter
2020-06-04 12:30 ` Dan Carpenter
2020-06-04 16:08 ` Joe Perches
2020-06-04 16:08 ` Joe Perches
2020-06-04 16:08 ` Joe Perches
2020-06-04 16:29 ` Julia Lawall
2020-06-04 16:29 ` Julia Lawall
2020-06-04 16:29 ` Julia Lawall
2020-06-04 17:35 ` Dan Carpenter
2020-06-04 17:35 ` Dan Carpenter
2020-06-04 17:35 ` Dan Carpenter
2020-06-04 18:02 ` Joe Perches
2020-06-04 18:02 ` Joe Perches
2020-06-04 18:02 ` Joe Perches
2020-06-03 22:05 ` Linus Walleij
2020-06-03 22:05 ` Linus Walleij
2020-06-03 22:05 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601183102.GS30374@kadam \
--to=dan.carpenter@oracle.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.