From: Mark Brown <broonie@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Navid Emamdoost <navid.emamdoost@gmail.com>,
linux-spi@vger.kernel.org, Navid Emamdoost <emamd001@umn.edu>,
Kangjie Lu <kjlu@umn.edu>, Stephen McCamant <smccaman@umn.edu>,
Qiushi Wu <wu000273@umn.edu>,
Dinghao Liu <dinghao.liu@zju.edu.cn>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] spi: spi-ti-qspi: call pm_runtime_put on pm_runtime_get failure
Date: Tue, 02 Jun 2020 09:49:47 +0000 [thread overview]
Message-ID: <20200602094947.GA5684@sirena.org.uk> (raw)
In-Reply-To: <26028f50-3fb8-eb08-3c9f-08ada018bf9e@web.de>
[-- Attachment #1: Type: text/plain, Size: 638 bytes --]
On Tue, Jun 02, 2020 at 10:40:33AM +0200, Markus Elfring wrote:
> > The counter is incremented via pm_runtime_get even in failure case.
> > To correct the counter call pm_runtime_put in case of failure, too.
>
> How do you think about a wording variant like the following?
>
> Change description:
> The PM runtime reference counter is generally incremented by a call of
> the function “pm_runtime_get_sync”.
> Thus call the function “pm_runtime_put_autosuspend” also in one error case
> to keep the reference counting consistent.
The original changelog is perfectly fine, please stop sending these.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Navid Emamdoost <navid.emamdoost@gmail.com>,
linux-spi@vger.kernel.org, Navid Emamdoost <emamd001@umn.edu>,
Kangjie Lu <kjlu@umn.edu>, Stephen McCamant <smccaman@umn.edu>,
Qiushi Wu <wu000273@umn.edu>,
Dinghao Liu <dinghao.liu@zju.edu.cn>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] spi: spi-ti-qspi: call pm_runtime_put on pm_runtime_get failure
Date: Tue, 2 Jun 2020 10:49:47 +0100 [thread overview]
Message-ID: <20200602094947.GA5684@sirena.org.uk> (raw)
In-Reply-To: <26028f50-3fb8-eb08-3c9f-08ada018bf9e@web.de>
[-- Attachment #1: Type: text/plain, Size: 638 bytes --]
On Tue, Jun 02, 2020 at 10:40:33AM +0200, Markus Elfring wrote:
> > The counter is incremented via pm_runtime_get even in failure case.
> > To correct the counter call pm_runtime_put in case of failure, too.
>
> How do you think about a wording variant like the following?
>
> Change description:
> The PM runtime reference counter is generally incremented by a call of
> the function “pm_runtime_get_sync”.
> Thus call the function “pm_runtime_put_autosuspend” also in one error case
> to keep the reference counting consistent.
The original changelog is perfectly fine, please stop sending these.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-02 9:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 8:40 [PATCH] spi: spi-ti-qspi: call pm_runtime_put on pm_runtime_get failure Markus Elfring
2020-06-02 8:40 ` Markus Elfring
2020-06-02 9:49 ` Mark Brown [this message]
2020-06-02 9:49 ` Mark Brown
2020-06-02 10:02 ` Markus Elfring
2020-06-02 10:02 ` Markus Elfring
2020-06-02 14:13 ` Mark Brown
2020-06-02 14:13 ` Mark Brown
2020-06-02 15:05 ` Markus Elfring
2020-06-02 15:05 ` Markus Elfring
2020-06-02 18:36 ` Mark Brown
2020-06-02 18:36 ` Mark Brown
2020-06-02 19:35 ` Navid Emamdoost
2020-06-02 19:35 ` Navid Emamdoost
2020-06-02 19:54 ` Markus Elfring
2020-06-02 19:54 ` Markus Elfring
-- strict thread matches above, loose matches on Subject: below --
2020-06-02 4:36 [PATCH] " Navid Emamdoost
2020-06-02 9:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602094947.GA5684@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=dinghao.liu@zju.edu.cn \
--cc=emamd001@umn.edu \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=smccaman@umn.edu \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.