From: Guru Das Srinagesh <gurus@codeaurora.org>
To: linux-pwm@vger.kernel.org,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Subbaraman Narayanamurthy <subbaram@codeaurora.org>,
David Collins <collinsd@codeaurora.org>,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
Stephen Boyd <sboyd@kernel.org>, Lee Jones <lee.jones@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Guenter Roeck <linux@roeck-us.net>,
Daniel Thompson <daniel.thompson@linaro.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v16 06/11] pwm: imx27: Use 64-bit division macro
Date: Tue, 2 Jun 2020 15:34:53 -0700 [thread overview]
Message-ID: <20200602223452.GA470@codeaurora.org> (raw)
In-Reply-To: <fcc92b6499e8200ad6b02ab13b38e4d310afe0ba.1591135774.git.gurus@codeaurora.org>
On Tue, Jun 02, 2020 at 03:31:11PM -0700, Guru Das Srinagesh wrote:
> Since the PWM framework is switching struct pwm_state.period's
> datatype to u64, prepare for this transition by using
> DIV_ROUND_UP_ULL to handle a 64-bit dividend.
>
> Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
> ---
> drivers/pwm/pwm-imx27.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c
> index 732a6f3..c50d453 100644
> --- a/drivers/pwm/pwm-imx27.c
> +++ b/drivers/pwm/pwm-imx27.c
> @@ -202,7 +202,7 @@ static void pwm_imx27_wait_fifo_slot(struct pwm_chip *chip,
> sr = readl(imx->mmio_base + MX3_PWMSR);
> fifoav = FIELD_GET(MX3_PWMSR_FIFOAV, sr);
> if (fifoav == MX3_PWMSR_FIFOAV_4WORDS) {
> - period_ms = DIV_ROUND_UP(pwm_get_period(pwm),
> + period_ms = DIV_ROUND_UP_ULL(pwm_get_period(pwm),
> NSEC_PER_MSEC);
> msleep(period_ms);
>
> --
Please disregard this patch, it was sent by mistake. The correct patch
is [1].
[1]: https://lore.kernel.org/lkml/bb43ff8ad9e0b9884722d85e51c8fdb3ef4154d1.1591136989.git.gurus@codeaurora.org/
Thank you.
Guru Das.
WARNING: multiple messages have this Message-ID (diff)
From: Guru Das Srinagesh <gurus@codeaurora.org>
To: linux-pwm@vger.kernel.org,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
Daniel Thompson <daniel.thompson@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
David Collins <collinsd@codeaurora.org>,
Stephen Boyd <sboyd@kernel.org>,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Joe Perches <joe@perches.com>,
Subbaraman Narayanamurthy <subbaram@codeaurora.org>,
Lee Jones <lee.jones@linaro.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v16 06/11] pwm: imx27: Use 64-bit division macro
Date: Tue, 2 Jun 2020 15:34:53 -0700 [thread overview]
Message-ID: <20200602223452.GA470@codeaurora.org> (raw)
In-Reply-To: <fcc92b6499e8200ad6b02ab13b38e4d310afe0ba.1591135774.git.gurus@codeaurora.org>
On Tue, Jun 02, 2020 at 03:31:11PM -0700, Guru Das Srinagesh wrote:
> Since the PWM framework is switching struct pwm_state.period's
> datatype to u64, prepare for this transition by using
> DIV_ROUND_UP_ULL to handle a 64-bit dividend.
>
> Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
> ---
> drivers/pwm/pwm-imx27.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c
> index 732a6f3..c50d453 100644
> --- a/drivers/pwm/pwm-imx27.c
> +++ b/drivers/pwm/pwm-imx27.c
> @@ -202,7 +202,7 @@ static void pwm_imx27_wait_fifo_slot(struct pwm_chip *chip,
> sr = readl(imx->mmio_base + MX3_PWMSR);
> fifoav = FIELD_GET(MX3_PWMSR_FIFOAV, sr);
> if (fifoav == MX3_PWMSR_FIFOAV_4WORDS) {
> - period_ms = DIV_ROUND_UP(pwm_get_period(pwm),
> + period_ms = DIV_ROUND_UP_ULL(pwm_get_period(pwm),
> NSEC_PER_MSEC);
> msleep(period_ms);
>
> --
Please disregard this patch, it was sent by mistake. The correct patch
is [1].
[1]: https://lore.kernel.org/lkml/bb43ff8ad9e0b9884722d85e51c8fdb3ef4154d1.1591136989.git.gurus@codeaurora.org/
Thank you.
Guru Das.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-02 22:34 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 22:31 [PATCH v16 00/11] Convert PWM period and duty cycle to u64 Guru Das Srinagesh
2020-06-02 22:31 ` Guru Das Srinagesh
2020-06-02 22:31 ` [PATCH v16 01/11] drm/i915: Use 64-bit division macro Guru Das Srinagesh
2020-06-02 22:31 ` Guru Das Srinagesh
2020-06-02 22:31 ` [PATCH v16 02/11] hwmon: pwm-fan: " Guru Das Srinagesh
2020-06-02 22:31 ` Guru Das Srinagesh
2020-06-02 22:31 ` Guru Das Srinagesh
2020-06-02 22:31 ` [PATCH v16 03/11] ir-rx51: " Guru Das Srinagesh
2020-06-02 22:31 ` Guru Das Srinagesh
2020-06-02 22:31 ` [PATCH v16 04/11] pwm: clps711x: " Guru Das Srinagesh
2020-06-02 22:31 ` Guru Das Srinagesh
2020-06-02 22:31 ` [PATCH v16 05/11] pwm: pwm-imx-tpm: " Guru Das Srinagesh
2020-06-02 22:31 ` Guru Das Srinagesh
2020-06-02 22:31 ` [PATCH v16 06/11] pwm: imx27: Use 64-bit division macro and function Guru Das Srinagesh
2020-06-02 22:31 ` Guru Das Srinagesh
2020-07-02 7:11 ` Uwe Kleine-König
2020-07-02 7:11 ` Uwe Kleine-König
[not found] ` <cover.1591135774.git.gurus@codeaurora.org>
2020-06-02 22:31 ` [PATCH v16 06/11] pwm: imx27: Use 64-bit division macro Guru Das Srinagesh
2020-06-02 22:31 ` Guru Das Srinagesh
2020-06-02 22:34 ` Guru Das Srinagesh [this message]
2020-06-02 22:34 ` Guru Das Srinagesh
2020-06-02 22:31 ` [PATCH v16 07/11] pwm: sifive: " Guru Das Srinagesh
2020-06-02 22:31 ` Guru Das Srinagesh
2020-06-02 22:31 ` [PATCH v16 08/11] pwm: sun4i: Use nsecs_to_jiffies to avoid a division Guru Das Srinagesh
2020-06-02 22:31 ` Guru Das Srinagesh
2020-06-02 22:31 ` [PATCH v16 09/11] backlight: pwm_bl: Use 64-bit division function Guru Das Srinagesh
2020-06-02 22:31 ` Guru Das Srinagesh
2020-06-02 22:31 ` [PATCH v16 10/11] clk: pwm: " Guru Das Srinagesh
2020-06-02 22:31 ` Guru Das Srinagesh
2020-06-02 22:31 ` [PATCH v16 11/11] pwm: core: Convert period and duty cycle to u64 Guru Das Srinagesh
2020-06-02 22:31 ` Guru Das Srinagesh
2020-06-11 16:55 ` [PATCH v16 00/11] Convert PWM " Guru Das Srinagesh
2020-06-11 16:55 ` Guru Das Srinagesh
2020-06-11 17:57 ` Lee Jones
2020-06-11 17:57 ` Lee Jones
2020-06-11 18:24 ` Thierry Reding
2020-06-11 18:24 ` Thierry Reding
2020-06-11 18:31 ` Guru Das Srinagesh
2020-06-11 18:31 ` Guru Das Srinagesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602223452.GA470@codeaurora.org \
--to=gurus@codeaurora.org \
--cc=arnd@arndb.de \
--cc=collinsd@codeaurora.org \
--cc=dan.carpenter@oracle.com \
--cc=daniel.thompson@linaro.org \
--cc=geert@linux-m68k.org \
--cc=joe@perches.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sboyd@kernel.org \
--cc=subbaram@codeaurora.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.