All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: marex@denx.de, devicetree@vger.kernel.org,
	michal.simek@xilinx.com, xuwei5@hisilicon.com,
	robh+dt@kernel.org, mcoquelin.stm32@gmail.com,
	kernel@collabora.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 3/4] ARM: dts: stm32: make hdmi-transmitter node compliant with DT bindings
Date: Wed, 3 Jun 2020 02:55:39 +0300	[thread overview]
Message-ID: <20200602235539.GT6547@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200601063308.13045-4-ricardo.canuelo@collabora.com>

Hi Ricardo,

Thank you for the patch.

On Mon, Jun 01, 2020 at 08:33:07AM +0200, Ricardo Cañuelo wrote:
> Reorder the I2C slave addresses of the hdmi-transmitter node and remove
> the adi,input-style and adi,input-justification properties to meet the
> adi,adv7513 binding requirements.
> 
> Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
> index 930202742a3f..b67a21a8698a 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
> @@ -185,8 +185,8 @@
>  &i2c4 {
>  	hdmi-transmitter@3d {
>  		compatible = "adi,adv7513";
> -		reg = <0x3d>, <0x2d>, <0x4d>, <0x5d>;
> -		reg-names = "main", "cec", "edid", "packet";
> +		reg = <0x3d>, <0x4d>, <0x2d> , <0x5d>;
> +		reg-names = "main", "edid", "cec", "packet";
>  		clocks = <&cec_clock>;
>  		clock-names = "cec";
>  
> @@ -204,8 +204,6 @@
>  		adi,input-depth = <8>;
>  		adi,input-colorspace = "rgb";
>  		adi,input-clock = "1x";
> -		adi,input-style = <1>;
> -		adi,input-justification = "evenly";
>  
>  		ports {
>  			#address-cells = <1>;

-- 
Regards,

Laurent Pinchart

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: kernel@collabora.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
	xuwei5@hisilicon.com, michal.simek@xilinx.com,
	mcoquelin.stm32@gmail.com, marex@denx.de
Subject: Re: [PATCH v3 3/4] ARM: dts: stm32: make hdmi-transmitter node compliant with DT bindings
Date: Wed, 3 Jun 2020 02:55:39 +0300	[thread overview]
Message-ID: <20200602235539.GT6547@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200601063308.13045-4-ricardo.canuelo@collabora.com>

Hi Ricardo,

Thank you for the patch.

On Mon, Jun 01, 2020 at 08:33:07AM +0200, Ricardo Cañuelo wrote:
> Reorder the I2C slave addresses of the hdmi-transmitter node and remove
> the adi,input-style and adi,input-justification properties to meet the
> adi,adv7513 binding requirements.
> 
> Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
> index 930202742a3f..b67a21a8698a 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
> @@ -185,8 +185,8 @@
>  &i2c4 {
>  	hdmi-transmitter@3d {
>  		compatible = "adi,adv7513";
> -		reg = <0x3d>, <0x2d>, <0x4d>, <0x5d>;
> -		reg-names = "main", "cec", "edid", "packet";
> +		reg = <0x3d>, <0x4d>, <0x2d> , <0x5d>;
> +		reg-names = "main", "edid", "cec", "packet";
>  		clocks = <&cec_clock>;
>  		clock-names = "cec";
>  
> @@ -204,8 +204,6 @@
>  		adi,input-depth = <8>;
>  		adi,input-colorspace = "rgb";
>  		adi,input-clock = "1x";
> -		adi,input-style = <1>;
> -		adi,input-justification = "evenly";
>  
>  		ports {
>  			#address-cells = <1>;

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2020-06-02 23:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-01  6:33 [PATCH v3 0/4] Convert adi,adv7511.txt DT bindings to yaml Ricardo Cañuelo
2020-06-01  6:33 ` Ricardo Cañuelo
2020-06-01  6:33 ` [PATCH v3 1/4] ARM: dts: zynq: add port definitions to hdmi-tx@39 Ricardo Cañuelo
2020-06-01  6:33   ` Ricardo Cañuelo
2020-06-01  6:33 ` [PATCH v3 2/4] arm64: dts: hisilicon: hikey: fixes to comply with adi, adv7533 DT binding Ricardo Cañuelo
2020-06-01  6:33   ` [PATCH v3 2/4] arm64: dts: hisilicon: hikey: fixes to comply with adi,adv7533 " Ricardo Cañuelo
2020-07-21  2:41   ` Wei Xu
2020-07-21  2:41     ` Wei Xu
2020-07-21  5:37     ` Ricardo Cañuelo
2020-07-21  5:37       ` Ricardo Cañuelo
2020-06-01  6:33 ` [PATCH v3 3/4] ARM: dts: stm32: make hdmi-transmitter node compliant with DT bindings Ricardo Cañuelo
2020-06-01  6:33   ` Ricardo Cañuelo
2020-06-02 23:55   ` Laurent Pinchart [this message]
2020-06-02 23:55     ` Laurent Pinchart
2020-06-01  6:33 ` [PATCH v3 4/4] dt-bindings: drm: bridge: adi, adv7511.txt: convert to yaml Ricardo Cañuelo
2020-06-01  6:33   ` [PATCH v3 4/4] dt-bindings: drm: bridge: adi,adv7511.txt: " Ricardo Cañuelo
2020-06-03  0:03   ` Laurent Pinchart
2020-06-03  0:03     ` Laurent Pinchart
2020-06-04 23:09   ` [PATCH v3 4/4] dt-bindings: drm: bridge: adi, adv7511.txt: " Rob Herring
2020-06-04 23:09     ` Rob Herring
2020-07-01  7:56 ` [PATCH v3 0/4] Convert adi,adv7511.txt DT bindings " Ricardo Cañuelo
2020-07-01  7:56   ` Ricardo Cañuelo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200602235539.GT6547@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marex@denx.de \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=michal.simek@xilinx.com \
    --cc=ricardo.canuelo@collabora.com \
    --cc=robh+dt@kernel.org \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.