From: Mika Westerberg <mika.westerberg@intel.com>
To: Rajat Jain <rajatja@google.com>
Cc: tbroch@google.com, pmalani@google.com,
Ashok Raj <ashok.raj@intel.com>,
rajatxjain@gmail.com, zsm@google.com,
linux-kernel@vger.kernel.org,
lalithambika.krishnakumar@intel.com,
iommu@lists.linux-foundation.org, mnissler@google.com,
bleung@google.com, levinale@google.com,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v3] iommu/vt-d: Don't apply gfx quirks to untrusted devices
Date: Wed, 3 Jun 2020 08:30:08 +0300 [thread overview]
Message-ID: <20200603053008.GR247495@lahna.fi.intel.com> (raw)
In-Reply-To: <20200602232602.156049-1-rajatja@google.com>
On Tue, Jun 02, 2020 at 04:26:02PM -0700, Rajat Jain wrote:
> +static bool risky_device(struct pci_dev *pdev)
> +{
> + if (pdev->untrusted) {
> + pci_warn(pdev,
> + "Skipping IOMMU quirk for dev (%04X:%04X) on untrusted"
> + " PCI link. Please check with your BIOS/Platform"
> + " vendor about this\n", pdev->vendor, pdev->device);
You should not break user visible strings like this. It makes grepping
for them harder (see also CodingStyle). You can write it like this instead:
pci_info(pdev, "Skipping IOMMU quirk for dev (%04X:%04X) on untrusted PCI link\n",
pdev->vendor, pdev->device);
pci_info(pdev, "Please check with your BIOS/Platform vendor about this\n");
Also I guess pci_info() might be better here after all. Your call :)
Rest of the patch looks good to me.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Mika Westerberg <mika.westerberg@intel.com>
To: Rajat Jain <rajatja@google.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Lu Baolu <baolu.lu@linux.intel.com>,
Joerg Roedel <joro@8bytes.org>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Ashok Raj <ashok.raj@intel.com>,
lalithambika.krishnakumar@intel.com, rajatxjain@gmail.com,
pmalani@google.com, bleung@google.com, levinale@google.com,
zsm@google.com, mnissler@google.com, tbroch@google.com
Subject: Re: [PATCH v3] iommu/vt-d: Don't apply gfx quirks to untrusted devices
Date: Wed, 3 Jun 2020 08:30:08 +0300 [thread overview]
Message-ID: <20200603053008.GR247495@lahna.fi.intel.com> (raw)
In-Reply-To: <20200602232602.156049-1-rajatja@google.com>
On Tue, Jun 02, 2020 at 04:26:02PM -0700, Rajat Jain wrote:
> +static bool risky_device(struct pci_dev *pdev)
> +{
> + if (pdev->untrusted) {
> + pci_warn(pdev,
> + "Skipping IOMMU quirk for dev (%04X:%04X) on untrusted"
> + " PCI link. Please check with your BIOS/Platform"
> + " vendor about this\n", pdev->vendor, pdev->device);
You should not break user visible strings like this. It makes grepping
for them harder (see also CodingStyle). You can write it like this instead:
pci_info(pdev, "Skipping IOMMU quirk for dev (%04X:%04X) on untrusted PCI link\n",
pdev->vendor, pdev->device);
pci_info(pdev, "Please check with your BIOS/Platform vendor about this\n");
Also I guess pci_info() might be better here after all. Your call :)
Rest of the patch looks good to me.
next prev parent reply other threads:[~2020-06-03 5:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 23:26 [PATCH v3] iommu/vt-d: Don't apply gfx quirks to untrusted devices Rajat Jain via iommu
2020-06-02 23:26 ` Rajat Jain
2020-06-02 23:28 ` Raj, Ashok
2020-06-02 23:28 ` Raj, Ashok
2020-06-02 23:49 ` Prashant Malani via iommu
2020-06-02 23:49 ` Prashant Malani
2020-06-03 0:23 ` Rajat Jain
2020-06-03 0:23 ` Rajat Jain
2020-06-03 0:32 ` Prashant Malani via iommu
2020-06-03 0:32 ` Prashant Malani
2020-06-03 5:30 ` Mika Westerberg [this message]
2020-06-03 5:30 ` Mika Westerberg
2020-06-03 13:03 ` Rajat Jain via iommu
2020-06-03 13:03 ` Rajat Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200603053008.GR247495@lahna.fi.intel.com \
--to=mika.westerberg@intel.com \
--cc=ashok.raj@intel.com \
--cc=bleung@google.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=lalithambika.krishnakumar@intel.com \
--cc=levinale@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mnissler@google.com \
--cc=pmalani@google.com \
--cc=rajatja@google.com \
--cc=rajatxjain@gmail.com \
--cc=tbroch@google.com \
--cc=zsm@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.