From: Will Deacon <will@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Sami Tolvanen <samitolvanen@google.com>,
Will Deacon <will@kernel.org>,
keescook@chromium.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH] scs: Report SCS usage in bytes rather than number of entries
Date: Wed, 3 Jun 2020 16:12:17 +0100 [thread overview]
Message-ID: <20200603151218.11659-1-will@kernel.org> (raw)
Fix the SCS debug usage check so that we report the number of bytes
usedm, rather than the number of entries.
Fixes: 5bbaf9d1fcb9 ("scs: Add support for stack usage debugging")
Reported-by: Sami Tolvanen <samitolvanen@google.com>
Signed-off-by: Will Deacon <will@kernel.org>
---
kernel/scs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/scs.c b/kernel/scs.c
index 222a7a9ad543..5d4d9bbdec36 100644
--- a/kernel/scs.c
+++ b/kernel/scs.c
@@ -74,7 +74,7 @@ static void scs_check_usage(struct task_struct *tsk)
for (p = task_scs(tsk); p < __scs_magic(tsk); ++p) {
if (!READ_ONCE_NOCHECK(*p))
break;
- used++;
+ used += sizeof(*p);
}
while (used > curr) {
--
2.27.0.rc2.251.g90737beb825-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: keescook@chromium.org, linux-arm-kernel@lists.infradead.org,
Will Deacon <will@kernel.org>,
Sami Tolvanen <samitolvanen@google.com>
Subject: [PATCH] scs: Report SCS usage in bytes rather than number of entries
Date: Wed, 3 Jun 2020 16:12:17 +0100 [thread overview]
Message-ID: <20200603151218.11659-1-will@kernel.org> (raw)
Fix the SCS debug usage check so that we report the number of bytes
usedm, rather than the number of entries.
Fixes: 5bbaf9d1fcb9 ("scs: Add support for stack usage debugging")
Reported-by: Sami Tolvanen <samitolvanen@google.com>
Signed-off-by: Will Deacon <will@kernel.org>
---
kernel/scs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/scs.c b/kernel/scs.c
index 222a7a9ad543..5d4d9bbdec36 100644
--- a/kernel/scs.c
+++ b/kernel/scs.c
@@ -74,7 +74,7 @@ static void scs_check_usage(struct task_struct *tsk)
for (p = task_scs(tsk); p < __scs_magic(tsk); ++p) {
if (!READ_ONCE_NOCHECK(*p))
break;
- used++;
+ used += sizeof(*p);
}
while (used > curr) {
--
2.27.0.rc2.251.g90737beb825-goog
next reply other threads:[~2020-06-03 15:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 15:12 Will Deacon [this message]
2020-06-03 15:12 ` [PATCH] scs: Report SCS usage in bytes rather than number of entries Will Deacon
2020-06-03 17:06 ` Kees Cook
2020-06-03 17:06 ` Kees Cook
2020-06-04 15:15 ` Will Deacon
2020-06-04 15:15 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200603151218.11659-1-will@kernel.org \
--to=will@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.