All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	Julien Su <juliensu@mxic.com.tw>,
	Richard Weinberger <richard@nod.at>,
	Boris Brezillon <boris.brezillon@collabora.com>,
	linux-mtd@lists.infradead.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Mason Yang <masonccyang@mxic.com.tw>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v10 07/20] dt-bindings: mtd: Document boolean NAND ECC properties
Date: Thu, 4 Jun 2020 17:08:04 -0600	[thread overview]
Message-ID: <20200604230804.GA13821@bogus> (raw)
In-Reply-To: <20200603175759.19948-8-miquel.raynal@bootlin.com>

On Wed, Jun 03, 2020 at 07:57:46PM +0200, Miquel Raynal wrote:
> Document nand-use-soft-ecc-engine and nand-no-ecc-engine properties.
> The former is here to force software correction, the latter prevents
> any correction to happen.
> 
> These properties (along with nand-ecc-engine) are supposed to be more
> accurate than the current nand-ecc-modes wich is very misleading and
> very often people think it is mandatory while the core should be
> relied upon to decide which correction to handle.
> 
> nand-ecc-mode was already inacurate, but it becomes totally
> problematic with setups where there are several hardware engines.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  Documentation/devicetree/bindings/mtd/nand-controller.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> index 0969d2e6720b..a3750978ebb8 100644
> --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> @@ -68,6 +68,12 @@ patternProperties:
>            3/ The ECC engine is external, in this case the phandle should
>            reference the specific ECC engine node.
>  
> +      nand-use-soft-ecc-engine: true
> +        description: Use a software ECC engine.

Humm, I'm surprised this is valid YAML. nand-use-soft-ecc-engine can't 
be both a boolean and a map (aka schema, aka dict).

nand-use-soft-ecc-engine:
  type: boolean
  description: ...

> +
> +      nand-no-ecc-engine: true
> +        description: Do not use any ECC correction.
> +
>        nand-ecc-placement:
>          allOf:
>            - $ref: /schemas/types.yaml#/definitions/string
> -- 
> 2.20.1
> 

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	Julien Su <juliensu@mxic.com.tw>,
	Richard Weinberger <richard@nod.at>,
	Boris Brezillon <boris.brezillon@collabora.com>,
	linux-mtd@lists.infradead.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Mason Yang <masonccyang@mxic.com.tw>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v10 07/20] dt-bindings: mtd: Document boolean NAND ECC properties
Date: Thu, 4 Jun 2020 17:08:04 -0600	[thread overview]
Message-ID: <20200604230804.GA13821@bogus> (raw)
In-Reply-To: <20200603175759.19948-8-miquel.raynal@bootlin.com>

On Wed, Jun 03, 2020 at 07:57:46PM +0200, Miquel Raynal wrote:
> Document nand-use-soft-ecc-engine and nand-no-ecc-engine properties.
> The former is here to force software correction, the latter prevents
> any correction to happen.
> 
> These properties (along with nand-ecc-engine) are supposed to be more
> accurate than the current nand-ecc-modes wich is very misleading and
> very often people think it is mandatory while the core should be
> relied upon to decide which correction to handle.
> 
> nand-ecc-mode was already inacurate, but it becomes totally
> problematic with setups where there are several hardware engines.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  Documentation/devicetree/bindings/mtd/nand-controller.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> index 0969d2e6720b..a3750978ebb8 100644
> --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> @@ -68,6 +68,12 @@ patternProperties:
>            3/ The ECC engine is external, in this case the phandle should
>            reference the specific ECC engine node.
>  
> +      nand-use-soft-ecc-engine: true
> +        description: Use a software ECC engine.

Humm, I'm surprised this is valid YAML. nand-use-soft-ecc-engine can't 
be both a boolean and a map (aka schema, aka dict).

nand-use-soft-ecc-engine:
  type: boolean
  description: ...

> +
> +      nand-no-ecc-engine: true
> +        description: Do not use any ECC correction.
> +
>        nand-ecc-placement:
>          allOf:
>            - $ref: /schemas/types.yaml#/definitions/string
> -- 
> 2.20.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	linux-mtd@lists.infradead.org,
	Boris Brezillon <boris.brezillon@collabora.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-arm-kernel@lists.infradead.org,
	Mason Yang <masonccyang@mxic.com.tw>,
	Julien Su <juliensu@mxic.com.tw>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v10 07/20] dt-bindings: mtd: Document boolean NAND ECC properties
Date: Thu, 4 Jun 2020 17:08:04 -0600	[thread overview]
Message-ID: <20200604230804.GA13821@bogus> (raw)
In-Reply-To: <20200603175759.19948-8-miquel.raynal@bootlin.com>

On Wed, Jun 03, 2020 at 07:57:46PM +0200, Miquel Raynal wrote:
> Document nand-use-soft-ecc-engine and nand-no-ecc-engine properties.
> The former is here to force software correction, the latter prevents
> any correction to happen.
> 
> These properties (along with nand-ecc-engine) are supposed to be more
> accurate than the current nand-ecc-modes wich is very misleading and
> very often people think it is mandatory while the core should be
> relied upon to decide which correction to handle.
> 
> nand-ecc-mode was already inacurate, but it becomes totally
> problematic with setups where there are several hardware engines.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  Documentation/devicetree/bindings/mtd/nand-controller.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> index 0969d2e6720b..a3750978ebb8 100644
> --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> @@ -68,6 +68,12 @@ patternProperties:
>            3/ The ECC engine is external, in this case the phandle should
>            reference the specific ECC engine node.
>  
> +      nand-use-soft-ecc-engine: true
> +        description: Use a software ECC engine.

Humm, I'm surprised this is valid YAML. nand-use-soft-ecc-engine can't 
be both a boolean and a map (aka schema, aka dict).

nand-use-soft-ecc-engine:
  type: boolean
  description: ...

> +
> +      nand-no-ecc-engine: true
> +        description: Do not use any ECC correction.
> +
>        nand-ecc-placement:
>          allOf:
>            - $ref: /schemas/types.yaml#/definitions/string
> -- 
> 2.20.1
> 

  reply	other threads:[~2020-06-04 23:08 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03 17:57 [PATCH v10 00/20] Introduction of the generic ECC framework Miquel Raynal
2020-06-03 17:57 ` Miquel Raynal
2020-06-03 17:57 ` Miquel Raynal
2020-06-03 17:57 ` [PATCH v10 01/20] mtd: rawnand: Add a kernel doc to the ECC algorithm enumeration Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57 ` [PATCH v10 02/20] mtd: rawnand: Rename the ECC algorithm enumeration items Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57 ` [PATCH v10 03/20] mtd: rawnand: Move the nand_ecc_algo enum to the generic NAND layer Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57 ` [PATCH v10 04/20] mtd: nand: Add a NAND page I/O request type Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57 ` [PATCH v10 05/20] dt-bindings: mtd: Document nand-ecc-placement Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57 ` [PATCH v10 06/20] dt-bindings: mtd: Document nand-ecc-engine Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 22:16   ` Rob Herring
2020-06-03 22:16     ` Rob Herring
2020-06-03 22:16     ` Rob Herring
2020-06-03 17:57 ` [PATCH v10 07/20] dt-bindings: mtd: Document boolean NAND ECC properties Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-04 23:08   ` Rob Herring [this message]
2020-06-04 23:08     ` Rob Herring
2020-06-04 23:08     ` Rob Herring
2020-06-05  7:18     ` Miquel Raynal
2020-06-05  7:18       ` Miquel Raynal
2020-06-05  7:18       ` Miquel Raynal
2020-06-03 17:57 ` [PATCH v10 08/20] mtd: nand: Introduce the ECC engine framework Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57 ` [PATCH v10 09/20] mtd: rawnand: Separate the ECC engine type and the ECC byte placement Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57 ` [PATCH v10 10/20] mtd: rawnand: Use the new ECC engine type enumeration Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57 ` [PATCH v10 11/20] mtd: nand: Create a helper to extract the ECC configuration Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57 ` [PATCH v10 12/20] mtd: spinand: Use nanddev_get_ecc_conf() when relevant Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57 ` [PATCH v10 13/20] mtd: nand: Create helpers to set/extract the ECC requirements Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57 ` [PATCH v10 14/20] mtd: rawnand: Use nanddev_get/set_ecc_requirements() when relevant Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57 ` [PATCH v10 15/20] mtd: nand: Use the new generic ECC object Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57 ` [PATCH v10 16/20] mtd: rawnand: Make use of the ECC framework Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57 ` [PATCH v10 17/20] mtd: rawnand: Use the ECC framework OOB layouts Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57 ` [PATCH v10 18/20] mtd: rawnand: Use the ECC framework nand_ecc_is_strong_enough() helper Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57 ` [PATCH v10 19/20] mtd: rawnand: Use the ECC framework user input parsing bits Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57 ` [PATCH v10 20/20] mtd: rawnand: Use the NAND framework user_conf object for ECC flags Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal
2020-06-03 17:57   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200604230804.GA13821@bogus \
    --to=robh@kernel.org \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=boris.brezillon@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=juliensu@mxic.com.tw \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=masonccyang@mxic.com.tw \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.