From: Al Viro <viro@zeniv.linux.org.uk>
To: "Rodolfo C. Villordo" <rodolfovillordo@gmail.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Forest Bond <forest@alittletooquiet.net>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,devel@d
Date: Mon, 08 Jun 2020 05:46:14 +0000 [thread overview]
Message-ID: <20200608054614.GO23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20200607224156.GA24090@ip-172-31-24-31.ec2.internal>
On Sun, Jun 07, 2020 at 10:41:56PM +0000, Rodolfo C. Villordo wrote:
> Multiple line over 80 characters fixes by splitting in multiple lines.
> Warning found by checkpatch.pl
I doubt that checkpatch.pl can catch the real problems there:
* Hungarian Notation Sucks. Really.
* so does CamelCase, especially for wonders like s_uGetRTSCTSRsvTime
* local variables are useful
* if a long expression keeps cropping up all over the place, you
probably are missing an inline helper.
PS: this
> - buf->time_stamp_off_a = vnt_time_stamp_off(pDevice, wCurrentRate);
> - buf->time_stamp_off_b = vnt_time_stamp_off(pDevice, pDevice->byTopCCKBasicRate);
> + buf->time_stamp_off_a > + vnt_time_stamp_off(pDevice, wCurrentRate);
> + buf->time_stamp_off_b > + vnt_time_stamp_off(pDevice,
> + pDevice->byTopCCKBasicRate);
is no improvement.
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@zeniv.linux.org.uk>
To: "Rodolfo C. Villordo" <rodolfovillordo@gmail.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Forest Bond <forest@alittletooquiet.net>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,devel@driverdev.osuosl.org,linux-kernel@vger.kernel.org
Date: Mon, 8 Jun 2020 06:46:14 +0100 [thread overview]
Message-ID: <20200608054614.GO23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20200607224156.GA24090@ip-172-31-24-31.ec2.internal>
On Sun, Jun 07, 2020 at 10:41:56PM +0000, Rodolfo C. Villordo wrote:
> Multiple line over 80 characters fixes by splitting in multiple lines.
> Warning found by checkpatch.pl
I doubt that checkpatch.pl can catch the real problems there:
* Hungarian Notation Sucks. Really.
* so does CamelCase, especially for wonders like s_uGetRTSCTSRsvTime
* local variables are useful
* if a long expression keeps cropping up all over the place, you
probably are missing an inline helper.
PS: this
> - buf->time_stamp_off_a = vnt_time_stamp_off(pDevice, wCurrentRate);
> - buf->time_stamp_off_b = vnt_time_stamp_off(pDevice, pDevice->byTopCCKBasicRate);
> + buf->time_stamp_off_a =
> + vnt_time_stamp_off(pDevice, wCurrentRate);
> + buf->time_stamp_off_b =
> + vnt_time_stamp_off(pDevice,
> + pDevice->byTopCCKBasicRate);
is no improvement.
next prev parent reply other threads:[~2020-06-08 5:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 22:41 Forest Bond <forest@alittletooquiet.net>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,devel@drive Rodolfo C. Villordo
2020-06-07 22:41 ` Forest Bond <forest@alittletooquiet.net>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,devel@driverdev.osuosl.org,linux-kernel@vger.kernel.org Rodolfo C. Villordo
2020-06-08 5:15 ` Forest Bond <forest@alittletooquiet.net>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,devel@d Greg Kroah-Hartman
2020-06-08 5:15 ` Forest Bond <forest@alittletooquiet.net>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,devel@driverdev.osuosl.org,linux-kernel@vger.kernel.org Greg Kroah-Hartman
2020-06-08 5:46 ` Al Viro [this message]
2020-06-08 5:46 ` Al Viro
2020-06-08 5:59 ` Forest Bond <forest@alittletooquiet.net>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,devel@d Julia Lawall
2020-06-08 5:59 ` Forest Bond <forest@alittletooquiet.net>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,devel@driverdev.osuosl.org,linux-kernel@vger.kernel.org Julia Lawall
2020-06-08 8:41 ` Forest Bond <forest@alittletooquiet.net>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,devel@d Joe Perches
2020-06-08 8:41 ` Forest Bond <forest@alittletooquiet.net>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,devel@driverdev.osuosl.org,linux-kernel@vger.kernel.org Joe Perches
[not found] ` <20200608225838.GA26559@ip-172-31-24-31.ec2.internal>
2020-06-08 23:33 ` Joe Perches
2020-06-10 19:20 ` Rodolfo C Villordo
2020-06-08 7:26 ` Forest Bond <forest@alittletooquiet.net>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,devel@d Dan Carpenter
2020-06-08 7:26 ` Forest Bond <forest@alittletooquiet.net>,Greg Kroah-Hartman <gregkh@linuxfoundation.org>,devel@driverdev.osuosl.org,linux-kernel@vger.kernel.org Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608054614.GO23230@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rodolfovillordo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.