All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denton Liu <liu.denton@gmail.com>
To: John Lin via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, John Lin <johnlinp@gmail.com>
Subject: Re: [PATCH] Recommend "git gc --prune=now" instead of "git prune"
Date: Mon, 8 Jun 2020 06:17:20 -0400	[thread overview]
Message-ID: <20200608101720.GA33389@generichostname> (raw)
In-Reply-To: <pull.652.git.1591581739031.gitgitgadget@gmail.com>

Hi John,

Thanks for working on this topic.

On Mon, Jun 08, 2020 at 02:02:18AM +0000, John Lin via GitGitGadget wrote:
> Subject: [PATCH] Recommend "git gc --prune=now" instead of "git prune"

The format for subjects is generally "<area>: <description>" so perhaps
something like "git gc: recommend use of `git gc --prune=now`"?

> From: John Lin <johnlinp@gmail.com>
> 
> Signed-off-by: John Lin <johnlinp@gmail.com>

This commit is missing some justification. In the commit message, we
should mention that `git prune` is a plumbing command and in the
documentation for it, it mentions that the porcelain `git gc` command
should be used instead.

  reply	other threads:[~2020-06-08 10:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-08  2:02 [PATCH] Recommend "git gc --prune=now" instead of "git prune" John Lin via GitGitGadget
2020-06-08 10:17 ` Denton Liu [this message]
2020-06-09  0:23 ` [PATCH v2] gc: recommend `git gc --prune=now` instead of `git prune` John Lin via GitGitGadget
2020-06-09  5:07   ` Junio C Hamano
2020-06-09 11:06   ` Ævar Arnfjörð Bjarmason
2020-06-09 16:03     ` Junio C Hamano
2020-06-10  3:43       ` 林自均
2020-06-10  3:47         ` Denton Liu
2020-06-10  7:38           ` 林自均

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200608101720.GA33389@generichostname \
    --to=liu.denton@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=johnlinp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.