All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: John Lin via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, John Lin <johnlinp@gmail.com>,
	Jeff King <peff@peff.net>, Denton Liu <liu.denton@gmail.com>
Subject: Re: [PATCH v2] gc: recommend `git gc --prune=now` instead of `git prune`
Date: Tue, 09 Jun 2020 09:03:18 -0700	[thread overview]
Message-ID: <xmqqa71ci5vd.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <87bllsa47u.fsf@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Tue, 09 Jun 2020 13:06:13 +0200")

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> On Tue, Jun 09 2020, John Lin via GitGitGadget wrote:
>
>> From: John Lin <johnlinp@gmail.com>
>>
>> `git prune` is a plumbing command and should not be run directly by
>> users. The corresponding porcelain command is `git gc`, which is
>> mentioned in the man page of `git prune`.
>
> This change feels incomplete without a change to git-prune's
> documentation, see 8d308b3540 ("Documentation: point git-prune users to
> git-gc", 2008-04-29).
>
> I.e. it still talks about "in most cases you shouldn't run this", but
> here we are removing a case where it would otherwise make sense because
> the user shouldn't use it directly.
>
> I think instead the small change that makes the most sense here is to
> just add "prune" to completions,...

That's perfectly reasonable stance to take.

  reply	other threads:[~2020-06-09 16:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-08  2:02 [PATCH] Recommend "git gc --prune=now" instead of "git prune" John Lin via GitGitGadget
2020-06-08 10:17 ` Denton Liu
2020-06-09  0:23 ` [PATCH v2] gc: recommend `git gc --prune=now` instead of `git prune` John Lin via GitGitGadget
2020-06-09  5:07   ` Junio C Hamano
2020-06-09 11:06   ` Ævar Arnfjörð Bjarmason
2020-06-09 16:03     ` Junio C Hamano [this message]
2020-06-10  3:43       ` 林自均
2020-06-10  3:47         ` Denton Liu
2020-06-10  7:38           ` 林自均

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa71ci5vd.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=johnlinp@gmail.com \
    --cc=liu.denton@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.