* [PATCH 0/2] DRA7 timer/mailbox dts fixes
@ 2020-06-05 22:13 Suman Anna
2020-06-05 22:13 ` [PATCH 1/2] ARM: dts: dra7: Fix timer nodes properly for timer_sys_ck clocks Suman Anna
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Suman Anna @ 2020-06-05 22:13 UTC (permalink / raw)
To: Tony Lindgren
Cc: Tero Kristo, linux-omap, devicetree, linux-kernel, Suman Anna
Hi Tony,
The following 2 patches are couple of minor fixes that clean up
couple of commits from the "ARM: dts: dra7/am57xx: remoteproc
support" series [1]. Please pick these for the 5.8-rc fixes.
The issues look to be result of incorrect rebase-conflict resolution
of the downstream TI patches based on 5.4 kernel.
regards
Suman
[1] https://patchwork.kernel.org/cover/11508091/
Suman Anna (2):
ARM: dts: dra7: Fix timer nodes properly for timer_sys_ck clocks
ARM: dts: dra7-evm-common: Fix duplicate mailbox nodes
arch/arm/boot/dts/dra7-evm-common.dtsi | 20 ---------------
arch/arm/boot/dts/dra7-l4.dtsi | 34 ++++++++++++--------------
2 files changed, 16 insertions(+), 38 deletions(-)
--
2.26.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] ARM: dts: dra7: Fix timer nodes properly for timer_sys_ck clocks
2020-06-05 22:13 [PATCH 0/2] DRA7 timer/mailbox dts fixes Suman Anna
@ 2020-06-05 22:13 ` Suman Anna
2020-06-05 22:13 ` [PATCH 2/2] ARM: dts: dra7-evm-common: Fix duplicate mailbox nodes Suman Anna
2020-06-08 17:16 ` [PATCH 0/2] DRA7 timer/mailbox dts fixes Tony Lindgren
2 siblings, 0 replies; 4+ messages in thread
From: Suman Anna @ 2020-06-05 22:13 UTC (permalink / raw)
To: Tony Lindgren
Cc: Tero Kristo, linux-omap, devicetree, linux-kernel, Suman Anna
The commit 5390130f3b28 ("ARM: dts: dra7: add timer_sys_ck entries
for IPU/DSP timers") was added to allow the OMAP clocksource timer
driver to use the clock aliases when reconfiguring the parent clock
source for the timer functional clocks after the timer_sys_ck clock
aliases got cleaned up in commit a8202cd5174d ("clk: ti: dra7: drop
unnecessary clock aliases").
The above patch however has missed adding the entries for couple of
timers (14, 15 and 16), and also added erroneously in the parent
ti-sysc nodes for couple of clocks (timers 4, 5 and 6). Fix these
properly, so that any of these timers can be used with OMAP remoteproc
IPU and DSP devices. The always-on timers 1 and 12 are not expected
to use this clock source, so they are not modified.
Fixes: 5390130f3b28 ("ARM: dts: dra7: add timer_sys_ck entries for IPU/DSP timers")
Signed-off-by: Suman Anna <s-anna@ti.com>
---
arch/arm/boot/dts/dra7-l4.dtsi | 34 ++++++++++++++++------------------
1 file changed, 16 insertions(+), 18 deletions(-)
diff --git a/arch/arm/boot/dts/dra7-l4.dtsi b/arch/arm/boot/dts/dra7-l4.dtsi
index 62ca89551219..0c6f26605506 100644
--- a/arch/arm/boot/dts/dra7-l4.dtsi
+++ b/arch/arm/boot/dts/dra7-l4.dtsi
@@ -1207,9 +1207,8 @@ target-module@36000 { /* 0x48036000, ap 9 4e.0 */
<SYSC_IDLE_SMART>,
<SYSC_IDLE_SMART_WKUP>;
/* Domains (P, C): l4per_pwrdm, l4per_clkdm */
- clocks = <&l4per_clkctrl DRA7_L4PER_TIMER4_CLKCTRL 0>,
- <&timer_sys_clk_div>;
- clock-names = "fck", "timer_sys_ck";
+ clocks = <&l4per_clkctrl DRA7_L4PER_TIMER4_CLKCTRL 0>;
+ clock-names = "fck";
#address-cells = <1>;
#size-cells = <1>;
ranges = <0x0 0x36000 0x1000>;
@@ -3352,8 +3351,8 @@ target-module@20000 { /* 0x48820000, ap 5 08.0 */
<SYSC_IDLE_SMART>,
<SYSC_IDLE_SMART_WKUP>;
/* Domains (P, C): ipu_pwrdm, ipu_clkdm */
- clocks = <&ipu_clkctrl DRA7_IPU_TIMER5_CLKCTRL 0>, <&timer_sys_clk_div>;
- clock-names = "fck", "timer_sys_ck";
+ clocks = <&ipu_clkctrl DRA7_IPU_TIMER5_CLKCTRL 0>;
+ clock-names = "fck";
#address-cells = <1>;
#size-cells = <1>;
ranges = <0x0 0x20000 0x1000>;
@@ -3361,8 +3360,8 @@ target-module@20000 { /* 0x48820000, ap 5 08.0 */
timer5: timer@0 {
compatible = "ti,omap5430-timer";
reg = <0x0 0x80>;
- clocks = <&ipu_clkctrl DRA7_IPU_TIMER5_CLKCTRL 24>;
- clock-names = "fck";
+ clocks = <&ipu_clkctrl DRA7_IPU_TIMER5_CLKCTRL 24>, <&timer_sys_clk_div>;
+ clock-names = "fck", "timer_sys_ck";
interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>;
};
};
@@ -3379,9 +3378,8 @@ target-module@22000 { /* 0x48822000, ap 7 24.0 */
<SYSC_IDLE_SMART>,
<SYSC_IDLE_SMART_WKUP>;
/* Domains (P, C): ipu_pwrdm, ipu_clkdm */
- clocks = <&ipu_clkctrl DRA7_IPU_TIMER6_CLKCTRL 0>,
- <&timer_sys_clk_div>;
- clock-names = "fck", "timer_sys_ck";
+ clocks = <&ipu_clkctrl DRA7_IPU_TIMER6_CLKCTRL 0>;
+ clock-names = "fck";
#address-cells = <1>;
#size-cells = <1>;
ranges = <0x0 0x22000 0x1000>;
@@ -3389,8 +3387,8 @@ target-module@22000 { /* 0x48822000, ap 7 24.0 */
timer6: timer@0 {
compatible = "ti,omap5430-timer";
reg = <0x0 0x80>;
- clocks = <&ipu_clkctrl DRA7_IPU_TIMER6_CLKCTRL 24>;
- clock-names = "fck";
+ clocks = <&ipu_clkctrl DRA7_IPU_TIMER6_CLKCTRL 24>, <&timer_sys_clk_div>;
+ clock-names = "fck", "timer_sys_ck";
interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
};
};
@@ -3498,8 +3496,8 @@ target-module@2a000 { /* 0x4882a000, ap 15 10.0 */
timer14: timer@0 {
compatible = "ti,omap5430-timer";
reg = <0x0 0x80>;
- clocks = <&l4per3_clkctrl DRA7_L4PER3_TIMER14_CLKCTRL 24>;
- clock-names = "fck";
+ clocks = <&l4per3_clkctrl DRA7_L4PER3_TIMER14_CLKCTRL 24>, <&timer_sys_clk_div>;
+ clock-names = "fck", "timer_sys_ck";
interrupts = <GIC_SPI 340 IRQ_TYPE_LEVEL_HIGH>;
ti,timer-pwm;
};
@@ -3526,8 +3524,8 @@ target-module@2c000 { /* 0x4882c000, ap 17 02.0 */
timer15: timer@0 {
compatible = "ti,omap5430-timer";
reg = <0x0 0x80>;
- clocks = <&l4per3_clkctrl DRA7_L4PER3_TIMER15_CLKCTRL 24>;
- clock-names = "fck";
+ clocks = <&l4per3_clkctrl DRA7_L4PER3_TIMER15_CLKCTRL 24>, <&timer_sys_clk_div>;
+ clock-names = "fck", "timer_sys_ck";
interrupts = <GIC_SPI 341 IRQ_TYPE_LEVEL_HIGH>;
ti,timer-pwm;
};
@@ -3554,8 +3552,8 @@ target-module@2e000 { /* 0x4882e000, ap 19 14.0 */
timer16: timer@0 {
compatible = "ti,omap5430-timer";
reg = <0x0 0x80>;
- clocks = <&l4per3_clkctrl DRA7_L4PER3_TIMER16_CLKCTRL 24>;
- clock-names = "fck";
+ clocks = <&l4per3_clkctrl DRA7_L4PER3_TIMER16_CLKCTRL 24>, <&timer_sys_clk_div>;
+ clock-names = "fck", "timer_sys_ck";
interrupts = <GIC_SPI 342 IRQ_TYPE_LEVEL_HIGH>;
ti,timer-pwm;
};
--
2.26.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] ARM: dts: dra7-evm-common: Fix duplicate mailbox nodes
2020-06-05 22:13 [PATCH 0/2] DRA7 timer/mailbox dts fixes Suman Anna
2020-06-05 22:13 ` [PATCH 1/2] ARM: dts: dra7: Fix timer nodes properly for timer_sys_ck clocks Suman Anna
@ 2020-06-05 22:13 ` Suman Anna
2020-06-08 17:16 ` [PATCH 0/2] DRA7 timer/mailbox dts fixes Tony Lindgren
2 siblings, 0 replies; 4+ messages in thread
From: Suman Anna @ 2020-06-05 22:13 UTC (permalink / raw)
To: Tony Lindgren
Cc: Tero Kristo, linux-omap, devicetree, linux-kernel, Suman Anna
The mailbox nodes defined in various dts files have been moved to
common dra7-ipu-dsp-common.dtsi and dra74-ipu-dsp-common.dtsi files
in commit a11a2f73b32d ("ARM: dts: dra7-ipu-dsp-common: Move mailboxes
into common files"), but the nodes were erroneously left out in the
dra7-evm-common.dtsi file. Fix this by removing these duplicate nodes.
Signed-off-by: Suman Anna <s-anna@ti.com>
---
arch/arm/boot/dts/dra7-evm-common.dtsi | 20 --------------------
1 file changed, 20 deletions(-)
diff --git a/arch/arm/boot/dts/dra7-evm-common.dtsi b/arch/arm/boot/dts/dra7-evm-common.dtsi
index f89a64cbcd53..2cf6a529d4ad 100644
--- a/arch/arm/boot/dts/dra7-evm-common.dtsi
+++ b/arch/arm/boot/dts/dra7-evm-common.dtsi
@@ -245,26 +245,6 @@ &mcasp3 {
rx-num-evt = <32>;
};
-&mailbox5 {
- status = "okay";
- mbox_ipu1_ipc3x: mbox_ipu1_ipc3x {
- status = "okay";
- };
- mbox_dsp1_ipc3x: mbox_dsp1_ipc3x {
- status = "okay";
- };
-};
-
-&mailbox6 {
- status = "okay";
- mbox_ipu2_ipc3x: mbox_ipu2_ipc3x {
- status = "okay";
- };
- mbox_dsp2_ipc3x: mbox_dsp2_ipc3x {
- status = "okay";
- };
-};
-
&pcie1_rc {
status = "okay";
};
--
2.26.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] DRA7 timer/mailbox dts fixes
2020-06-05 22:13 [PATCH 0/2] DRA7 timer/mailbox dts fixes Suman Anna
2020-06-05 22:13 ` [PATCH 1/2] ARM: dts: dra7: Fix timer nodes properly for timer_sys_ck clocks Suman Anna
2020-06-05 22:13 ` [PATCH 2/2] ARM: dts: dra7-evm-common: Fix duplicate mailbox nodes Suman Anna
@ 2020-06-08 17:16 ` Tony Lindgren
2 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2020-06-08 17:16 UTC (permalink / raw)
To: Suman Anna; +Cc: Tero Kristo, linux-omap, devicetree, linux-kernel
* Suman Anna <s-anna@ti.com> [200605 15:14]:
> Hi Tony,
>
> The following 2 patches are couple of minor fixes that clean up
> couple of commits from the "ARM: dts: dra7/am57xx: remoteproc
> support" series [1]. Please pick these for the 5.8-rc fixes.
>
> The issues look to be result of incorrect rebase-conflict resolution
> of the downstream TI patches based on 5.4 kernel.
Thanks applying both into fixes.
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-08 17:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-05 22:13 [PATCH 0/2] DRA7 timer/mailbox dts fixes Suman Anna
2020-06-05 22:13 ` [PATCH 1/2] ARM: dts: dra7: Fix timer nodes properly for timer_sys_ck clocks Suman Anna
2020-06-05 22:13 ` [PATCH 2/2] ARM: dts: dra7-evm-common: Fix duplicate mailbox nodes Suman Anna
2020-06-08 17:16 ` [PATCH 0/2] DRA7 timer/mailbox dts fixes Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.