From: Wolfram Sang <wsa@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Tali Perry <tali.perry1@gmail.com>,
linux-i2c@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] i2c: npcm7xx: Fix a couple error codes in probe
Date: Mon, 08 Jun 2020 20:30:55 +0000 [thread overview]
Message-ID: <20200608203055.GA917@ninjato> (raw)
In-Reply-To: <20200608141727.GC1912173@mwanda>
[-- Attachment #1: Type: text/plain, Size: 370 bytes --]
On Mon, Jun 08, 2020 at 05:17:27PM +0300, Dan Carpenter wrote:
> The code here is accidentally returning IS_ERR() which is 1 but it
> should be returning negative error codes with PTR_ERR().
>
> Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to for-5.8, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Tali Perry <tali.perry1@gmail.com>,
linux-i2c@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] i2c: npcm7xx: Fix a couple error codes in probe
Date: Mon, 8 Jun 2020 22:30:55 +0200 [thread overview]
Message-ID: <20200608203055.GA917@ninjato> (raw)
In-Reply-To: <20200608141727.GC1912173@mwanda>
[-- Attachment #1: Type: text/plain, Size: 370 bytes --]
On Mon, Jun 08, 2020 at 05:17:27PM +0300, Dan Carpenter wrote:
> The code here is accidentally returning IS_ERR() which is 1 but it
> should be returning negative error codes with PTR_ERR().
>
> Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to for-5.8, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-06-08 20:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 14:17 [PATCH] i2c: npcm7xx: Fix a couple error codes in probe Dan Carpenter
2020-06-08 14:17 ` Dan Carpenter
2020-06-08 20:30 ` Wolfram Sang [this message]
2020-06-08 20:30 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608203055.GA917@ninjato \
--to=wsa@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=tali.perry1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.