From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v6 2/6] drm/of: Make drm_of_find_panel_or_bridge() to check graph's presence
Date: Tue, 9 Jun 2020 16:28:51 +0300 [thread overview]
Message-ID: <20200609132855.20975-3-digetx@gmail.com> (raw)
In-Reply-To: <20200609132855.20975-1-digetx@gmail.com>
When graph isn't defined in a device-tree, the of_graph_get_remote_node()
prints a noisy error message, telling that port node is not found. This is
undesirable behaviour in our case because absence of a panel/bridge graph
is a valid case. Let's check presence of the local port in a device-tree
before proceeding with parsing the graph.
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/gpu/drm/drm_of.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
index b50b44e76279..e0652c38f357 100644
--- a/drivers/gpu/drm/drm_of.c
+++ b/drivers/gpu/drm/drm_of.c
@@ -239,13 +239,24 @@ int drm_of_find_panel_or_bridge(const struct device_node *np,
struct drm_bridge **bridge)
{
int ret = -EPROBE_DEFER;
- struct device_node *remote;
+ struct device_node *local, *remote;
if (!panel && !bridge)
return -EINVAL;
if (panel)
*panel = NULL;
+ /*
+ * of_graph_get_remote_node() produces a noisy error message if port
+ * node isn't found and the absence of the port is a legit case here,
+ * so at first we silently check presence of the local port.
+ */
+ local = of_graph_get_local_port(np);
+ if (!local)
+ return -ENODEV;
+
+ of_node_put(local);
+
remote = of_graph_get_remote_node(np, port, endpoint);
if (!remote)
return -ENODEV;
--
2.26.0
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>
Cc: linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: [PATCH v6 2/6] drm/of: Make drm_of_find_panel_or_bridge() to check graph's presence
Date: Tue, 9 Jun 2020 16:28:51 +0300 [thread overview]
Message-ID: <20200609132855.20975-3-digetx@gmail.com> (raw)
In-Reply-To: <20200609132855.20975-1-digetx@gmail.com>
When graph isn't defined in a device-tree, the of_graph_get_remote_node()
prints a noisy error message, telling that port node is not found. This is
undesirable behaviour in our case because absence of a panel/bridge graph
is a valid case. Let's check presence of the local port in a device-tree
before proceeding with parsing the graph.
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/gpu/drm/drm_of.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
index b50b44e76279..e0652c38f357 100644
--- a/drivers/gpu/drm/drm_of.c
+++ b/drivers/gpu/drm/drm_of.c
@@ -239,13 +239,24 @@ int drm_of_find_panel_or_bridge(const struct device_node *np,
struct drm_bridge **bridge)
{
int ret = -EPROBE_DEFER;
- struct device_node *remote;
+ struct device_node *local, *remote;
if (!panel && !bridge)
return -EINVAL;
if (panel)
*panel = NULL;
+ /*
+ * of_graph_get_remote_node() produces a noisy error message if port
+ * node isn't found and the absence of the port is a legit case here,
+ * so at first we silently check presence of the local port.
+ */
+ local = of_graph_get_local_port(np);
+ if (!local)
+ return -ENODEV;
+
+ of_node_put(local);
+
remote = of_graph_get_remote_node(np, port, endpoint);
if (!remote)
return -ENODEV;
--
2.26.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-06-09 13:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 13:28 [PATCH v6 0/6] Support DRM bridges on NVIDIA Tegra Dmitry Osipenko
2020-06-09 13:28 ` Dmitry Osipenko
2020-06-09 13:28 ` Dmitry Osipenko
2020-06-09 13:28 ` [PATCH v6 1/6] of_graph: add of_graph_get_local_port() Dmitry Osipenko
2020-06-09 13:28 ` Dmitry Osipenko
2020-06-09 13:28 ` Dmitry Osipenko [this message]
2020-06-09 13:28 ` [PATCH v6 2/6] drm/of: Make drm_of_find_panel_or_bridge() to check graph's presence Dmitry Osipenko
2020-06-09 13:28 ` [PATCH v6 4/6] drm/tegra: output: Support DRM bridges Dmitry Osipenko
2020-06-09 13:28 ` Dmitry Osipenko
[not found] ` <20200609132855.20975-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-06-09 13:28 ` [PATCH v6 3/6] drm/tegra: output: Don't leak OF node on error Dmitry Osipenko
2020-06-09 13:28 ` Dmitry Osipenko
2020-06-09 13:28 ` Dmitry Osipenko
2020-06-09 13:28 ` [PATCH v6 5/6] drm/tegra: output: rgb: Support LVDS encoder bridge Dmitry Osipenko
2020-06-09 13:28 ` Dmitry Osipenko
2020-06-09 13:28 ` Dmitry Osipenko
2020-06-09 13:28 ` [PATCH v6 6/6] drm/tegra: output: rgb: Wrap directly-connected panel into DRM bridge Dmitry Osipenko
2020-06-09 13:28 ` Dmitry Osipenko
2020-06-09 13:28 ` Dmitry Osipenko
[not found] ` <20200609132855.20975-7-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-06-12 21:23 ` kernel test robot
2020-06-12 21:23 ` kernel test robot
2020-06-12 21:23 ` kernel test robot
2020-06-12 21:23 ` kernel test robot
[not found] ` <202006130511.AE6Kvrjm%lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2020-06-12 21:53 ` Dmitry Osipenko
2020-06-12 21:53 ` Dmitry Osipenko
2020-06-12 21:53 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200609132855.20975-3-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frowand.list@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.