All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/omap: force runtime PM suspend on system suspend
Date: Tue, 9 Jun 2020 08:12:32 -0700	[thread overview]
Message-ID: <20200609151232.GR43721@atomide.com> (raw)
In-Reply-To: <20200609103220.753969-1-tomi.valkeinen@ti.com>

* Tomi Valkeinen <tomi.valkeinen@ti.com> [200609 10:33]:
> Use suspend_late and resume_early callbacks in DSS submodules to force
> runtime PM suspend and resume.
> 
> We use suspend_late callback so that omapdrm's system suspend callback
> is called first, as that will disable all the display outputs after
> which it's safe to force DSS into suspend.

I think we can avoid the pm_runtime_force use if we have omapdrm
implement both .suspend and .suspend_late. In that case suspend would
only disable the display outputs, then suspend_late would take care
of switching off the lights and release the last PM runtime count
after the children are done suspending.

Looks like we have already something similar done for i915_drv.c, so
it should be doable. Maybe the disconnect can be done in .prepare and
then .suspend_late is not even needed?

And I think at that point the children can just use the standard
UNIVERSAL_DEV_PM_OPS without pm_runtime_force usage hopefully :)

Regards,

Tony
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-06-10  7:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09 10:32 [PATCH] drm/omap: force runtime PM suspend on system suspend Tomi Valkeinen
2020-06-09 15:12 ` Tony Lindgren [this message]
2020-06-09 15:37   ` Tomi Valkeinen
2020-06-09 16:10     ` Tony Lindgren
2020-06-09 16:26       ` Tomi Valkeinen
2020-06-09 16:37         ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200609151232.GR43721@atomide.com \
    --to=tony@atomide.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.