All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/omap: force runtime PM suspend on system suspend
Date: Tue, 9 Jun 2020 09:37:24 -0700	[thread overview]
Message-ID: <20200609163724.GT43721@atomide.com> (raw)
In-Reply-To: <fc4e7d29-b170-8863-3bfb-9159196421f4@ti.com>

* Tomi Valkeinen <tomi.valkeinen@ti.com> [200609 16:27]:
> On 09/06/2020 19:10, Tony Lindgren wrote:
> > Yeah so it seems. Can we just diconnect the display outputs
> > in .prepare somewhere? Or is that the wrong place to do it?
> 
> Hmm, yes, perhaps... If omapdrm uses .prepare to disable all the outputs.
> Then DSS submodules could use UNIVERSAL_DEV_PM_OPS() and have the same
> functions for system and runtime suspend.

Yeah that would be nice. And maybe the need for force_suspend
also disappears with the ordering issues gone :)

> Although that has the problem that if the DSS is already runtime suspended
> when system suspend happens, the PM does not wake DSS up, and thus the
> suspend callbacks will crash if they access registers. So they need some
> extra logic there.
> 
> I'll see tomorrow if I can come up with something like that.

OK. This $subject patch works for my test cases for suspend
and resume based on a brief test with my fixes branch FYI.

Regards,

Tony
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2020-06-10  7:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09 10:32 [PATCH] drm/omap: force runtime PM suspend on system suspend Tomi Valkeinen
2020-06-09 15:12 ` Tony Lindgren
2020-06-09 15:37   ` Tomi Valkeinen
2020-06-09 16:10     ` Tony Lindgren
2020-06-09 16:26       ` Tomi Valkeinen
2020-06-09 16:37         ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200609163724.GT43721@atomide.com \
    --to=tony@atomide.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.