[Intel-gfx] [PATCH] drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors

[Intel-gfx] [PATCH] drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors

[Imre Deak]

DSC is not supported on DP MST streams so just return -EINVAL when
reading/writing the i915_dsc_fec_support debugfs file for such
connectors.

This also fixes an OOPS, caused by the encoder->digport cast, which is
not valid for MST encoders.

Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 .../drm/i915/display/intel_display_debugfs.c  | 36 +++++++++++++++----
 1 file changed, 29 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
index 2b640d8ab9d2..ebca8e488d03 100644
--- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
+++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
@@ -2094,6 +2094,8 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
 	drm_modeset_acquire_init(&ctx, DRM_MODESET_ACQUIRE_INTERRUPTIBLE);
 
 	do {
+		struct intel_encoder *encoder;
+
 		try_again = false;
 		ret = drm_modeset_lock(&dev->mode_config.connection_mutex,
 				       &ctx);
@@ -2120,8 +2122,17 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
 		} else if (ret) {
 			break;
 		}
-		intel_dp = intel_attached_dp(to_intel_connector(connector));
+
+		encoder = intel_attached_encoder(to_intel_connector(connector));
+		/* TODO: Add DSC support for MST streams */
+		if (encoder->type == INTEL_OUTPUT_DP_MST) {
+			ret = -EINVAL;
+			break;
+		}
+
+		intel_dp = &enc_to_dig_port(encoder)->dp;
 		crtc_state = to_intel_crtc_state(crtc->state);
+
 		seq_printf(m, "DSC_Enabled: %s\n",
 			   yesno(crtc_state->dsc.compression_enable));
 		seq_printf(m, "DSC_Sink_Support: %s\n",
@@ -2147,9 +2158,8 @@ static ssize_t i915_dsc_fec_support_write(struct file *file,
 	int ret;
 	struct drm_connector *connector =
 		((struct seq_file *)file->private_data)->private;
-	struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
-	struct drm_i915_private *i915 = to_i915(encoder->base.dev);
-	struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
+	struct drm_i915_private *i915 = to_i915(connector->dev);
+	struct intel_encoder *encoder;
 
 	if (len == 0)
 		return 0;
@@ -2163,10 +2173,22 @@ static ssize_t i915_dsc_fec_support_write(struct file *file,
 
 	drm_dbg(&i915->drm, "Got %s for DSC Enable\n",
 		(dsc_enable) ? "true" : "false");
-	intel_dp->force_dsc_en = dsc_enable;
 
-	*offp += len;
-	return len;
+	drm_modeset_lock(&i915->drm.mode_config.connection_mutex, NULL);
+
+	encoder = intel_attached_encoder(to_intel_connector(connector));
+	/* TODO: Add DSC support for MST streams */
+	if (encoder->type == INTEL_OUTPUT_DP_MST) {
+		ret = -EINVAL;
+	} else {
+		enc_to_intel_dp(encoder)->force_dsc_en = dsc_enable;
+		*offp += len;
+		ret = len;
+	}
+
+	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
+
+	return ret;
 }
 
 static int i915_dsc_fec_support_open(struct inode *inode,
-- 
2.23.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH v2] drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors

[Imre Deak]

DSC is not supported on DP MST streams so just return -EINVAL when
reading/writing the i915_dsc_fec_support debugfs file for such
connectors.

This also fixes an OOPS, caused by the encoder->digport cast, which is
not valid for MST encoders.

v2:
- Check encoder, which is unset for an MST connector, before it gets
  enabled.

Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 .../drm/i915/display/intel_display_debugfs.c  | 36 +++++++++++++++----
 1 file changed, 29 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
index 2b640d8ab9d2..9db6f7e0ccaa 100644
--- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
+++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
@@ -2094,6 +2094,8 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
 	drm_modeset_acquire_init(&ctx, DRM_MODESET_ACQUIRE_INTERRUPTIBLE);
 
 	do {
+		struct intel_encoder *encoder;
+
 		try_again = false;
 		ret = drm_modeset_lock(&dev->mode_config.connection_mutex,
 				       &ctx);
@@ -2120,8 +2122,17 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
 		} else if (ret) {
 			break;
 		}
-		intel_dp = intel_attached_dp(to_intel_connector(connector));
+
+		encoder = intel_attached_encoder(to_intel_connector(connector));
+		/* TODO: Add DSC support for MST streams */
+		if (encoder->type == INTEL_OUTPUT_DP_MST) {
+			ret = -EINVAL;
+			break;
+		}
+
+		intel_dp = &enc_to_dig_port(encoder)->dp;
 		crtc_state = to_intel_crtc_state(crtc->state);
+
 		seq_printf(m, "DSC_Enabled: %s\n",
 			   yesno(crtc_state->dsc.compression_enable));
 		seq_printf(m, "DSC_Sink_Support: %s\n",
@@ -2147,9 +2158,8 @@ static ssize_t i915_dsc_fec_support_write(struct file *file,
 	int ret;
 	struct drm_connector *connector =
 		((struct seq_file *)file->private_data)->private;
-	struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
-	struct drm_i915_private *i915 = to_i915(encoder->base.dev);
-	struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
+	struct drm_i915_private *i915 = to_i915(connector->dev);
+	struct intel_encoder *encoder;
 
 	if (len == 0)
 		return 0;
@@ -2163,10 +2173,22 @@ static ssize_t i915_dsc_fec_support_write(struct file *file,
 
 	drm_dbg(&i915->drm, "Got %s for DSC Enable\n",
 		(dsc_enable) ? "true" : "false");
-	intel_dp->force_dsc_en = dsc_enable;
 
-	*offp += len;
-	return len;
+	drm_modeset_lock(&i915->drm.mode_config.connection_mutex, NULL);
+
+	encoder = intel_attached_encoder(to_intel_connector(connector));
+	/* TODO: Add DSC support for MST streams */
+	if (!encoder || encoder->type == INTEL_OUTPUT_DP_MST) {
+		ret = -EINVAL;
+	} else {
+		enc_to_intel_dp(encoder)->force_dsc_en = dsc_enable;
+		*offp += len;
+		ret = len;
+	}
+
+	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
+
+	return ret;
 }
 
 static int i915_dsc_fec_support_open(struct inode *inode,
-- 
2.23.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors (rev2)

[Patchwork]

== Series Details ==

Series: drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors (rev2)
URL   : https://patchwork.freedesktop.org/series/78128/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8601 -> Patchwork_17911
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/index.html

Known issues
------------

  Here are the changes found in Patchwork_17911 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_pm_rpm@module-reload:
    - fi-byt-j1900:       [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html

  * igt@kms_busy@basic@flip:
    - fi-kbl-x1275:       [PASS][3] -> [DMESG-WARN][4] ([i915#62] / [i915#92] / [i915#95])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/fi-kbl-x1275/igt@kms_busy@basic@flip.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/fi-kbl-x1275/igt@kms_busy@basic@flip.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
    - fi-bsw-kefka:       [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html

  * igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
    - fi-icl-u2:          [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html

  
#### Possible fixes ####

  * igt@i915_module_load@reload:
    - fi-byt-n2820:       [DMESG-WARN][9] ([i915#1982]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/fi-byt-n2820/igt@i915_module_load@reload.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/fi-byt-n2820/igt@i915_module_load@reload.html

  * igt@i915_pm_rpm@basic-pci-d3-state:
    - fi-bsw-kefka:       [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html

  * igt@i915_pm_rpm@basic-rte:
    - fi-byt-j1900:       [DMESG-WARN][13] ([i915#1982]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/fi-byt-j1900/igt@i915_pm_rpm@basic-rte.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/fi-byt-j1900/igt@i915_pm_rpm@basic-rte.html

  * igt@i915_pm_rpm@module-reload:
    - fi-glk-dsi:         [DMESG-WARN][15] ([i915#1982]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/fi-glk-dsi/igt@i915_pm_rpm@module-reload.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/fi-glk-dsi/igt@i915_pm_rpm@module-reload.html

  * igt@kms_cursor_legacy@basic-flip-before-cursor-atomic:
    - fi-icl-u2:          [DMESG-WARN][17] ([i915#1982]) -> [PASS][18] +1 similar issue
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html

  
#### Warnings ####

  * igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
    - fi-kbl-x1275:       [DMESG-WARN][19] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][20] ([i915#62] / [i915#92])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html

  * igt@kms_force_connector_basic@force-connector-state:
    - fi-kbl-x1275:       [DMESG-WARN][21] ([i915#62] / [i915#92]) -> [DMESG-WARN][22] ([i915#62] / [i915#92] / [i915#95]) +2 similar issues
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/fi-kbl-x1275/igt@kms_force_connector_basic@force-connector-state.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/fi-kbl-x1275/igt@kms_force_connector_basic@force-connector-state.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
  [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (49 -> 43)
------------------------------

  Missing    (6): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_8601 -> Patchwork_17911

  CI-20190529: 20190529
  CI_DRM_8601: c801ab3a923b2436d765bd7a97888715f68451cb @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5699: 201da47cb57b8fadd9bc45be16b82617b32a2c01 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_17911: 2c4524628e2260caff58cb7020b91497c3091394 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

2c4524628e22 drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors (rev2)

[Patchwork]

== Series Details ==

Series: drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors (rev2)
URL   : https://patchwork.freedesktop.org/series/78128/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8601_full -> Patchwork_17911_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Known issues
------------

  Here are the changes found in Patchwork_17911_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_engines@idempotent:
    - shard-tglb:         [PASS][1] -> [DMESG-WARN][2] ([i915#402]) +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-tglb6/igt@gem_ctx_engines@idempotent.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-tglb2/igt@gem_ctx_engines@idempotent.html

  * igt@gem_exec_whisper@basic-queues-priority-all:
    - shard-glk:          [PASS][3] -> [DMESG-WARN][4] ([i915#118] / [i915#95])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-glk4/igt@gem_exec_whisper@basic-queues-priority-all.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-glk7/igt@gem_exec_whisper@basic-queues-priority-all.html

  * igt@gem_sync@basic-store-each:
    - shard-apl:          [PASS][5] -> [DMESG-WARN][6] ([i915#95]) +11 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-apl3/igt@gem_sync@basic-store-each.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-apl4/igt@gem_sync@basic-store-each.html

  * igt@i915_suspend@forcewake:
    - shard-kbl:          [PASS][7] -> [DMESG-WARN][8] ([i915#180])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-kbl6/igt@i915_suspend@forcewake.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-kbl2/igt@i915_suspend@forcewake.html

  * igt@kms_big_fb@y-tiled-64bpp-rotate-180:
    - shard-glk:          [PASS][9] -> [DMESG-FAIL][10] ([i915#118] / [i915#95])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-glk6/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-glk8/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html

  * igt@kms_color@pipe-c-ctm-0-5:
    - shard-skl:          [PASS][11] -> [DMESG-WARN][12] ([i915#1982]) +6 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-skl5/igt@kms_color@pipe-c-ctm-0-5.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-skl8/igt@kms_color@pipe-c-ctm-0-5.html

  * igt@kms_color@pipe-c-ctm-blue-to-red:
    - shard-kbl:          [PASS][13] -> [DMESG-WARN][14] ([i915#93] / [i915#95])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-kbl6/igt@kms_color@pipe-c-ctm-blue-to-red.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-kbl2/igt@kms_color@pipe-c-ctm-blue-to-red.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
    - shard-skl:          [PASS][15] -> [FAIL][16] ([IGT#5])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
    - shard-tglb:         [PASS][17] -> [DMESG-WARN][18] ([i915#1982])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt:
    - shard-snb:          [PASS][19] -> [SKIP][20] ([fdo#109271])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-snb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-snb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbc-stridechange:
    - shard-glk:          [PASS][21] -> [DMESG-WARN][22] ([i915#1982])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-glk4/igt@kms_frontbuffer_tracking@fbc-stridechange.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-glk6/igt@kms_frontbuffer_tracking@fbc-stridechange.html

  * igt@kms_hdr@bpc-switch:
    - shard-skl:          [PASS][23] -> [FAIL][24] ([i915#1188])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-skl7/igt@kms_hdr@bpc-switch.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-skl6/igt@kms_hdr@bpc-switch.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
    - shard-skl:          [PASS][25] -> [INCOMPLETE][26] ([i915#69]) +2 similar issues
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-skl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-skl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
    - shard-apl:          [PASS][27] -> [DMESG-WARN][28] ([i915#180])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-apl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html

  * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
    - shard-skl:          [PASS][29] -> [FAIL][30] ([fdo#108145] / [i915#265])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html

  * igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
    - shard-iclb:         [PASS][31] -> [DMESG-WARN][32] ([i915#1982])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-iclb2/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-iclb3/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html

  * igt@kms_psr@no_drrs:
    - shard-iclb:         [PASS][33] -> [FAIL][34] ([i915#173])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-iclb2/igt@kms_psr@no_drrs.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-iclb1/igt@kms_psr@no_drrs.html

  * igt@kms_psr@psr2_cursor_plane_move:
    - shard-iclb:         [PASS][35] -> [SKIP][36] ([fdo#109441]) +2 similar issues
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-iclb3/igt@kms_psr@psr2_cursor_plane_move.html

  * igt@kms_psr@psr2_cursor_plane_onoff:
    - shard-tglb:         [PASS][37] -> [SKIP][38] ([i915#668]) +6 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-tglb8/igt@kms_psr@psr2_cursor_plane_onoff.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-tglb6/igt@kms_psr@psr2_cursor_plane_onoff.html

  
#### Possible fixes ####

  * igt@gem_mmap_gtt@fault-concurrent:
    - shard-skl:          [CRASH][39] -> [PASS][40]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-skl2/igt@gem_mmap_gtt@fault-concurrent.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-skl9/igt@gem_mmap_gtt@fault-concurrent.html

  * igt@kms_big_fb@x-tiled-64bpp-rotate-0:
    - shard-glk:          [DMESG-FAIL][41] ([i915#118] / [i915#95]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-glk8/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-glk4/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-kbl:          [DMESG-WARN][43] ([i915#180]) -> [PASS][44] +2 similar issues
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-kbl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@kms_cursor_edge_walk@pipe-a-128x128-right-edge:
    - shard-skl:          [DMESG-WARN][45] ([i915#1982]) -> [PASS][46] +10 similar issues
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-skl3/igt@kms_cursor_edge_walk@pipe-a-128x128-right-edge.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-skl4/igt@kms_cursor_edge_walk@pipe-a-128x128-right-edge.html

  * igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled:
    - shard-skl:          [FAIL][47] ([i915#52] / [i915#54]) -> [PASS][48]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-skl4/igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-skl4/igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled.html

  * {igt@kms_flip@2x-blocking-wf_vblank@ab-hdmi-a1-hdmi-a2}:
    - shard-glk:          [FAIL][49] ([i915#1928]) -> [PASS][50]
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-glk5/igt@kms_flip@2x-blocking-wf_vblank@ab-hdmi-a1-hdmi-a2.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-glk9/igt@kms_flip@2x-blocking-wf_vblank@ab-hdmi-a1-hdmi-a2.html

  * {igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1}:
    - shard-kbl:          [FAIL][51] ([i915#79]) -> [PASS][52]
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-kbl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-kbl2/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1.html

  * {igt@kms_flip@flip-vs-suspend-interruptible@a-dp1}:
    - shard-apl:          [DMESG-WARN][53] ([i915#180]) -> [PASS][54]
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-apl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html

  * {igt@kms_flip@flip-vs-suspend@a-edp1}:
    - shard-skl:          [INCOMPLETE][55] ([i915#198]) -> [PASS][56] +1 similar issue
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-skl4/igt@kms_flip@flip-vs-suspend@a-edp1.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-skl1/igt@kms_flip@flip-vs-suspend@a-edp1.html

  * igt@kms_frontbuffer_tracking@psr-shrfb-scaledprimary:
    - shard-iclb:         [DMESG-WARN][57] ([i915#1982]) -> [PASS][58] +1 similar issue
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-iclb3/igt@kms_frontbuffer_tracking@psr-shrfb-scaledprimary.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-iclb2/igt@kms_frontbuffer_tracking@psr-shrfb-scaledprimary.html

  * igt@kms_hdr@bpc-switch-suspend:
    - shard-skl:          [FAIL][59] ([i915#1188]) -> [PASS][60]
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-skl10/igt@kms_hdr@bpc-switch-suspend.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-skl10/igt@kms_hdr@bpc-switch-suspend.html

  * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
    - shard-skl:          [FAIL][61] ([fdo#108145] / [i915#265]) -> [PASS][62] +2 similar issues
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html

  * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-mid:
    - shard-apl:          [DMESG-WARN][63] ([i915#95]) -> [PASS][64] +12 similar issues
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-apl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-mid.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-apl2/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-mid.html

  * igt@kms_psr@psr2_dpms:
    - shard-iclb:         [SKIP][65] ([fdo#109441]) -> [PASS][66] +2 similar issues
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-iclb7/igt@kms_psr@psr2_dpms.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-iclb2/igt@kms_psr@psr2_dpms.html

  * igt@kms_vblank@pipe-b-ts-continuation-suspend:
    - shard-kbl:          [INCOMPLETE][67] ([i915#155]) -> [PASS][68]
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-kbl2/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-kbl7/igt@kms_vblank@pipe-b-ts-continuation-suspend.html

  * {igt@perf@blocking-parameterized}:
    - shard-iclb:         [FAIL][69] ([i915#1542]) -> [PASS][70] +1 similar issue
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-iclb3/igt@perf@blocking-parameterized.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-iclb2/igt@perf@blocking-parameterized.html

  * {igt@perf@polling-parameterized}:
    - shard-hsw:          [FAIL][71] ([i915#1542]) -> [PASS][72]
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-hsw6/igt@perf@polling-parameterized.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-hsw2/igt@perf@polling-parameterized.html

  * igt@syncobj_wait@multi-wait-all-for-submit-signaled:
    - shard-tglb:         [DMESG-WARN][73] ([i915#402]) -> [PASS][74]
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-tglb3/igt@syncobj_wait@multi-wait-all-for-submit-signaled.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-tglb7/igt@syncobj_wait@multi-wait-all-for-submit-signaled.html

  
#### Warnings ####

  * igt@i915_pm_dc@dc3co-vpb-simulation:
    - shard-iclb:         [SKIP][75] ([i915#588]) -> [SKIP][76] ([i915#658])
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-iclb3/igt@i915_pm_dc@dc3co-vpb-simulation.html

  * igt@i915_pm_dc@dc6-psr:
    - shard-tglb:         [FAIL][77] ([i915#454]) -> [SKIP][78] ([i915#468])
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-tglb3/igt@i915_pm_dc@dc6-psr.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-tglb2/igt@i915_pm_dc@dc6-psr.html

  * igt@kms_content_protection@atomic:
    - shard-apl:          [TIMEOUT][79] ([i915#1319] / [i915#1635]) -> [DMESG-FAIL][80] ([fdo#110321] / [i915#95])
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-apl4/igt@kms_content_protection@atomic.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-apl6/igt@kms_content_protection@atomic.html

  * igt@kms_content_protection@atomic-dpms:
    - shard-apl:          [FAIL][81] ([fdo#110321] / [fdo#110336]) -> [DMESG-FAIL][82] ([fdo#110321])
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-apl3/igt@kms_content_protection@atomic-dpms.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-apl1/igt@kms_content_protection@atomic-dpms.html

  * igt@kms_content_protection@lic:
    - shard-apl:          [TIMEOUT][83] ([i915#1319] / [i915#1635]) -> [TIMEOUT][84] ([i915#1319]) +1 similar issue
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-apl4/igt@kms_content_protection@lic.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-apl7/igt@kms_content_protection@lic.html

  * igt@kms_frontbuffer_tracking@fbc-suspend:
    - shard-kbl:          [DMESG-WARN][85] ([i915#180] / [i915#93] / [i915#95]) -> [DMESG-WARN][86] ([i915#93] / [i915#95])
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8601/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [IGT#5]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/5
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
  [fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
  [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
  [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
  [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
  [i915#1519]: https://gitlab.freedesktop.org/drm/intel/issues/1519
  [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
  [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
  [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
  [i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#1928]: https://gitlab.freedesktop.org/drm/intel/issues/1928
  [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
  [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
  [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
  [i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
  [i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
  [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
  [i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
  [i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
  [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
  [i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (11 -> 11)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * Linux: CI_DRM_8601 -> Patchwork_17911

  CI-20190529: 20190529
  CI_DRM_8601: c801ab3a923b2436d765bd7a97888715f68451cb @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5699: 201da47cb57b8fadd9bc45be16b82617b32a2c01 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_17911: 2c4524628e2260caff58cb7020b91497c3091394 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17911/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors

[Ville Syrjälä]

On Mon, Jun 08, 2020 at 09:10:23PM +0300, Imre Deak wrote:
> DSC is not supported on DP MST streams so just return -EINVAL when
> reading/writing the i915_dsc_fec_support debugfs file for such
> connectors.
> 
> This also fixes an OOPS, caused by the encoder->digport cast, which is
> not valid for MST encoders.
> 
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
>  .../drm/i915/display/intel_display_debugfs.c  | 36 +++++++++++++++----
>  1 file changed, 29 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index 2b640d8ab9d2..ebca8e488d03 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -2094,6 +2094,8 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
>  	drm_modeset_acquire_init(&ctx, DRM_MODESET_ACQUIRE_INTERRUPTIBLE);
>  
>  	do {
> +		struct intel_encoder *encoder;
> +
>  		try_again = false;
>  		ret = drm_modeset_lock(&dev->mode_config.connection_mutex,
>  				       &ctx);
> @@ -2120,8 +2122,17 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
>  		} else if (ret) {
>  			break;
>  		}
> -		intel_dp = intel_attached_dp(to_intel_connector(connector));
> +
> +		encoder = intel_attached_encoder(to_intel_connector(connector));
> +		/* TODO: Add DSC support for MST streams */
> +		if (encoder->type == INTEL_OUTPUT_DP_MST) {
> +			ret = -EINVAL;
> +			break;
> +		}
> +
> +		intel_dp = &enc_to_dig_port(encoder)->dp;
>  		crtc_state = to_intel_crtc_state(crtc->state);
> +
>  		seq_printf(m, "DSC_Enabled: %s\n",
>  			   yesno(crtc_state->dsc.compression_enable));
>  		seq_printf(m, "DSC_Sink_Support: %s\n",
> @@ -2147,9 +2158,8 @@ static ssize_t i915_dsc_fec_support_write(struct file *file,
>  	int ret;
>  	struct drm_connector *connector =
>  		((struct seq_file *)file->private_data)->private;
> -	struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
> -	struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> -	struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> +	struct drm_i915_private *i915 = to_i915(connector->dev);
> +	struct intel_encoder *encoder;
>  
>  	if (len == 0)
>  		return 0;
> @@ -2163,10 +2173,22 @@ static ssize_t i915_dsc_fec_support_write(struct file *file,
>  
>  	drm_dbg(&i915->drm, "Got %s for DSC Enable\n",
>  		(dsc_enable) ? "true" : "false");
> -	intel_dp->force_dsc_en = dsc_enable;
>  
> -	*offp += len;
> -	return len;
> +	drm_modeset_lock(&i915->drm.mode_config.connection_mutex, NULL);
> +
> +	encoder = intel_attached_encoder(to_intel_connector(connector));
> +	/* TODO: Add DSC support for MST streams */
> +	if (encoder->type == INTEL_OUTPUT_DP_MST) {

The attached encoder can be NULL for MST.

Can't we just not add this debugfs file for MST connectors?

> +		ret = -EINVAL;
> +	} else {
> +		enc_to_intel_dp(encoder)->force_dsc_en = dsc_enable;
> +		*offp += len;
> +		ret = len;
> +	}
> +
> +	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
> +
> +	return ret;
>  }
>  
>  static int i915_dsc_fec_support_open(struct inode *inode,
> -- 
> 2.23.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors

[Imre Deak]

On Tue, Jun 09, 2020 at 06:05:25PM +0300, Ville Syrjälä wrote:
> On Mon, Jun 08, 2020 at 09:10:23PM +0300, Imre Deak wrote:
> > DSC is not supported on DP MST streams so just return -EINVAL when
> > reading/writing the i915_dsc_fec_support debugfs file for such
> > connectors.
> > 
> > This also fixes an OOPS, caused by the encoder->digport cast, which is
> > not valid for MST encoders.
> > 
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > ---
> >  .../drm/i915/display/intel_display_debugfs.c  | 36 +++++++++++++++----
> >  1 file changed, 29 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > index 2b640d8ab9d2..ebca8e488d03 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > @@ -2094,6 +2094,8 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
> >  	drm_modeset_acquire_init(&ctx, DRM_MODESET_ACQUIRE_INTERRUPTIBLE);
> >  
> >  	do {
> > +		struct intel_encoder *encoder;
> > +
> >  		try_again = false;
> >  		ret = drm_modeset_lock(&dev->mode_config.connection_mutex,
> >  				       &ctx);
> > @@ -2120,8 +2122,17 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
> >  		} else if (ret) {
> >  			break;
> >  		}
> > -		intel_dp = intel_attached_dp(to_intel_connector(connector));
> > +
> > +		encoder = intel_attached_encoder(to_intel_connector(connector));
> > +		/* TODO: Add DSC support for MST streams */
> > +		if (encoder->type == INTEL_OUTPUT_DP_MST) {
> > +			ret = -EINVAL;
> > +			break;
> > +		}
> > +
> > +		intel_dp = &enc_to_dig_port(encoder)->dp;
> >  		crtc_state = to_intel_crtc_state(crtc->state);
> > +
> >  		seq_printf(m, "DSC_Enabled: %s\n",
> >  			   yesno(crtc_state->dsc.compression_enable));
> >  		seq_printf(m, "DSC_Sink_Support: %s\n",
> > @@ -2147,9 +2158,8 @@ static ssize_t i915_dsc_fec_support_write(struct file *file,
> >  	int ret;
> >  	struct drm_connector *connector =
> >  		((struct seq_file *)file->private_data)->private;
> > -	struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
> > -	struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> > -	struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> > +	struct drm_i915_private *i915 = to_i915(connector->dev);
> > +	struct intel_encoder *encoder;
> >  
> >  	if (len == 0)
> >  		return 0;
> > @@ -2163,10 +2173,22 @@ static ssize_t i915_dsc_fec_support_write(struct file *file,
> >  
> >  	drm_dbg(&i915->drm, "Got %s for DSC Enable\n",
> >  		(dsc_enable) ? "true" : "false");
> > -	intel_dp->force_dsc_en = dsc_enable;
> >  
> > -	*offp += len;
> > -	return len;
> > +	drm_modeset_lock(&i915->drm.mode_config.connection_mutex, NULL);
> > +
> > +	encoder = intel_attached_encoder(to_intel_connector(connector));
> > +	/* TODO: Add DSC support for MST streams */
> > +	if (encoder->type == INTEL_OUTPUT_DP_MST) {
> 
> The attached encoder can be NULL for MST.

Yes, I also sent v2 with that fixed.

> Can't we just not add this debugfs file for MST connectors?

Won't we have per MST connector DSC at one point? In that case we'd need
something like this anyway. If this is never needed then yes, better not
to add it. I can't use connector_type which is the same for MST and SST
connectors so is it ok to differentiate based on a
intel_attached_encoder() == NULL check?

> 
> > +		ret = -EINVAL;
> > +	} else {
> > +		enc_to_intel_dp(encoder)->force_dsc_en = dsc_enable;
> > +		*offp += len;
> > +		ret = len;
> > +	}
> > +
> > +	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
> > +
> > +	return ret;
> >  }
> >  
> >  static int i915_dsc_fec_support_open(struct inode *inode,
> > -- 
> > 2.23.1
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> -- 
> Ville Syrjälä
> Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors

[Ville Syrjälä]

On Tue, Jun 09, 2020 at 08:40:35PM +0300, Imre Deak wrote:
> On Tue, Jun 09, 2020 at 06:05:25PM +0300, Ville Syrjälä wrote:
> > On Mon, Jun 08, 2020 at 09:10:23PM +0300, Imre Deak wrote:
> > > DSC is not supported on DP MST streams so just return -EINVAL when
> > > reading/writing the i915_dsc_fec_support debugfs file for such
> > > connectors.
> > > 
> > > This also fixes an OOPS, caused by the encoder->digport cast, which is
> > > not valid for MST encoders.
> > > 
> > > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > > ---
> > >  .../drm/i915/display/intel_display_debugfs.c  | 36 +++++++++++++++----
> > >  1 file changed, 29 insertions(+), 7 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > > index 2b640d8ab9d2..ebca8e488d03 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > > @@ -2094,6 +2094,8 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
> > >  	drm_modeset_acquire_init(&ctx, DRM_MODESET_ACQUIRE_INTERRUPTIBLE);
> > >  
> > >  	do {
> > > +		struct intel_encoder *encoder;
> > > +
> > >  		try_again = false;
> > >  		ret = drm_modeset_lock(&dev->mode_config.connection_mutex,
> > >  				       &ctx);
> > > @@ -2120,8 +2122,17 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
> > >  		} else if (ret) {
> > >  			break;
> > >  		}
> > > -		intel_dp = intel_attached_dp(to_intel_connector(connector));
> > > +
> > > +		encoder = intel_attached_encoder(to_intel_connector(connector));
> > > +		/* TODO: Add DSC support for MST streams */
> > > +		if (encoder->type == INTEL_OUTPUT_DP_MST) {
> > > +			ret = -EINVAL;
> > > +			break;
> > > +		}
> > > +
> > > +		intel_dp = &enc_to_dig_port(encoder)->dp;
> > >  		crtc_state = to_intel_crtc_state(crtc->state);
> > > +
> > >  		seq_printf(m, "DSC_Enabled: %s\n",
> > >  			   yesno(crtc_state->dsc.compression_enable));
> > >  		seq_printf(m, "DSC_Sink_Support: %s\n",
> > > @@ -2147,9 +2158,8 @@ static ssize_t i915_dsc_fec_support_write(struct file *file,
> > >  	int ret;
> > >  	struct drm_connector *connector =
> > >  		((struct seq_file *)file->private_data)->private;
> > > -	struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
> > > -	struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> > > -	struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> > > +	struct drm_i915_private *i915 = to_i915(connector->dev);
> > > +	struct intel_encoder *encoder;
> > >  
> > >  	if (len == 0)
> > >  		return 0;
> > > @@ -2163,10 +2173,22 @@ static ssize_t i915_dsc_fec_support_write(struct file *file,
> > >  
> > >  	drm_dbg(&i915->drm, "Got %s for DSC Enable\n",
> > >  		(dsc_enable) ? "true" : "false");
> > > -	intel_dp->force_dsc_en = dsc_enable;
> > >  
> > > -	*offp += len;
> > > -	return len;
> > > +	drm_modeset_lock(&i915->drm.mode_config.connection_mutex, NULL);
> > > +
> > > +	encoder = intel_attached_encoder(to_intel_connector(connector));
> > > +	/* TODO: Add DSC support for MST streams */
> > > +	if (encoder->type == INTEL_OUTPUT_DP_MST) {
> > 
> > The attached encoder can be NULL for MST.
> 
> Yes, I also sent v2 with that fixed.
> 
> > Can't we just not add this debugfs file for MST connectors?
> 
> Won't we have per MST connector DSC at one point? In that case we'd need
> something like this anyway.

The problem is that it doesn't work until the encoder has been attached.
So the behaviour of the interface would be rather inconsistent when
applied to MST connectors. No idea what current tests are doing with
this stuff so can't say whether it would be a problem in practice.

> If this is never needed then yes, better not
> to add it. I can't use connector_type which is the same for MST and SST
> connectors so is it ok to differentiate based on a
> intel_attached_encoder() == NULL check?

IIRC some other places use connector.mst_port to tell the two
apart.

> 
> > 
> > > +		ret = -EINVAL;
> > > +	} else {
> > > +		enc_to_intel_dp(encoder)->force_dsc_en = dsc_enable;
> > > +		*offp += len;
> > > +		ret = len;
> > > +	}
> > > +
> > > +	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
> > > +
> > > +	return ret;
> > >  }
> > >  
> > >  static int i915_dsc_fec_support_open(struct inode *inode,
> > > -- 
> > > 2.23.1
> > > 
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > 
> > -- 
> > Ville Syrjälä
> > Intel

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors

[Imre Deak]

On Tue, Jun 09, 2020 at 08:59:23PM +0300, Ville Syrjälä wrote:
> On Tue, Jun 09, 2020 at 08:40:35PM +0300, Imre Deak wrote:
> > On Tue, Jun 09, 2020 at 06:05:25PM +0300, Ville Syrjälä wrote:
> > > On Mon, Jun 08, 2020 at 09:10:23PM +0300, Imre Deak wrote:
> > > > DSC is not supported on DP MST streams so just return -EINVAL when
> > > > reading/writing the i915_dsc_fec_support debugfs file for such
> > > > connectors.
> > > > 
> > > > This also fixes an OOPS, caused by the encoder->digport cast, which is
> > > > not valid for MST encoders.
> > > > 
> > > > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > > > ---
> > > >  .../drm/i915/display/intel_display_debugfs.c  | 36 +++++++++++++++----
> > > >  1 file changed, 29 insertions(+), 7 deletions(-)
> > > > 
> > > > diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > > > index 2b640d8ab9d2..ebca8e488d03 100644
> > > > --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > > > +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > > > @@ -2094,6 +2094,8 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
> > > >  	drm_modeset_acquire_init(&ctx, DRM_MODESET_ACQUIRE_INTERRUPTIBLE);
> > > >  
> > > >  	do {
> > > > +		struct intel_encoder *encoder;
> > > > +
> > > >  		try_again = false;
> > > >  		ret = drm_modeset_lock(&dev->mode_config.connection_mutex,
> > > >  				       &ctx);
> > > > @@ -2120,8 +2122,17 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
> > > >  		} else if (ret) {
> > > >  			break;
> > > >  		}
> > > > -		intel_dp = intel_attached_dp(to_intel_connector(connector));
> > > > +
> > > > +		encoder = intel_attached_encoder(to_intel_connector(connector));
> > > > +		/* TODO: Add DSC support for MST streams */
> > > > +		if (encoder->type == INTEL_OUTPUT_DP_MST) {
> > > > +			ret = -EINVAL;
> > > > +			break;
> > > > +		}
> > > > +
> > > > +		intel_dp = &enc_to_dig_port(encoder)->dp;
> > > >  		crtc_state = to_intel_crtc_state(crtc->state);
> > > > +
> > > >  		seq_printf(m, "DSC_Enabled: %s\n",
> > > >  			   yesno(crtc_state->dsc.compression_enable));
> > > >  		seq_printf(m, "DSC_Sink_Support: %s\n",
> > > > @@ -2147,9 +2158,8 @@ static ssize_t i915_dsc_fec_support_write(struct file *file,
> > > >  	int ret;
> > > >  	struct drm_connector *connector =
> > > >  		((struct seq_file *)file->private_data)->private;
> > > > -	struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
> > > > -	struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> > > > -	struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> > > > +	struct drm_i915_private *i915 = to_i915(connector->dev);
> > > > +	struct intel_encoder *encoder;
> > > >  
> > > >  	if (len == 0)
> > > >  		return 0;
> > > > @@ -2163,10 +2173,22 @@ static ssize_t i915_dsc_fec_support_write(struct file *file,
> > > >  
> > > >  	drm_dbg(&i915->drm, "Got %s for DSC Enable\n",
> > > >  		(dsc_enable) ? "true" : "false");
> > > > -	intel_dp->force_dsc_en = dsc_enable;
> > > >  
> > > > -	*offp += len;
> > > > -	return len;
> > > > +	drm_modeset_lock(&i915->drm.mode_config.connection_mutex, NULL);
> > > > +
> > > > +	encoder = intel_attached_encoder(to_intel_connector(connector));
> > > > +	/* TODO: Add DSC support for MST streams */
> > > > +	if (encoder->type == INTEL_OUTPUT_DP_MST) {
> > > 
> > > The attached encoder can be NULL for MST.
> > 
> > Yes, I also sent v2 with that fixed.
> > 
> > > Can't we just not add this debugfs file for MST connectors?
> > 
> > Won't we have per MST connector DSC at one point? In that case we'd need
> > something like this anyway.
> 
> The problem is that it doesn't work until the encoder has been attached.
> So the behaviour of the interface would be rather inconsistent when
> applied to MST connectors. No idea what current tests are doing with
> this stuff so can't say whether it would be a problem in practice.

It's used to force DSC by writing to it before commit, so yes then it
wouldn't work anyway.

> > If this is never needed then yes, better not
> > to add it. I can't use connector_type which is the same for MST and SST
> > connectors so is it ok to differentiate based on a
> > intel_attached_encoder() == NULL check?
> 
> IIRC some other places use connector.mst_port to tell the two
> apart.

Ok, will use that.

> 
> > 
> > > 
> > > > +		ret = -EINVAL;
> > > > +	} else {
> > > > +		enc_to_intel_dp(encoder)->force_dsc_en = dsc_enable;
> > > > +		*offp += len;
> > > > +		ret = len;
> > > > +	}
> > > > +
> > > > +	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
> > > > +
> > > > +	return ret;
> > > >  }
> > > >  
> > > >  static int i915_dsc_fec_support_open(struct inode *inode,
> > > > -- 
> > > > 2.23.1
> > > > 
> > > > _______________________________________________
> > > > Intel-gfx mailing list
> > > > Intel-gfx@lists.freedesktop.org
> > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > > 
> > > -- 
> > > Ville Syrjälä
> > > Intel
> 
> -- 
> Ville Syrjälä
> Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors

[Imre Deak]

DSC is not supported on DP MST streams so just don't add this entry for
MST connectors.

This also fixes an OOPS, caused by the encoder->digport cast, which is
not valid for MST encoders.

v2:
- Check encoder, which is unset for an MST connector, before it gets
  enabled.
v3:
- Just don't add this debugfs file for MST connectors. (Ville)

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_debugfs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
index 2b640d8ab9d2..28dd717e943a 100644
--- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
+++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
@@ -2218,7 +2218,8 @@ int intel_connector_debugfs_add(struct drm_connector *connector)
 	}
 
 	if (INTEL_GEN(dev_priv) >= 10 &&
-	    (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
+	    ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort &&
+	      !to_intel_connector(connector)->mst_port) ||
 	     connector->connector_type == DRM_MODE_CONNECTOR_eDP))
 		debugfs_create_file("i915_dsc_fec_support", S_IRUGO, root,
 				    connector, &i915_dsc_fec_support_fops);
-- 
2.23.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors

[Manasi Navare]

On Tue, Jun 09, 2020 at 09:08:52PM +0300, Imre Deak wrote:
> On Tue, Jun 09, 2020 at 08:59:23PM +0300, Ville Syrjälä wrote:
> > On Tue, Jun 09, 2020 at 08:40:35PM +0300, Imre Deak wrote:
> > > On Tue, Jun 09, 2020 at 06:05:25PM +0300, Ville Syrjälä wrote:
> > > > On Mon, Jun 08, 2020 at 09:10:23PM +0300, Imre Deak wrote:
> > > > > DSC is not supported on DP MST streams so just return -EINVAL when
> > > > > reading/writing the i915_dsc_fec_support debugfs file for such
> > > > > connectors.
> > > > > 
> > > > > This also fixes an OOPS, caused by the encoder->digport cast, which is
> > > > > not valid for MST encoders.
> > > > > 
> > > > > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > > > > ---
> > > > >  .../drm/i915/display/intel_display_debugfs.c  | 36 +++++++++++++++----
> > > > >  1 file changed, 29 insertions(+), 7 deletions(-)
> > > > > 
> > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > > > > index 2b640d8ab9d2..ebca8e488d03 100644
> > > > > --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > > > > +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > > > > @@ -2094,6 +2094,8 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
> > > > >  	drm_modeset_acquire_init(&ctx, DRM_MODESET_ACQUIRE_INTERRUPTIBLE);
> > > > >  
> > > > >  	do {
> > > > > +		struct intel_encoder *encoder;
> > > > > +
> > > > >  		try_again = false;
> > > > >  		ret = drm_modeset_lock(&dev->mode_config.connection_mutex,
> > > > >  				       &ctx);
> > > > > @@ -2120,8 +2122,17 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
> > > > >  		} else if (ret) {
> > > > >  			break;
> > > > >  		}
> > > > > -		intel_dp = intel_attached_dp(to_intel_connector(connector));
> > > > > +
> > > > > +		encoder = intel_attached_encoder(to_intel_connector(connector));
> > > > > +		/* TODO: Add DSC support for MST streams */
> > > > > +		if (encoder->type == INTEL_OUTPUT_DP_MST) {
> > > > > +			ret = -EINVAL;
> > > > > +			break;
> > > > > +		}
> > > > > +
> > > > > +		intel_dp = &enc_to_dig_port(encoder)->dp;
> > > > >  		crtc_state = to_intel_crtc_state(crtc->state);
> > > > > +
> > > > >  		seq_printf(m, "DSC_Enabled: %s\n",
> > > > >  			   yesno(crtc_state->dsc.compression_enable));
> > > > >  		seq_printf(m, "DSC_Sink_Support: %s\n",
> > > > > @@ -2147,9 +2158,8 @@ static ssize_t i915_dsc_fec_support_write(struct file *file,
> > > > >  	int ret;
> > > > >  	struct drm_connector *connector =
> > > > >  		((struct seq_file *)file->private_data)->private;
> > > > > -	struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
> > > > > -	struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> > > > > -	struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> > > > > +	struct drm_i915_private *i915 = to_i915(connector->dev);
> > > > > +	struct intel_encoder *encoder;
> > > > >  
> > > > >  	if (len == 0)
> > > > >  		return 0;
> > > > > @@ -2163,10 +2173,22 @@ static ssize_t i915_dsc_fec_support_write(struct file *file,
> > > > >  
> > > > >  	drm_dbg(&i915->drm, "Got %s for DSC Enable\n",
> > > > >  		(dsc_enable) ? "true" : "false");
> > > > > -	intel_dp->force_dsc_en = dsc_enable;
> > > > >  
> > > > > -	*offp += len;
> > > > > -	return len;
> > > > > +	drm_modeset_lock(&i915->drm.mode_config.connection_mutex, NULL);
> > > > > +
> > > > > +	encoder = intel_attached_encoder(to_intel_connector(connector));
> > > > > +	/* TODO: Add DSC support for MST streams */
> > > > > +	if (encoder->type == INTEL_OUTPUT_DP_MST) {

even after we force dsc en from IGT through this debugfs node, the actual enabling
checks if dsc supported, so may be since we currently dont support on MST, can we
add some condition in this function: intel_dsc_source_support() to not support
on MST encoders?
Also, currently since we dont even call intel_dp_dsc_compute_config in MST codepath,
how does it even make a difference if we set force_dsc_en through this debugfs or not for MST?

Manasi

> > > > 
> > > > The attached encoder can be NULL for MST.
> > > 
> > > Yes, I also sent v2 with that fixed.
> > > 
> > > > Can't we just not add this debugfs file for MST connectors?
> > > 
> > > Won't we have per MST connector DSC at one point? In that case we'd need
> > > something like this anyway.
> > 
> > The problem is that it doesn't work until the encoder has been attached.
> > So the behaviour of the interface would be rather inconsistent when
> > applied to MST connectors. No idea what current tests are doing with
> > this stuff so can't say whether it would be a problem in practice.
> 
> It's used to force DSC by writing to it before commit, so yes then it
> wouldn't work anyway.
> 
> > > If this is never needed then yes, better not
> > > to add it. I can't use connector_type which is the same for MST and SST
> > > connectors so is it ok to differentiate based on a
> > > intel_attached_encoder() == NULL check?
> > 
> > IIRC some other places use connector.mst_port to tell the two
> > apart.
> 
> Ok, will use that.
> 
> > 
> > > 
> > > > 
> > > > > +		ret = -EINVAL;
> > > > > +	} else {
> > > > > +		enc_to_intel_dp(encoder)->force_dsc_en = dsc_enable;
> > > > > +		*offp += len;
> > > > > +		ret = len;
> > > > > +	}
> > > > > +
> > > > > +	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
> > > > > +
> > > > > +	return ret;
> > > > >  }
> > > > >  
> > > > >  static int i915_dsc_fec_support_open(struct inode *inode,
> > > > > -- 
> > > > > 2.23.1
> > > > > 
> > > > > _______________________________________________
> > > > > Intel-gfx mailing list
> > > > > Intel-gfx@lists.freedesktop.org
> > > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > > > 
> > > > -- 
> > > > Ville Syrjälä
> > > > Intel
> > 
> > -- 
> > Ville Syrjälä
> > Intel
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors

[Manasi Navare]

On Tue, Jun 09, 2020 at 09:41:40PM +0300, Imre Deak wrote:
> DSC is not supported on DP MST streams so just don't add this entry for
> MST connectors.
> 
> This also fixes an OOPS, caused by the encoder->digport cast, which is
> not valid for MST encoders.
> 
> v2:
> - Check encoder, which is unset for an MST connector, before it gets
>   enabled.
> v3:
> - Just don't add this debugfs file for MST connectors. (Ville)
> 
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Yes now just not having this debugfs entry for MST connectors makes sense
once we support it on MST we can expose it the right way

Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>

Manasi

> ---
>  drivers/gpu/drm/i915/display/intel_display_debugfs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index 2b640d8ab9d2..28dd717e943a 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -2218,7 +2218,8 @@ int intel_connector_debugfs_add(struct drm_connector *connector)
>  	}
>  
>  	if (INTEL_GEN(dev_priv) >= 10 &&
> -	    (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
> +	    ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort &&
> +	      !to_intel_connector(connector)->mst_port) ||
>  	     connector->connector_type == DRM_MODE_CONNECTOR_eDP))
>  		debugfs_create_file("i915_dsc_fec_support", S_IRUGO, root,
>  				    connector, &i915_dsc_fec_support_fops);
> -- 
> 2.23.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors

[Imre Deak]

On Tue, Jun 09, 2020 at 11:56:56AM -0700, Manasi Navare wrote:
> On Tue, Jun 09, 2020 at 09:08:52PM +0300, Imre Deak wrote:
> > On Tue, Jun 09, 2020 at 08:59:23PM +0300, Ville Syrjälä wrote:
> > > On Tue, Jun 09, 2020 at 08:40:35PM +0300, Imre Deak wrote:
> > > > On Tue, Jun 09, 2020 at 06:05:25PM +0300, Ville Syrjälä wrote:
> > > > > On Mon, Jun 08, 2020 at 09:10:23PM +0300, Imre Deak wrote:
> > > > > > DSC is not supported on DP MST streams so just return -EINVAL when
> > > > > > reading/writing the i915_dsc_fec_support debugfs file for such
> > > > > > connectors.
> > > > > > 
> > > > > > This also fixes an OOPS, caused by the encoder->digport cast, which is
> > > > > > not valid for MST encoders.
> > > > > > 
> > > > > > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > > > > > ---
> > > > > >  .../drm/i915/display/intel_display_debugfs.c  | 36 +++++++++++++++----
> > > > > >  1 file changed, 29 insertions(+), 7 deletions(-)
> > > > > > 
> > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > > > > > index 2b640d8ab9d2..ebca8e488d03 100644
> > > > > > --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > > > > > +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > > > > > @@ -2094,6 +2094,8 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
> > > > > >  	drm_modeset_acquire_init(&ctx, DRM_MODESET_ACQUIRE_INTERRUPTIBLE);
> > > > > >  
> > > > > >  	do {
> > > > > > +		struct intel_encoder *encoder;
> > > > > > +
> > > > > >  		try_again = false;
> > > > > >  		ret = drm_modeset_lock(&dev->mode_config.connection_mutex,
> > > > > >  				       &ctx);
> > > > > > @@ -2120,8 +2122,17 @@ static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
> > > > > >  		} else if (ret) {
> > > > > >  			break;
> > > > > >  		}
> > > > > > -		intel_dp = intel_attached_dp(to_intel_connector(connector));
> > > > > > +
> > > > > > +		encoder = intel_attached_encoder(to_intel_connector(connector));
> > > > > > +		/* TODO: Add DSC support for MST streams */
> > > > > > +		if (encoder->type == INTEL_OUTPUT_DP_MST) {
> > > > > > +			ret = -EINVAL;
> > > > > > +			break;
> > > > > > +		}
> > > > > > +
> > > > > > +		intel_dp = &enc_to_dig_port(encoder)->dp;
> > > > > >  		crtc_state = to_intel_crtc_state(crtc->state);
> > > > > > +
> > > > > >  		seq_printf(m, "DSC_Enabled: %s\n",
> > > > > >  			   yesno(crtc_state->dsc.compression_enable));
> > > > > >  		seq_printf(m, "DSC_Sink_Support: %s\n",
> > > > > > @@ -2147,9 +2158,8 @@ static ssize_t i915_dsc_fec_support_write(struct file *file,
> > > > > >  	int ret;
> > > > > >  	struct drm_connector *connector =
> > > > > >  		((struct seq_file *)file->private_data)->private;
> > > > > > -	struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
> > > > > > -	struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> > > > > > -	struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> > > > > > +	struct drm_i915_private *i915 = to_i915(connector->dev);
> > > > > > +	struct intel_encoder *encoder;
> > > > > >  
> > > > > >  	if (len == 0)
> > > > > >  		return 0;
> > > > > > @@ -2163,10 +2173,22 @@ static ssize_t i915_dsc_fec_support_write(struct file *file,
> > > > > >  
> > > > > >  	drm_dbg(&i915->drm, "Got %s for DSC Enable\n",
> > > > > >  		(dsc_enable) ? "true" : "false");
> > > > > > -	intel_dp->force_dsc_en = dsc_enable;
> > > > > >  
> > > > > > -	*offp += len;
> > > > > > -	return len;
> > > > > > +	drm_modeset_lock(&i915->drm.mode_config.connection_mutex, NULL);
> > > > > > +
> > > > > > +	encoder = intel_attached_encoder(to_intel_connector(connector));
> > > > > > +	/* TODO: Add DSC support for MST streams */
> > > > > > +	if (encoder->type == INTEL_OUTPUT_DP_MST) {
> 
> even after we force dsc en from IGT through this debugfs node, the
> actual enabling checks if dsc supported, so may be since we currently
> dont support on MST, can we add some condition in this function:
> intel_dsc_source_support() to not support on MST encoders?

I think the final API is not yeat clear for MST, so since it's not used
either I agree that it's better to remove it.

> Also, currently since we dont even call intel_dp_dsc_compute_config in
> MST codepath, how does it even make a difference if we set
> force_dsc_en through this debugfs or not for MST?

The difference is that intel_attached_dp() can't be used on MST
connectors.

> 
> Manasi
> 
> > > > > 
> > > > > The attached encoder can be NULL for MST.
> > > > 
> > > > Yes, I also sent v2 with that fixed.
> > > > 
> > > > > Can't we just not add this debugfs file for MST connectors?
> > > > 
> > > > Won't we have per MST connector DSC at one point? In that case we'd need
> > > > something like this anyway.
> > > 
> > > The problem is that it doesn't work until the encoder has been attached.
> > > So the behaviour of the interface would be rather inconsistent when
> > > applied to MST connectors. No idea what current tests are doing with
> > > this stuff so can't say whether it would be a problem in practice.
> > 
> > It's used to force DSC by writing to it before commit, so yes then it
> > wouldn't work anyway.
> > 
> > > > If this is never needed then yes, better not
> > > > to add it. I can't use connector_type which is the same for MST and SST
> > > > connectors so is it ok to differentiate based on a
> > > > intel_attached_encoder() == NULL check?
> > > 
> > > IIRC some other places use connector.mst_port to tell the two
> > > apart.
> > 
> > Ok, will use that.
> > 
> > > 
> > > > 
> > > > > 
> > > > > > +		ret = -EINVAL;
> > > > > > +	} else {
> > > > > > +		enc_to_intel_dp(encoder)->force_dsc_en = dsc_enable;
> > > > > > +		*offp += len;
> > > > > > +		ret = len;
> > > > > > +	}
> > > > > > +
> > > > > > +	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
> > > > > > +
> > > > > > +	return ret;
> > > > > >  }
> > > > > >  
> > > > > >  static int i915_dsc_fec_support_open(struct inode *inode,
> > > > > > -- 
> > > > > > 2.23.1
> > > > > > 
> > > > > > _______________________________________________
> > > > > > Intel-gfx mailing list
> > > > > > Intel-gfx@lists.freedesktop.org
> > > > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > > > > 
> > > > > -- 
> > > > > Ville Syrjälä
> > > > > Intel
> > > 
> > > -- 
> > > Ville Syrjälä
> > > Intel
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors (rev3)

[Patchwork]

== Series Details ==

Series: drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors (rev3)
URL   : https://patchwork.freedesktop.org/series/78128/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8604 -> Patchwork_17916
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/index.html

Known issues
------------

  Here are the changes found in Patchwork_17916 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
    - fi-icl-u2:          [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html

  
#### Possible fixes ####

  * igt@i915_module_load@reload:
    - fi-byt-j1900:       [DMESG-WARN][3] ([i915#1982]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/fi-byt-j1900/igt@i915_module_load@reload.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/fi-byt-j1900/igt@i915_module_load@reload.html
    - fi-byt-n2820:       [DMESG-WARN][5] ([i915#1982]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/fi-byt-n2820/igt@i915_module_load@reload.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/fi-byt-n2820/igt@i915_module_load@reload.html

  * igt@i915_pm_backlight@basic-brightness:
    - fi-whl-u:           [DMESG-WARN][7] ([i915#95]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/fi-whl-u/igt@i915_pm_backlight@basic-brightness.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/fi-whl-u/igt@i915_pm_backlight@basic-brightness.html

  * igt@i915_pm_rpm@module-reload:
    - fi-glk-dsi:         [DMESG-WARN][9] ([i915#1982]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/fi-glk-dsi/igt@i915_pm_rpm@module-reload.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/fi-glk-dsi/igt@i915_pm_rpm@module-reload.html

  * igt@kms_chamelium@dp-crc-fast:
    - fi-icl-u2:          [FAIL][11] ([i915#262]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/fi-icl-u2/igt@kms_chamelium@dp-crc-fast.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/fi-icl-u2/igt@kms_chamelium@dp-crc-fast.html

  * igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
    - fi-icl-u2:          [DMESG-WARN][13] ([i915#1982]) -> [PASS][14] +1 similar issue
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html

  
#### Warnings ####

  * igt@gem_exec_suspend@basic-s0:
    - fi-kbl-x1275:       [DMESG-WARN][15] ([i915#1982] / [i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][16] ([i915#62] / [i915#92] / [i915#95])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html

  * igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
    - fi-kbl-x1275:       [DMESG-WARN][17] ([i915#62] / [i915#92]) -> [DMESG-WARN][18] ([i915#62] / [i915#92] / [i915#95]) +6 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html

  * igt@kms_flip@basic-flip-vs-wf_vblank@a-dp1:
    - fi-kbl-x1275:       [DMESG-WARN][19] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][20] ([i915#62] / [i915#92]) +2 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-wf_vblank@a-dp1.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-wf_vblank@a-dp1.html

  
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
  [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
  [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (49 -> 42)
------------------------------

  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_8604 -> Patchwork_17916

  CI-20190529: 20190529
  CI_DRM_8604: 24c6364ec0e3c895ec4237d7a8f3516316a761ff @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5700: 88e379cef970db3dab020966d5dd117de7cc03ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_17916: b4af214db886283d6bc416bb70d95623c8c47ff6 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

b4af214db886 drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors (rev3)

[Patchwork]

== Series Details ==

Series: drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors (rev3)
URL   : https://patchwork.freedesktop.org/series/78128/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8604_full -> Patchwork_17916_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Known issues
------------

  Here are the changes found in Patchwork_17916_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_shared@q-independent@bcs0:
    - shard-kbl:          [PASS][1] -> [FAIL][2] ([i915#2013])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-kbl6/igt@gem_ctx_shared@q-independent@bcs0.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-kbl1/igt@gem_ctx_shared@q-independent@bcs0.html

  * igt@gem_exec_create@forked:
    - shard-hsw:          [PASS][3] -> [INCOMPLETE][4] ([i915#61])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-hsw7/igt@gem_exec_create@forked.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-hsw2/igt@gem_exec_create@forked.html

  * igt@gem_exec_schedule@implicit-read-write@rcs0:
    - shard-snb:          [PASS][5] -> [INCOMPLETE][6] ([i915#82])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-snb4/igt@gem_exec_schedule@implicit-read-write@rcs0.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-snb6/igt@gem_exec_schedule@implicit-read-write@rcs0.html

  * igt@gem_exec_whisper@basic-forked-all:
    - shard-glk:          [PASS][7] -> [DMESG-WARN][8] ([i915#118] / [i915#95]) +1 similar issue
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-glk8/igt@gem_exec_whisper@basic-forked-all.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-glk4/igt@gem_exec_whisper@basic-forked-all.html

  * igt@gem_workarounds@suspend-resume-context:
    - shard-apl:          [PASS][9] -> [DMESG-WARN][10] ([i915#180]) +3 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-apl7/igt@gem_workarounds@suspend-resume-context.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-apl4/igt@gem_workarounds@suspend-resume-context.html

  * igt@i915_module_load@reload-with-fault-injection:
    - shard-tglb:         [PASS][11] -> [DMESG-WARN][12] ([i915#402]) +3 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-tglb6/igt@i915_module_load@reload-with-fault-injection.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-tglb5/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_pm_rps@reset:
    - shard-skl:          [PASS][13] -> [FAIL][14] ([i915#39])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl10/igt@i915_pm_rps@reset.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl5/igt@i915_pm_rps@reset.html

  * igt@kms_big_fb@linear-64bpp-rotate-180:
    - shard-glk:          [PASS][15] -> [DMESG-FAIL][16] ([i915#118] / [i915#95]) +1 similar issue
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-glk2/igt@kms_big_fb@linear-64bpp-rotate-180.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-glk8/igt@kms_big_fb@linear-64bpp-rotate-180.html

  * igt@kms_big_fb@yf-tiled-32bpp-rotate-0:
    - shard-kbl:          [PASS][17] -> [DMESG-WARN][18] ([i915#1982])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-kbl3/igt@kms_big_fb@yf-tiled-32bpp-rotate-0.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-kbl1/igt@kms_big_fb@yf-tiled-32bpp-rotate-0.html

  * igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen:
    - shard-kbl:          [PASS][19] -> [DMESG-FAIL][20] ([i915#54] / [i915#95]) +1 similar issue
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen.html

  * igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen:
    - shard-skl:          [PASS][21] -> [FAIL][22] ([i915#54]) +1 similar issue
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl4/igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl1/igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-kbl:          [PASS][23] -> [DMESG-WARN][24] ([i915#180]) +2 similar issues
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy:
    - shard-kbl:          [PASS][25] -> [DMESG-FAIL][26] ([i915#95])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-kbl3/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-kbl4/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html

  * igt@kms_cursor_legacy@flip-vs-cursor-legacy:
    - shard-skl:          [PASS][27] -> [FAIL][28] ([IGT#5])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html

  * igt@kms_cursor_legacy@pipe-c-torture-move:
    - shard-iclb:         [PASS][29] -> [DMESG-WARN][30] ([i915#128])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-iclb4/igt@kms_cursor_legacy@pipe-c-torture-move.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-iclb4/igt@kms_cursor_legacy@pipe-c-torture-move.html

  * igt@kms_draw_crc@draw-method-rgb565-mmap-wc-ytiled:
    - shard-kbl:          [PASS][31] -> [DMESG-WARN][32] ([i915#93] / [i915#95]) +2 similar issues
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-kbl4/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-ytiled.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-kbl6/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-ytiled.html

  * igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-ytiled:
    - shard-skl:          [PASS][33] -> [DMESG-WARN][34] ([i915#1982]) +10 similar issues
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl7/igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-ytiled.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl10/igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-ytiled.html

  * igt@kms_fbcon_fbt@psr-suspend:
    - shard-iclb:         [PASS][35] -> [INCOMPLETE][36] ([i915#1185])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-iclb5/igt@kms_fbcon_fbt@psr-suspend.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-iclb3/igt@kms_fbcon_fbt@psr-suspend.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-wc:
    - shard-tglb:         [PASS][37] -> [DMESG-WARN][38] ([i915#1982])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-tglb6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-wc.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-tglb5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-wc.html

  * igt@kms_hdr@bpc-switch:
    - shard-skl:          [PASS][39] -> [FAIL][40] ([i915#1188])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl2/igt@kms_hdr@bpc-switch.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl1/igt@kms_hdr@bpc-switch.html

  * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
    - shard-skl:          [PASS][41] -> [FAIL][42] ([fdo#108145] / [i915#265]) +1 similar issue
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html

  * igt@kms_psr2_su@frontbuffer:
    - shard-iclb:         [PASS][43] -> [SKIP][44] ([fdo#109642] / [fdo#111068])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-iclb4/igt@kms_psr2_su@frontbuffer.html

  * igt@kms_psr@psr2_primary_mmap_gtt:
    - shard-iclb:         [PASS][45] -> [SKIP][46] ([fdo#109441]) +1 similar issue
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-iclb4/igt@kms_psr@psr2_primary_mmap_gtt.html

  * igt@kms_setmode@basic:
    - shard-skl:          [PASS][47] -> [FAIL][48] ([i915#31])
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl8/igt@kms_setmode@basic.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl2/igt@kms_setmode@basic.html

  * igt@perf_pmu@module-unload:
    - shard-iclb:         [PASS][49] -> [DMESG-WARN][50] ([i915#1982])
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-iclb8/igt@perf_pmu@module-unload.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-iclb3/igt@perf_pmu@module-unload.html

  * igt@syncobj_wait@invalid-wait-illegal-handle:
    - shard-apl:          [PASS][51] -> [DMESG-WARN][52] ([i915#95]) +25 similar issues
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-apl1/igt@syncobj_wait@invalid-wait-illegal-handle.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-apl8/igt@syncobj_wait@invalid-wait-illegal-handle.html

  
#### Possible fixes ####

  * igt@gem_ctx_shared@q-independent@bcs0:
    - shard-apl:          [FAIL][53] ([i915#2013]) -> [PASS][54]
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-apl2/igt@gem_ctx_shared@q-independent@bcs0.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-apl1/igt@gem_ctx_shared@q-independent@bcs0.html

  * igt@gem_exec_suspend@basic-s3:
    - shard-kbl:          [DMESG-WARN][55] ([i915#93] / [i915#95]) -> [PASS][56]
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-kbl4/igt@gem_exec_suspend@basic-s3.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-kbl2/igt@gem_exec_suspend@basic-s3.html

  * igt@kms_big_fb@x-tiled-64bpp-rotate-180:
    - shard-glk:          [DMESG-FAIL][57] ([i915#118] / [i915#95]) -> [PASS][58]
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-glk8/igt@kms_big_fb@x-tiled-64bpp-rotate-180.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-glk4/igt@kms_big_fb@x-tiled-64bpp-rotate-180.html

  * igt@kms_big_fb@yf-tiled-32bpp-rotate-90:
    - shard-apl:          [DMESG-WARN][59] ([i915#1982]) -> [PASS][60]
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-apl6/igt@kms_big_fb@yf-tiled-32bpp-rotate-90.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-apl1/igt@kms_big_fb@yf-tiled-32bpp-rotate-90.html

  * igt@kms_color@pipe-a-ctm-0-5:
    - shard-skl:          [DMESG-WARN][61] ([i915#1982]) -> [PASS][62] +5 similar issues
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl7/igt@kms_color@pipe-a-ctm-0-5.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl8/igt@kms_color@pipe-a-ctm-0-5.html

  * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
    - shard-apl:          [DMESG-WARN][63] ([i915#180]) -> [PASS][64]
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-apl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html

  * igt@kms_flip@flip-vs-suspend@a-edp1:
    - shard-skl:          [INCOMPLETE][65] ([i915#198]) -> [PASS][66]
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl8/igt@kms_flip@flip-vs-suspend@a-edp1.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl5/igt@kms_flip@flip-vs-suspend@a-edp1.html

  * igt@kms_flip@flip-vs-suspend@c-dp1:
    - shard-kbl:          [DMESG-WARN][67] ([i915#180]) -> [PASS][68] +5 similar issues
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-kbl7/igt@kms_flip@flip-vs-suspend@c-dp1.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-kbl6/igt@kms_flip@flip-vs-suspend@c-dp1.html

  * igt@kms_flip_tiling@flip-changes-tiling:
    - shard-kbl:          [DMESG-WARN][69] ([i915#1982]) -> [PASS][70]
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-kbl4/igt@kms_flip_tiling@flip-changes-tiling.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-kbl2/igt@kms_flip_tiling@flip-changes-tiling.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-render:
    - shard-skl:          [FAIL][71] ([i915#49]) -> [PASS][72]
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-render.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-render.html

  * igt@kms_hdr@bpc-switch-suspend:
    - shard-skl:          [FAIL][73] ([i915#1188]) -> [PASS][74]
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl2/igt@kms_hdr@bpc-switch-suspend.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl9/igt@kms_hdr@bpc-switch-suspend.html

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c-frame-sequence:
    - shard-skl:          [FAIL][75] ([i915#53]) -> [PASS][76]
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl6/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c-frame-sequence.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl3/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c-frame-sequence.html

  * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
    - shard-skl:          [FAIL][77] ([fdo#108145] / [i915#265]) -> [PASS][78] +1 similar issue
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html

  * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
    - shard-skl:          [DMESG-FAIL][79] ([fdo#108145] / [i915#1982]) -> [PASS][80]
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html

  * igt@kms_psr@psr2_primary_mmap_cpu:
    - shard-iclb:         [SKIP][81] ([fdo#109441]) -> [PASS][82] +2 similar issues
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-iclb3/igt@kms_psr@psr2_primary_mmap_cpu.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html

  * igt@kms_setmode@basic:
    - shard-kbl:          [FAIL][83] ([i915#31]) -> [PASS][84]
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-kbl4/igt@kms_setmode@basic.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-kbl6/igt@kms_setmode@basic.html

  * igt@kms_vblank@pipe-c-query-busy-hang:
    - shard-tglb:         [DMESG-WARN][85] ([i915#402]) -> [PASS][86]
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-tglb1/igt@kms_vblank@pipe-c-query-busy-hang.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-tglb7/igt@kms_vblank@pipe-c-query-busy-hang.html

  * igt@sw_sync@sync_merge_same:
    - shard-apl:          [DMESG-WARN][87] ([i915#95]) -> [PASS][88] +19 similar issues
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-apl4/igt@sw_sync@sync_merge_same.html
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-apl8/igt@sw_sync@sync_merge_same.html

  
#### Warnings ####

  * igt@i915_pm_dc@dc3co-vpb-simulation:
    - shard-iclb:         [SKIP][89] ([i915#588]) -> [SKIP][90] ([i915#658])
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-iclb4/igt@i915_pm_dc@dc3co-vpb-simulation.html

  * igt@i915_pm_dc@dc6-dpms:
    - shard-tglb:         [FAIL][91] ([i915#454]) -> [SKIP][92] ([i915#468])
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-tglb6/igt@i915_pm_dc@dc6-dpms.html
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-tglb2/igt@i915_pm_dc@dc6-dpms.html

  * igt@i915_pm_dc@dc6-psr:
    - shard-skl:          [FAIL][93] ([i915#454]) -> [DMESG-FAIL][94] ([i915#1982])
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl4/igt@i915_pm_dc@dc6-psr.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl9/igt@i915_pm_dc@dc6-psr.html

  * igt@kms_content_protection@atomic:
    - shard-apl:          [FAIL][95] ([fdo#110321] / [fdo#110336]) -> [TIMEOUT][96] ([i915#1319] / [i915#1635])
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-apl1/igt@kms_content_protection@atomic.html
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-apl8/igt@kms_content_protection@atomic.html

  * igt@kms_content_protection@atomic-dpms:
    - shard-apl:          [TIMEOUT][97] ([i915#1319]) -> [TIMEOUT][98] ([i915#1319] / [i915#1635])
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-apl3/igt@kms_content_protection@atomic-dpms.html
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-apl6/igt@kms_content_protection@atomic-dpms.html

  * igt@kms_content_protection@legacy:
    - shard-apl:          [TIMEOUT][99] ([i915#1319] / [i915#1635]) -> [FAIL][100] ([fdo#110321] / [fdo#110336])
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-apl4/igt@kms_content_protection@legacy.html
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-apl4/igt@kms_content_protection@legacy.html

  * igt@kms_content_protection@lic:
    - shard-apl:          [TIMEOUT][101] ([i915#1319] / [i915#1635]) -> [TIMEOUT][102] ([i915#1319]) +1 similar issue
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-apl2/igt@kms_content_protection@lic.html
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-apl7/igt@kms_content_protection@lic.html

  * igt@kms_draw_crc@fill-fb:
    - shard-apl:          [DMESG-WARN][103] ([i915#95]) -> [DMESG-FAIL][104] ([i915#95])
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-apl7/igt@kms_draw_crc@fill-fb.html
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-apl2/igt@kms_draw_crc@fill-fb.html

  * igt@kms_fbcon_fbt@fbc:
    - shard-kbl:          [FAIL][105] ([i915#64]) -> [DMESG-FAIL][106] ([i915#95])
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-kbl6/igt@kms_fbcon_fbt@fbc.html
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-kbl1/igt@kms_fbcon_fbt@fbc.html

  
  [IGT#5]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/5
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
  [fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
  [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
  [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
  [i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185
  [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
  [i915#128]: https://gitlab.freedesktop.org/drm/intel/issues/128
  [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
  [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2013]: https://gitlab.freedesktop.org/drm/intel/issues/2013
  [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
  [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
  [i915#39]: https://gitlab.freedesktop.org/drm/intel/issues/39
  [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
  [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
  [i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
  [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
  [i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53
  [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
  [i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
  [i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
  [i915#64]: https://gitlab.freedesktop.org/drm/intel/issues/64
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
  [i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (11 -> 11)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * Linux: CI_DRM_8604 -> Patchwork_17916

  CI-20190529: 20190529
  CI_DRM_8604: 24c6364ec0e3c895ec4237d7a8f3516316a761ff @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5700: 88e379cef970db3dab020966d5dd117de7cc03ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_17916: b4af214db886283d6bc416bb70d95623c8c47ff6 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors (rev3)

[Imre Deak]

On Tue, Jun 09, 2020 at 08:58:41PM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915: Fix the i915_dsc_fec_support debugfs file for DP MST connectors (rev3)
> URL   : https://patchwork.freedesktop.org/series/78128/
> State : success

Thanks for the review, pushed to -dinq.

> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_8604_full -> Patchwork_17916_full
> ====================================================
> 
> Summary
> -------
> 
>   **SUCCESS**
> 
>   No regressions found.
> 
>   
> 
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_17916_full that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@gem_ctx_shared@q-independent@bcs0:
>     - shard-kbl:          [PASS][1] -> [FAIL][2] ([i915#2013])
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-kbl6/igt@gem_ctx_shared@q-independent@bcs0.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-kbl1/igt@gem_ctx_shared@q-independent@bcs0.html
> 
>   * igt@gem_exec_create@forked:
>     - shard-hsw:          [PASS][3] -> [INCOMPLETE][4] ([i915#61])
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-hsw7/igt@gem_exec_create@forked.html
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-hsw2/igt@gem_exec_create@forked.html
> 
>   * igt@gem_exec_schedule@implicit-read-write@rcs0:
>     - shard-snb:          [PASS][5] -> [INCOMPLETE][6] ([i915#82])
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-snb4/igt@gem_exec_schedule@implicit-read-write@rcs0.html
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-snb6/igt@gem_exec_schedule@implicit-read-write@rcs0.html
> 
>   * igt@gem_exec_whisper@basic-forked-all:
>     - shard-glk:          [PASS][7] -> [DMESG-WARN][8] ([i915#118] / [i915#95]) +1 similar issue
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-glk8/igt@gem_exec_whisper@basic-forked-all.html
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-glk4/igt@gem_exec_whisper@basic-forked-all.html
> 
>   * igt@gem_workarounds@suspend-resume-context:
>     - shard-apl:          [PASS][9] -> [DMESG-WARN][10] ([i915#180]) +3 similar issues
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-apl7/igt@gem_workarounds@suspend-resume-context.html
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-apl4/igt@gem_workarounds@suspend-resume-context.html
> 
>   * igt@i915_module_load@reload-with-fault-injection:
>     - shard-tglb:         [PASS][11] -> [DMESG-WARN][12] ([i915#402]) +3 similar issues
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-tglb6/igt@i915_module_load@reload-with-fault-injection.html
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-tglb5/igt@i915_module_load@reload-with-fault-injection.html
> 
>   * igt@i915_pm_rps@reset:
>     - shard-skl:          [PASS][13] -> [FAIL][14] ([i915#39])
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl10/igt@i915_pm_rps@reset.html
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl5/igt@i915_pm_rps@reset.html
> 
>   * igt@kms_big_fb@linear-64bpp-rotate-180:
>     - shard-glk:          [PASS][15] -> [DMESG-FAIL][16] ([i915#118] / [i915#95]) +1 similar issue
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-glk2/igt@kms_big_fb@linear-64bpp-rotate-180.html
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-glk8/igt@kms_big_fb@linear-64bpp-rotate-180.html
> 
>   * igt@kms_big_fb@yf-tiled-32bpp-rotate-0:
>     - shard-kbl:          [PASS][17] -> [DMESG-WARN][18] ([i915#1982])
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-kbl3/igt@kms_big_fb@yf-tiled-32bpp-rotate-0.html
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-kbl1/igt@kms_big_fb@yf-tiled-32bpp-rotate-0.html
> 
>   * igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen:
>     - shard-kbl:          [PASS][19] -> [DMESG-FAIL][20] ([i915#54] / [i915#95]) +1 similar issue
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen.html
>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen.html
> 
>   * igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen:
>     - shard-skl:          [PASS][21] -> [FAIL][22] ([i915#54]) +1 similar issue
>    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl4/igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen.html
>    [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl1/igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen.html
> 
>   * igt@kms_cursor_crc@pipe-a-cursor-suspend:
>     - shard-kbl:          [PASS][23] -> [DMESG-WARN][24] ([i915#180]) +2 similar issues
>    [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
>    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
> 
>   * igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy:
>     - shard-kbl:          [PASS][25] -> [DMESG-FAIL][26] ([i915#95])
>    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-kbl3/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
>    [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-kbl4/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
> 
>   * igt@kms_cursor_legacy@flip-vs-cursor-legacy:
>     - shard-skl:          [PASS][27] -> [FAIL][28] ([IGT#5])
>    [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
>    [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
> 
>   * igt@kms_cursor_legacy@pipe-c-torture-move:
>     - shard-iclb:         [PASS][29] -> [DMESG-WARN][30] ([i915#128])
>    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-iclb4/igt@kms_cursor_legacy@pipe-c-torture-move.html
>    [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-iclb4/igt@kms_cursor_legacy@pipe-c-torture-move.html
> 
>   * igt@kms_draw_crc@draw-method-rgb565-mmap-wc-ytiled:
>     - shard-kbl:          [PASS][31] -> [DMESG-WARN][32] ([i915#93] / [i915#95]) +2 similar issues
>    [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-kbl4/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-ytiled.html
>    [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-kbl6/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-ytiled.html
> 
>   * igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-ytiled:
>     - shard-skl:          [PASS][33] -> [DMESG-WARN][34] ([i915#1982]) +10 similar issues
>    [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl7/igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-ytiled.html
>    [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl10/igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-ytiled.html
> 
>   * igt@kms_fbcon_fbt@psr-suspend:
>     - shard-iclb:         [PASS][35] -> [INCOMPLETE][36] ([i915#1185])
>    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-iclb5/igt@kms_fbcon_fbt@psr-suspend.html
>    [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-iclb3/igt@kms_fbcon_fbt@psr-suspend.html
> 
>   * igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-wc:
>     - shard-tglb:         [PASS][37] -> [DMESG-WARN][38] ([i915#1982])
>    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-tglb6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-wc.html
>    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-tglb5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-wc.html
> 
>   * igt@kms_hdr@bpc-switch:
>     - shard-skl:          [PASS][39] -> [FAIL][40] ([i915#1188])
>    [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl2/igt@kms_hdr@bpc-switch.html
>    [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl1/igt@kms_hdr@bpc-switch.html
> 
>   * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
>     - shard-skl:          [PASS][41] -> [FAIL][42] ([fdo#108145] / [i915#265]) +1 similar issue
>    [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
>    [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
> 
>   * igt@kms_psr2_su@frontbuffer:
>     - shard-iclb:         [PASS][43] -> [SKIP][44] ([fdo#109642] / [fdo#111068])
>    [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
>    [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-iclb4/igt@kms_psr2_su@frontbuffer.html
> 
>   * igt@kms_psr@psr2_primary_mmap_gtt:
>     - shard-iclb:         [PASS][45] -> [SKIP][46] ([fdo#109441]) +1 similar issue
>    [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
>    [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-iclb4/igt@kms_psr@psr2_primary_mmap_gtt.html
> 
>   * igt@kms_setmode@basic:
>     - shard-skl:          [PASS][47] -> [FAIL][48] ([i915#31])
>    [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl8/igt@kms_setmode@basic.html
>    [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl2/igt@kms_setmode@basic.html
> 
>   * igt@perf_pmu@module-unload:
>     - shard-iclb:         [PASS][49] -> [DMESG-WARN][50] ([i915#1982])
>    [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-iclb8/igt@perf_pmu@module-unload.html
>    [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-iclb3/igt@perf_pmu@module-unload.html
> 
>   * igt@syncobj_wait@invalid-wait-illegal-handle:
>     - shard-apl:          [PASS][51] -> [DMESG-WARN][52] ([i915#95]) +25 similar issues
>    [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-apl1/igt@syncobj_wait@invalid-wait-illegal-handle.html
>    [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-apl8/igt@syncobj_wait@invalid-wait-illegal-handle.html
> 
>   
> #### Possible fixes ####
> 
>   * igt@gem_ctx_shared@q-independent@bcs0:
>     - shard-apl:          [FAIL][53] ([i915#2013]) -> [PASS][54]
>    [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-apl2/igt@gem_ctx_shared@q-independent@bcs0.html
>    [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-apl1/igt@gem_ctx_shared@q-independent@bcs0.html
> 
>   * igt@gem_exec_suspend@basic-s3:
>     - shard-kbl:          [DMESG-WARN][55] ([i915#93] / [i915#95]) -> [PASS][56]
>    [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-kbl4/igt@gem_exec_suspend@basic-s3.html
>    [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-kbl2/igt@gem_exec_suspend@basic-s3.html
> 
>   * igt@kms_big_fb@x-tiled-64bpp-rotate-180:
>     - shard-glk:          [DMESG-FAIL][57] ([i915#118] / [i915#95]) -> [PASS][58]
>    [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-glk8/igt@kms_big_fb@x-tiled-64bpp-rotate-180.html
>    [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-glk4/igt@kms_big_fb@x-tiled-64bpp-rotate-180.html
> 
>   * igt@kms_big_fb@yf-tiled-32bpp-rotate-90:
>     - shard-apl:          [DMESG-WARN][59] ([i915#1982]) -> [PASS][60]
>    [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-apl6/igt@kms_big_fb@yf-tiled-32bpp-rotate-90.html
>    [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-apl1/igt@kms_big_fb@yf-tiled-32bpp-rotate-90.html
> 
>   * igt@kms_color@pipe-a-ctm-0-5:
>     - shard-skl:          [DMESG-WARN][61] ([i915#1982]) -> [PASS][62] +5 similar issues
>    [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl7/igt@kms_color@pipe-a-ctm-0-5.html
>    [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl8/igt@kms_color@pipe-a-ctm-0-5.html
> 
>   * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
>     - shard-apl:          [DMESG-WARN][63] ([i915#180]) -> [PASS][64]
>    [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
>    [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-apl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
> 
>   * igt@kms_flip@flip-vs-suspend@a-edp1:
>     - shard-skl:          [INCOMPLETE][65] ([i915#198]) -> [PASS][66]
>    [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl8/igt@kms_flip@flip-vs-suspend@a-edp1.html
>    [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl5/igt@kms_flip@flip-vs-suspend@a-edp1.html
> 
>   * igt@kms_flip@flip-vs-suspend@c-dp1:
>     - shard-kbl:          [DMESG-WARN][67] ([i915#180]) -> [PASS][68] +5 similar issues
>    [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-kbl7/igt@kms_flip@flip-vs-suspend@c-dp1.html
>    [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-kbl6/igt@kms_flip@flip-vs-suspend@c-dp1.html
> 
>   * igt@kms_flip_tiling@flip-changes-tiling:
>     - shard-kbl:          [DMESG-WARN][69] ([i915#1982]) -> [PASS][70]
>    [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-kbl4/igt@kms_flip_tiling@flip-changes-tiling.html
>    [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-kbl2/igt@kms_flip_tiling@flip-changes-tiling.html
> 
>   * igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-render:
>     - shard-skl:          [FAIL][71] ([i915#49]) -> [PASS][72]
>    [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-render.html
>    [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-render.html
> 
>   * igt@kms_hdr@bpc-switch-suspend:
>     - shard-skl:          [FAIL][73] ([i915#1188]) -> [PASS][74]
>    [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl2/igt@kms_hdr@bpc-switch-suspend.html
>    [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl9/igt@kms_hdr@bpc-switch-suspend.html
> 
>   * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c-frame-sequence:
>     - shard-skl:          [FAIL][75] ([i915#53]) -> [PASS][76]
>    [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl6/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c-frame-sequence.html
>    [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl3/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c-frame-sequence.html
> 
>   * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
>     - shard-skl:          [FAIL][77] ([fdo#108145] / [i915#265]) -> [PASS][78] +1 similar issue
>    [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
>    [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
> 
>   * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
>     - shard-skl:          [DMESG-FAIL][79] ([fdo#108145] / [i915#1982]) -> [PASS][80]
>    [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
>    [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
> 
>   * igt@kms_psr@psr2_primary_mmap_cpu:
>     - shard-iclb:         [SKIP][81] ([fdo#109441]) -> [PASS][82] +2 similar issues
>    [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-iclb3/igt@kms_psr@psr2_primary_mmap_cpu.html
>    [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
> 
>   * igt@kms_setmode@basic:
>     - shard-kbl:          [FAIL][83] ([i915#31]) -> [PASS][84]
>    [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-kbl4/igt@kms_setmode@basic.html
>    [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-kbl6/igt@kms_setmode@basic.html
> 
>   * igt@kms_vblank@pipe-c-query-busy-hang:
>     - shard-tglb:         [DMESG-WARN][85] ([i915#402]) -> [PASS][86]
>    [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-tglb1/igt@kms_vblank@pipe-c-query-busy-hang.html
>    [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-tglb7/igt@kms_vblank@pipe-c-query-busy-hang.html
> 
>   * igt@sw_sync@sync_merge_same:
>     - shard-apl:          [DMESG-WARN][87] ([i915#95]) -> [PASS][88] +19 similar issues
>    [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-apl4/igt@sw_sync@sync_merge_same.html
>    [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-apl8/igt@sw_sync@sync_merge_same.html
> 
>   
> #### Warnings ####
> 
>   * igt@i915_pm_dc@dc3co-vpb-simulation:
>     - shard-iclb:         [SKIP][89] ([i915#588]) -> [SKIP][90] ([i915#658])
>    [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
>    [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-iclb4/igt@i915_pm_dc@dc3co-vpb-simulation.html
> 
>   * igt@i915_pm_dc@dc6-dpms:
>     - shard-tglb:         [FAIL][91] ([i915#454]) -> [SKIP][92] ([i915#468])
>    [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-tglb6/igt@i915_pm_dc@dc6-dpms.html
>    [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-tglb2/igt@i915_pm_dc@dc6-dpms.html
> 
>   * igt@i915_pm_dc@dc6-psr:
>     - shard-skl:          [FAIL][93] ([i915#454]) -> [DMESG-FAIL][94] ([i915#1982])
>    [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-skl4/igt@i915_pm_dc@dc6-psr.html
>    [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-skl9/igt@i915_pm_dc@dc6-psr.html
> 
>   * igt@kms_content_protection@atomic:
>     - shard-apl:          [FAIL][95] ([fdo#110321] / [fdo#110336]) -> [TIMEOUT][96] ([i915#1319] / [i915#1635])
>    [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-apl1/igt@kms_content_protection@atomic.html
>    [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-apl8/igt@kms_content_protection@atomic.html
> 
>   * igt@kms_content_protection@atomic-dpms:
>     - shard-apl:          [TIMEOUT][97] ([i915#1319]) -> [TIMEOUT][98] ([i915#1319] / [i915#1635])
>    [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-apl3/igt@kms_content_protection@atomic-dpms.html
>    [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-apl6/igt@kms_content_protection@atomic-dpms.html
> 
>   * igt@kms_content_protection@legacy:
>     - shard-apl:          [TIMEOUT][99] ([i915#1319] / [i915#1635]) -> [FAIL][100] ([fdo#110321] / [fdo#110336])
>    [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-apl4/igt@kms_content_protection@legacy.html
>    [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-apl4/igt@kms_content_protection@legacy.html
> 
>   * igt@kms_content_protection@lic:
>     - shard-apl:          [TIMEOUT][101] ([i915#1319] / [i915#1635]) -> [TIMEOUT][102] ([i915#1319]) +1 similar issue
>    [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-apl2/igt@kms_content_protection@lic.html
>    [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-apl7/igt@kms_content_protection@lic.html
> 
>   * igt@kms_draw_crc@fill-fb:
>     - shard-apl:          [DMESG-WARN][103] ([i915#95]) -> [DMESG-FAIL][104] ([i915#95])
>    [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-apl7/igt@kms_draw_crc@fill-fb.html
>    [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-apl2/igt@kms_draw_crc@fill-fb.html
> 
>   * igt@kms_fbcon_fbt@fbc:
>     - shard-kbl:          [FAIL][105] ([i915#64]) -> [DMESG-FAIL][106] ([i915#95])
>    [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8604/shard-kbl6/igt@kms_fbcon_fbt@fbc.html
>    [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/shard-kbl1/igt@kms_fbcon_fbt@fbc.html
> 
>   
>   [IGT#5]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/5
>   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
>   [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
>   [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
>   [fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
>   [fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
>   [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
>   [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
>   [i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185
>   [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
>   [i915#128]: https://gitlab.freedesktop.org/drm/intel/issues/128
>   [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
>   [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
>   [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
>   [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
>   [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
>   [i915#2013]: https://gitlab.freedesktop.org/drm/intel/issues/2013
>   [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
>   [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
>   [i915#39]: https://gitlab.freedesktop.org/drm/intel/issues/39
>   [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
>   [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
>   [i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
>   [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
>   [i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53
>   [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
>   [i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
>   [i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
>   [i915#64]: https://gitlab.freedesktop.org/drm/intel/issues/64
>   [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
>   [i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
>   [i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
>   [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
> 
> 
> Participating hosts (11 -> 11)
> ------------------------------
> 
>   No changes in participating hosts
> 
> 
> Build changes
> -------------
> 
>   * Linux: CI_DRM_8604 -> Patchwork_17916
> 
>   CI-20190529: 20190529
>   CI_DRM_8604: 24c6364ec0e3c895ec4237d7a8f3516316a761ff @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_5700: 88e379cef970db3dab020966d5dd117de7cc03ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_17916: b4af214db886283d6bc416bb70d95623c8c47ff6 @ git://anongit.freedesktop.org/gfx-ci/linux
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17916/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx