All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Naohiro Aota <naohiro.aota@wdc.com>,
	Stephen Boyd <swboyd@google.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Masahiro Yamada <masahiroy@kernel.org>,
	linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
	Manoj Gupta <manojgupta@google.com>,
	Luis Lozano <llozano@google.com>,
	Nathan Chancellor <natechancellor@gmail.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	Will Deacon <will@kernel.org>, Dave Martin <Dave.Martin@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] arm64: vdso32: add CONFIG_THUMB2_COMPAT_VDSO
Date: Tue, 9 Jun 2020 21:35:03 +0100	[thread overview]
Message-ID: <20200609203502.GA21214@gaia> (raw)
In-Reply-To: <20200608205711.109418-1-ndesaulniers@google.com>

On Mon, Jun 08, 2020 at 01:57:08PM -0700, Nick Desaulniers wrote:
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 7f9d38444d6d..fe9e6b231cac 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -1299,6 +1299,14 @@ config COMPAT_VDSO
>  	  You must have a 32-bit build of glibc 2.22 or later for programs
>  	  to seamlessly take advantage of this.
>  
> +config THUMB2_COMPAT_VDSO
> +	bool "Compile the vDSO in THUMB2 mode"
> +	depends on COMPAT_VDSO
> +	default y
> +	help
> +	  Compile the compat vDSO with -mthumb -fomit-frame-pointer if y, otherwise
> +	  as -marm.

Now that we understood the issue (I think), do we actually need this
choice? Why not going for -mthumb -fomit-frame-pointer always for the
compat vdso?

-- 
Catalin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Will Deacon <will@kernel.org>, Stephen Boyd <swboyd@google.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Dave Martin <Dave.Martin@arm.com>,
	Luis Lozano <llozano@google.com>,
	Manoj Gupta <manojgupta@google.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Nathan Chancellor <natechancellor@gmail.com>,
	Naohiro Aota <naohiro.aota@wdc.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH v2] arm64: vdso32: add CONFIG_THUMB2_COMPAT_VDSO
Date: Tue, 9 Jun 2020 21:35:03 +0100	[thread overview]
Message-ID: <20200609203502.GA21214@gaia> (raw)
In-Reply-To: <20200608205711.109418-1-ndesaulniers@google.com>

On Mon, Jun 08, 2020 at 01:57:08PM -0700, Nick Desaulniers wrote:
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 7f9d38444d6d..fe9e6b231cac 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -1299,6 +1299,14 @@ config COMPAT_VDSO
>  	  You must have a 32-bit build of glibc 2.22 or later for programs
>  	  to seamlessly take advantage of this.
>  
> +config THUMB2_COMPAT_VDSO
> +	bool "Compile the vDSO in THUMB2 mode"
> +	depends on COMPAT_VDSO
> +	default y
> +	help
> +	  Compile the compat vDSO with -mthumb -fomit-frame-pointer if y, otherwise
> +	  as -marm.

Now that we understood the issue (I think), do we actually need this
choice? Why not going for -mthumb -fomit-frame-pointer always for the
compat vdso?

-- 
Catalin

  reply	other threads:[~2020-06-09 20:35 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-26 17:31 [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm Nick Desaulniers
2020-05-26 17:31 ` Nick Desaulniers
2020-05-26 18:55 ` Stephen Boyd
2020-05-26 18:55   ` Stephen Boyd
2020-05-26 20:45 ` Will Deacon
2020-05-26 20:45   ` Will Deacon
2020-05-27 13:53   ` Dave Martin
2020-05-27 13:53     ` Dave Martin
2020-05-27 17:58     ` Nick Desaulniers
2020-05-27 17:58       ` Nick Desaulniers
2020-05-27 13:45 ` Robin Murphy
2020-05-27 13:45   ` Robin Murphy
2020-05-27 17:55   ` Nick Desaulniers
2020-05-27 17:55     ` Nick Desaulniers
2020-05-27 18:08     ` Will Deacon
2020-05-27 18:08       ` Will Deacon
2020-05-27 18:17       ` Nick Desaulniers
2020-05-27 18:17         ` Nick Desaulniers
2020-05-28  7:20         ` Will Deacon
2020-05-28  7:20           ` Will Deacon
2020-06-08 20:57           ` [PATCH v2] arm64: vdso32: add CONFIG_THUMB2_COMPAT_VDSO Nick Desaulniers
2020-06-08 20:57             ` Nick Desaulniers
2020-06-09 20:35             ` Catalin Marinas [this message]
2020-06-09 20:35               ` Catalin Marinas
2020-06-09 23:55               ` Nick Desaulniers
2020-06-09 23:55                 ` Nick Desaulniers
2020-06-10  8:47                 ` Will Deacon
2020-06-10  8:47                   ` Will Deacon
2020-06-10 10:29                   ` Catalin Marinas
2020-06-10 10:29                     ` Catalin Marinas
2020-06-10 10:32                     ` Will Deacon
2020-06-10 10:32                       ` Will Deacon
2020-06-10 11:21             ` Will Deacon
2020-06-10 11:21               ` Will Deacon
2020-05-27 19:28     ` [PATCH] arm64: vdso32: force vdso32 to be compiled as -marm Robin Murphy
2020-05-27 19:28       ` Robin Murphy
2020-05-27 20:02       ` Robin Murphy
2020-05-27 20:02         ` Robin Murphy
2020-05-27 20:14       ` Nick Desaulniers
2020-05-27 20:14         ` Nick Desaulniers
2020-05-27 20:31         ` Nick Desaulniers
2020-05-27 20:31           ` Nick Desaulniers
2020-05-27 21:47           ` Nick Desaulniers
2020-05-27 21:47             ` Nick Desaulniers
2020-05-28  8:05           ` Peter Smith
2020-05-28  8:05             ` Peter Smith
2020-05-28  9:41             ` Catalin Marinas
2020-05-28  9:41               ` Catalin Marinas
2020-05-28 19:06               ` Nick Desaulniers
2020-05-28 19:06                 ` Nick Desaulniers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200609203502.GA21214@gaia \
    --to=catalin.marinas@arm.com \
    --cc=Dave.Martin@arm.com \
    --cc=clang-built-linux@googlegroups.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llozano@google.com \
    --cc=manojgupta@google.com \
    --cc=masahiroy@kernel.org \
    --cc=naohiro.aota@wdc.com \
    --cc=natechancellor@gmail.com \
    --cc=ndesaulniers@google.com \
    --cc=robin.murphy@arm.com \
    --cc=swboyd@google.com \
    --cc=vincenzo.frascino@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.