[MPTCP] Re: [PATCH mptcp-next 1/2] selftests: mptcp: add option to specify size of file to transfer

[MPTCP] Re: [PATCH mptcp-next 1/2] selftests: mptcp: add option to specify size of file to transfer

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 1577 bytes --]

Hi Florian,

On 10/06/2020 13:55, Florian Westphal wrote:
> The script generates two random files that are then sent via tcp and
> mptcp connections.
> 
> In order to compare throughput over consecutive runs add an option
> to provide the file size on the command line: "-f 128000".
> 
> Also add an option, -t, to enable tcp tests. This is useful to
> compare throughput of mptcp connections and tcp connections.
> 
> Example: run tests with a 4mb file size, 300ms delay 0.01% loss,
> default gso/tso/gro settings and with large write/blocking io:
> 
> mptcp_connect.sh -t -f $((4 * 1024 * 1024)) -d 300 -l 0.01%  -r 0 -e "" -m mmap

Thank you for the patch! Good idea!

> diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.sh b/tools/testing/selftests/net/mptcp/mptcp_connect.sh
> index acf02e156d20..d9e83efd438b 100755
> --- a/tools/testing/selftests/net/mptcp/mptcp_connect.sh
> +++ b/tools/testing/selftests/net/mptcp/mptcp_connect.sh

(...)

> @@ -40,9 +42,11 @@ usage() {
>   	echo -e "\t-e: ethtool features to disable, e.g.: \"-e tso -e gso\" (default: randomly disable any of tso/gso/gro)"
>   	echo -e "\t-4: IPv4 only: disable IPv6 tests (default: test both IPv4 and IPv6)"
>   	echo -e "\t-c: capture packets for each test using tcpdump (default: no capture)"
> +	echo -e "\t-s: size of file to transfer in bytes (default random)"

Small detail: it should be "-f" instead of "-s". I can fix this when 
applying the patch in mptcp-next.

Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

[MPTCP] Re: [PATCH mptcp-next 1/2] selftests: mptcp: add option to specify size of file to transfer

[Florian Westphal]

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

Matthieu Baerts <matthieu.baerts(a)tessares.net> wrote:
> > @@ -40,9 +42,11 @@ usage() {
> >   	echo -e "\t-e: ethtool features to disable, e.g.: \"-e tso -e gso\" (default: randomly disable any of tso/gso/gro)"
> >   	echo -e "\t-4: IPv4 only: disable IPv6 tests (default: test both IPv4 and IPv6)"
> >   	echo -e "\t-c: capture packets for each test using tcpdump (default: no capture)"
> > +	echo -e "\t-s: size of file to transfer in bytes (default random)"
> 
> Small detail: it should be "-f" instead of "-s". I can fix this when
> applying the patch in mptcp-next.

Thanks, please do that.