From: Al Viro <viro@zeniv.linux.org.uk>
To: Matthew Wilcox <willy@infradead.org>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
Miklos Szeredi <miklos@szeredi.hu>,
kbuild test robot <lkp@intel.com>,
kbuild-all@lists.01.org, Colin Walters <walters@verbum.org>,
syzbot <syzbot+d6ec23007e951dadf3de@syzkaller.appspotmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
overlayfs <linux-unionfs@vger.kernel.org>
Subject: Re: [PATCH v2] ovl: provide real_file() and overlayfs get_unmapped_area()
Date: Thu, 11 Jun 2020 03:17:10 +0100 [thread overview]
Message-ID: <20200611021710.GA23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20200611013616.GM19604@bombadil.infradead.org>
On Wed, Jun 10, 2020 at 06:36:16PM -0700, Matthew Wilcox wrote:
> while (file->f_mode & FMODE_OVL_UPPER)
> file = file->private_data;
> return file;
>
> Or are you proposing that overlayfs copy FMODE_HUGEPAGES from the
> underlying fs to the overlaying fs?
The latter - that way nobody outside of overlayfs needs to know what
its ->private_data points to, for one thing. And it's cheaper that
way, obviously.
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@zeniv.linux.org.uk>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2] ovl: provide real_file() and overlayfs get_unmapped_area()
Date: Thu, 11 Jun 2020 03:17:10 +0100 [thread overview]
Message-ID: <20200611021710.GA23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20200611013616.GM19604@bombadil.infradead.org>
[-- Attachment #1: Type: text/plain, Size: 427 bytes --]
On Wed, Jun 10, 2020 at 06:36:16PM -0700, Matthew Wilcox wrote:
> while (file->f_mode & FMODE_OVL_UPPER)
> file = file->private_data;
> return file;
>
> Or are you proposing that overlayfs copy FMODE_HUGEPAGES from the
> underlying fs to the overlaying fs?
The latter - that way nobody outside of overlayfs needs to know what
its ->private_data points to, for one thing. And it's cheaper that
way, obviously.
next prev parent reply other threads:[~2020-06-11 2:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 3:06 kernel BUG at mm/hugetlb.c:LINE! syzbot
2020-04-06 22:05 ` Mike Kravetz
2020-05-12 15:04 ` Miklos Szeredi
2020-05-12 18:11 ` Mike Kravetz
2020-05-15 22:15 ` Mike Kravetz
2020-05-18 11:12 ` Miklos Szeredi
2020-05-18 23:22 ` Mike Kravetz
2020-05-18 23:41 ` Colin Walters
2020-05-19 0:35 ` Mike Kravetz
2020-05-20 11:20 ` Miklos Szeredi
2020-05-20 17:27 ` Mike Kravetz
2020-05-22 10:05 ` Miklos Szeredi
2020-05-28 0:01 ` Mike Kravetz
2020-05-28 8:37 ` [PATCH v2] ovl: provide real_file() and overlayfs get_unmapped_area() kbuild test robot
2020-05-28 8:37 ` kbuild test robot
2020-05-28 21:01 ` Mike Kravetz
2020-05-28 21:01 ` Mike Kravetz
2020-06-04 9:16 ` Miklos Szeredi
2020-06-04 9:16 ` Miklos Szeredi
2020-06-11 0:13 ` Mike Kravetz
2020-06-11 0:13 ` Mike Kravetz
2020-06-11 0:37 ` Al Viro
2020-06-11 0:37 ` Al Viro
2020-06-11 1:36 ` Matthew Wilcox
2020-06-11 1:36 ` Matthew Wilcox
2020-06-11 2:17 ` Al Viro [this message]
2020-06-11 2:17 ` Al Viro
2020-06-11 2:31 ` Mike Kravetz
2020-06-11 2:31 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200611021710.GA23230@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mike.kravetz@oracle.com \
--cc=miklos@szeredi.hu \
--cc=syzbot+d6ec23007e951dadf3de@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=walters@verbum.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.