* [wsa:i2c/for-5.8 98/102] drivers/i2c/busses/i2c-npcm7xx.c:127:11: sparse: sparse: symbol 'npcm_i2caddr' was not declared. Should it be
@ 2020-06-11 2:50 kernel test robot
2020-06-11 2:50 ` [RFC PATCH wsa] i2c: npcm7xx: npcm_i2caddr[] can be static kernel test robot
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2020-06-11 2:50 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-5.8
head: cb301414763e07e4cef58c9d5ef3750d1f9539bc
commit: f54736925a4f83a67588381d0ead69d19323b526 [98/102] i2c: npcm7xx: Add support for slave mode for Nuvoton
config: i386-randconfig-s001-20200611 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-247-gcadbd124-dirty
git checkout f54736925a4f83a67588381d0ead69d19323b526
# save the attached .config to linux build tree
make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/i2c/busses/i2c-npcm7xx.c:127:11: sparse: sparse: symbol 'npcm_i2caddr' was not declared. Should it be static?
>> drivers/i2c/busses/i2c-npcm7xx.c:1115:61: sparse: sparse: Using plain integer as NULL pointer
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41767 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RFC PATCH wsa] i2c: npcm7xx: npcm_i2caddr[] can be static
2020-06-11 2:50 [wsa:i2c/for-5.8 98/102] drivers/i2c/busses/i2c-npcm7xx.c:127:11: sparse: sparse: symbol 'npcm_i2caddr' was not declared. Should it be kernel test robot
@ 2020-06-11 2:50 ` kernel test robot
2020-06-11 10:31 ` Wolfram Sang
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2020-06-11 2:50 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 805 bytes --]
Fixes: f54736925a4f ("i2c: npcm7xx: Add support for slave mode for Nuvoton")
Signed-off-by: kernel test robot <lkp@intel.com>
---
i2c-npcm7xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c
index a8e75c3484f12..d027c0a3a887f 100644
--- a/drivers/i2c/busses/i2c-npcm7xx.c
+++ b/drivers/i2c/busses/i2c-npcm7xx.c
@@ -124,7 +124,7 @@ enum i2c_addr {
* use this array to get the address or each register.
*/
#define I2C_NUM_OWN_ADDR 10
-const int npcm_i2caddr[I2C_NUM_OWN_ADDR] = {
+static const int npcm_i2caddr[I2C_NUM_OWN_ADDR] = {
NPCM_I2CADDR1, NPCM_I2CADDR2, NPCM_I2CADDR3, NPCM_I2CADDR4,
NPCM_I2CADDR5, NPCM_I2CADDR6, NPCM_I2CADDR7, NPCM_I2CADDR8,
NPCM_I2CADDR9, NPCM_I2CADDR10,
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH wsa] i2c: npcm7xx: npcm_i2caddr[] can be static
2020-06-11 2:50 ` [RFC PATCH wsa] i2c: npcm7xx: npcm_i2caddr[] can be static kernel test robot
@ 2020-06-11 10:31 ` Wolfram Sang
0 siblings, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2020-06-11 10:31 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 238 bytes --]
On Thu, Jun 11, 2020 at 10:50:35AM +0800, kernel test robot wrote:
>
> Fixes: f54736925a4f ("i2c: npcm7xx: Add support for slave mode for Nuvoton")
> Signed-off-by: kernel test robot <lkp@intel.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-11 10:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-11 2:50 [wsa:i2c/for-5.8 98/102] drivers/i2c/busses/i2c-npcm7xx.c:127:11: sparse: sparse: symbol 'npcm_i2caddr' was not declared. Should it be kernel test robot
2020-06-11 2:50 ` [RFC PATCH wsa] i2c: npcm7xx: npcm_i2caddr[] can be static kernel test robot
2020-06-11 10:31 ` Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.