From: kernel test robot <lkp@intel.com>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>
Cc: kbuild-all@lists.01.org, linux-watchdog@vger.kernel.org,
kernel@pengutronix.de, Ahmad Fatoum <a.fatoum@pengutronix.de>,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH] watchdog: f71808e_wdt: fintek_variants[] can be static
Date: Fri, 12 Jun 2020 12:57:21 +0800 [thread overview]
Message-ID: <20200612045721.GA41703@e3d72cc7cdb3> (raw)
In-Reply-To: <20200611191750.28096-9-a.fatoum@pengutronix.de>
Signed-off-by: kernel test robot <lkp@intel.com>
---
f71808e_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/f71808e_wdt.c b/drivers/watchdog/f71808e_wdt.c
index c866d05e8788b..849620041c0ef 100644
--- a/drivers/watchdog/f71808e_wdt.c
+++ b/drivers/watchdog/f71808e_wdt.c
@@ -484,7 +484,7 @@ static void f81866_pinconf(struct fintek_wdog_data *wd)
superio_clear_bit(wd->sioaddr, SIO_F81866_REG_GPIO1, 5);
}
-struct fintek_variant fintek_variants[] = {
+static struct fintek_variant fintek_variants[] = {
{ SIO_F71808_ID, "f71808fg", f71808fg_pinconf },
{ SIO_F71862_ID, "f71862fg", f71862fg_pinconf },
{ SIO_F71868_ID, "f71868", f71868_pinconf },
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [RFC PATCH] watchdog: f71808e_wdt: fintek_variants[] can be static
Date: Fri, 12 Jun 2020 12:57:21 +0800 [thread overview]
Message-ID: <20200612045721.GA41703@e3d72cc7cdb3> (raw)
In-Reply-To: <20200611191750.28096-9-a.fatoum@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 728 bytes --]
Signed-off-by: kernel test robot <lkp@intel.com>
---
f71808e_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/f71808e_wdt.c b/drivers/watchdog/f71808e_wdt.c
index c866d05e8788b..849620041c0ef 100644
--- a/drivers/watchdog/f71808e_wdt.c
+++ b/drivers/watchdog/f71808e_wdt.c
@@ -484,7 +484,7 @@ static void f81866_pinconf(struct fintek_wdog_data *wd)
superio_clear_bit(wd->sioaddr, SIO_F81866_REG_GPIO1, 5);
}
-struct fintek_variant fintek_variants[] = {
+static struct fintek_variant fintek_variants[] = {
{ SIO_F71808_ID, "f71808fg", f71808fg_pinconf },
{ SIO_F71862_ID, "f71862fg", f71862fg_pinconf },
{ SIO_F71868_ID, "f71868", f71868_pinconf },
next prev parent reply other threads:[~2020-06-12 4:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 19:17 [PATCH v1 0/8] watchdog: f71808e_wdt: migrate to kernel Ahmad Fatoum
2020-06-11 19:17 ` [PATCH v1 1/8] docs: watchdog: codify ident.options as superset of possible status flags Ahmad Fatoum
2020-06-30 20:49 ` Guenter Roeck
2020-06-11 19:17 ` [PATCH v1 2/8] watchdog: f71808e_wdt: indicate WDIOF_CARDRESET support in watchdog_info.options Ahmad Fatoum
2020-06-30 20:51 ` Guenter Roeck
2020-06-11 19:17 ` [PATCH v1 3/8] watchdog: f71808e_wdt: remove use of wrong watchdog_info option Ahmad Fatoum
2020-06-30 21:07 ` Guenter Roeck
2020-06-11 19:17 ` [PATCH v1 4/8] watchdog: f71808e_wdt: clear watchdog timeout occurred flag Ahmad Fatoum
2020-06-30 21:09 ` Guenter Roeck
2020-06-11 19:17 ` [PATCH v1 5/8] watchdog: f71808e_wdt: do stricter parameter validation Ahmad Fatoum
2020-06-30 21:11 ` Guenter Roeck
2020-06-11 19:17 ` [PATCH v1 6/8] watchdog: f71808e_wdt: consolidate variant handling into single array Ahmad Fatoum
2020-06-30 21:18 ` Guenter Roeck
2020-06-11 19:17 ` [PATCH v1 7/8] watchdog: f71808e_wdt: migrate to new kernel watchdog API Ahmad Fatoum
2020-06-30 21:26 ` Guenter Roeck
2020-06-11 19:17 ` [PATCH v1 8/8] watchdog: f71808e_wdt: rename variant-independent identifiers appropriately Ahmad Fatoum
2020-06-12 4:57 ` kernel test robot
2020-06-12 4:57 ` kernel test robot
2020-06-12 4:57 ` kernel test robot [this message]
2020-06-12 4:57 ` [RFC PATCH] watchdog: f71808e_wdt: fintek_variants[] can be static kernel test robot
2020-06-30 21:29 ` [PATCH v1 8/8] watchdog: f71808e_wdt: rename variant-independent identifiers appropriately Guenter Roeck
2020-07-13 8:59 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612045721.GA41703@e3d72cc7cdb3 \
--to=lkp@intel.com \
--cc=a.fatoum@pengutronix.de \
--cc=kbuild-all@lists.01.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.