All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vaibhav Agarwal <vaibhav.sr@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: devel@driverdev.osuosl.org, alsa-devel@alsa-project.org,
	Alex Elder <elder@kernel.org>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Greer <mgreer@animalcreek.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Takashi Iwai <tiwai@suse.com>,
	greybus-dev@lists.linaro.org, Johan Hovold <johan@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/6] Enable Greybus Audio codec driver
Date: Fri, 12 Jun 2020 21:07:24 +0530	[thread overview]
Message-ID: <20200612153722.GB26807@gmail.com> (raw)
In-Reply-To: <20200611082616.GA4671@sirena.org.uk>

On Thu, Jun 11, 2020 at 09:26:16AM +0100, Mark Brown wrote:
> On Wed, Jun 10, 2020 at 11:53:24PM +0530, Vaibhav Agarwal wrote:
> 
> > With patch#6 in this series, I'm proposing some of the (dummy) helper 
> > APIs required to link DAPM DAI widgets for the GB Audio modules 
> > added/removed dynamically.
> 
> > Eventually, I would like to propose relevant changes in snd-soc APIs to 
> > enable dynamic linking of DAI widgets for the modules added and 
> > remove/free component controls for the module removed.
> 
> > I'm seeking your opinion on the proposed changes. And as per the 
> > recommendation I'm sharing the changes with ASoC mailing list as well.
> 
> These are proposed incremental changes to an out of tree driver that has
> never been submitted.  I don't know what the current code looks like,
> what it's supposed to be doing or anything like that so I've no idea
> what's going on or why.
> 
> > Kindly suggest me the preferred way to follow on this thread. 
> 
> This is effectively out of tree code, until someone submits it properly
> I'm not sure it's useful to submit incremental patches upstream.

Thanks for the suggestion Mark. I'll create a separate patchset aligned 
to the ASoC tree in next ~2 weeks and share them separately.

Hi Greg,

Do you think the current patchset can be considered for the purpose of 
resolving componentization issue raised by Alexandre?

--
Regards,
Vaibhav

WARNING: multiple messages have this Message-ID (diff)
From: Vaibhav Agarwal <vaibhav.sr@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Alex Elder <elder@kernel.org>, Johan Hovold <johan@kernel.org>,
	Mark Greer <mgreer@animalcreek.com>,
	Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
	Liam Girdwood <lgirdwood@gmail.com>,
	greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH v2 0/6] Enable Greybus Audio codec driver
Date: Fri, 12 Jun 2020 21:07:24 +0530	[thread overview]
Message-ID: <20200612153722.GB26807@gmail.com> (raw)
In-Reply-To: <20200611082616.GA4671@sirena.org.uk>

On Thu, Jun 11, 2020 at 09:26:16AM +0100, Mark Brown wrote:
> On Wed, Jun 10, 2020 at 11:53:24PM +0530, Vaibhav Agarwal wrote:
> 
> > With patch#6 in this series, I'm proposing some of the (dummy) helper 
> > APIs required to link DAPM DAI widgets for the GB Audio modules 
> > added/removed dynamically.
> 
> > Eventually, I would like to propose relevant changes in snd-soc APIs to 
> > enable dynamic linking of DAI widgets for the modules added and 
> > remove/free component controls for the module removed.
> 
> > I'm seeking your opinion on the proposed changes. And as per the 
> > recommendation I'm sharing the changes with ASoC mailing list as well.
> 
> These are proposed incremental changes to an out of tree driver that has
> never been submitted.  I don't know what the current code looks like,
> what it's supposed to be doing or anything like that so I've no idea
> what's going on or why.
> 
> > Kindly suggest me the preferred way to follow on this thread. 
> 
> This is effectively out of tree code, until someone submits it properly
> I'm not sure it's useful to submit incremental patches upstream.

Thanks for the suggestion Mark. I'll create a separate patchset aligned 
to the ASoC tree in next ~2 weeks and share them separately.

Hi Greg,

Do you think the current patchset can be considered for the purpose of 
resolving componentization issue raised by Alexandre?

--
Regards,
Vaibhav

  reply	other threads:[~2020-06-12 15:38 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-10 17:28 [PATCH v2 0/6] Enable Greybus Audio codec driver Vaibhav Agarwal
2020-06-10 17:28 ` Vaibhav Agarwal
2020-06-10 17:28 ` [PATCH v2 1/6] staging: greybus: audio: Update snd_jack FW usage as per new APIs Vaibhav Agarwal
2020-06-10 17:28   ` Vaibhav Agarwal
2020-06-10 17:28 ` [PATCH v2 2/6] staging: greybus: audio: Maintain jack list within GB Audio module Vaibhav Agarwal
2020-06-10 17:28   ` Vaibhav Agarwal
2020-06-10 17:28 ` [PATCH v2 3/6] staging: greybus: audio: Resolve compilation errors for GB codec module Vaibhav Agarwal
2020-06-10 17:28   ` Vaibhav Agarwal
2020-06-10 17:28 ` [PATCH v2 4/6] staging: greybus: audio: Resolve compilation error in topology parser Vaibhav Agarwal
2020-06-10 17:28   ` Vaibhav Agarwal
2020-06-10 17:45   ` Dan Carpenter
2020-06-10 17:45     ` Dan Carpenter
2020-06-10 18:36     ` Vaibhav Agarwal
2020-06-10 18:36       ` Vaibhav Agarwal
2020-06-10 17:28 ` [PATCH v2 5/6] staging: greybus: audio: Add helper APIs for dynamic audio modules Vaibhav Agarwal
2020-06-10 17:28   ` Vaibhav Agarwal
2020-06-10 17:28 ` [PATCH v2 6/6] staging: greybus: audio: Enable GB codec, audio module compilation Vaibhav Agarwal
2020-06-10 17:28   ` Vaibhav Agarwal
2020-06-10 17:37 ` [PATCH v2 0/6] Enable Greybus Audio codec driver Mark Brown
2020-06-10 17:37   ` Mark Brown
2020-06-10 18:01   ` Alexandre Belloni
2020-06-10 18:01     ` Alexandre Belloni
2020-06-11  8:41     ` Mark Brown
2020-06-11  8:41       ` Mark Brown
2020-06-10 18:23   ` Vaibhav Agarwal
2020-06-10 18:23     ` Vaibhav Agarwal
2020-06-11  8:26     ` Mark Brown
2020-06-11  8:26       ` Mark Brown
2020-06-12 15:37       ` Vaibhav Agarwal [this message]
2020-06-12 15:37         ` Vaibhav Agarwal
2020-06-12 16:06         ` Mark Brown
2020-06-12 16:06           ` Mark Brown
2020-06-10 17:51 ` Dan Carpenter
2020-06-10 17:51   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200612153722.GB26807@gmail.com \
    --to=vaibhav.sr@gmail.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgreer@animalcreek.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.