From: Mark Brown <broonie@kernel.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: robh@kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
tiwai@suse.com, lgirdwood@gmail.com
Subject: Re: [PATCH v3 2/2] ASoC: tas2562: Update shutdown GPIO property
Date: Fri, 12 Jun 2020 17:22:00 +0100 [thread overview]
Message-ID: <20200612162200.GM5396@sirena.org.uk> (raw)
In-Reply-To: <0e482167-71c2-a128-b8b4-a054557d30e9@ti.com>
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
On Fri, Jun 12, 2020 at 11:18:57AM -0500, Dan Murphy wrote:
> On 6/12/20 11:09 AM, Mark Brown wrote:
> > On Fri, Jun 12, 2020 at 11:06:03AM -0500, Dan Murphy wrote:
> > > - tas2562->sdz_gpio = devm_gpiod_get_optional(dev, "shut-down-gpio",
> > > + tas2562->sdz_gpio = devm_gpiod_get_optional(dev, "shutdown",
> > > GPIOD_OUT_HIGH);
> > This also changes the name from shut-down to shutdown which will be
> > incompatible (IIRC we do try -gpio as well as -gpios).
> Yes the non-standardish name was highlighted by Rob[1].
Yes, but we released with it so it's an ABI now and we should still
support the old name.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
robh@kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/2] ASoC: tas2562: Update shutdown GPIO property
Date: Fri, 12 Jun 2020 17:22:00 +0100 [thread overview]
Message-ID: <20200612162200.GM5396@sirena.org.uk> (raw)
In-Reply-To: <0e482167-71c2-a128-b8b4-a054557d30e9@ti.com>
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
On Fri, Jun 12, 2020 at 11:18:57AM -0500, Dan Murphy wrote:
> On 6/12/20 11:09 AM, Mark Brown wrote:
> > On Fri, Jun 12, 2020 at 11:06:03AM -0500, Dan Murphy wrote:
> > > - tas2562->sdz_gpio = devm_gpiod_get_optional(dev, "shut-down-gpio",
> > > + tas2562->sdz_gpio = devm_gpiod_get_optional(dev, "shutdown",
> > > GPIOD_OUT_HIGH);
> > This also changes the name from shut-down to shutdown which will be
> > incompatible (IIRC we do try -gpio as well as -gpios).
> Yes the non-standardish name was highlighted by Rob[1].
Yes, but we released with it so it's an ABI now and we should still
support the old name.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-12 16:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 16:06 [PATCH v3 1/2] dt-bindings: tas2562: Convert the tas2562 binding to yaml Dan Murphy
2020-06-12 16:06 ` Dan Murphy
2020-06-12 16:06 ` [PATCH v3 2/2] ASoC: tas2562: Update shutdown GPIO property Dan Murphy
2020-06-12 16:06 ` Dan Murphy
2020-06-12 16:09 ` Mark Brown
2020-06-12 16:09 ` Mark Brown
2020-06-12 16:18 ` Dan Murphy
2020-06-12 16:18 ` Dan Murphy
2020-06-12 16:22 ` Mark Brown [this message]
2020-06-12 16:22 ` Mark Brown
2020-06-12 16:27 ` Dan Murphy
2020-06-12 16:27 ` Dan Murphy
2020-06-12 16:30 ` Mark Brown
2020-06-12 16:30 ` Mark Brown
2020-06-12 16:56 ` Dan Murphy
2020-06-12 16:56 ` Dan Murphy
-- strict thread matches above, loose matches on Subject: below --
2020-07-23 16:08 [PATCH v3 1/2] dt-bindings: tas2562: Convert the tas2562 binding to yaml Dan Murphy
2020-07-23 16:08 ` [PATCH v3 2/2] ASoC: tas2562: Update shutdown GPIO property Dan Murphy
2020-07-23 16:08 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612162200.GM5396@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.