* [PATCH] arm-bsp: Fix gem5 build break
@ 2020-06-11 12:48 Jon Mason
2020-06-11 13:18 ` Diego Sueiro
2020-06-11 17:36 ` [meta-arm] " Denys Dmytriyenko
0 siblings, 2 replies; 5+ messages in thread
From: Jon Mason @ 2020-06-11 12:48 UTC (permalink / raw)
To: meta-arm; +Cc: nd
OE-core removed DEPLOY_DIR_TOOLS, which is causing a build break on gem5
due to DEPLOY_DIR_TOOLS usage. Temporarily define it in the recipe to
get it working.
Change-Id: I8d4d6e73009cab8ad7102045b855afcad34d3bf3
Signed-off-by: Jon Mason <jon.mason@arm.com>
---
meta-arm-bsp/conf/machine/gem5-arm64.conf | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta-arm-bsp/conf/machine/gem5-arm64.conf b/meta-arm-bsp/conf/machine/gem5-arm64.conf
index 4db86c9..fc31bcf 100644
--- a/meta-arm-bsp/conf/machine/gem5-arm64.conf
+++ b/meta-arm-bsp/conf/machine/gem5-arm64.conf
@@ -51,3 +51,5 @@ EXTRA_IMAGEDEPENDS += "gem5-aarch64-native"
# rngd (Part of rng-tools) takes ~7 mins to init resulting in a slow boot time.
PACKAGE_EXCLUDE_append = " rng-tools"
IMAGE_INSTALL_append = " haveged"
+
+DEPLOY_DIR_TOOLS = "${DEPLOY_DIR}/tools"
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm-bsp: Fix gem5 build break
2020-06-11 12:48 [PATCH] arm-bsp: Fix gem5 build break Jon Mason
@ 2020-06-11 13:18 ` Diego Sueiro
2020-06-11 17:36 ` [meta-arm] " Denys Dmytriyenko
1 sibling, 0 replies; 5+ messages in thread
From: Diego Sueiro @ 2020-06-11 13:18 UTC (permalink / raw)
To: meta-arm
On Thu, Jun 11, 2020 at 01:48 PM, Jon Mason wrote:
>
> OE-core removed DEPLOY_DIR_TOOLS, which is causing a build break on gem5
> due to DEPLOY_DIR_TOOLS usage. Temporarily define it in the recipe to
> get it working.
>
> Change-Id: I8d4d6e73009cab8ad7102045b855afcad34d3bf3
> Signed-off-by: Jon Mason <jon.mason@arm.com>
Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>
> ---
> meta-arm-bsp/conf/machine/gem5-arm64.conf | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta-arm-bsp/conf/machine/gem5-arm64.conf
> b/meta-arm-bsp/conf/machine/gem5-arm64.conf
> index 4db86c9..fc31bcf 100644
> --- a/meta-arm-bsp/conf/machine/gem5-arm64.conf
> +++ b/meta-arm-bsp/conf/machine/gem5-arm64.conf
> @@ -51,3 +51,5 @@ EXTRA_IMAGEDEPENDS += "gem5-aarch64-native"
> # rngd (Part of rng-tools) takes ~7 mins to init resulting in a slow boot
> time.
> PACKAGE_EXCLUDE_append = " rng-tools"
> IMAGE_INSTALL_append = " haveged"
> +
> +DEPLOY_DIR_TOOLS = "${DEPLOY_DIR}/tools"
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [meta-arm] [PATCH] arm-bsp: Fix gem5 build break
2020-06-11 12:48 [PATCH] arm-bsp: Fix gem5 build break Jon Mason
2020-06-11 13:18 ` Diego Sueiro
@ 2020-06-11 17:36 ` Denys Dmytriyenko
2020-06-12 12:43 ` Jon Mason
1 sibling, 1 reply; 5+ messages in thread
From: Denys Dmytriyenko @ 2020-06-11 17:36 UTC (permalink / raw)
To: Jon Mason; +Cc: meta-arm, nd
On Thu, Jun 11, 2020 at 08:48:26AM -0400, Jon Mason wrote:
> OE-core removed DEPLOY_DIR_TOOLS, which is causing a build break on gem5
> due to DEPLOY_DIR_TOOLS usage. Temporarily define it in the recipe to
> get it working.
It's coming back, it's in master-next of OE-Core now:
https://git.openembedded.org/openembedded-core/commit/?h=master-next&id=6a6cb9bcf97dfad636ab782c1d337003a9118a82
> Change-Id: I8d4d6e73009cab8ad7102045b855afcad34d3bf3
> Signed-off-by: Jon Mason <jon.mason@arm.com>
> ---
> meta-arm-bsp/conf/machine/gem5-arm64.conf | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta-arm-bsp/conf/machine/gem5-arm64.conf b/meta-arm-bsp/conf/machine/gem5-arm64.conf
> index 4db86c9..fc31bcf 100644
> --- a/meta-arm-bsp/conf/machine/gem5-arm64.conf
> +++ b/meta-arm-bsp/conf/machine/gem5-arm64.conf
> @@ -51,3 +51,5 @@ EXTRA_IMAGEDEPENDS += "gem5-aarch64-native"
> # rngd (Part of rng-tools) takes ~7 mins to init resulting in a slow boot time.
> PACKAGE_EXCLUDE_append = " rng-tools"
> IMAGE_INSTALL_append = " haveged"
> +
> +DEPLOY_DIR_TOOLS = "${DEPLOY_DIR}/tools"
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [meta-arm] [PATCH] arm-bsp: Fix gem5 build break
2020-06-11 17:36 ` [meta-arm] " Denys Dmytriyenko
@ 2020-06-12 12:43 ` Jon Mason
2020-06-12 17:41 ` Denys Dmytriyenko
0 siblings, 1 reply; 5+ messages in thread
From: Jon Mason @ 2020-06-12 12:43 UTC (permalink / raw)
To: Denys Dmytriyenko; +Cc: Jon Mason, meta-arm, nd
On Thu, Jun 11, 2020 at 01:36:20PM -0400, Denys Dmytriyenko wrote:
> On Thu, Jun 11, 2020 at 08:48:26AM -0400, Jon Mason wrote:
> > OE-core removed DEPLOY_DIR_TOOLS, which is causing a build break on gem5
> > due to DEPLOY_DIR_TOOLS usage. Temporarily define it in the recipe to
> > get it working.
>
> It's coming back, it's in master-next of OE-Core now:
> https://git.openembedded.org/openembedded-core/commit/?h=master-next&id=6a6cb9bcf97dfad636ab782c1d337003a9118a82
Alright. I'd prefer to wait rather than apply and revert. So,
dropping this patch.
Thanks,
Jon
>
>
> > Change-Id: I8d4d6e73009cab8ad7102045b855afcad34d3bf3
> > Signed-off-by: Jon Mason <jon.mason@arm.com>
> > ---
> > meta-arm-bsp/conf/machine/gem5-arm64.conf | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/meta-arm-bsp/conf/machine/gem5-arm64.conf b/meta-arm-bsp/conf/machine/gem5-arm64.conf
> > index 4db86c9..fc31bcf 100644
> > --- a/meta-arm-bsp/conf/machine/gem5-arm64.conf
> > +++ b/meta-arm-bsp/conf/machine/gem5-arm64.conf
> > @@ -51,3 +51,5 @@ EXTRA_IMAGEDEPENDS += "gem5-aarch64-native"
> > # rngd (Part of rng-tools) takes ~7 mins to init resulting in a slow boot time.
> > PACKAGE_EXCLUDE_append = " rng-tools"
> > IMAGE_INSTALL_append = " haveged"
> > +
> > +DEPLOY_DIR_TOOLS = "${DEPLOY_DIR}/tools"
> > --
> > 2.17.1
> >
>
> >
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [meta-arm] [PATCH] arm-bsp: Fix gem5 build break
2020-06-12 12:43 ` Jon Mason
@ 2020-06-12 17:41 ` Denys Dmytriyenko
0 siblings, 0 replies; 5+ messages in thread
From: Denys Dmytriyenko @ 2020-06-12 17:41 UTC (permalink / raw)
To: Jon Mason; +Cc: Jon Mason, meta-arm, nd
On Fri, Jun 12, 2020 at 08:43:08AM -0400, Jon Mason wrote:
> On Thu, Jun 11, 2020 at 01:36:20PM -0400, Denys Dmytriyenko wrote:
> > On Thu, Jun 11, 2020 at 08:48:26AM -0400, Jon Mason wrote:
> > > OE-core removed DEPLOY_DIR_TOOLS, which is causing a build break on gem5
> > > due to DEPLOY_DIR_TOOLS usage. Temporarily define it in the recipe to
> > > get it working.
> >
> > It's coming back, it's in master-next of OE-Core now:
> > https://git.openembedded.org/openembedded-core/commit/?h=master-next&id=6a6cb9bcf97dfad636ab782c1d337003a9118a82
>
> Alright. I'd prefer to wait rather than apply and revert. So,
> dropping this patch.
Yes, it's in master as of this morning.
--
Denys
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-06-12 17:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-11 12:48 [PATCH] arm-bsp: Fix gem5 build break Jon Mason
2020-06-11 13:18 ` Diego Sueiro
2020-06-11 17:36 ` [meta-arm] " Denys Dmytriyenko
2020-06-12 12:43 ` Jon Mason
2020-06-12 17:41 ` Denys Dmytriyenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.