* [PATCH] trusted-firmware-a: fiptool build using BUILD_CFLAGS and BUILD_LDFLAGS
@ 2020-06-11 14:17 Diego Sueiro
2020-06-12 12:45 ` [meta-arm] " Jon Mason
0 siblings, 1 reply; 7+ messages in thread
From: Diego Sueiro @ 2020-06-11 14:17 UTC (permalink / raw)
To: meta-arm; +Cc: nd
Since the TF-A fiptool is native tool we should be using the
BUILD_CFLAGS and BUILD_LDFLAGS flags to proper build and execute it.
Change-Id: I9634604dbc42ba7da85d9b9449f1ed94ecb38df2
Issue-Id: SCM-888
Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
---
meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
index 6f64773..e57d3fe 100644
--- a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
+++ b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
@@ -116,9 +116,8 @@ do_compile() {
cd ${S}
# These changes are needed to have the fiptool compiling and executing properly
- sed -i '/^LDLIBS/ s,$, \-L${RECIPE_SYSROOT_NATIVE}${libdir},' ${S}/tools/fiptool/Makefile
- sed -i '/^INCLUDE_PATHS/ s,$, \-I${RECIPE_SYSROOT_NATIVE}${includedir},' ${S}/tools/fiptool/Makefile
- export LD_LIBRARY_PATH=${STAGING_DIR_NATIVE}${libdir}:$LD_LIBRARY_PATH
+ sed -i '/^LDLIBS/ s,$, \$\{BUILD_LDFLAGS},' ${S}/tools/fiptool/Makefile
+ sed -i '/^INCLUDE_PATHS/ s,$, \$\{BUILD_CFLAGS},' ${S}/tools/fiptool/Makefile
oe_runmake ${TFA_BUILD_TARGET}
}
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [meta-arm] [PATCH] trusted-firmware-a: fiptool build using BUILD_CFLAGS and BUILD_LDFLAGS
2020-06-11 14:17 [PATCH] trusted-firmware-a: fiptool build using BUILD_CFLAGS and BUILD_LDFLAGS Diego Sueiro
@ 2020-06-12 12:45 ` Jon Mason
2020-06-12 12:54 ` Diego Sueiro
0 siblings, 1 reply; 7+ messages in thread
From: Jon Mason @ 2020-06-12 12:45 UTC (permalink / raw)
To: Diego Sueiro; +Cc: meta-arm, nd
On Thu, Jun 11, 2020 at 03:17:04PM +0100, Diego Sueiro wrote:
> Since the TF-A fiptool is native tool we should be using the
> BUILD_CFLAGS and BUILD_LDFLAGS flags to proper build and execute it.
>
> Change-Id: I9634604dbc42ba7da85d9b9449f1ed94ecb38df2
> Issue-Id: SCM-888
> Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
Pulled into master.
Thanks,
Jon
> ---
> meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> index 6f64773..e57d3fe 100644
> --- a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> +++ b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> @@ -116,9 +116,8 @@ do_compile() {
> cd ${S}
>
> # These changes are needed to have the fiptool compiling and executing properly
> - sed -i '/^LDLIBS/ s,$, \-L${RECIPE_SYSROOT_NATIVE}${libdir},' ${S}/tools/fiptool/Makefile
> - sed -i '/^INCLUDE_PATHS/ s,$, \-I${RECIPE_SYSROOT_NATIVE}${includedir},' ${S}/tools/fiptool/Makefile
> - export LD_LIBRARY_PATH=${STAGING_DIR_NATIVE}${libdir}:$LD_LIBRARY_PATH
> + sed -i '/^LDLIBS/ s,$, \$\{BUILD_LDFLAGS},' ${S}/tools/fiptool/Makefile
> + sed -i '/^INCLUDE_PATHS/ s,$, \$\{BUILD_CFLAGS},' ${S}/tools/fiptool/Makefile
>
> oe_runmake ${TFA_BUILD_TARGET}
> }
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] trusted-firmware-a: fiptool build using BUILD_CFLAGS and BUILD_LDFLAGS
2020-06-12 12:45 ` [meta-arm] " Jon Mason
@ 2020-06-12 12:54 ` Diego Sueiro
2020-06-12 13:00 ` [meta-arm] " Jon Mason
2020-06-15 12:57 ` Jon Mason
0 siblings, 2 replies; 7+ messages in thread
From: Diego Sueiro @ 2020-06-12 12:54 UTC (permalink / raw)
To: meta-arm
On Fri, Jun 12, 2020 at 01:45 PM, Jon Mason wrote:
>
> On Thu, Jun 11, 2020 at 03:17:04PM +0100, Diego Sueiro wrote:
> > Since the TF-A fiptool is native tool we should be using the
> > BUILD_CFLAGS and BUILD_LDFLAGS flags to proper build and execute it.
> >
> > Change-Id: I9634604dbc42ba7da85d9b9449f1ed94ecb38df2
> > Issue-Id: SCM-888
> > Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
>
> Pulled into master.
Thanks.
Could you please backport it to dunfell?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-arm] [PATCH] trusted-firmware-a: fiptool build using BUILD_CFLAGS and BUILD_LDFLAGS
2020-06-12 12:54 ` Diego Sueiro
@ 2020-06-12 13:00 ` Jon Mason
2020-06-12 15:45 ` Joshua Watt
2020-06-15 12:57 ` Jon Mason
1 sibling, 1 reply; 7+ messages in thread
From: Jon Mason @ 2020-06-12 13:00 UTC (permalink / raw)
To: Diego Sueiro; +Cc: meta-arm, Joshua Watt, Denys Dmytriyenko
On Fri, Jun 12, 2020 at 05:54:07AM -0700, Diego Sueiro wrote:
> On Fri, Jun 12, 2020 at 01:45 PM, Jon Mason wrote:
>
> >
> > On Thu, Jun 11, 2020 at 03:17:04PM +0100, Diego Sueiro wrote:
> > > Since the TF-A fiptool is native tool we should be using the
> > > BUILD_CFLAGS and BUILD_LDFLAGS flags to proper build and execute it.
> > >
> > > Change-Id: I9634604dbc42ba7da85d9b9449f1ed94ecb38df2
> > > Issue-Id: SCM-888
> > > Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
> >
> > Pulled into master.
>
> Thanks.
>
> Could you please backport it to dunfell?
Yes, this seems like a good bug fix. I just want to make sure that
Denys and Joshua are aware, since it might break them.
Thanks,
Jon
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-arm] [PATCH] trusted-firmware-a: fiptool build using BUILD_CFLAGS and BUILD_LDFLAGS
2020-06-12 13:00 ` [meta-arm] " Jon Mason
@ 2020-06-12 15:45 ` Joshua Watt
2020-06-12 18:40 ` Denys Dmytriyenko
0 siblings, 1 reply; 7+ messages in thread
From: Joshua Watt @ 2020-06-12 15:45 UTC (permalink / raw)
To: Jon Mason, Diego Sueiro; +Cc: meta-arm, Denys Dmytriyenko
On 6/12/20 8:00 AM, Jon Mason wrote:
> On Fri, Jun 12, 2020 at 05:54:07AM -0700, Diego Sueiro wrote:
>> On Fri, Jun 12, 2020 at 01:45 PM, Jon Mason wrote:
>>
>>> On Thu, Jun 11, 2020 at 03:17:04PM +0100, Diego Sueiro wrote:
>>>> Since the TF-A fiptool is native tool we should be using the
>>>> BUILD_CFLAGS and BUILD_LDFLAGS flags to proper build and execute it.
>>>>
>>>> Change-Id: I9634604dbc42ba7da85d9b9449f1ed94ecb38df2
>>>> Issue-Id: SCM-888
>>>> Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
>>> Pulled into master.
>> Thanks.
>>
>> Could you please backport it to dunfell?
> Yes, this seems like a good bug fix. I just want to make sure that
> Denys and Joshua are aware, since it might break them.
Thanks for the heads up. I tested this on master with rock-pi-4 and
qemuarm-secureboot, and everything looks OK.
>
> Thanks,
> Jon
>
>
>>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-arm] [PATCH] trusted-firmware-a: fiptool build using BUILD_CFLAGS and BUILD_LDFLAGS
2020-06-12 15:45 ` Joshua Watt
@ 2020-06-12 18:40 ` Denys Dmytriyenko
0 siblings, 0 replies; 7+ messages in thread
From: Denys Dmytriyenko @ 2020-06-12 18:40 UTC (permalink / raw)
To: Joshua Watt; +Cc: Jon Mason, Diego Sueiro, meta-arm
On Fri, Jun 12, 2020 at 10:45:20AM -0500, Joshua Watt wrote:
>
> On 6/12/20 8:00 AM, Jon Mason wrote:
> >On Fri, Jun 12, 2020 at 05:54:07AM -0700, Diego Sueiro wrote:
> >>On Fri, Jun 12, 2020 at 01:45 PM, Jon Mason wrote:
> >>
> >>>On Thu, Jun 11, 2020 at 03:17:04PM +0100, Diego Sueiro wrote:
> >>>>Since the TF-A fiptool is native tool we should be using the
> >>>>BUILD_CFLAGS and BUILD_LDFLAGS flags to proper build and execute it.
> >>>>
> >>>>Change-Id: I9634604dbc42ba7da85d9b9449f1ed94ecb38df2
> >>>>Issue-Id: SCM-888
> >>>>Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
> >>>Pulled into master.
> >>Thanks.
> >>
> >>Could you please backport it to dunfell?
> >Yes, this seems like a good bug fix. I just want to make sure that
> >Denys and Joshua are aware, since it might break them.
>
> Thanks for the heads up. I tested this on master with rock-pi-4 and
> qemuarm-secureboot, and everything looks OK.
I also tested this change against TI platforms and seems fine. Thanks.
--
Denys
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-arm] [PATCH] trusted-firmware-a: fiptool build using BUILD_CFLAGS and BUILD_LDFLAGS
2020-06-12 12:54 ` Diego Sueiro
2020-06-12 13:00 ` [meta-arm] " Jon Mason
@ 2020-06-15 12:57 ` Jon Mason
1 sibling, 0 replies; 7+ messages in thread
From: Jon Mason @ 2020-06-15 12:57 UTC (permalink / raw)
To: Diego Sueiro; +Cc: meta-arm
On Fri, Jun 12, 2020 at 05:54:07AM -0700, Diego Sueiro wrote:
> On Fri, Jun 12, 2020 at 01:45 PM, Jon Mason wrote:
>
> >
> > On Thu, Jun 11, 2020 at 03:17:04PM +0100, Diego Sueiro wrote:
> > > Since the TF-A fiptool is native tool we should be using the
> > > BUILD_CFLAGS and BUILD_LDFLAGS flags to proper build and execute it.
> > >
> > > Change-Id: I9634604dbc42ba7da85d9b9449f1ed94ecb38df2
> > > Issue-Id: SCM-888
> > > Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
> >
> > Pulled into master.
>
> Thanks.
>
> Could you please backport it to dunfell?
Done.
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-06-15 12:57 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-11 14:17 [PATCH] trusted-firmware-a: fiptool build using BUILD_CFLAGS and BUILD_LDFLAGS Diego Sueiro
2020-06-12 12:45 ` [meta-arm] " Jon Mason
2020-06-12 12:54 ` Diego Sueiro
2020-06-12 13:00 ` [meta-arm] " Jon Mason
2020-06-12 15:45 ` Joshua Watt
2020-06-12 18:40 ` Denys Dmytriyenko
2020-06-15 12:57 ` Jon Mason
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.