From: Wolfram Sang <wsa@kernel.org>
To: linux-pm@vger.kernel.org, "Rafael J. Wysocki" <rafael@kernel.org>
Cc: linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: RFC: a failing pm_runtime_get increases the refcnt?
Date: Sun, 14 Jun 2020 11:07:51 +0200 [thread overview]
Message-ID: <20200614090751.GA2878@kunai> (raw)
[-- Attachment #1: Type: text/plain, Size: 503 bytes --]
Hi Linux-PM,
both in the I2C subsystem and also for Renesas drivers I maintain, I am
starting to get boilerplate patches doing some pm_runtime_put_* variant
because a failing pm_runtime_get is supposed to increase the ref
counters? Really? This feels wrong and unintuitive to me. I expect there
has been a discussion around it but I couldn't find it. I wonder why we
don't fix the code where the incremented refcount is expected for some
reason.
Can I have some pointers please?
Thanks,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next reply other threads:[~2020-06-14 9:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 9:07 Wolfram Sang [this message]
2020-06-14 9:34 ` RFC: a failing pm_runtime_get increases the refcnt? Andy Shevchenko
2020-06-14 9:42 ` Andy Shevchenko
2020-06-14 10:00 ` Geert Uytterhoeven
2020-06-14 10:04 ` Geert Uytterhoeven
2020-06-14 10:44 ` Andy Shevchenko
2020-06-14 12:42 ` Andy Shevchenko
2020-06-14 13:59 ` Rafael J. Wysocki
2020-06-14 14:07 ` Wolfram Sang
2020-06-30 19:48 ` Wolfram Sang
2020-06-14 13:50 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200614090751.GA2878@kunai \
--to=wsa@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.