All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: "Alexander A. Klimov" <grandmaster@al2klimov.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
	Jozsef Kadlecsik <kadlec@netfilter.org>,
	Florian Westphal <fw@strlen.de>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Andrea Parri <parri.andrea@gmail.com>,
	Will Deacon <will@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Boqun Feng <boqun.feng@gmail.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	David Howells <dhowells@redhat.com>,
	Jade Alglave <j.alglave@ucl.ac.uk>,
	Luc Maranget <luc.maranget@inria.fr>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Akira Yokosawa <akiyks@gmail.com>,
	Daniel Lustig <dlustig@nvidia.com>,
	linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org,
	coreteam@netfilter.org, netdev@vger.kernel.org
Subject: Re: Good idea to rename files in include/uapi/ ?
Date: Sun, 14 Jun 2020 22:34:56 +0200	[thread overview]
Message-ID: <20200614223456.13807a00@redhat.com> (raw)
In-Reply-To: <9feded75-4b45-2821-287b-af00ec5f910f@al2klimov.de>

On Sun, 14 Jun 2020 21:41:17 +0200
"Alexander A. Klimov" <grandmaster@al2klimov.de> wrote:

> Hello there!
> 
> At the moment one can't checkout a clean working directory w/o any 
> changed files on a case-insensitive FS as the following file names have 
> lower-case duplicates:

They are not duplicates: matching extensions are lowercase, target
extensions are uppercase. DSCP is the extension to set DSCP bits, dscp
is the extension to match on those packet bits.

> ➜  linux git:(96144c58abe7) git ls-files |sort -f |uniq -id
> include/uapi/linux/netfilter/xt_CONNMARK.h
> include/uapi/linux/netfilter/xt_DSCP.h
> include/uapi/linux/netfilter/xt_MARK.h
> include/uapi/linux/netfilter/xt_RATEEST.h
> include/uapi/linux/netfilter/xt_TCPMSS.h
> include/uapi/linux/netfilter_ipv4/ipt_ECN.h
> include/uapi/linux/netfilter_ipv4/ipt_TTL.h
> include/uapi/linux/netfilter_ipv6/ip6t_HL.h
> net/netfilter/xt_DSCP.c
> net/netfilter/xt_HL.c
> net/netfilter/xt_RATEEST.c
> net/netfilter/xt_TCPMSS.c
> tools/memory-model/litmus-tests/Z6.0+pooncelock+poonceLock+pombonce.litmus
> ➜  linux git:(96144c58abe7)
> 
> Also even on a case-sensitive one VIm seems to have trouble with editing 
> both case-insensitively equal files at the same time.

...what trouble exactly?

> I was going to make a patch renaming the respective duplicates, but I'm 
> not sure:
> 
> *Is it a good idea to rename files in include/uapi/ ?*

I'm not sure it's a good idea to even use git on a case-insensitive
filesystem. I'm curious, what is your use case?

-- 
Stefano

WARNING: multiple messages have this Message-ID (diff)
From: Stefano Brivio <sbrivio@redhat.com>
To: "Alexander A. Klimov" <grandmaster@al2klimov.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
	Jozsef Kadlecsik <kadlec@netfilter.org>,
	Florian Westphal <fw@strlen.de>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Andrea Parri <parri.andrea@gmail.com>,
	Will Deacon <will@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Boqun Feng <boqun.feng@gmail.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	David Howells <dhowells@redhat.com>,
	Jade Alglave <j.alglave@ucl.ac.uk>,
	Luc Maranget <luc.maranget@inria.fr>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Akira Yokosawa <akiyks@gmail.com>,
	Daniel Lustig <dlustig@nvidia.com>,
	linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org,
	coreteam@netfilter.org, netdev@vger.kernel.org,
	linux-arch@vger.kernel.org
Subject: Re: Good idea to rename files in include/uapi/ ?
Date: Sun, 14 Jun 2020 22:34:56 +0200	[thread overview]
Message-ID: <20200614223456.13807a00@redhat.com> (raw)
Message-ID: <20200614203456.xGJP7NfwUPZcwzik0PUj_XTz38Uo8lUeOJF03CMkrhM@z> (raw)
In-Reply-To: <9feded75-4b45-2821-287b-af00ec5f910f@al2klimov.de>

On Sun, 14 Jun 2020 21:41:17 +0200
"Alexander A. Klimov" <grandmaster@al2klimov.de> wrote:

> Hello there!
> 
> At the moment one can't checkout a clean working directory w/o any 
> changed files on a case-insensitive FS as the following file names have 
> lower-case duplicates:

They are not duplicates: matching extensions are lowercase, target
extensions are uppercase. DSCP is the extension to set DSCP bits, dscp
is the extension to match on those packet bits.

> ➜  linux git:(96144c58abe7) git ls-files |sort -f |uniq -id
> include/uapi/linux/netfilter/xt_CONNMARK.h
> include/uapi/linux/netfilter/xt_DSCP.h
> include/uapi/linux/netfilter/xt_MARK.h
> include/uapi/linux/netfilter/xt_RATEEST.h
> include/uapi/linux/netfilter/xt_TCPMSS.h
> include/uapi/linux/netfilter_ipv4/ipt_ECN.h
> include/uapi/linux/netfilter_ipv4/ipt_TTL.h
> include/uapi/linux/netfilter_ipv6/ip6t_HL.h
> net/netfilter/xt_DSCP.c
> net/netfilter/xt_HL.c
> net/netfilter/xt_RATEEST.c
> net/netfilter/xt_TCPMSS.c
> tools/memory-model/litmus-tests/Z6.0+pooncelock+poonceLock+pombonce.litmus
> ➜  linux git:(96144c58abe7)
> 
> Also even on a case-sensitive one VIm seems to have trouble with editing 
> both case-insensitively equal files at the same time.

...what trouble exactly?

> I was going to make a patch renaming the respective duplicates, but I'm 
> not sure:
> 
> *Is it a good idea to rename files in include/uapi/ ?*

I'm not sure it's a good idea to even use git on a case-insensitive
filesystem. I'm curious, what is your use case?

-- 
Stefano

  parent reply	other threads:[~2020-06-14 20:34 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-14 19:41 Good idea to rename files in include/uapi/ ? Alexander A. Klimov
2020-06-14 19:41 ` Alexander A. Klimov
2020-06-14 20:19 ` David Howells
2020-06-14 20:19   ` David Howells
2020-06-14 21:08   ` Jan Engelhardt
2020-06-14 21:08     ` Jan Engelhardt
2020-06-14 22:01     ` Pablo Neira Ayuso
2020-06-14 22:01       ` Pablo Neira Ayuso
2020-06-14 23:34     ` Alexander A. Klimov
2020-06-14 23:34       ` Alexander A. Klimov
2020-06-22 11:37       ` Jan Engelhardt
2020-06-22 11:37         ` Jan Engelhardt
2020-06-22 12:07         ` Pablo Neira Ayuso
2020-06-22 12:07           ` Pablo Neira Ayuso
2020-06-22 18:06         ` Alexander A. Klimov
2020-06-22 18:06           ` Alexander A. Klimov
2020-06-14 20:34 ` Stefano Brivio [this message]
2020-06-14 20:34   ` Stefano Brivio
2020-06-14 23:07   ` Alexander A. Klimov
2020-06-14 23:07     ` Alexander A. Klimov
2020-06-15 11:11     ` Geert Uytterhoeven
2020-06-15 11:11       ` Geert Uytterhoeven
2020-06-14 22:47 ` Al Viro
2020-06-14 22:47   ` Al Viro
2020-06-15 11:12 ` Geert Uytterhoeven
2020-06-15 11:12   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200614223456.13807a00@redhat.com \
    --to=sbrivio@redhat.com \
    --cc=akiyks@gmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=dlustig@nvidia.com \
    --cc=fw@strlen.de \
    --cc=grandmaster@al2klimov.de \
    --cc=j.alglave@ucl.ac.uk \
    --cc=kadlec@netfilter.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luc.maranget@inria.fr \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=npiggin@gmail.com \
    --cc=pablo@netfilter.org \
    --cc=parri.andrea@gmail.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=stern@rowland.harvard.edu \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.