* [PATCH] ath11k: removing redundant reo unlock followed by immediate lock
@ 2020-06-09 14:37 ` Sowmiya Sree Elavalagan
0 siblings, 0 replies; 4+ messages in thread
From: Sowmiya Sree Elavalagan @ 2020-06-09 14:37 UTC (permalink / raw)
To: ath11k; +Cc: Sowmiya Sree Elavalagan, linux-wireless
Removed reo cmd lock and unlock which was acquiring the lock immediately
after unlock. Done for code clean up.
Signed-off-by: Sowmiya Sree Elavalagan <ssreeela@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/dp_rx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index a54610d..a010cf7 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -653,10 +653,8 @@ static void ath11k_dp_rx_tid_del_func(struct ath11k_dp *dp, void *ctx,
spin_lock_bh(&dp->reo_cmd_lock);
list_add_tail(&elem->list, &dp->reo_cmd_cache_flush_list);
dp->reo_cmd_cache_flush_count++;
- spin_unlock_bh(&dp->reo_cmd_lock);
/* Flush and invalidate aged REO desc from HW cache */
- spin_lock_bh(&dp->reo_cmd_lock);
list_for_each_entry_safe(elem, tmp, &dp->reo_cmd_cache_flush_list,
list) {
if (dp->reo_cmd_cache_flush_count > DP_REO_DESC_FREE_THRESHOLD ||
--
2.7.4
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ath11k: removing redundant reo unlock followed by immediate lock
@ 2020-06-09 14:37 ` Sowmiya Sree Elavalagan
0 siblings, 0 replies; 4+ messages in thread
From: Sowmiya Sree Elavalagan @ 2020-06-09 14:37 UTC (permalink / raw)
To: ath11k; +Cc: linux-wireless, Sowmiya Sree Elavalagan
Removed reo cmd lock and unlock which was acquiring the lock immediately
after unlock. Done for code clean up.
Signed-off-by: Sowmiya Sree Elavalagan <ssreeela@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/dp_rx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index a54610d..a010cf7 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -653,10 +653,8 @@ static void ath11k_dp_rx_tid_del_func(struct ath11k_dp *dp, void *ctx,
spin_lock_bh(&dp->reo_cmd_lock);
list_add_tail(&elem->list, &dp->reo_cmd_cache_flush_list);
dp->reo_cmd_cache_flush_count++;
- spin_unlock_bh(&dp->reo_cmd_lock);
/* Flush and invalidate aged REO desc from HW cache */
- spin_lock_bh(&dp->reo_cmd_lock);
list_for_each_entry_safe(elem, tmp, &dp->reo_cmd_cache_flush_list,
list) {
if (dp->reo_cmd_cache_flush_count > DP_REO_DESC_FREE_THRESHOLD ||
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ath11k: removing redundant reo unlock followed by immediate lock
2020-06-09 14:37 ` Sowmiya Sree Elavalagan
(?)
@ 2020-06-15 14:29 ` Kalle Valo
-1 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-06-15 14:29 UTC (permalink / raw)
To: Sowmiya Sree Elavalagan; +Cc: linux-wireless, ath11k
Sowmiya Sree Elavalagan <ssreeela@codeaurora.org> wrote:
> Removed reo cmd lock and unlock which was acquiring the lock immediately
> after unlock. Done for code clean up.
>
> Signed-off-by: Sowmiya Sree Elavalagan <ssreeela@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
8cacd0389c4f ath11k: removing redundant reo unlock followed by immediate lock
--
https://patchwork.kernel.org/patch/11595859/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ath11k: removing redundant reo unlock followed by immediate lock
2020-06-09 14:37 ` Sowmiya Sree Elavalagan
(?)
(?)
@ 2020-06-15 14:29 ` Kalle Valo
-1 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-06-15 14:29 UTC (permalink / raw)
To: Sowmiya Sree Elavalagan; +Cc: ath11k, linux-wireless, Sowmiya Sree Elavalagan
Sowmiya Sree Elavalagan <ssreeela@codeaurora.org> wrote:
> Removed reo cmd lock and unlock which was acquiring the lock immediately
> after unlock. Done for code clean up.
>
> Signed-off-by: Sowmiya Sree Elavalagan <ssreeela@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
8cacd0389c4f ath11k: removing redundant reo unlock followed by immediate lock
--
https://patchwork.kernel.org/patch/11595859/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-15 14:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-09 14:37 [PATCH] ath11k: removing redundant reo unlock followed by immediate lock Sowmiya Sree Elavalagan
2020-06-09 14:37 ` Sowmiya Sree Elavalagan
2020-06-15 14:29 ` Kalle Valo
2020-06-15 14:29 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.