From: Sahitya Tummala <stummala@codeaurora.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Jaegeuk Kim <jaegeuk@kernel.org>,
Satya Tangirala <satyat@google.com>
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix use-after-free when accessing bio->bi_crypt_context
Date: Tue, 16 Jun 2020 07:06:22 +0530 [thread overview]
Message-ID: <20200616013622.GC2916@codeaurora.org> (raw)
In-Reply-To: <20200615154720.GA902@sol.localdomain>
On Mon, Jun 15, 2020 at 08:47:20AM -0700, Eric Biggers wrote:
> On Mon, Jun 15, 2020 at 03:23:16PM +0530, Sahitya Tummala wrote:
> > >
> > > Should I fold this change into the original patch? Or keep it as a
> > > separate patch when I send out the fscrypt/f2fs inline encryption
> > > patches?
> >
> > It may be good to keep it seperate as we already have the base FBE patches in
> > several downstream kernels, so this fix can be applied easily. But I will
> > leave it up to you to take a call on this.
> >
>
> We should fold it in because the patch this fixes isn't applied upstream yet.
>
> We'll need to submit this as a separate fix to the Android common kernels
> because they already have a previous version of the inline encryption patchset.
> (I assume that's where you have the code from.) But that doesn't affect what we
> do upstream.
Sure, no concerns from my side. It can be merged into the original series.
Thanks,
>
> - Eric
--
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Sahitya Tummala <stummala@codeaurora.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Satya Tangirala <satyat@google.com>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <yuchao0@huawei.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, stummala@codeaurora.org
Subject: Re: [PATCH] f2fs: fix use-after-free when accessing bio->bi_crypt_context
Date: Tue, 16 Jun 2020 07:06:22 +0530 [thread overview]
Message-ID: <20200616013622.GC2916@codeaurora.org> (raw)
In-Reply-To: <20200615154720.GA902@sol.localdomain>
On Mon, Jun 15, 2020 at 08:47:20AM -0700, Eric Biggers wrote:
> On Mon, Jun 15, 2020 at 03:23:16PM +0530, Sahitya Tummala wrote:
> > >
> > > Should I fold this change into the original patch? Or keep it as a
> > > separate patch when I send out the fscrypt/f2fs inline encryption
> > > patches?
> >
> > It may be good to keep it seperate as we already have the base FBE patches in
> > several downstream kernels, so this fix can be applied easily. But I will
> > leave it up to you to take a call on this.
> >
>
> We should fold it in because the patch this fixes isn't applied upstream yet.
>
> We'll need to submit this as a separate fix to the Android common kernels
> because they already have a previous version of the inline encryption patchset.
> (I assume that's where you have the code from.) But that doesn't affect what we
> do upstream.
Sure, no concerns from my side. It can be merged into the original series.
Thanks,
>
> - Eric
--
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2020-06-16 1:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 3:59 [f2fs-dev] [PATCH] f2fs: fix use-after-free when accessing bio->bi_crypt_context Sahitya Tummala
2020-06-15 5:00 ` Eric Biggers
2020-06-15 6:16 ` Satya Tangirala via Linux-f2fs-devel
2020-06-15 9:53 ` Sahitya Tummala
2020-06-15 9:53 ` Sahitya Tummala
2020-06-15 15:47 ` [f2fs-dev] " Eric Biggers
2020-06-15 15:47 ` Eric Biggers
2020-06-16 1:36 ` Sahitya Tummala [this message]
2020-06-16 1:36 ` Sahitya Tummala
2020-06-15 9:48 ` [f2fs-dev] " Sahitya Tummala
2020-06-15 9:48 ` Sahitya Tummala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616013622.GC2916@codeaurora.org \
--to=stummala@codeaurora.org \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=satyat@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.