From: Kalle Valo <kvalo@codeaurora.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: 24601deerej@gmail.com, linux-wireless@vger.kernel.org,
sven@narfation.org, ath10k@lists.infradead.org,
markus.theil@tu-ilmenau.de
Subject: Re: [PATCH v6] ath10k: provide survey info as accumulated data
Date: Tue, 16 Jun 2020 08:16:11 +0000 (UTC) [thread overview]
Message-ID: <20200616081611.32C3CC433CB@smtp.codeaurora.org> (raw)
In-Reply-To: <1592232686-28712-1-git-send-email-kvalo@codeaurora.org>
Kalle Valo <kvalo@codeaurora.org> wrote:
> It is expected that the returned counters by .get_survey are monotonic
> increasing. But the data from ath10k gets reset to zero regularly. Channel
> active/busy time are then showing incorrect values (less than previous or
> sometimes zero) for the currently active channel during successive survey
> dump commands.
>
> example:
>
> $ iw dev wlan0 survey dump
> Survey data from wlan0
> frequency: 5180 MHz [in use]
> channel active time: 54995 ms
> channel busy time: 432 ms
> channel receive time: 0 ms
> channel transmit time: 59 ms
> ...
>
> $ iw dev wlan0 survey dump
> Survey data from wlan0
> frequency: 5180 MHz [in use]
> channel active time: 32592 ms
> channel busy time: 254 ms
> channel receive time: 0 ms
> channel transmit time: 0 ms
> ...
>
> The correct way to handle this is to use the non-clearing
> WMI_BSS_SURVEY_REQ_TYPE_READ wmi_bss_survey_req_type. The firmware will
> then accumulate the survey data and handle wrap arounds.
>
> Tested-on: QCA9984 hw1.0 10.4-3.5.3-00057
> Tested-on: QCA988X hw2.0 10.2.4-1.0-00047
> Tested-on: QCA9888 hw2.0 10.4-3.9.0.2-00024
> Tested-on: QCA4019 hw1.0 10.4-3.6-00140
>
> Fixes: fa7937e3d5c2 ("ath10k: update bss channel survey information")
> Signed-off-by: Venkateswara Naralasetty <vnaralas@codeaurora.org>
> Tested-by: Markus Theil <markus.theil@tu-ilmenau.de>
> Tested-by: John Deere <24601deerej@gmail.com>
> [sven@narfation.org: adjust commit message]
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
720e5c03e5cb ath10k: provide survey info as accumulated data
--
https://patchwork.kernel.org/patch/11605281/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2020-06-16 8:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 14:51 [PATCH v6] ath10k: provide survey info as accumulated data Kalle Valo
2020-06-15 14:51 ` Kalle Valo
2020-06-16 8:16 ` Kalle Valo
2020-06-16 8:16 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616081611.32C3CC433CB@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=24601deerej@gmail.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=markus.theil@tu-ilmenau.de \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.