* [PATCH] thermal: ti-soc-thermal: Fix reversed condition in ti_thermal_expose_sensor()
@ 2020-06-16 9:19 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2020-06-16 9:19 UTC (permalink / raw)
To: Eduardo Valentin, Sudip Mukherjee
Cc: Keerthy, Zhang Rui, Daniel Lezcano, Amit Kucheria, linux-pm,
linux-omap, linux-kernel, kernel-janitors
This condition is reversed and will cause breakage.
Fixes: 7440f518dad9 ("thermal/drivers/ti-soc-thermal: Avoid dereferencing ERR_PTR")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
index 85776db4bf34..2ce4b19f312a 100644
--- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
+++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
@@ -169,7 +169,7 @@ int ti_thermal_expose_sensor(struct ti_bandgap *bgp, int id,
data = ti_bandgap_get_sensor_data(bgp, id);
- if (!IS_ERR_OR_NULL(data))
+ if (IS_ERR_OR_NULL(data))
data = ti_thermal_build_data(bgp, id);
if (!data)
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] thermal: ti-soc-thermal: Fix reversed condition in ti_thermal_expose_sensor()
@ 2020-06-16 9:19 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2020-06-16 9:19 UTC (permalink / raw)
To: Eduardo Valentin, Sudip Mukherjee
Cc: Keerthy, Zhang Rui, Daniel Lezcano, Amit Kucheria, linux-pm,
linux-omap, linux-kernel, kernel-janitors
This condition is reversed and will cause breakage.
Fixes: 7440f518dad9 ("thermal/drivers/ti-soc-thermal: Avoid dereferencing ERR_PTR")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
index 85776db4bf34..2ce4b19f312a 100644
--- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
+++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
@@ -169,7 +169,7 @@ int ti_thermal_expose_sensor(struct ti_bandgap *bgp, int id,
data = ti_bandgap_get_sensor_data(bgp, id);
- if (!IS_ERR_OR_NULL(data))
+ if (IS_ERR_OR_NULL(data))
data = ti_thermal_build_data(bgp, id);
if (!data)
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] thermal: ti-soc-thermal: Fix reversed condition in ti_thermal_expose_sensor()
2020-06-16 9:19 ` Dan Carpenter
@ 2020-07-21 13:13 ` Daniel Lezcano
-1 siblings, 0 replies; 4+ messages in thread
From: Daniel Lezcano @ 2020-07-21 13:13 UTC (permalink / raw)
To: Dan Carpenter, Eduardo Valentin, Sudip Mukherjee
Cc: Keerthy, Zhang Rui, Amit Kucheria, linux-pm, linux-omap,
linux-kernel, kernel-janitors
On 16/06/2020 11:19, Dan Carpenter wrote:
> This condition is reversed and will cause breakage.
>
> Fixes: 7440f518dad9 ("thermal/drivers/ti-soc-thermal: Avoid dereferencing ERR_PTR")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Applied.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] thermal: ti-soc-thermal: Fix reversed condition in ti_thermal_expose_sensor()
@ 2020-07-21 13:13 ` Daniel Lezcano
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Lezcano @ 2020-07-21 13:13 UTC (permalink / raw)
To: Dan Carpenter, Eduardo Valentin, Sudip Mukherjee
Cc: Keerthy, Zhang Rui, Amit Kucheria, linux-pm, linux-omap,
linux-kernel, kernel-janitors
On 16/06/2020 11:19, Dan Carpenter wrote:
> This condition is reversed and will cause breakage.
>
> Fixes: 7440f518dad9 ("thermal/drivers/ti-soc-thermal: Avoid dereferencing ERR_PTR")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Applied.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-21 13:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-16 9:19 [PATCH] thermal: ti-soc-thermal: Fix reversed condition in ti_thermal_expose_sensor() Dan Carpenter
2020-06-16 9:19 ` Dan Carpenter
2020-07-21 13:13 ` Daniel Lezcano
2020-07-21 13:13 ` Daniel Lezcano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.