From: Dan Carpenter <dan.carpenter@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: David Airlie <airlied@linux.ie>,
Animesh Manna <animesh.manna@intel.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
intel-gfx@lists.freedesktop.org,
Maarten Lankhorst <maarten.lankhorst@intel.com>
Subject: Re: [PATCH] drm/i915/display: fix missing null check on allocated dsb object
Date: Tue, 16 Jun 2020 11:54:59 +0000 [thread overview]
Message-ID: <20200616115459.GN4151@kadam> (raw)
In-Reply-To: <20200616114221.73971-1-colin.king@canonical.com>
On Tue, Jun 16, 2020 at 12:42:21PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently there is no null check for a failed memory allocation
> on the dsb object and without this a null pointer dereference
> error can occur. Fix this by adding a null check.
>
> Note: added a drm_err message in keeping with the error message style
> in the function.
Don't give in to peer pressure! That's like being a lemming when Disney
film makers come to push you off the cliff to create the 1958 nature
film "White Wilderness".
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: David Airlie <airlied@linux.ie>,
Animesh Manna <animesh.manna@intel.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
intel-gfx@lists.freedesktop.org,
Maarten Lankhorst <maarten.lankhorst@intel.com>
Subject: Re: [PATCH] drm/i915/display: fix missing null check on allocated dsb object
Date: Tue, 16 Jun 2020 14:54:59 +0300 [thread overview]
Message-ID: <20200616115459.GN4151@kadam> (raw)
In-Reply-To: <20200616114221.73971-1-colin.king@canonical.com>
On Tue, Jun 16, 2020 at 12:42:21PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently there is no null check for a failed memory allocation
> on the dsb object and without this a null pointer dereference
> error can occur. Fix this by adding a null check.
>
> Note: added a drm_err message in keeping with the error message style
> in the function.
Don't give in to peer pressure! That's like being a lemming when Disney
film makers come to push you off the cliff to create the 1958 nature
film "White Wilderness".
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
Maarten Lankhorst <maarten.lankhorst@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: fix missing null check on allocated dsb object
Date: Tue, 16 Jun 2020 14:54:59 +0300 [thread overview]
Message-ID: <20200616115459.GN4151@kadam> (raw)
In-Reply-To: <20200616114221.73971-1-colin.king@canonical.com>
On Tue, Jun 16, 2020 at 12:42:21PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently there is no null check for a failed memory allocation
> on the dsb object and without this a null pointer dereference
> error can occur. Fix this by adding a null check.
>
> Note: added a drm_err message in keeping with the error message style
> in the function.
Don't give in to peer pressure! That's like being a lemming when Disney
film makers come to push you off the cliff to create the 1958 nature
film "White Wilderness".
regards,
dan carpenter
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Animesh Manna <animesh.manna@intel.com>,
Maarten Lankhorst <maarten.lankhorst@intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i915/display: fix missing null check on allocated dsb object
Date: Tue, 16 Jun 2020 14:54:59 +0300 [thread overview]
Message-ID: <20200616115459.GN4151@kadam> (raw)
In-Reply-To: <20200616114221.73971-1-colin.king@canonical.com>
On Tue, Jun 16, 2020 at 12:42:21PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently there is no null check for a failed memory allocation
> on the dsb object and without this a null pointer dereference
> error can occur. Fix this by adding a null check.
>
> Note: added a drm_err message in keeping with the error message style
> in the function.
Don't give in to peer pressure! That's like being a lemming when Disney
film makers come to push you off the cliff to create the 1958 nature
film "White Wilderness".
regards,
dan carpenter
next prev parent reply other threads:[~2020-06-16 11:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 11:42 [PATCH] drm/i915/display: fix missing null check on allocated dsb object Colin King
2020-06-16 11:42 ` Colin King
2020-06-16 11:42 ` [Intel-gfx] " Colin King
2020-06-16 11:42 ` Colin King
2020-06-16 11:54 ` Dan Carpenter [this message]
2020-06-16 11:54 ` Dan Carpenter
2020-06-16 11:54 ` [Intel-gfx] " Dan Carpenter
2020-06-16 11:54 ` Dan Carpenter
2020-06-16 11:56 ` Colin Ian King
2020-06-16 11:56 ` Colin Ian King
2020-06-16 11:56 ` [Intel-gfx] " Colin Ian King
2020-06-16 11:56 ` Colin Ian King
2020-06-30 11:28 ` Jani Nikula
2020-06-30 11:28 ` Jani Nikula
2020-06-30 11:28 ` [Intel-gfx] " Jani Nikula
2020-06-30 11:28 ` Jani Nikula
2020-06-16 19:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-06-16 19:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-06-16 21:33 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616115459.GN4151@kadam \
--to=dan.carpenter@oracle.com \
--cc=airlied@linux.ie \
--cc=animesh.manna@intel.com \
--cc=colin.king@canonical.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.