From: Sasha Levin <sashal@kernel.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-hyperv@vger.kernel.org, sthemmin@microsoft.com,
tvrtko.ursulin@intel.com, gregkh@linuxfoundation.org,
haiyangz@microsoft.com, spronovo@microsoft.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
chris@chris-wilson.co.uk, linux-fbdev@vger.kernel.org,
wei.liu@kernel.org, Thomas Zimmermann <tzimmermann@suse.de>,
iourit@microsoft.com, alexander.deucher@amd.com,
kys@microsoft.com, Hawking.Zhang@amd.com
Subject: Re: [RFC PATCH 0/4] DirectX on Linux
Date: Tue, 16 Jun 2020 13:28:19 +0000 [thread overview]
Message-ID: <20200616132819.GP1931@sasha-vm> (raw)
In-Reply-To: <20200616105112.GC1718@bug>
On Tue, Jun 16, 2020 at 12:51:13PM +0200, Pavel Machek wrote:
>Hi!
>
>> > The driver creates the /dev/dxg device, which can be opened by user mode
>> > application and handles their ioctls. The IOCTL interface to the driver
>> > is defined in dxgkmthk.h (Dxgkrnl Graphics Port Driver ioctl
>> > definitions). The interface matches the D3DKMT interface on Windows.
>> > Ioctls are implemented in ioctl.c.
>>
>> Echoing what others said, you're not making a DRM driver. The driver should live outside
>> of the DRM code.
>>
>
>Actually, this sounds to me like "this should not be merged into linux kernel". I mean,
>we already have DRM API on Linux. We don't want another one, do we?
This driver doesn't have any display functionality.
>And at the very least... this misses API docs for /dev/dxg. Code can't really
>be reviewed without that.
The docs live here: https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/d3dkmthk/
--
Thanks,
Sasha
WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <sashal@kernel.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
alexander.deucher@amd.com, chris@chris-wilson.co.uk,
ville.syrjala@linux.intel.com, Hawking.Zhang@amd.com,
tvrtko.ursulin@intel.com, linux-kernel@vger.kernel.org,
linux-hyperv@vger.kernel.org, kys@microsoft.com,
haiyangz@microsoft.com, sthemmin@microsoft.com,
wei.liu@kernel.org, spronovo@microsoft.com, iourit@microsoft.com,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
gregkh@linuxfoundation.org
Subject: Re: [RFC PATCH 0/4] DirectX on Linux
Date: Tue, 16 Jun 2020 09:28:19 -0400 [thread overview]
Message-ID: <20200616132819.GP1931@sasha-vm> (raw)
In-Reply-To: <20200616105112.GC1718@bug>
On Tue, Jun 16, 2020 at 12:51:13PM +0200, Pavel Machek wrote:
>Hi!
>
>> > The driver creates the /dev/dxg device, which can be opened by user mode
>> > application and handles their ioctls. The IOCTL interface to the driver
>> > is defined in dxgkmthk.h (Dxgkrnl Graphics Port Driver ioctl
>> > definitions). The interface matches the D3DKMT interface on Windows.
>> > Ioctls are implemented in ioctl.c.
>>
>> Echoing what others said, you're not making a DRM driver. The driver should live outside
>> of the DRM code.
>>
>
>Actually, this sounds to me like "this should not be merged into linux kernel". I mean,
>we already have DRM API on Linux. We don't want another one, do we?
This driver doesn't have any display functionality.
>And at the very least... this misses API docs for /dev/dxg. Code can't really
>be reviewed without that.
The docs live here: https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/d3dkmthk/
--
Thanks,
Sasha
WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <sashal@kernel.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-hyperv@vger.kernel.org, sthemmin@microsoft.com,
tvrtko.ursulin@intel.com, gregkh@linuxfoundation.org,
haiyangz@microsoft.com, spronovo@microsoft.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
chris@chris-wilson.co.uk, linux-fbdev@vger.kernel.org,
wei.liu@kernel.org, Thomas Zimmermann <tzimmermann@suse.de>,
iourit@microsoft.com, alexander.deucher@amd.com,
kys@microsoft.com, Hawking.Zhang@amd.com
Subject: Re: [RFC PATCH 0/4] DirectX on Linux
Date: Tue, 16 Jun 2020 09:28:19 -0400 [thread overview]
Message-ID: <20200616132819.GP1931@sasha-vm> (raw)
In-Reply-To: <20200616105112.GC1718@bug>
On Tue, Jun 16, 2020 at 12:51:13PM +0200, Pavel Machek wrote:
>Hi!
>
>> > The driver creates the /dev/dxg device, which can be opened by user mode
>> > application and handles their ioctls. The IOCTL interface to the driver
>> > is defined in dxgkmthk.h (Dxgkrnl Graphics Port Driver ioctl
>> > definitions). The interface matches the D3DKMT interface on Windows.
>> > Ioctls are implemented in ioctl.c.
>>
>> Echoing what others said, you're not making a DRM driver. The driver should live outside
>> of the DRM code.
>>
>
>Actually, this sounds to me like "this should not be merged into linux kernel". I mean,
>we already have DRM API on Linux. We don't want another one, do we?
This driver doesn't have any display functionality.
>And at the very least... this misses API docs for /dev/dxg. Code can't really
>be reviewed without that.
The docs live here: https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/d3dkmthk/
--
Thanks,
Sasha
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-06-16 13:28 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 16:32 [RFC PATCH 0/4] DirectX on Linux Sasha Levin
2020-05-19 16:32 ` Sasha Levin
2020-05-19 16:32 ` Sasha Levin
2020-05-19 16:32 ` [RFC PATCH 1/4] gpu: dxgkrnl: core code Sasha Levin
2020-05-19 16:32 ` Sasha Levin
2020-05-19 17:19 ` Greg KH
2020-05-19 17:19 ` Greg KH
2020-05-19 17:19 ` Greg KH
2020-05-19 17:21 ` Greg KH
2020-05-19 17:21 ` Greg KH
2020-05-19 17:21 ` Greg KH
2020-05-19 17:45 ` Sasha Levin
2020-05-19 17:45 ` Sasha Levin
2020-05-19 17:45 ` Sasha Levin
2020-05-20 6:13 ` Greg KH
2020-05-20 6:13 ` Greg KH
2020-05-20 6:13 ` Greg KH
2020-05-19 17:27 ` Greg KH
2020-05-19 17:27 ` Greg KH
2020-05-19 17:27 ` Greg KH
2020-05-19 16:32 ` [RFC PATCH 2/4] gpu: dxgkrnl: hook up dxgkrnl Sasha Levin
2020-05-19 16:32 ` Sasha Levin
2020-05-19 16:32 ` Sasha Levin
2020-05-19 23:27 ` kbuild test robot
2020-05-19 23:27 ` kbuild test robot
2020-05-20 7:05 ` kbuild test robot
2020-05-22 8:10 ` Dan Carpenter
2020-05-22 8:10 ` [kbuild] " Dan Carpenter
2020-05-30 13:48 ` kbuild test robot
2020-05-19 16:32 ` [RFC PATCH 3/4] Drivers: hv: vmbus: " Sasha Levin
2020-05-19 16:32 ` Sasha Levin
2020-05-19 16:32 ` Sasha Levin
2020-05-19 16:32 ` [RFC PATCH 4/4] gpu: dxgkrnl: create a MAINTAINERS entry Sasha Levin
2020-05-19 16:32 ` Sasha Levin
2020-05-19 16:32 ` Sasha Levin
2020-05-19 19:21 ` [RFC PATCH 0/4] DirectX on Linux Daniel Vetter
2020-05-19 19:21 ` Daniel Vetter
2020-05-19 19:21 ` Daniel Vetter
2020-05-19 20:36 ` Sasha Levin
2020-05-19 20:36 ` Sasha Levin
2020-05-19 20:36 ` Sasha Levin
2020-05-20 10:37 ` Jan Engelhardt
2020-05-20 10:37 ` Jan Engelhardt
2020-05-20 10:37 ` Jan Engelhardt
2020-06-28 23:39 ` James Hilliard
2020-06-28 23:39 ` James Hilliard
2020-06-28 23:39 ` James Hilliard
2020-05-19 22:42 ` Dave Airlie
2020-05-19 22:42 ` Dave Airlie
2020-05-19 22:42 ` Dave Airlie
2020-05-19 23:01 ` Daniel Vetter
2020-05-19 23:01 ` Daniel Vetter
2020-05-19 23:01 ` Daniel Vetter
2020-05-20 3:47 ` [EXTERNAL] " Steve Pronovost
2020-05-20 3:47 ` Steve Pronovost
2020-05-20 3:47 ` Steve Pronovost
2020-05-20 7:40 ` Daniel Vetter
2020-05-20 8:19 ` Steve Pronovost
2020-05-20 15:34 ` Steve Pronovost
2020-05-20 15:34 ` Steve Pronovost
2020-05-20 15:34 ` Steve Pronovost
2020-06-16 10:51 ` Pavel Machek
2020-06-16 10:51 ` Pavel Machek
2020-06-16 10:51 ` Pavel Machek
2020-05-19 23:12 ` Dave Airlie
2020-05-19 23:12 ` Dave Airlie
2020-05-19 23:12 ` Dave Airlie
2020-06-16 10:51 ` Pavel Machek
2020-06-16 10:51 ` Pavel Machek
2020-06-16 10:51 ` Pavel Machek
2020-06-16 13:21 ` Sasha Levin
2020-06-16 13:21 ` Sasha Levin
2020-06-16 13:21 ` Sasha Levin
2020-05-20 7:10 ` Thomas Zimmermann
2020-05-20 7:10 ` Thomas Zimmermann
2020-05-20 7:10 ` Thomas Zimmermann
2020-05-20 7:42 ` [EXTERNAL] " Steve Pronovost
2020-05-20 7:42 ` Steve Pronovost
2020-05-20 7:42 ` Steve Pronovost
2020-05-20 11:06 ` Thomas Zimmermann
2020-05-20 11:06 ` Thomas Zimmermann
2020-05-20 11:06 ` Thomas Zimmermann
2020-06-16 10:51 ` Pavel Machek
2020-06-16 10:51 ` Pavel Machek
2020-06-16 10:51 ` Pavel Machek
2020-06-16 13:28 ` Sasha Levin [this message]
2020-06-16 13:28 ` Sasha Levin
2020-06-16 13:28 ` Sasha Levin
2020-06-16 14:41 ` Pavel Machek
2020-06-16 14:41 ` Pavel Machek
2020-06-16 14:41 ` Pavel Machek
2020-06-16 16:00 ` Sasha Levin
2020-06-16 16:00 ` Sasha Levin
2020-06-16 16:00 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616132819.GP1931@sasha-vm \
--to=sashal@kernel.org \
--cc=Hawking.Zhang@amd.com \
--cc=alexander.deucher@amd.com \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=iourit@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=spronovo@microsoft.com \
--cc=sthemmin@microsoft.com \
--cc=tvrtko.ursulin@intel.com \
--cc=tzimmermann@suse.de \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.