* [PATCH linux dev-5.4 0/2] ARM: dts: Aspeed: Enable EHCI controllers
@ 2020-06-16 13:57 Eddie James
2020-06-16 13:57 ` [PATCH linux dev-5.4 1/2] ARM: dts: Aspeed: Rainier: Enable EHCI controller Eddie James
2020-06-16 13:57 ` [PATCH linux dev-5.4 2/2] ARM: dts: Aspeed: Tacoma: " Eddie James
0 siblings, 2 replies; 6+ messages in thread
From: Eddie James @ 2020-06-16 13:57 UTC (permalink / raw)
To: openbmc; +Cc: joel, Eddie James
Enable the second EHCI controller on both the Tacoma board and Rainier system.
Eddie James (2):
ARM: dts: Aspeed: Rainier: Enable EHCI controller
ARM: dts: Aspeed: Tacoma: Enable EHCI controller
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 6 +++++-
arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 6 +++++-
2 files changed, 10 insertions(+), 2 deletions(-)
--
2.24.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH linux dev-5.4 1/2] ARM: dts: Aspeed: Rainier: Enable EHCI controller
2020-06-16 13:57 [PATCH linux dev-5.4 0/2] ARM: dts: Aspeed: Enable EHCI controllers Eddie James
@ 2020-06-16 13:57 ` Eddie James
2020-06-16 13:57 ` [PATCH linux dev-5.4 2/2] ARM: dts: Aspeed: Tacoma: " Eddie James
1 sibling, 0 replies; 6+ messages in thread
From: Eddie James @ 2020-06-16 13:57 UTC (permalink / raw)
To: openbmc; +Cc: joel, Eddie James
Enable the second EHCI controller on the AST2600. Also add a line-name
for the GPIO that controls power to the USB port.
Signed-off-by: Eddie James <eajames@linux.ibm.com>
---
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
index bcf96e16f8cc..e41a2c2f4438 100644
--- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
@@ -71,6 +71,10 @@
};
+&ehci1 {
+ status = "okay";
+};
+
&gpio0 {
gpio-line-names =
/*A0-A7*/ "","","","","","","","",
@@ -87,7 +91,7 @@
/*L0-L7*/ "","","","","","","","",
/*M0-M7*/ "","","","","","","","",
/*N0-N7*/ "","","","","","","","",
- /*O0-O7*/ "","","","","","","","",
+ /*O0-O7*/ "","","","usb-power","","","","",
/*P0-P7*/ "","","","","","","","",
/*Q0-Q7*/ "cfam-reset","","","","","","","",
/*R0-R7*/ "","","","","","","","",
--
2.24.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH linux dev-5.4 2/2] ARM: dts: Aspeed: Tacoma: Enable EHCI controller
2020-06-16 13:57 [PATCH linux dev-5.4 0/2] ARM: dts: Aspeed: Enable EHCI controllers Eddie James
2020-06-16 13:57 ` [PATCH linux dev-5.4 1/2] ARM: dts: Aspeed: Rainier: Enable EHCI controller Eddie James
@ 2020-06-16 13:57 ` Eddie James
2020-06-30 3:02 ` Joel Stanley
1 sibling, 1 reply; 6+ messages in thread
From: Eddie James @ 2020-06-16 13:57 UTC (permalink / raw)
To: openbmc; +Cc: joel, Eddie James
Enable the second EHCI controller on the AST2600. Also add a line-name
for the GPIO that controls power to the USB port.
Signed-off-by: Eddie James <eajames@linux.ibm.com>
---
arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
index 96a45014b7e5..fcaff4023240 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
@@ -95,6 +95,10 @@
};
};
+&ehci1 {
+ status = "okay";
+};
+
&gpio0 {
gpio-line-names =
/*A0-A7*/ "","","","","","","","",
@@ -111,7 +115,7 @@
/*L0-L7*/ "","","","","","","","",
/*M0-M7*/ "","","","","","","","",
/*N0-N7*/ "","","","","","","","",
- /*O0-O7*/ "led-rear-power","led-rear-id","","","","","","",
+ /*O0-O7*/ "led-rear-power","led-rear-id","","usb-power","","","","",
/*P0-P7*/ "","","","","","","","",
/*Q0-Q7*/ "cfam-reset","","","","","","","fsi-routing",
/*R0-R7*/ "","","","","","","","",
--
2.24.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH linux dev-5.4 2/2] ARM: dts: Aspeed: Tacoma: Enable EHCI controller
2020-06-16 13:57 ` [PATCH linux dev-5.4 2/2] ARM: dts: Aspeed: Tacoma: " Eddie James
@ 2020-06-30 3:02 ` Joel Stanley
2020-06-30 12:57 ` Brad Bishop
0 siblings, 1 reply; 6+ messages in thread
From: Joel Stanley @ 2020-06-30 3:02 UTC (permalink / raw)
To: Eddie James; +Cc: OpenBMC Maillist
On Tue, 16 Jun 2020 at 13:57, Eddie James <eajames@linux.ibm.com> wrote:
>
> Enable the second EHCI controller on the AST2600. Also add a line-name
> for the GPIO that controls power to the USB port.
What's the idea behind the power control?
Is there any reason not to add a hog, so power is always applied?
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
> index 96a45014b7e5..fcaff4023240 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
> @@ -95,6 +95,10 @@
> };
> };
>
> +&ehci1 {
> + status = "okay";
> +};
> +
> &gpio0 {
> gpio-line-names =
> /*A0-A7*/ "","","","","","","","",
> @@ -111,7 +115,7 @@
> /*L0-L7*/ "","","","","","","","",
> /*M0-M7*/ "","","","","","","","",
> /*N0-N7*/ "","","","","","","","",
> - /*O0-O7*/ "led-rear-power","led-rear-id","","","","","","",
> + /*O0-O7*/ "led-rear-power","led-rear-id","","usb-power","","","","",
> /*P0-P7*/ "","","","","","","","",
> /*Q0-Q7*/ "cfam-reset","","","","","","","fsi-routing",
> /*R0-R7*/ "","","","","","","","",
> --
> 2.24.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH linux dev-5.4 2/2] ARM: dts: Aspeed: Tacoma: Enable EHCI controller
2020-06-30 3:02 ` Joel Stanley
@ 2020-06-30 12:57 ` Brad Bishop
2020-07-27 2:29 ` Joel Stanley
0 siblings, 1 reply; 6+ messages in thread
From: Brad Bishop @ 2020-06-30 12:57 UTC (permalink / raw)
To: Joel Stanley, Eddie James; +Cc: OpenBMC Maillist
On Tue, 2020-06-30 at 03:02 +0000, Joel Stanley wrote:
> On Tue, 16 Jun 2020 at 13:57, Eddie James <eajames@linux.ibm.com>
> wrote:
> > Enable the second EHCI controller on the AST2600. Also add a line-
> > name
> > for the GPIO that controls power to the USB port.
>
> What's the idea behind the power control?
>
> Is there any reason not to add a hog, so power is always applied?
There is a desire to allow the port to be disabled, for those that are
worried about rogue USB sticks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH linux dev-5.4 2/2] ARM: dts: Aspeed: Tacoma: Enable EHCI controller
2020-06-30 12:57 ` Brad Bishop
@ 2020-07-27 2:29 ` Joel Stanley
0 siblings, 0 replies; 6+ messages in thread
From: Joel Stanley @ 2020-07-27 2:29 UTC (permalink / raw)
To: Brad Bishop; +Cc: Eddie James, OpenBMC Maillist
On Tue, 30 Jun 2020 at 12:58, Brad Bishop <bradleyb@fuzziesquirrel.com> wrote:
>
> On Tue, 2020-06-30 at 03:02 +0000, Joel Stanley wrote:
> > On Tue, 16 Jun 2020 at 13:57, Eddie James <eajames@linux.ibm.com>
> > wrote:
> > > Enable the second EHCI controller on the AST2600. Also add a line-
> > > name
> > > for the GPIO that controls power to the USB port.
> >
> > What's the idea behind the power control?
> >
> > Is there any reason not to add a hog, so power is always applied?
>
> There is a desire to allow the port to be disabled, for those that are
> worried about rogue USB sticks.
Ok. Do we have userspace that enables the power?
I propose we hog them on for now, so we can test the USB function.
When someone has time to implement the enable/disable function we can
remove the hog.
Cheers,
Joel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-27 2:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-16 13:57 [PATCH linux dev-5.4 0/2] ARM: dts: Aspeed: Enable EHCI controllers Eddie James
2020-06-16 13:57 ` [PATCH linux dev-5.4 1/2] ARM: dts: Aspeed: Rainier: Enable EHCI controller Eddie James
2020-06-16 13:57 ` [PATCH linux dev-5.4 2/2] ARM: dts: Aspeed: Tacoma: " Eddie James
2020-06-30 3:02 ` Joel Stanley
2020-06-30 12:57 ` Brad Bishop
2020-07-27 2:29 ` Joel Stanley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.