All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	ludovic.desroches@microchip.com, robh+dt@kernel.org,
	claudiu.beznea@microchip.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] Revert "ARM: at91/dt: sama5d2 Xplained: add pdmic node"
Date: Wed, 17 Jun 2020 23:34:38 +0200	[thread overview]
Message-ID: <20200617213438.GF3675@piout.net> (raw)
In-Reply-To: <20200615095525.43414-3-codrin.ciubotariu@microchip.com>

Hi,

The correct subject line prefix is "ARM: dts: at91:"

On 15/06/2020 12:55:25+0300, Codrin Ciubotariu wrote:
> There are no PDM microphones on SAMA5D2 Xplained, to exercize the
> PDMIC.
> 
> This reverts commit ca6349a8c51f2e3d6f2acdb36431e7d7328261f7.
> 
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> ---
>  arch/arm/boot/dts/at91-sama5d2_xplained.dts | 16 ----------------
>  1 file changed, 16 deletions(-)
> 

This patch doesn't apply and I think you'll have to motivate the removal
a bit more because this seems like a change of policy to me.

> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> index 54d96649da77..c0a255bda477 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> @@ -109,16 +109,6 @@ timer1: timer@1 {
>  				};
>  			};
>  
> -			pdmic@f8018000 {
> -				pinctrl-names = "default";
> -				pinctrl-0 = <&pinctrl_pdmic_default>;
> -				atmel,model = "PDMIC @ sama5d2_xplained";
> -				atmel,mic-min-freq = <1000000>;
> -				atmel,mic-max-freq = <3246000>;
> -				atmel,mic-offset = <0x0>;
> -				status = "okay";
> -			};
> -
>  			uart1: serial@f8020000 {
>  				pinctrl-names = "default";
>  				pinctrl-0 = <&pinctrl_uart1_default>;
> @@ -533,12 +523,6 @@ pinctrl_macb0_phy_irq: macb0_phy_irq {
>  					bias-disable;
>  				};
>  
> -				pinctrl_pdmic_default: pdmic_default {
> -					pinmux = <PIN_PB26__PDMIC_DAT>,
> -						<PIN_PB27__PDMIC_CLK>;
> -					bias-disable;
> -				};
> -
>  				pinctrl_sdmmc0_default: sdmmc0_default {
>  					cmd_data {
>  						pinmux = <PIN_PA1__SDMMC0_CMD>,
> -- 
> 2.25.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	nicolas.ferre@microchip.com, ludovic.desroches@microchip.com,
	claudiu.beznea@microchip.com
Subject: Re: [PATCH 3/3] Revert "ARM: at91/dt: sama5d2 Xplained: add pdmic node"
Date: Wed, 17 Jun 2020 23:34:38 +0200	[thread overview]
Message-ID: <20200617213438.GF3675@piout.net> (raw)
In-Reply-To: <20200615095525.43414-3-codrin.ciubotariu@microchip.com>

Hi,

The correct subject line prefix is "ARM: dts: at91:"

On 15/06/2020 12:55:25+0300, Codrin Ciubotariu wrote:
> There are no PDM microphones on SAMA5D2 Xplained, to exercize the
> PDMIC.
> 
> This reverts commit ca6349a8c51f2e3d6f2acdb36431e7d7328261f7.
> 
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> ---
>  arch/arm/boot/dts/at91-sama5d2_xplained.dts | 16 ----------------
>  1 file changed, 16 deletions(-)
> 

This patch doesn't apply and I think you'll have to motivate the removal
a bit more because this seems like a change of policy to me.

> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> index 54d96649da77..c0a255bda477 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> @@ -109,16 +109,6 @@ timer1: timer@1 {
>  				};
>  			};
>  
> -			pdmic@f8018000 {
> -				pinctrl-names = "default";
> -				pinctrl-0 = <&pinctrl_pdmic_default>;
> -				atmel,model = "PDMIC @ sama5d2_xplained";
> -				atmel,mic-min-freq = <1000000>;
> -				atmel,mic-max-freq = <3246000>;
> -				atmel,mic-offset = <0x0>;
> -				status = "okay";
> -			};
> -
>  			uart1: serial@f8020000 {
>  				pinctrl-names = "default";
>  				pinctrl-0 = <&pinctrl_uart1_default>;
> @@ -533,12 +523,6 @@ pinctrl_macb0_phy_irq: macb0_phy_irq {
>  					bias-disable;
>  				};
>  
> -				pinctrl_pdmic_default: pdmic_default {
> -					pinmux = <PIN_PB26__PDMIC_DAT>,
> -						<PIN_PB27__PDMIC_CLK>;
> -					bias-disable;
> -				};
> -
>  				pinctrl_sdmmc0_default: sdmmc0_default {
>  					cmd_data {
>  						pinmux = <PIN_PA1__SDMMC0_CMD>,
> -- 
> 2.25.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-06-17 21:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-15  9:55 [PATCH 1/3] ARM: dts: at91: sama5d2_xplained: classd: pull-down the R1 and R3 lines Codrin Ciubotariu
2020-06-15  9:55 ` Codrin Ciubotariu
2020-06-15  9:55 ` [PATCH 2/3] ARM: dts: at91: sam9x60ek: classd: pull-down the L1 and L3 lines Codrin Ciubotariu
2020-06-15  9:55   ` Codrin Ciubotariu
2020-06-17 21:28   ` Alexandre Belloni
2020-06-17 21:28     ` Alexandre Belloni
2020-06-15  9:55 ` [PATCH 3/3] Revert "ARM: at91/dt: sama5d2 Xplained: add pdmic node" Codrin Ciubotariu
2020-06-15  9:55   ` Codrin Ciubotariu
2020-06-17 21:34   ` Alexandre Belloni [this message]
2020-06-17 21:34     ` Alexandre Belloni
2020-06-18  7:43     ` Codrin.Ciubotariu
2020-06-18  7:43       ` Codrin.Ciubotariu
2020-06-17 21:27 ` [PATCH 1/3] ARM: dts: at91: sama5d2_xplained: classd: pull-down the R1 and R3 lines Alexandre Belloni
2020-06-17 21:27   ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200617213438.GF3675@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=claudiu.beznea@microchip.com \
    --cc=codrin.ciubotariu@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.