[meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

[meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

[Ankur Tyagi]

When using meta-ti BSP layer, user should be able to override default uboot
board config with their custom board config as it is common for customers
to design custom board based upon am335x-evm dev kit.

Signed-off-by: Ankur Tyagi <ankur.tyagi@gallagher.com>
---
 conf/machine/include/ti33x.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/conf/machine/include/ti33x.inc b/conf/machine/include/ti33x.inc
index abfd7ec7..ff72a382 100644
--- a/conf/machine/include/ti33x.inc
+++ b/conf/machine/include/ti33x.inc
@@ -39,7 +39,7 @@ KERNEL_DEVICETREE = " \
 KERNEL_DEVICETREE += "${@oe.utils.conditional('ENABLE_TI_UIO_DEVICES', '1', 'am335x-icev2-pru-excl-uio.dtb', '', d)}"
 
 UBOOT_ARCH = "arm"
-UBOOT_MACHINE = "am335x_evm_config"
+UBOOT_MACHINE ?= "am335x_evm_config"
 
 UBOOT_ENTRYPOINT = "0x80008000"
 UBOOT_LOADADDRESS = "0x80008000"
-- 
2.17.1

Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

[Ankur Tyagi]

Hi Denys,

Gentle reminder as this patch has been in the mailing list (#12992) for some time now but I haven't heard anything.

Regards
Ankur

-----Original Message-----
From: Ankur Tyagi 
Sent: Friday, 12 June 2020 10:49 AM
To: meta-ti@lists.yoctoproject.org
Subject: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

When using meta-ti BSP layer, user should be able to override default uboot
board config with their custom board config as it is common for customers
to design custom board based upon am335x-evm dev kit.

Signed-off-by: Ankur Tyagi <ankur.tyagi@gallagher.com>
---
 conf/machine/include/ti33x.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/conf/machine/include/ti33x.inc b/conf/machine/include/ti33x.inc
index abfd7ec7..ff72a382 100644
--- a/conf/machine/include/ti33x.inc
+++ b/conf/machine/include/ti33x.inc
@@ -39,7 +39,7 @@ KERNEL_DEVICETREE = " \
 KERNEL_DEVICETREE += "${@oe.utils.conditional('ENABLE_TI_UIO_DEVICES', '1', 'am335x-icev2-pru-excl-uio.dtb', '', d)}"
 
 UBOOT_ARCH = "arm"
-UBOOT_MACHINE = "am335x_evm_config"
+UBOOT_MACHINE ?= "am335x_evm_config"
 
 UBOOT_ENTRYPOINT = "0x80008000"
 UBOOT_LOADADDRESS = "0x80008000"
-- 
2.17.1

Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

[Denys Dmytriyenko]

On Mon, Jun 15, 2020 at 07:38:36PM +0000, Ankur Tyagi wrote:
> Hi Denys,
> 
> Gentle reminder as this patch has been in the mailing list (#12992) for some 
> time now but I haven't heard anything.

Is your subscription working properly? I did reply here:
https://lists.yoctoproject.org/g/meta-ti/topic/74828692


> Regards
> Ankur
> 
> -----Original Message-----
> From: Ankur Tyagi 
> Sent: Friday, 12 June 2020 10:49 AM
> To: meta-ti@lists.yoctoproject.org
> Subject: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> 
> When using meta-ti BSP layer, user should be able to override default uboot
> board config with their custom board config as it is common for customers
> to design custom board based upon am335x-evm dev kit.
> 
> Signed-off-by: Ankur Tyagi <ankur.tyagi@gallagher.com>
> ---
>  conf/machine/include/ti33x.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/conf/machine/include/ti33x.inc b/conf/machine/include/ti33x.inc
> index abfd7ec7..ff72a382 100644
> --- a/conf/machine/include/ti33x.inc
> +++ b/conf/machine/include/ti33x.inc
> @@ -39,7 +39,7 @@ KERNEL_DEVICETREE = " \
>  KERNEL_DEVICETREE += "${@oe.utils.conditional('ENABLE_TI_UIO_DEVICES', '1', 'am335x-icev2-pru-excl-uio.dtb', '', d)}"
>  
>  UBOOT_ARCH = "arm"
> -UBOOT_MACHINE = "am335x_evm_config"
> +UBOOT_MACHINE ?= "am335x_evm_config"
>  
>  UBOOT_ENTRYPOINT = "0x80008000"
>  UBOOT_LOADADDRESS = "0x80008000"
> -- 
> 2.17.1
> 

Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

[Ankur Tyagi]

Hi Denys,

I did received your response and resent the patch.
This is the reminder for the second patch.

Regards
Ankur

-----Original Message-----
From: Denys Dmytriyenko <denys@ti.com> 
Sent: Tuesday, 16 June 2020 7:42 AM
To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
Cc: meta-ti@lists.yoctoproject.org
Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

On Mon, Jun 15, 2020 at 07:38:36PM +0000, Ankur Tyagi wrote:
> Hi Denys,
> 
> Gentle reminder as this patch has been in the mailing list (#12992) for some 
> time now but I haven't heard anything.

Is your subscription working properly? I did reply here:
https://lists.yoctoproject.org/g/meta-ti/topic/74828692


> Regards
> Ankur
> 
> -----Original Message-----
> From: Ankur Tyagi 
> Sent: Friday, 12 June 2020 10:49 AM
> To: meta-ti@lists.yoctoproject.org
> Subject: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> 
> When using meta-ti BSP layer, user should be able to override default uboot
> board config with their custom board config as it is common for customers
> to design custom board based upon am335x-evm dev kit.
> 
> Signed-off-by: Ankur Tyagi <ankur.tyagi@gallagher.com>
> ---
>  conf/machine/include/ti33x.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/conf/machine/include/ti33x.inc b/conf/machine/include/ti33x.inc
> index abfd7ec7..ff72a382 100644
> --- a/conf/machine/include/ti33x.inc
> +++ b/conf/machine/include/ti33x.inc
> @@ -39,7 +39,7 @@ KERNEL_DEVICETREE = " \
>  KERNEL_DEVICETREE += "${@oe.utils.conditional('ENABLE_TI_UIO_DEVICES', '1', 'am335x-icev2-pru-excl-uio.dtb', '', d)}"
>  
>  UBOOT_ARCH = "arm"
> -UBOOT_MACHINE = "am335x_evm_config"
> +UBOOT_MACHINE ?= "am335x_evm_config"
>  
>  UBOOT_ENTRYPOINT = "0x80008000"
>  UBOOT_LOADADDRESS = "0x80008000"
> -- 
> 2.17.1
> 

Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

[Ankur Tyagi]

Hi Denys,

Do you want me to send another patch?
Maybe with an updated subject to differentiate?

Let me know what's the best way to proceed

Regards
Ankur

-----Original Message-----
From: meta-ti@lists.yoctoproject.org <meta-ti@lists.yoctoproject.org> On Behalf Of Ankur Tyagi
Sent: Tuesday, 16 June 2020 7:45 AM
To: Denys Dmytriyenko <denys@ti.com>
Cc: meta-ti@lists.yoctoproject.org
Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

Hi Denys,

I did received your response and resent the patch.
This is the reminder for the second patch.

Regards
Ankur

-----Original Message-----
From: Denys Dmytriyenko <denys@ti.com>
Sent: Tuesday, 16 June 2020 7:42 AM
To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
Cc: meta-ti@lists.yoctoproject.org
Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

On Mon, Jun 15, 2020 at 07:38:36PM +0000, Ankur Tyagi wrote:
> Hi Denys,
> 
> Gentle reminder as this patch has been in the mailing list (#12992) 
> for some time now but I haven't heard anything.

Is your subscription working properly? I did reply here:
https://lists.yoctoproject.org/g/meta-ti/topic/74828692


> Regards
> Ankur
> 
> -----Original Message-----
> From: Ankur Tyagi
> Sent: Friday, 12 June 2020 10:49 AM
> To: meta-ti@lists.yoctoproject.org
> Subject: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak 
> assignment for uboot board config
> 
> When using meta-ti BSP layer, user should be able to override default 
> uboot board config with their custom board config as it is common for 
> customers to design custom board based upon am335x-evm dev kit.
> 
> Signed-off-by: Ankur Tyagi <ankur.tyagi@gallagher.com>
> ---
>  conf/machine/include/ti33x.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/conf/machine/include/ti33x.inc 
> b/conf/machine/include/ti33x.inc index abfd7ec7..ff72a382 100644
> --- a/conf/machine/include/ti33x.inc
> +++ b/conf/machine/include/ti33x.inc
> @@ -39,7 +39,7 @@ KERNEL_DEVICETREE = " \  KERNEL_DEVICETREE += 
> "${@oe.utils.conditional('ENABLE_TI_UIO_DEVICES', '1', 'am335x-icev2-pru-excl-uio.dtb', '', d)}"
>  
>  UBOOT_ARCH = "arm"
> -UBOOT_MACHINE = "am335x_evm_config"
> +UBOOT_MACHINE ?= "am335x_evm_config"
>  
>  UBOOT_ENTRYPOINT = "0x80008000"
>  UBOOT_LOADADDRESS = "0x80008000"
> --
> 2.17.1
> 

Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

[Denys Dmytriyenko]

On Tue, Jun 16, 2020 at 11:40:47PM +0000, Ankur Tyagi wrote:
> Hi Denys,
> 
> Do you want me to send another patch?
> Maybe with an updated subject to differentiate?
> 
> Let me know what's the best way to proceed

Have you considered what I said here:
https://lists.yoctoproject.org/g/meta-ti/topic/74828692


> Regards
> Ankur
> 
> -----Original Message-----
> From: meta-ti@lists.yoctoproject.org <meta-ti@lists.yoctoproject.org> On Behalf Of Ankur Tyagi
> Sent: Tuesday, 16 June 2020 7:45 AM
> To: Denys Dmytriyenko <denys@ti.com>
> Cc: meta-ti@lists.yoctoproject.org
> Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> 
> Hi Denys,
> 
> I did received your response and resent the patch.
> This is the reminder for the second patch.
> 
> Regards
> Ankur
> 
> -----Original Message-----
> From: Denys Dmytriyenko <denys@ti.com>
> Sent: Tuesday, 16 June 2020 7:42 AM
> To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
> Cc: meta-ti@lists.yoctoproject.org
> Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> 
> On Mon, Jun 15, 2020 at 07:38:36PM +0000, Ankur Tyagi wrote:
> > Hi Denys,
> > 
> > Gentle reminder as this patch has been in the mailing list (#12992) 
> > for some time now but I haven't heard anything.
> 
> Is your subscription working properly? I did reply here:
> https://lists.yoctoproject.org/g/meta-ti/topic/74828692
> 
> 
> > Regards
> > Ankur
> > 
> > -----Original Message-----
> > From: Ankur Tyagi
> > Sent: Friday, 12 June 2020 10:49 AM
> > To: meta-ti@lists.yoctoproject.org
> > Subject: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak 
> > assignment for uboot board config
> > 
> > When using meta-ti BSP layer, user should be able to override default 
> > uboot board config with their custom board config as it is common for 
> > customers to design custom board based upon am335x-evm dev kit.
> > 
> > Signed-off-by: Ankur Tyagi <ankur.tyagi@gallagher.com>
> > ---
> >  conf/machine/include/ti33x.inc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/conf/machine/include/ti33x.inc 
> > b/conf/machine/include/ti33x.inc index abfd7ec7..ff72a382 100644
> > --- a/conf/machine/include/ti33x.inc
> > +++ b/conf/machine/include/ti33x.inc
> > @@ -39,7 +39,7 @@ KERNEL_DEVICETREE = " \  KERNEL_DEVICETREE += 
> > "${@oe.utils.conditional('ENABLE_TI_UIO_DEVICES', '1', 'am335x-icev2-pru-excl-uio.dtb', '', d)}"
> >  
> >  UBOOT_ARCH = "arm"
> > -UBOOT_MACHINE = "am335x_evm_config"
> > +UBOOT_MACHINE ?= "am335x_evm_config"
> >  
> >  UBOOT_ENTRYPOINT = "0x80008000"
> >  UBOOT_LOADADDRESS = "0x80008000"
> > --
> > 2.17.1
> > 

Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

[Ankur Tyagi]

Hi Denys,

Yes, I did sent the patch again on mailing list and once the patch appeared, then only I sent reminder.

To begin with, this is what I think happened:
- Sent a patch to the list but somehow it failed
- without realizing that failure, I sent reminder for the failed one
https://lists.yoctoproject.org/g/meta-ti/message/12990
- you identified the problem and suggested to send it again
https://lists.yoctoproject.org/g/meta-ti/message/12991
- I did sent the patch again and it made it to mailing list
https://lists.yoctoproject.org/g/meta-ti/message/12992
- and then reminder for the successful sent patch
https://lists.yoctoproject.org/g/meta-ti/message/12993

I sent the patch again with the same subject, somehow it got merged in the same topic
and doesn't appear as a separate patch?
Should I do slight change in the subject so that it appears as a separate topic in the list?

Not sure what's the best way to proceed here.

Regards
Ankur

-----Original Message-----
From: Denys Dmytriyenko <denys@ti.com> 
Sent: Thursday, 18 June 2020 11:54 AM
To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
Cc: meta-ti@lists.yoctoproject.org
Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

On Tue, Jun 16, 2020 at 11:40:47PM +0000, Ankur Tyagi wrote:
> Hi Denys,
> 
> Do you want me to send another patch?
> Maybe with an updated subject to differentiate?
> 
> Let me know what's the best way to proceed

Have you considered what I said here:
https://lists.yoctoproject.org/g/meta-ti/topic/74828692


> Regards
> Ankur
> 
> -----Original Message-----
> From: meta-ti@lists.yoctoproject.org <meta-ti@lists.yoctoproject.org> On Behalf Of Ankur Tyagi
> Sent: Tuesday, 16 June 2020 7:45 AM
> To: Denys Dmytriyenko <denys@ti.com>
> Cc: meta-ti@lists.yoctoproject.org
> Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> 
> Hi Denys,
> 
> I did received your response and resent the patch.
> This is the reminder for the second patch.
> 
> Regards
> Ankur
> 
> -----Original Message-----
> From: Denys Dmytriyenko <denys@ti.com>
> Sent: Tuesday, 16 June 2020 7:42 AM
> To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
> Cc: meta-ti@lists.yoctoproject.org
> Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> 
> On Mon, Jun 15, 2020 at 07:38:36PM +0000, Ankur Tyagi wrote:
> > Hi Denys,
> > 
> > Gentle reminder as this patch has been in the mailing list (#12992) 
> > for some time now but I haven't heard anything.
> 
> Is your subscription working properly? I did reply here:
> https://lists.yoctoproject.org/g/meta-ti/topic/74828692
> 
> 
> > Regards
> > Ankur
> > 
> > -----Original Message-----
> > From: Ankur Tyagi
> > Sent: Friday, 12 June 2020 10:49 AM
> > To: meta-ti@lists.yoctoproject.org
> > Subject: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak 
> > assignment for uboot board config
> > 
> > When using meta-ti BSP layer, user should be able to override default 
> > uboot board config with their custom board config as it is common for 
> > customers to design custom board based upon am335x-evm dev kit.
> > 
> > Signed-off-by: Ankur Tyagi <ankur.tyagi@gallagher.com>
> > ---
> >  conf/machine/include/ti33x.inc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/conf/machine/include/ti33x.inc 
> > b/conf/machine/include/ti33x.inc index abfd7ec7..ff72a382 100644
> > --- a/conf/machine/include/ti33x.inc
> > +++ b/conf/machine/include/ti33x.inc
> > @@ -39,7 +39,7 @@ KERNEL_DEVICETREE = " \  KERNEL_DEVICETREE += 
> > "${@oe.utils.conditional('ENABLE_TI_UIO_DEVICES', '1', 'am335x-icev2-pru-excl-uio.dtb', '', d)}"
> >  
> >  UBOOT_ARCH = "arm"
> > -UBOOT_MACHINE = "am335x_evm_config"
> > +UBOOT_MACHINE ?= "am335x_evm_config"
> >  
> >  UBOOT_ENTRYPOINT = "0x80008000"
> >  UBOOT_LOADADDRESS = "0x80008000"
> > --
> > 2.17.1
> > 

Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

[Denys Dmytriyenko]

On Thu, Jun 18, 2020 at 12:40:23AM +0000, Ankur Tyagi wrote:
> Hi Denys,
> 
> Yes, I did sent the patch again on mailing list and once the patch appeared, 
> then only I sent reminder.
> 
> To begin with, this is what I think happened:
> - Sent a patch to the list but somehow it failed
> - without realizing that failure, I sent reminder for the failed one
> https://lists.yoctoproject.org/g/meta-ti/message/12990
> - you identified the problem and suggested to send it again
> https://lists.yoctoproject.org/g/meta-ti/message/12991

And also there ^^^ I commented on feasibility of the change, which you seem to 
have missed...


> - I did sent the patch again and it made it to mailing list
> https://lists.yoctoproject.org/g/meta-ti/message/12992
> - and then reminder for the successful sent patch
> https://lists.yoctoproject.org/g/meta-ti/message/12993
> 
> I sent the patch again with the same subject, somehow it got merged in the same topic
> and doesn't appear as a separate patch?
> Should I do slight change in the subject so that it appears as a separate topic in the list?
> 
> Not sure what's the best way to proceed here.
> 
> Regards
> Ankur
> 
> -----Original Message-----
> From: Denys Dmytriyenko <denys@ti.com> 
> Sent: Thursday, 18 June 2020 11:54 AM
> To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
> Cc: meta-ti@lists.yoctoproject.org
> Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> 
> On Tue, Jun 16, 2020 at 11:40:47PM +0000, Ankur Tyagi wrote:
> > Hi Denys,
> > 
> > Do you want me to send another patch?
> > Maybe with an updated subject to differentiate?
> > 
> > Let me know what's the best way to proceed
> 
> Have you considered what I said here:
> https://lists.yoctoproject.org/g/meta-ti/topic/74828692
> 
> 
> > Regards
> > Ankur
> > 
> > -----Original Message-----
> > From: meta-ti@lists.yoctoproject.org <meta-ti@lists.yoctoproject.org> On Behalf Of Ankur Tyagi
> > Sent: Tuesday, 16 June 2020 7:45 AM
> > To: Denys Dmytriyenko <denys@ti.com>
> > Cc: meta-ti@lists.yoctoproject.org
> > Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> > 
> > Hi Denys,
> > 
> > I did received your response and resent the patch.
> > This is the reminder for the second patch.
> > 
> > Regards
> > Ankur
> > 
> > -----Original Message-----
> > From: Denys Dmytriyenko <denys@ti.com>
> > Sent: Tuesday, 16 June 2020 7:42 AM
> > To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
> > Cc: meta-ti@lists.yoctoproject.org
> > Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> > 
> > On Mon, Jun 15, 2020 at 07:38:36PM +0000, Ankur Tyagi wrote:
> > > Hi Denys,
> > > 
> > > Gentle reminder as this patch has been in the mailing list (#12992) 
> > > for some time now but I haven't heard anything.
> > 
> > Is your subscription working properly? I did reply here:
> > https://lists.yoctoproject.org/g/meta-ti/topic/74828692
> > 
> > 
> > > Regards
> > > Ankur
> > > 
> > > -----Original Message-----
> > > From: Ankur Tyagi
> > > Sent: Friday, 12 June 2020 10:49 AM
> > > To: meta-ti@lists.yoctoproject.org
> > > Subject: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak 
> > > assignment for uboot board config
> > > 
> > > When using meta-ti BSP layer, user should be able to override default 
> > > uboot board config with their custom board config as it is common for 
> > > customers to design custom board based upon am335x-evm dev kit.
> > > 
> > > Signed-off-by: Ankur Tyagi <ankur.tyagi@gallagher.com>
> > > ---
> > >  conf/machine/include/ti33x.inc | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/conf/machine/include/ti33x.inc 
> > > b/conf/machine/include/ti33x.inc index abfd7ec7..ff72a382 100644
> > > --- a/conf/machine/include/ti33x.inc
> > > +++ b/conf/machine/include/ti33x.inc
> > > @@ -39,7 +39,7 @@ KERNEL_DEVICETREE = " \  KERNEL_DEVICETREE += 
> > > "${@oe.utils.conditional('ENABLE_TI_UIO_DEVICES', '1', 'am335x-icev2-pru-excl-uio.dtb', '', d)}"
> > >  
> > >  UBOOT_ARCH = "arm"
> > > -UBOOT_MACHINE = "am335x_evm_config"
> > > +UBOOT_MACHINE ?= "am335x_evm_config"
> > >  
> > >  UBOOT_ENTRYPOINT = "0x80008000"
> > >  UBOOT_LOADADDRESS = "0x80008000"
> > > --
> > > 2.17.1
> > > 

Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

[Ankur Tyagi]

Apologies, my bad

> The idea is that if you are creating a custom board based on am335x-evm and 
> adding new config to U-boot, you should consider adding a new OE machine. Even 
> if your machine includes ti33x.inc for common SoC definitions, you can still 
> overwrite UBOOT_MACHINE in your <custom-machine>.conf file...

I did started with this idea but meta-arago has lot of "am335x-evm" machine usage throughout.
That would mean to add new machine override in lot of meta-arago recipes.

Keeping a new board config in u-boot is desired to allow easy upgrading of u-boot from sitara-u-boot git repo.
Modifying am335x board specific in u-boot doesn't scale well.

Hence came up with this approach to allow uboot config override in bsp layer but still use most of distro layer
as it is.

But I am open to new ideas/suggestions as well.

Regards
Ankur

-----Original Message-----
From: Denys Dmytriyenko <denys@ti.com> 
Sent: Thursday, 18 June 2020 1:19 PM
To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
Cc: meta-ti@lists.yoctoproject.org
Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

On Thu, Jun 18, 2020 at 12:40:23AM +0000, Ankur Tyagi wrote:
> Hi Denys,
> 
> Yes, I did sent the patch again on mailing list and once the patch appeared, 
> then only I sent reminder.
> 
> To begin with, this is what I think happened:
> - Sent a patch to the list but somehow it failed
> - without realizing that failure, I sent reminder for the failed one
> https://lists.yoctoproject.org/g/meta-ti/message/12990
> - you identified the problem and suggested to send it again
> https://lists.yoctoproject.org/g/meta-ti/message/12991

And also there ^^^ I commented on feasibility of the change, which you seem to 
have missed...


> - I did sent the patch again and it made it to mailing list
> https://lists.yoctoproject.org/g/meta-ti/message/12992
> - and then reminder for the successful sent patch
> https://lists.yoctoproject.org/g/meta-ti/message/12993
> 
> I sent the patch again with the same subject, somehow it got merged in the same topic
> and doesn't appear as a separate patch?
> Should I do slight change in the subject so that it appears as a separate topic in the list?
> 
> Not sure what's the best way to proceed here.
> 
> Regards
> Ankur
> 
> -----Original Message-----
> From: Denys Dmytriyenko <denys@ti.com> 
> Sent: Thursday, 18 June 2020 11:54 AM
> To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
> Cc: meta-ti@lists.yoctoproject.org
> Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> 
> On Tue, Jun 16, 2020 at 11:40:47PM +0000, Ankur Tyagi wrote:
> > Hi Denys,
> > 
> > Do you want me to send another patch?
> > Maybe with an updated subject to differentiate?
> > 
> > Let me know what's the best way to proceed
> 
> Have you considered what I said here:
> https://lists.yoctoproject.org/g/meta-ti/topic/74828692
> 
> 
> > Regards
> > Ankur
> > 
> > -----Original Message-----
> > From: meta-ti@lists.yoctoproject.org <meta-ti@lists.yoctoproject.org> On Behalf Of Ankur Tyagi
> > Sent: Tuesday, 16 June 2020 7:45 AM
> > To: Denys Dmytriyenko <denys@ti.com>
> > Cc: meta-ti@lists.yoctoproject.org
> > Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> > 
> > Hi Denys,
> > 
> > I did received your response and resent the patch.
> > This is the reminder for the second patch.
> > 
> > Regards
> > Ankur
> > 
> > -----Original Message-----
> > From: Denys Dmytriyenko <denys@ti.com>
> > Sent: Tuesday, 16 June 2020 7:42 AM
> > To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
> > Cc: meta-ti@lists.yoctoproject.org
> > Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> > 
> > On Mon, Jun 15, 2020 at 07:38:36PM +0000, Ankur Tyagi wrote:
> > > Hi Denys,
> > > 
> > > Gentle reminder as this patch has been in the mailing list (#12992) 
> > > for some time now but I haven't heard anything.
> > 
> > Is your subscription working properly? I did reply here:
> > https://lists.yoctoproject.org/g/meta-ti/topic/74828692
> > 
> > 
> > > Regards
> > > Ankur
> > > 
> > > -----Original Message-----
> > > From: Ankur Tyagi
> > > Sent: Friday, 12 June 2020 10:49 AM
> > > To: meta-ti@lists.yoctoproject.org
> > > Subject: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak 
> > > assignment for uboot board config
> > > 
> > > When using meta-ti BSP layer, user should be able to override default 
> > > uboot board config with their custom board config as it is common for 
> > > customers to design custom board based upon am335x-evm dev kit.
> > > 
> > > Signed-off-by: Ankur Tyagi <ankur.tyagi@gallagher.com>
> > > ---
> > >  conf/machine/include/ti33x.inc | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/conf/machine/include/ti33x.inc 
> > > b/conf/machine/include/ti33x.inc index abfd7ec7..ff72a382 100644
> > > --- a/conf/machine/include/ti33x.inc
> > > +++ b/conf/machine/include/ti33x.inc
> > > @@ -39,7 +39,7 @@ KERNEL_DEVICETREE = " \  KERNEL_DEVICETREE += 
> > > "${@oe.utils.conditional('ENABLE_TI_UIO_DEVICES', '1', 'am335x-icev2-pru-excl-uio.dtb', '', d)}"
> > >  
> > >  UBOOT_ARCH = "arm"
> > > -UBOOT_MACHINE = "am335x_evm_config"
> > > +UBOOT_MACHINE ?= "am335x_evm_config"
> > >  
> > >  UBOOT_ENTRYPOINT = "0x80008000"
> > >  UBOOT_LOADADDRESS = "0x80008000"
> > > --
> > > 2.17.1
> > > 

Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

[Ankur Tyagi]

Hi Denys,

Didn't got your feedback so does that mean my reason doesn't stack up?

Regards
Ankur

-----Original Message-----
From: meta-ti@lists.yoctoproject.org <meta-ti@lists.yoctoproject.org> On Behalf Of Ankur Tyagi
Sent: Thursday, 18 June 2020 3:55 PM
To: Denys Dmytriyenko <denys@ti.com>
Cc: meta-ti@lists.yoctoproject.org
Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

Apologies, my bad

> The idea is that if you are creating a custom board based on am335x-evm and
> adding new config to U-boot, you should consider adding a new OE machine. Even
> if your machine includes ti33x.inc for common SoC definitions, you can still
> overwrite UBOOT_MACHINE in your <custom-machine>.conf file...

I did started with this idea but meta-arago has lot of "am335x-evm" machine usage throughout.
That would mean to add new machine override in lot of meta-arago recipes.

Keeping a new board config in u-boot is desired to allow easy upgrading of u-boot from sitara-u-boot git repo.
Modifying am335x board specific in u-boot doesn't scale well.

Hence came up with this approach to allow uboot config override in bsp layer but still use most of distro layer
as it is.

But I am open to new ideas/suggestions as well.

Regards
Ankur

-----Original Message-----
From: Denys Dmytriyenko <denys@ti.com>
Sent: Thursday, 18 June 2020 1:19 PM
To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
Cc: meta-ti@lists.yoctoproject.org
Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

On Thu, Jun 18, 2020 at 12:40:23AM +0000, Ankur Tyagi wrote:
> Hi Denys,
>
> Yes, I did sent the patch again on mailing list and once the patch appeared,
> then only I sent reminder.
>
> To begin with, this is what I think happened:
> - Sent a patch to the list but somehow it failed
> - without realizing that failure, I sent reminder for the failed one
> https://lists.yoctoproject.org/g/meta-ti/message/12990
> - you identified the problem and suggested to send it again
> https://lists.yoctoproject.org/g/meta-ti/message/12991

And also there ^^^ I commented on feasibility of the change, which you seem to
have missed...


> - I did sent the patch again and it made it to mailing list
> https://lists.yoctoproject.org/g/meta-ti/message/12992
> - and then reminder for the successful sent patch
> https://lists.yoctoproject.org/g/meta-ti/message/12993
>
> I sent the patch again with the same subject, somehow it got merged in the same topic
> and doesn't appear as a separate patch?
> Should I do slight change in the subject so that it appears as a separate topic in the list?
>
> Not sure what's the best way to proceed here.
>
> Regards
> Ankur
>
> -----Original Message-----
> From: Denys Dmytriyenko <denys@ti.com>
> Sent: Thursday, 18 June 2020 11:54 AM
> To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
> Cc: meta-ti@lists.yoctoproject.org
> Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
>
> On Tue, Jun 16, 2020 at 11:40:47PM +0000, Ankur Tyagi wrote:
> > Hi Denys,
> >
> > Do you want me to send another patch?
> > Maybe with an updated subject to differentiate?
> >
> > Let me know what's the best way to proceed
>
> Have you considered what I said here:
> https://lists.yoctoproject.org/g/meta-ti/topic/74828692
>
>
> > Regards
> > Ankur
> >
> > -----Original Message-----
> > From: meta-ti@lists.yoctoproject.org <meta-ti@lists.yoctoproject.org> On Behalf Of Ankur Tyagi
> > Sent: Tuesday, 16 June 2020 7:45 AM
> > To: Denys Dmytriyenko <denys@ti.com>
> > Cc: meta-ti@lists.yoctoproject.org
> > Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> >
> > Hi Denys,
> >
> > I did received your response and resent the patch.
> > This is the reminder for the second patch.
> >
> > Regards
> > Ankur
> >
> > -----Original Message-----
> > From: Denys Dmytriyenko <denys@ti.com>
> > Sent: Tuesday, 16 June 2020 7:42 AM
> > To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
> > Cc: meta-ti@lists.yoctoproject.org
> > Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> >
> > On Mon, Jun 15, 2020 at 07:38:36PM +0000, Ankur Tyagi wrote:
> > > Hi Denys,
> > >
> > > Gentle reminder as this patch has been in the mailing list (#12992)
> > > for some time now but I haven't heard anything.
> >
> > Is your subscription working properly? I did reply here:
> > https://lists.yoctoproject.org/g/meta-ti/topic/74828692
> >
> >
> > > Regards
> > > Ankur
> > >
> > > -----Original Message-----
> > > From: Ankur Tyagi
> > > Sent: Friday, 12 June 2020 10:49 AM
> > > To: meta-ti@lists.yoctoproject.org
> > > Subject: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak
> > > assignment for uboot board config
> > >
> > > When using meta-ti BSP layer, user should be able to override default
> > > uboot board config with their custom board config as it is common for
> > > customers to design custom board based upon am335x-evm dev kit.
> > >
> > > Signed-off-by: Ankur Tyagi <ankur.tyagi@gallagher.com>
> > > ---
> > >  conf/machine/include/ti33x.inc | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/conf/machine/include/ti33x.inc
> > > b/conf/machine/include/ti33x.inc index abfd7ec7..ff72a382 100644
> > > --- a/conf/machine/include/ti33x.inc
> > > +++ b/conf/machine/include/ti33x.inc
> > > @@ -39,7 +39,7 @@ KERNEL_DEVICETREE = " \  KERNEL_DEVICETREE +=
> > > "${@oe.utils.conditional('ENABLE_TI_UIO_DEVICES', '1', 'am335x-icev2-pru-excl-uio.dtb', '', d)}"
> > >
> > >  UBOOT_ARCH = "arm"
> > > -UBOOT_MACHINE = "am335x_evm_config"
> > > +UBOOT_MACHINE ?= "am335x_evm_config"
> > >
> > >  UBOOT_ENTRYPOINT = "0x80008000"
> > >  UBOOT_LOADADDRESS = "0x80008000"
> > > --
> > > 2.17.1
> > >
________________________________
 This email is confidential and may contain information subject to legal privilege. If you are not the intended recipient please advise us of our error by return e-mail then delete this email and any attached files. You may not copy, disclose or use the contents in any way. The views expressed in this email may not be those of Gallagher Group Ltd or subsidiary companies thereof.
________________________________

Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

[Denys Dmytriyenko]

Sorry, was away for a bit. Can you please identify where in meta-arago 
"am335x-evm" machine is used directly where it should be "ti33x" family 
instead? Or you can send patches to fix those places. Thanks.

-- 
Denys


On Mon, Jun 29, 2020 at 04:05:13PM +0000, Ankur Tyagi wrote:
> Hi Denys,
> 
> Didn't got your feedback so does that mean my reason doesn't stack up?
> 
> Regards
> Ankur
> 
> -----Original Message-----
> From: meta-ti@lists.yoctoproject.org <meta-ti@lists.yoctoproject.org> On Behalf Of Ankur Tyagi
> Sent: Thursday, 18 June 2020 3:55 PM
> To: Denys Dmytriyenko <denys@ti.com>
> Cc: meta-ti@lists.yoctoproject.org
> Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> 
> Apologies, my bad
> 
> > The idea is that if you are creating a custom board based on am335x-evm and
> > adding new config to U-boot, you should consider adding a new OE machine. Even
> > if your machine includes ti33x.inc for common SoC definitions, you can still
> > overwrite UBOOT_MACHINE in your <custom-machine>.conf file...
> 
> I did started with this idea but meta-arago has lot of "am335x-evm" machine usage throughout.
> That would mean to add new machine override in lot of meta-arago recipes.
> 
> Keeping a new board config in u-boot is desired to allow easy upgrading of u-boot from sitara-u-boot git repo.
> Modifying am335x board specific in u-boot doesn't scale well.
> 
> Hence came up with this approach to allow uboot config override in bsp layer but still use most of distro layer
> as it is.
> 
> But I am open to new ideas/suggestions as well.
> 
> Regards
> Ankur
> 
> -----Original Message-----
> From: Denys Dmytriyenko <denys@ti.com>
> Sent: Thursday, 18 June 2020 1:19 PM
> To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
> Cc: meta-ti@lists.yoctoproject.org
> Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> 
> On Thu, Jun 18, 2020 at 12:40:23AM +0000, Ankur Tyagi wrote:
> > Hi Denys,
> >
> > Yes, I did sent the patch again on mailing list and once the patch appeared,
> > then only I sent reminder.
> >
> > To begin with, this is what I think happened:
> > - Sent a patch to the list but somehow it failed
> > - without realizing that failure, I sent reminder for the failed one
> > https://lists.yoctoproject.org/g/meta-ti/message/12990
> > - you identified the problem and suggested to send it again
> > https://lists.yoctoproject.org/g/meta-ti/message/12991
> 
> And also there ^^^ I commented on feasibility of the change, which you seem to
> have missed...
> 
> 
> > - I did sent the patch again and it made it to mailing list
> > https://lists.yoctoproject.org/g/meta-ti/message/12992
> > - and then reminder for the successful sent patch
> > https://lists.yoctoproject.org/g/meta-ti/message/12993
> >
> > I sent the patch again with the same subject, somehow it got merged in the same topic
> > and doesn't appear as a separate patch?
> > Should I do slight change in the subject so that it appears as a separate topic in the list?
> >
> > Not sure what's the best way to proceed here.
> >
> > Regards
> > Ankur
> >
> > -----Original Message-----
> > From: Denys Dmytriyenko <denys@ti.com>
> > Sent: Thursday, 18 June 2020 11:54 AM
> > To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
> > Cc: meta-ti@lists.yoctoproject.org
> > Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> >
> > On Tue, Jun 16, 2020 at 11:40:47PM +0000, Ankur Tyagi wrote:
> > > Hi Denys,
> > >
> > > Do you want me to send another patch?
> > > Maybe with an updated subject to differentiate?
> > >
> > > Let me know what's the best way to proceed
> >
> > Have you considered what I said here:
> > https://lists.yoctoproject.org/g/meta-ti/topic/74828692
> >
> >
> > > Regards
> > > Ankur
> > >
> > > -----Original Message-----
> > > From: meta-ti@lists.yoctoproject.org <meta-ti@lists.yoctoproject.org> On Behalf Of Ankur Tyagi
> > > Sent: Tuesday, 16 June 2020 7:45 AM
> > > To: Denys Dmytriyenko <denys@ti.com>
> > > Cc: meta-ti@lists.yoctoproject.org
> > > Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> > >
> > > Hi Denys,
> > >
> > > I did received your response and resent the patch.
> > > This is the reminder for the second patch.
> > >
> > > Regards
> > > Ankur
> > >
> > > -----Original Message-----
> > > From: Denys Dmytriyenko <denys@ti.com>
> > > Sent: Tuesday, 16 June 2020 7:42 AM
> > > To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
> > > Cc: meta-ti@lists.yoctoproject.org
> > > Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> > >
> > > On Mon, Jun 15, 2020 at 07:38:36PM +0000, Ankur Tyagi wrote:
> > > > Hi Denys,
> > > >
> > > > Gentle reminder as this patch has been in the mailing list (#12992)
> > > > for some time now but I haven't heard anything.
> > >
> > > Is your subscription working properly? I did reply here:
> > > https://lists.yoctoproject.org/g/meta-ti/topic/74828692
> > >
> > >
> > > > Regards
> > > > Ankur
> > > >
> > > > -----Original Message-----
> > > > From: Ankur Tyagi
> > > > Sent: Friday, 12 June 2020 10:49 AM
> > > > To: meta-ti@lists.yoctoproject.org
> > > > Subject: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak
> > > > assignment for uboot board config
> > > >
> > > > When using meta-ti BSP layer, user should be able to override default
> > > > uboot board config with their custom board config as it is common for
> > > > customers to design custom board based upon am335x-evm dev kit.
> > > >
> > > > Signed-off-by: Ankur Tyagi <ankur.tyagi@gallagher.com>
> > > > ---
> > > >  conf/machine/include/ti33x.inc | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/conf/machine/include/ti33x.inc
> > > > b/conf/machine/include/ti33x.inc index abfd7ec7..ff72a382 100644
> > > > --- a/conf/machine/include/ti33x.inc
> > > > +++ b/conf/machine/include/ti33x.inc
> > > > @@ -39,7 +39,7 @@ KERNEL_DEVICETREE = " \  KERNEL_DEVICETREE +=
> > > > "${@oe.utils.conditional('ENABLE_TI_UIO_DEVICES', '1', 'am335x-icev2-pru-excl-uio.dtb', '', d)}"
> > > >
> > > >  UBOOT_ARCH = "arm"
> > > > -UBOOT_MACHINE = "am335x_evm_config"
> > > > +UBOOT_MACHINE ?= "am335x_evm_config"
> > > >
> > > >  UBOOT_ENTRYPOINT = "0x80008000"
> > > >  UBOOT_LOADADDRESS = "0x80008000"
> > > > --
> > > > 2.17.1
> > > >
> ________________________________
>  This email is confidential and may contain information subject to legal privilege. If you are not the intended recipient please advise us of our error by return e-mail then delete this email and any attached files. You may not copy, disclose or use the contents in any way. The views expressed in this email may not be those of Gallagher Group Ltd or subsidiary companies thereof.
> ________________________________

Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

[Ankur Tyagi]

Hi Denys,

meta-arago seems good now (dunfell), not much usage of am335x-evm

./meta-arago-distro/conf/distro/include/branding-amsdk.inc
./meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb
./meta-arago-extras/recipes-apps/acontis-ethercat-demo/acontis-atemsys_3.0.1.28.bb
./meta-arago-extras/recipes-devtools/pinmux-utility/pinmux-utility_2.5.2.0.bb

My response was biased with previous (old)branches experience.

I had another look in meta-ti machines and I think I should follow the pattern
used in am335x-hs-evm.conf.

This way I can add my board conf that can reside with default machine conf's
What is your opinion about it?

Regards
Ankur

-----Original Message-----
From: Denys Dmytriyenko <denys@ti.com> 
Sent: Tuesday, 30 June 2020 9:21 AM
To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
Cc: meta-ti@lists.yoctoproject.org
Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

Sorry, was away for a bit. Can you please identify where in meta-arago 
"am335x-evm" machine is used directly where it should be "ti33x" family 
instead? Or you can send patches to fix those places. Thanks.

-- 
Denys


On Mon, Jun 29, 2020 at 04:05:13PM +0000, Ankur Tyagi wrote:
> Hi Denys,
> 
> Didn't got your feedback so does that mean my reason doesn't stack up?
> 
> Regards
> Ankur
> 
> -----Original Message-----
> From: meta-ti@lists.yoctoproject.org <meta-ti@lists.yoctoproject.org> On Behalf Of Ankur Tyagi
> Sent: Thursday, 18 June 2020 3:55 PM
> To: Denys Dmytriyenko <denys@ti.com>
> Cc: meta-ti@lists.yoctoproject.org
> Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> 
> Apologies, my bad
> 
> > The idea is that if you are creating a custom board based on am335x-evm and
> > adding new config to U-boot, you should consider adding a new OE machine. Even
> > if your machine includes ti33x.inc for common SoC definitions, you can still
> > overwrite UBOOT_MACHINE in your <custom-machine>.conf file...
> 
> I did started with this idea but meta-arago has lot of "am335x-evm" machine usage throughout.
> That would mean to add new machine override in lot of meta-arago recipes.
> 
> Keeping a new board config in u-boot is desired to allow easy upgrading of u-boot from sitara-u-boot git repo.
> Modifying am335x board specific in u-boot doesn't scale well.
> 
> Hence came up with this approach to allow uboot config override in bsp layer but still use most of distro layer
> as it is.
> 
> But I am open to new ideas/suggestions as well.
> 
> Regards
> Ankur
> 
> -----Original Message-----
> From: Denys Dmytriyenko <denys@ti.com>
> Sent: Thursday, 18 June 2020 1:19 PM
> To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
> Cc: meta-ti@lists.yoctoproject.org
> Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> 
> On Thu, Jun 18, 2020 at 12:40:23AM +0000, Ankur Tyagi wrote:
> > Hi Denys,
> >
> > Yes, I did sent the patch again on mailing list and once the patch appeared,
> > then only I sent reminder.
> >
> > To begin with, this is what I think happened:
> > - Sent a patch to the list but somehow it failed
> > - without realizing that failure, I sent reminder for the failed one
> > https://lists.yoctoproject.org/g/meta-ti/message/12990
> > - you identified the problem and suggested to send it again
> > https://lists.yoctoproject.org/g/meta-ti/message/12991
> 
> And also there ^^^ I commented on feasibility of the change, which you seem to
> have missed...
> 
> 
> > - I did sent the patch again and it made it to mailing list
> > https://lists.yoctoproject.org/g/meta-ti/message/12992
> > - and then reminder for the successful sent patch
> > https://lists.yoctoproject.org/g/meta-ti/message/12993
> >
> > I sent the patch again with the same subject, somehow it got merged in the same topic
> > and doesn't appear as a separate patch?
> > Should I do slight change in the subject so that it appears as a separate topic in the list?
> >
> > Not sure what's the best way to proceed here.
> >
> > Regards
> > Ankur
> >
> > -----Original Message-----
> > From: Denys Dmytriyenko <denys@ti.com>
> > Sent: Thursday, 18 June 2020 11:54 AM
> > To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
> > Cc: meta-ti@lists.yoctoproject.org
> > Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> >
> > On Tue, Jun 16, 2020 at 11:40:47PM +0000, Ankur Tyagi wrote:
> > > Hi Denys,
> > >
> > > Do you want me to send another patch?
> > > Maybe with an updated subject to differentiate?
> > >
> > > Let me know what's the best way to proceed
> >
> > Have you considered what I said here:
> > https://lists.yoctoproject.org/g/meta-ti/topic/74828692
> >
> >
> > > Regards
> > > Ankur
> > >
> > > -----Original Message-----
> > > From: meta-ti@lists.yoctoproject.org <meta-ti@lists.yoctoproject.org> On Behalf Of Ankur Tyagi
> > > Sent: Tuesday, 16 June 2020 7:45 AM
> > > To: Denys Dmytriyenko <denys@ti.com>
> > > Cc: meta-ti@lists.yoctoproject.org
> > > Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> > >
> > > Hi Denys,
> > >
> > > I did received your response and resent the patch.
> > > This is the reminder for the second patch.
> > >
> > > Regards
> > > Ankur
> > >
> > > -----Original Message-----
> > > From: Denys Dmytriyenko <denys@ti.com>
> > > Sent: Tuesday, 16 June 2020 7:42 AM
> > > To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
> > > Cc: meta-ti@lists.yoctoproject.org
> > > Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> > >
> > > On Mon, Jun 15, 2020 at 07:38:36PM +0000, Ankur Tyagi wrote:
> > > > Hi Denys,
> > > >
> > > > Gentle reminder as this patch has been in the mailing list (#12992)
> > > > for some time now but I haven't heard anything.
> > >
> > > Is your subscription working properly? I did reply here:
> > > https://lists.yoctoproject.org/g/meta-ti/topic/74828692
> > >
> > >
> > > > Regards
> > > > Ankur
> > > >
> > > > -----Original Message-----
> > > > From: Ankur Tyagi
> > > > Sent: Friday, 12 June 2020 10:49 AM
> > > > To: meta-ti@lists.yoctoproject.org
> > > > Subject: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak
> > > > assignment for uboot board config
> > > >
> > > > When using meta-ti BSP layer, user should be able to override default
> > > > uboot board config with their custom board config as it is common for
> > > > customers to design custom board based upon am335x-evm dev kit.
> > > >
> > > > Signed-off-by: Ankur Tyagi <ankur.tyagi@gallagher.com>
> > > > ---
> > > >  conf/machine/include/ti33x.inc | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/conf/machine/include/ti33x.inc
> > > > b/conf/machine/include/ti33x.inc index abfd7ec7..ff72a382 100644
> > > > --- a/conf/machine/include/ti33x.inc
> > > > +++ b/conf/machine/include/ti33x.inc
> > > > @@ -39,7 +39,7 @@ KERNEL_DEVICETREE = " \  KERNEL_DEVICETREE +=
> > > > "${@oe.utils.conditional('ENABLE_TI_UIO_DEVICES', '1', 'am335x-icev2-pru-excl-uio.dtb', '', d)}"
> > > >
> > > >  UBOOT_ARCH = "arm"
> > > > -UBOOT_MACHINE = "am335x_evm_config"
> > > > +UBOOT_MACHINE ?= "am335x_evm_config"
> > > >
> > > >  UBOOT_ENTRYPOINT = "0x80008000"
> > > >  UBOOT_LOADADDRESS = "0x80008000"
> > > > --
> > > > 2.17.1
> > > >
> ________________________________
>  This email is confidential and may contain information subject to legal privilege. If you are not the intended recipient please advise us of our error by return e-mail then delete this email and any attached files. You may not copy, disclose or use the contents in any way. The views expressed in this email may not be those of Gallagher Group Ltd or subsidiary companies thereof.
> ________________________________

Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

[Denys Dmytriyenko]

On Tue, Jun 30, 2020 at 12:55:13AM +0000, Ankur Tyagi wrote:
> Hi Denys,
> 
> meta-arago seems good now (dunfell), not much usage of am335x-evm
> 
> ./meta-arago-distro/conf/distro/include/branding-amsdk.inc
> ./meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb
> ./meta-arago-extras/recipes-apps/acontis-ethercat-demo/acontis-atemsys_3.0.1.28.bb
> ./meta-arago-extras/recipes-devtools/pinmux-utility/pinmux-utility_2.5.2.0.bb
> 
> My response was biased with previous (old)branches experience.
> 
> I had another look in meta-ti machines and I think I should follow the pattern
> used in am335x-hs-evm.conf.
> 
> This way I can add my board conf that can reside with default machine conf's
> What is your opinion about it?

Yeah, that sounds good. Let me know how that goes and if you need any fixes. 
Thanks.

-- 
Denys


> Regards
> Ankur
> 
> -----Original Message-----
> From: Denys Dmytriyenko <denys@ti.com> 
> Sent: Tuesday, 30 June 2020 9:21 AM
> To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
> Cc: meta-ti@lists.yoctoproject.org
> Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> 
> Sorry, was away for a bit. Can you please identify where in meta-arago 
> "am335x-evm" machine is used directly where it should be "ti33x" family 
> instead? Or you can send patches to fix those places. Thanks.
> 
> -- 
> Denys
> 
> 
> On Mon, Jun 29, 2020 at 04:05:13PM +0000, Ankur Tyagi wrote:
> > Hi Denys,
> > 
> > Didn't got your feedback so does that mean my reason doesn't stack up?
> > 
> > Regards
> > Ankur
> > 
> > -----Original Message-----
> > From: meta-ti@lists.yoctoproject.org <meta-ti@lists.yoctoproject.org> On Behalf Of Ankur Tyagi
> > Sent: Thursday, 18 June 2020 3:55 PM
> > To: Denys Dmytriyenko <denys@ti.com>
> > Cc: meta-ti@lists.yoctoproject.org
> > Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> > 
> > Apologies, my bad
> > 
> > > The idea is that if you are creating a custom board based on am335x-evm and
> > > adding new config to U-boot, you should consider adding a new OE machine. Even
> > > if your machine includes ti33x.inc for common SoC definitions, you can still
> > > overwrite UBOOT_MACHINE in your <custom-machine>.conf file...
> > 
> > I did started with this idea but meta-arago has lot of "am335x-evm" machine usage throughout.
> > That would mean to add new machine override in lot of meta-arago recipes.
> > 
> > Keeping a new board config in u-boot is desired to allow easy upgrading of u-boot from sitara-u-boot git repo.
> > Modifying am335x board specific in u-boot doesn't scale well.
> > 
> > Hence came up with this approach to allow uboot config override in bsp layer but still use most of distro layer
> > as it is.
> > 
> > But I am open to new ideas/suggestions as well.
> > 
> > Regards
> > Ankur
> > 
> > -----Original Message-----
> > From: Denys Dmytriyenko <denys@ti.com>
> > Sent: Thursday, 18 June 2020 1:19 PM
> > To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
> > Cc: meta-ti@lists.yoctoproject.org
> > Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> > 
> > On Thu, Jun 18, 2020 at 12:40:23AM +0000, Ankur Tyagi wrote:
> > > Hi Denys,
> > >
> > > Yes, I did sent the patch again on mailing list and once the patch appeared,
> > > then only I sent reminder.
> > >
> > > To begin with, this is what I think happened:
> > > - Sent a patch to the list but somehow it failed
> > > - without realizing that failure, I sent reminder for the failed one
> > > https://lists.yoctoproject.org/g/meta-ti/message/12990
> > > - you identified the problem and suggested to send it again
> > > https://lists.yoctoproject.org/g/meta-ti/message/12991
> > 
> > And also there ^^^ I commented on feasibility of the change, which you seem to
> > have missed...
> > 
> > 
> > > - I did sent the patch again and it made it to mailing list
> > > https://lists.yoctoproject.org/g/meta-ti/message/12992
> > > - and then reminder for the successful sent patch
> > > https://lists.yoctoproject.org/g/meta-ti/message/12993
> > >
> > > I sent the patch again with the same subject, somehow it got merged in the same topic
> > > and doesn't appear as a separate patch?
> > > Should I do slight change in the subject so that it appears as a separate topic in the list?
> > >
> > > Not sure what's the best way to proceed here.
> > >
> > > Regards
> > > Ankur
> > >
> > > -----Original Message-----
> > > From: Denys Dmytriyenko <denys@ti.com>
> > > Sent: Thursday, 18 June 2020 11:54 AM
> > > To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
> > > Cc: meta-ti@lists.yoctoproject.org
> > > Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> > >
> > > On Tue, Jun 16, 2020 at 11:40:47PM +0000, Ankur Tyagi wrote:
> > > > Hi Denys,
> > > >
> > > > Do you want me to send another patch?
> > > > Maybe with an updated subject to differentiate?
> > > >
> > > > Let me know what's the best way to proceed
> > >
> > > Have you considered what I said here:
> > > https://lists.yoctoproject.org/g/meta-ti/topic/74828692
> > >
> > >
> > > > Regards
> > > > Ankur
> > > >
> > > > -----Original Message-----
> > > > From: meta-ti@lists.yoctoproject.org <meta-ti@lists.yoctoproject.org> On Behalf Of Ankur Tyagi
> > > > Sent: Tuesday, 16 June 2020 7:45 AM
> > > > To: Denys Dmytriyenko <denys@ti.com>
> > > > Cc: meta-ti@lists.yoctoproject.org
> > > > Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> > > >
> > > > Hi Denys,
> > > >
> > > > I did received your response and resent the patch.
> > > > This is the reminder for the second patch.
> > > >
> > > > Regards
> > > > Ankur
> > > >
> > > > -----Original Message-----
> > > > From: Denys Dmytriyenko <denys@ti.com>
> > > > Sent: Tuesday, 16 June 2020 7:42 AM
> > > > To: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
> > > > Cc: meta-ti@lists.yoctoproject.org
> > > > Subject: Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> > > >
> > > > On Mon, Jun 15, 2020 at 07:38:36PM +0000, Ankur Tyagi wrote:
> > > > > Hi Denys,
> > > > >
> > > > > Gentle reminder as this patch has been in the mailing list (#12992)
> > > > > for some time now but I haven't heard anything.
> > > >
> > > > Is your subscription working properly? I did reply here:
> > > > https://lists.yoctoproject.org/g/meta-ti/topic/74828692
> > > >
> > > >
> > > > > Regards
> > > > > Ankur
> > > > >
> > > > > -----Original Message-----
> > > > > From: Ankur Tyagi
> > > > > Sent: Friday, 12 June 2020 10:49 AM
> > > > > To: meta-ti@lists.yoctoproject.org
> > > > > Subject: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak
> > > > > assignment for uboot board config
> > > > >
> > > > > When using meta-ti BSP layer, user should be able to override default
> > > > > uboot board config with their custom board config as it is common for
> > > > > customers to design custom board based upon am335x-evm dev kit.
> > > > >
> > > > > Signed-off-by: Ankur Tyagi <ankur.tyagi@gallagher.com>
> > > > > ---
> > > > >  conf/machine/include/ti33x.inc | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/conf/machine/include/ti33x.inc
> > > > > b/conf/machine/include/ti33x.inc index abfd7ec7..ff72a382 100644
> > > > > --- a/conf/machine/include/ti33x.inc
> > > > > +++ b/conf/machine/include/ti33x.inc
> > > > > @@ -39,7 +39,7 @@ KERNEL_DEVICETREE = " \  KERNEL_DEVICETREE +=
> > > > > "${@oe.utils.conditional('ENABLE_TI_UIO_DEVICES', '1', 'am335x-icev2-pru-excl-uio.dtb', '', d)}"
> > > > >
> > > > >  UBOOT_ARCH = "arm"
> > > > > -UBOOT_MACHINE = "am335x_evm_config"
> > > > > +UBOOT_MACHINE ?= "am335x_evm_config"
> > > > >
> > > > >  UBOOT_ENTRYPOINT = "0x80008000"
> > > > >  UBOOT_LOADADDRESS = "0x80008000"
> > > > > --
> > > > > 2.17.1
> > > > >
> > ________________________________
> >  This email is confidential and may contain information subject to legal privilege. If you are not the intended recipient please advise us of our error by return e-mail then delete this email and any attached files. You may not copy, disclose or use the contents in any way. The views expressed in this email may not be those of Gallagher Group Ltd or subsidiary companies thereof.
> > ________________________________

Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

[Ankur Tyagi]

ping

-----Original Message-----
From: Ankur Tyagi <ankur.tyagi@gallagher.com> 
Sent: Tuesday, 9 June 2020 4:02 PM
To: meta-ti@lists.yoctoproject.org
Cc: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
Subject: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

When using meta-ti BSP layer, user should be able to override default uboot
board config with their custom board config as it is common for customers
to design custom board based upon am335x-evm dev kit.

Signed-off-by: Ankur Tyagi <ankur.tyagi@gallagher.com>
---
 conf/machine/include/ti33x.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/conf/machine/include/ti33x.inc b/conf/machine/include/ti33x.inc
index abfd7ec7..ff72a382 100644
--- a/conf/machine/include/ti33x.inc
+++ b/conf/machine/include/ti33x.inc
@@ -39,7 +39,7 @@ KERNEL_DEVICETREE = " \
 KERNEL_DEVICETREE += "${@oe.utils.conditional('ENABLE_TI_UIO_DEVICES', '1', 'am335x-icev2-pru-excl-uio.dtb', '', d)}"
 
 UBOOT_ARCH = "arm"
-UBOOT_MACHINE = "am335x_evm_config"
+UBOOT_MACHINE ?= "am335x_evm_config"
 
 UBOOT_ENTRYPOINT = "0x80008000"
 UBOOT_LOADADDRESS = "0x80008000"
-- 
2.17.1

Re: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config

[Denys Dmytriyenko]

On Thu, Jun 11, 2020 at 10:13:53PM +0000, Ankur Tyagi wrote:
> ping

I haven't seen this patch on the list - are you sure you sent it properly? Can 
you please re-send it again?


> -----Original Message-----
> From: Ankur Tyagi <ankur.tyagi@gallagher.com> 
> Sent: Tuesday, 9 June 2020 4:02 PM
> To: meta-ti@lists.yoctoproject.org
> Cc: Ankur Tyagi <Ankur.Tyagi@gallagher.com>
> Subject: [meta-ti][dunfell/master PATCH] ti33x.inc: Use weak assignment for uboot board config
> 
> When using meta-ti BSP layer, user should be able to override default uboot
> board config with their custom board config as it is common for customers
> to design custom board based upon am335x-evm dev kit.

The idea is that if you are creating a custom board based on am335x-evm and 
adding new config to U-boot, you should consider adding a new OE machine. Even 
if your machine includes ti33x.inc for common SoC definitions, you can still 
overwrite UBOOT_MACHINE in your <custom-machine>.conf file...


> Signed-off-by: Ankur Tyagi <ankur.tyagi@gallagher.com>
> ---
>  conf/machine/include/ti33x.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/conf/machine/include/ti33x.inc b/conf/machine/include/ti33x.inc
> index abfd7ec7..ff72a382 100644
> --- a/conf/machine/include/ti33x.inc
> +++ b/conf/machine/include/ti33x.inc
> @@ -39,7 +39,7 @@ KERNEL_DEVICETREE = " \
>  KERNEL_DEVICETREE += "${@oe.utils.conditional('ENABLE_TI_UIO_DEVICES', '1', 'am335x-icev2-pru-excl-uio.dtb', '', d)}"
>  
>  UBOOT_ARCH = "arm"
> -UBOOT_MACHINE = "am335x_evm_config"
> +UBOOT_MACHINE ?= "am335x_evm_config"
>  
>  UBOOT_ENTRYPOINT = "0x80008000"
>  UBOOT_LOADADDRESS = "0x80008000"
> -- 
> 2.17.1
> 

>