From: Dan Carpenter <dan.carpenter@oracle.com>
To: Garrit Franke <garritfranke@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
Liviu Dudau <liviu.dudau@arm.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Colin Ian King <colin.king@canonical.com>
Subject: Re: [PATCH] drm/arm: fix unintentional integer overflow on left shift
Date: Thu, 18 Jun 2020 15:22:04 +0000 [thread overview]
Message-ID: <20200618152204.GU4151@kadam> (raw)
In-Reply-To: <CAD16O86ebsDkwbnuw2G04YZWfukqxJ=_Tex5OT07icEpfPdQNw@mail.gmail.com>
On Thu, Jun 18, 2020 at 04:36:51PM +0200, Garrit Franke wrote:
> Hi all, newbie here.
> Can the BIT macro be safely used on other parts of the kernel as well?
> Just using git grep "1 <<" returns a ton of results where bit shifting
> is used the old fashioned way.
Yeah. There is a checkpatch warning for it and everything. :)
But I like the way you think. Start with patches to staging though.
People don't necessarily like doing cleanups on ancient code.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Garrit Franke <garritfranke@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
Liviu Dudau <liviu.dudau@arm.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Colin Ian King <colin.king@canonical.com>
Subject: Re: [PATCH] drm/arm: fix unintentional integer overflow on left shift
Date: Thu, 18 Jun 2020 18:22:04 +0300 [thread overview]
Message-ID: <20200618152204.GU4151@kadam> (raw)
In-Reply-To: <CAD16O86ebsDkwbnuw2G04YZWfukqxJ=_Tex5OT07icEpfPdQNw@mail.gmail.com>
On Thu, Jun 18, 2020 at 04:36:51PM +0200, Garrit Franke wrote:
> Hi all, newbie here.
> Can the BIT macro be safely used on other parts of the kernel as well?
> Just using git grep "1 <<" returns a ton of results where bit shifting
> is used the old fashioned way.
Yeah. There is a checkpatch warning for it and everything. :)
But I like the way you think. Start with patches to staging though.
People don't necessarily like doing cleanups on ancient code.
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Garrit Franke <garritfranke@gmail.com>
Cc: Liviu Dudau <liviu.dudau@arm.com>,
Colin Ian King <colin.king@canonical.com>,
David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/arm: fix unintentional integer overflow on left shift
Date: Thu, 18 Jun 2020 18:22:04 +0300 [thread overview]
Message-ID: <20200618152204.GU4151@kadam> (raw)
In-Reply-To: <CAD16O86ebsDkwbnuw2G04YZWfukqxJ=_Tex5OT07icEpfPdQNw@mail.gmail.com>
On Thu, Jun 18, 2020 at 04:36:51PM +0200, Garrit Franke wrote:
> Hi all, newbie here.
> Can the BIT macro be safely used on other parts of the kernel as well?
> Just using git grep "1 <<" returns a ton of results where bit shifting
> is used the old fashioned way.
Yeah. There is a checkpatch warning for it and everything. :)
But I like the way you think. Start with patches to staging though.
People don't necessarily like doing cleanups on ancient code.
regards,
dan carpenter
next prev parent reply other threads:[~2020-06-18 15:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 10:04 [PATCH] drm/arm: fix unintentional integer overflow on left shift Colin King
2020-06-18 10:04 ` Colin King
2020-06-18 10:04 ` Colin King
2020-06-18 12:14 ` Liviu Dudau
2020-06-18 12:14 ` Liviu Dudau
2020-06-18 12:14 ` Liviu Dudau
2020-06-18 12:50 ` Colin Ian King
2020-06-18 12:50 ` Colin Ian King
2020-06-18 12:50 ` Colin Ian King
2020-06-18 14:21 ` Liviu Dudau
2020-06-18 14:21 ` Liviu Dudau
2020-06-18 14:21 ` Liviu Dudau
2020-06-18 14:36 ` Garrit Franke
2020-06-18 14:36 ` Garrit Franke
2020-06-18 14:36 ` Garrit Franke
2020-06-18 14:38 ` Colin Ian King
2020-06-18 14:38 ` Colin Ian King
2020-06-18 14:38 ` Colin Ian King
2020-06-18 15:22 ` Dan Carpenter [this message]
2020-06-18 15:22 ` Dan Carpenter
2020-06-18 15:22 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618152204.GU4151@kadam \
--to=dan.carpenter@oracle.com \
--cc=airlied@linux.ie \
--cc=colin.king@canonical.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=garritfranke@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.