From: Kees Cook <keescook@chromium.org>
To: Sedat Dilek <sedat.dilek@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Alexander Potapenko <glider@google.com>,
Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
x86@kernel.org, drbd-dev@lists.linbit.com,
linux-block@vger.kernel.org, b43-dev@lists.infradead.org,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-wireless@vger.kernel.org, linux-ide@vger.kernel.org,
linux-clk@vger.kernel.org, linux-spi@vger.kernel.org,
linux-mm@kvack.org,
Clang-Built-Linux ML <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH v2 00/16] Remove uninitialized_var() macro
Date: Sat, 20 Jun 2020 08:57:04 -0700 [thread overview]
Message-ID: <202006200854.B2D8F21@keescook> (raw)
In-Reply-To: <CA+icZUWpHRR7ukyepiUH1dR3r4GMi-s2crfwR5vTszdt1SUTQw@mail.gmail.com>
On Sat, Jun 20, 2020 at 09:03:34AM +0200, Sedat Dilek wrote:
> On Sat, Jun 20, 2020 at 5:30 AM Kees Cook <keescook@chromium.org> wrote:
> >
> > v2:
> > - more special-cased fixes
> > - add reviews
> > v1: https://lore.kernel.org/lkml/20200603233203.1695403-1-keescook@chromium.org
> >
> > Using uninitialized_var() is dangerous as it papers over real bugs[1]
> > (or can in the future), and suppresses unrelated compiler warnings
> > (e.g. "unused variable"). If the compiler thinks it is uninitialized,
> > either simply initialize the variable or make compiler changes.
> >
> > As recommended[2] by[3] Linus[4], remove the macro.
> >
> > Most of the 300 uses don't cause any warnings on gcc 9.3.0, so they're in
> > a single treewide commit in this series. A few others needed to actually
> > get cleaned up, and I broke those out into individual patches.
> >
> > The tree is:
> > https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=kspp/uninit/macro
> >
> > -Kees
> >
>
> Hi Kees,
>
> thanks for doing a v2 of your patchset.
>
> As I saw Jason Yan providing some "uninitialized_var() macro" patches
> to the MLs I pointen him to your tree "v1".
Thanks!
> BTW, I have tested your "v1" against Linux v5.7 (see [1]) - just
> yesterday with Linux v5.7.5-rc1.
>
> Is it possible to have a v2 of this patchset on top od Linux v5.7 - if
> you do not mind.
Since it's only going to be for post-v5.8, I'm fine skipping the v5.7
testing. Mainly I'm looking at v5.8 and linux-next.
Thanks for looking at it!
--
Kees Cook
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Sedat Dilek <sedat.dilek@gmail.com>
Cc: Andy Whitcroft <apw@canonical.com>,
Clang-Built-Linux ML <clang-built-linux@googlegroups.com>,
linux-doc@vger.kernel.org, netdev@vger.kernel.org,
x86@kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-block@vger.kernel.org,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
linux-mm@kvack.org, Alexander Potapenko <glider@google.com>,
b43-dev@lists.infradead.org, linux-ide@vger.kernel.org,
Joe Perches <joe@perches.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-clk@vger.kernel.org, drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH v2 00/16] Remove uninitialized_var() macro
Date: Sat, 20 Jun 2020 08:57:04 -0700 [thread overview]
Message-ID: <202006200854.B2D8F21@keescook> (raw)
In-Reply-To: <CA+icZUWpHRR7ukyepiUH1dR3r4GMi-s2crfwR5vTszdt1SUTQw@mail.gmail.com>
On Sat, Jun 20, 2020 at 09:03:34AM +0200, Sedat Dilek wrote:
> On Sat, Jun 20, 2020 at 5:30 AM Kees Cook <keescook@chromium.org> wrote:
> >
> > v2:
> > - more special-cased fixes
> > - add reviews
> > v1: https://lore.kernel.org/lkml/20200603233203.1695403-1-keescook@chromium.org
> >
> > Using uninitialized_var() is dangerous as it papers over real bugs[1]
> > (or can in the future), and suppresses unrelated compiler warnings
> > (e.g. "unused variable"). If the compiler thinks it is uninitialized,
> > either simply initialize the variable or make compiler changes.
> >
> > As recommended[2] by[3] Linus[4], remove the macro.
> >
> > Most of the 300 uses don't cause any warnings on gcc 9.3.0, so they're in
> > a single treewide commit in this series. A few others needed to actually
> > get cleaned up, and I broke those out into individual patches.
> >
> > The tree is:
> > https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=kspp/uninit/macro
> >
> > -Kees
> >
>
> Hi Kees,
>
> thanks for doing a v2 of your patchset.
>
> As I saw Jason Yan providing some "uninitialized_var() macro" patches
> to the MLs I pointen him to your tree "v1".
Thanks!
> BTW, I have tested your "v1" against Linux v5.7 (see [1]) - just
> yesterday with Linux v5.7.5-rc1.
>
> Is it possible to have a v2 of this patchset on top od Linux v5.7 - if
> you do not mind.
Since it's only going to be for post-v5.8, I'm fine skipping the v5.7
testing. Mainly I'm looking at v5.8 and linux-next.
Thanks for looking at it!
--
Kees Cook
next prev parent reply other threads:[~2020-06-20 15:57 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-20 3:29 [PATCH v2 00/16] Remove uninitialized_var() macro Kees Cook
2020-06-20 3:29 ` [Drbd-dev] " Kees Cook
2020-06-20 3:29 ` [PATCH v2 01/16] docs: deprecated.rst: Add uninitialized_var() Kees Cook
2020-06-20 3:29 ` [Drbd-dev] " Kees Cook
2020-06-22 16:59 ` Nick Desaulniers
2020-06-22 16:59 ` Nick Desaulniers
2020-06-20 3:29 ` [PATCH v2 02/16] x86/mm/numa: Remove uninitialized_var() usage Kees Cook
2020-06-20 3:29 ` [Drbd-dev] " Kees Cook
2020-06-20 3:29 ` [PATCH v2 03/16] drbd: " Kees Cook
2020-06-20 3:29 ` [Drbd-dev] " Kees Cook
2020-06-20 3:29 ` [PATCH v2 04/16] b43: " Kees Cook
2020-06-20 3:29 ` [Drbd-dev] " Kees Cook
2020-06-22 17:04 ` Nick Desaulniers
2020-06-22 17:04 ` Nick Desaulniers
2020-06-22 21:04 ` Kees Cook
2020-06-22 21:04 ` [Drbd-dev] " Kees Cook
2020-06-22 21:04 ` Kees Cook
2020-06-23 18:29 ` Nick Desaulniers
2020-06-23 18:29 ` Nick Desaulniers
2020-07-15 10:37 ` Kalle Valo
2020-07-15 10:37 ` Kalle Valo
2020-07-15 10:37 ` [Drbd-dev] " Kalle Valo
2020-07-15 10:37 ` Kalle Valo
2020-06-20 3:29 ` [PATCH v2 05/16] rtlwifi: rtl8192cu: " Kees Cook
2020-06-20 3:29 ` [Drbd-dev] " Kees Cook
2020-06-20 3:29 ` [PATCH v2 06/16] ide: " Kees Cook
2020-06-20 3:29 ` [Drbd-dev] " Kees Cook
2020-06-20 3:29 ` [PATCH v2 07/16] clk: st: " Kees Cook
2020-06-20 3:29 ` [Drbd-dev] " Kees Cook
2020-06-22 9:03 ` Stephen Boyd
2020-06-22 9:03 ` Stephen Boyd
2020-06-20 3:29 ` [PATCH v2 08/16] spi: davinci: " Kees Cook
2020-06-20 3:29 ` [Drbd-dev] " Kees Cook
2020-07-01 20:39 ` Mark Brown
2020-07-01 20:39 ` Mark Brown
2020-07-02 15:21 ` Kees Cook
2020-07-02 15:21 ` [Drbd-dev] " Kees Cook
2020-07-02 15:21 ` Kees Cook
2020-07-02 15:23 ` Mark Brown
2020-07-02 15:23 ` Mark Brown
2020-07-02 15:42 ` Kees Cook
2020-07-02 15:42 ` [Drbd-dev] " Kees Cook
2020-07-02 15:42 ` Kees Cook
2020-07-02 16:23 ` Joe Perches
2020-07-02 16:23 ` [Drbd-dev] " Joe Perches
2020-07-02 16:23 ` Joe Perches
2020-06-20 3:30 ` [PATCH v2 09/16] clk: spear: " Kees Cook
2020-06-20 3:30 ` [Drbd-dev] " Kees Cook
2020-06-22 9:03 ` Stephen Boyd
2020-06-22 9:03 ` Stephen Boyd
2020-06-20 3:30 ` [PATCH v2 10/16] KVM: PPC: Book3S PR: " Kees Cook
2020-06-20 3:30 ` [Drbd-dev] " Kees Cook
2020-06-22 17:22 ` Nick Desaulniers
2020-06-22 17:22 ` Nick Desaulniers
2020-06-20 3:30 ` [PATCH v2 11/16] media: sur40: " Kees Cook
2020-06-20 3:30 ` [Drbd-dev] " Kees Cook
2020-06-22 18:39 ` Nick Desaulniers
2020-06-22 18:39 ` Nick Desaulniers
2020-06-20 3:30 ` [PATCH v2 12/16] f2fs: Eliminate usage of uninitialized_var() macro Kees Cook
2020-06-20 3:30 ` [Drbd-dev] " Kees Cook
2020-06-20 3:30 ` [PATCH v2 14/16] checkpatch: Remove awareness " Kees Cook
2020-06-20 3:30 ` [Drbd-dev] " Kees Cook
2020-06-20 3:30 ` [PATCH v2 15/16] treewide: Remove uninitialized_var() usage Kees Cook
2020-06-22 11:32 ` Dan Carpenter
2020-06-22 11:32 ` Dan Carpenter
2020-06-20 3:30 ` [PATCH v2 16/16] compiler: Remove uninitialized_var() macro Kees Cook
2020-06-20 3:30 ` [Drbd-dev] " Kees Cook
2020-06-20 3:30 ` [PATCH v2 13/16] mm/debug_vm_pgtable: Remove uninitialized_var() usage Kees Cook
2020-06-20 3:30 ` [Drbd-dev] " Kees Cook
2020-06-22 17:27 ` Nick Desaulniers
2020-06-22 17:27 ` Nick Desaulniers
2020-06-20 7:03 ` [PATCH v2 00/16] Remove uninitialized_var() macro Sedat Dilek
2020-10-12 15:37 ` [Drbd-dev] " Sedat Dilek
2020-06-20 15:57 ` Kees Cook [this message]
2020-06-20 15:57 ` Kees Cook
2020-06-22 9:07 ` Sedat Dilek
2020-06-22 9:07 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006200854.B2D8F21@keescook \
--to=keescook@chromium.org \
--cc=apw@canonical.com \
--cc=b43-dev@lists.infradead.org \
--cc=clang-built-linux@googlegroups.com \
--cc=drbd-dev@lists.linbit.com \
--cc=glider@google.com \
--cc=joe@perches.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sedat.dilek@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.