[rcu:dev.2020.06.17a 35/38] kernel/sched/core.c:2650 try_to_wake

All of lore.kernel.org
 help / color / mirror / Atom feed

* [rcu:dev.2020.06.17a 35/38] kernel/sched/core.c:2650 try_to_wake_up() error: uninitialized symbol 'cpu'.
@ 2020-06-22 12:11 ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2020-06-22 12:11 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 2362 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2020.06.17a
head:   d3779e78b9848a707448dbb4a0cb6c4bb651fe9c
commit: 59a5d883f2ccdce1700862b5983cfd3473630aea [35/38] EXP sched: Alleged fix for v5.8 merge-window scheduler issue
config: x86_64-randconfig-m001-20200621 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
kernel/sched/core.c:2650 try_to_wake_up() error: uninitialized symbol 'cpu'.

# https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/commit/?id=59a5d883f2ccdce1700862b5983cfd3473630aea
git remote add rcu https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
git remote update rcu
git checkout 59a5d883f2ccdce1700862b5983cfd3473630aea
vim +/cpu +2650 kernel/sched/core.c

^1da177e4c3f41 kernel/sched.c      Linus Torvalds 2005-04-16  2644  
b5179ac70de85e kernel/sched/core.c Peter Zijlstra 2016-05-11  2645  	ttwu_queue(p, cpu, wake_flags);
aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07  2646  unlock:
013fdb8086acaa kernel/sched.c      Peter Zijlstra 2011-04-05  2647  	raw_spin_unlock_irqrestore(&p->pi_lock, flags);
aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07  2648  out:
aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07  2649  	if (success)
aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07 @2650  		ttwu_stat(p, cpu, wake_flags);
                                                                                             ^^^
This can be uninitialized on a couple "goto unlock;" paths.  Lines
2581 and 2622.  The KASan tool will warn about this at run time as well.
I'm not sure why the build bot doesn't include the whole function for
this bug report...

e3d85487fba422 kernel/sched/core.c Peter Zijlstra 2019-07-10  2651  	preempt_enable();
^1da177e4c3f41 kernel/sched.c      Linus Torvalds 2005-04-16  2652  
^1da177e4c3f41 kernel/sched.c      Linus Torvalds 2005-04-16  2653  	return success;
^1da177e4c3f41 kernel/sched.c      Linus Torvalds 2005-04-16  2654  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33539 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [rcu:dev.2020.06.17a 35/38] kernel/sched/core.c:2650 try_to_wake_up() error: uninitialized symbol 'cpu'.
@ 2020-06-22 12:11 ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2020-06-22 12:11 UTC (permalink / raw)
  To: kbuild, Peter Zijlstra; +Cc: lkp, kbuild-all, linux-kernel, Paul E. McKenney

[-- Attachment #1: Type: text/plain, Size: 2320 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2020.06.17a
head:   d3779e78b9848a707448dbb4a0cb6c4bb651fe9c
commit: 59a5d883f2ccdce1700862b5983cfd3473630aea [35/38] EXP sched: Alleged fix for v5.8 merge-window scheduler issue
config: x86_64-randconfig-m001-20200621 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
kernel/sched/core.c:2650 try_to_wake_up() error: uninitialized symbol 'cpu'.

# https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/commit/?id=59a5d883f2ccdce1700862b5983cfd3473630aea
git remote add rcu https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
git remote update rcu
git checkout 59a5d883f2ccdce1700862b5983cfd3473630aea
vim +/cpu +2650 kernel/sched/core.c

^1da177e4c3f41 kernel/sched.c      Linus Torvalds 2005-04-16  2644  
b5179ac70de85e kernel/sched/core.c Peter Zijlstra 2016-05-11  2645  	ttwu_queue(p, cpu, wake_flags);
aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07  2646  unlock:
013fdb8086acaa kernel/sched.c      Peter Zijlstra 2011-04-05  2647  	raw_spin_unlock_irqrestore(&p->pi_lock, flags);
aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07  2648  out:
aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07  2649  	if (success)
aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07 @2650  		ttwu_stat(p, cpu, wake_flags);
                                                                                             ^^^
This can be uninitialized on a couple "goto unlock;" paths.  Lines
2581 and 2622.  The KASan tool will warn about this at run time as well.
I'm not sure why the build bot doesn't include the whole function for
this bug report...

e3d85487fba422 kernel/sched/core.c Peter Zijlstra 2019-07-10  2651  	preempt_enable();
^1da177e4c3f41 kernel/sched.c      Linus Torvalds 2005-04-16  2652  
^1da177e4c3f41 kernel/sched.c      Linus Torvalds 2005-04-16  2653  	return success;
^1da177e4c3f41 kernel/sched.c      Linus Torvalds 2005-04-16  2654  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33539 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [rcu:dev.2020.06.17a 35/38] kernel/sched/core.c:2650 try_to_wake_up() error: uninitialized symbol 'cpu'.
@ 2020-06-22 12:11 ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2020-06-22 12:11 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 2362 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2020.06.17a
head:   d3779e78b9848a707448dbb4a0cb6c4bb651fe9c
commit: 59a5d883f2ccdce1700862b5983cfd3473630aea [35/38] EXP sched: Alleged fix for v5.8 merge-window scheduler issue
config: x86_64-randconfig-m001-20200621 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
kernel/sched/core.c:2650 try_to_wake_up() error: uninitialized symbol 'cpu'.

# https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/commit/?id=59a5d883f2ccdce1700862b5983cfd3473630aea
git remote add rcu https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
git remote update rcu
git checkout 59a5d883f2ccdce1700862b5983cfd3473630aea
vim +/cpu +2650 kernel/sched/core.c

^1da177e4c3f41 kernel/sched.c      Linus Torvalds 2005-04-16  2644  
b5179ac70de85e kernel/sched/core.c Peter Zijlstra 2016-05-11  2645  	ttwu_queue(p, cpu, wake_flags);
aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07  2646  unlock:
013fdb8086acaa kernel/sched.c      Peter Zijlstra 2011-04-05  2647  	raw_spin_unlock_irqrestore(&p->pi_lock, flags);
aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07  2648  out:
aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07  2649  	if (success)
aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07 @2650  		ttwu_stat(p, cpu, wake_flags);
                                                                                             ^^^
This can be uninitialized on a couple "goto unlock;" paths.  Lines
2581 and 2622.  The KASan tool will warn about this at run time as well.
I'm not sure why the build bot doesn't include the whole function for
this bug report...

e3d85487fba422 kernel/sched/core.c Peter Zijlstra 2019-07-10  2651  	preempt_enable();
^1da177e4c3f41 kernel/sched.c      Linus Torvalds 2005-04-16  2652  
^1da177e4c3f41 kernel/sched.c      Linus Torvalds 2005-04-16  2653  	return success;
^1da177e4c3f41 kernel/sched.c      Linus Torvalds 2005-04-16  2654  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33539 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [rcu:dev.2020.06.17a 35/38] kernel/sched/core.c:2650 try_to_wake_up() error: uninitialized symbol 'cpu'.
  2020-06-22 12:11 ` Dan Carpenter
@ 2020-06-22 12:27   ` Peter Zijlstra
  -1 siblings, 0 replies; 6+ messages in thread
From: Peter Zijlstra @ 2020-06-22 12:27 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 2074 bytes --]

On Mon, Jun 22, 2020 at 03:11:17PM +0300, Dan Carpenter wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2020.06.17a
> head:   d3779e78b9848a707448dbb4a0cb6c4bb651fe9c
> commit: 59a5d883f2ccdce1700862b5983cfd3473630aea [35/38] EXP sched: Alleged fix for v5.8 merge-window scheduler issue
> config: x86_64-randconfig-m001-20200621 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> smatch warnings:
> kernel/sched/core.c:2650 try_to_wake_up() error: uninitialized symbol 'cpu'.
> 
> # https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/commit/?id=59a5d883f2ccdce1700862b5983cfd3473630aea
> git remote add rcu https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
> git remote update rcu
> git checkout 59a5d883f2ccdce1700862b5983cfd3473630aea
> vim +/cpu +2650 kernel/sched/core.c
> 
> ^1da177e4c3f41 kernel/sched.c      Linus Torvalds 2005-04-16  2644  
> b5179ac70de85e kernel/sched/core.c Peter Zijlstra 2016-05-11  2645  	ttwu_queue(p, cpu, wake_flags);
> aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07  2646  unlock:
> 013fdb8086acaa kernel/sched.c      Peter Zijlstra 2011-04-05  2647  	raw_spin_unlock_irqrestore(&p->pi_lock, flags);
> aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07  2648  out:
> aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07  2649  	if (success)
> aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07 @2650  		ttwu_stat(p, cpu, wake_flags);
>                                                                                              ^^^
> This can be uninitialized on a couple "goto unlock;" paths.  Lines
> 2581 and 2622.  The KASan tool will warn about this at run time as well.
> I'm not sure why the build bot doesn't include the whole function for
> this bug report...

Indeed, lemme go fix.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [rcu:dev.2020.06.17a 35/38] kernel/sched/core.c:2650 try_to_wake_up() error: uninitialized symbol 'cpu'.
@ 2020-06-22 12:27   ` Peter Zijlstra
  0 siblings, 0 replies; 6+ messages in thread
From: Peter Zijlstra @ 2020-06-22 12:27 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: kbuild, lkp, kbuild-all, linux-kernel, Paul E. McKenney

On Mon, Jun 22, 2020 at 03:11:17PM +0300, Dan Carpenter wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2020.06.17a
> head:   d3779e78b9848a707448dbb4a0cb6c4bb651fe9c
> commit: 59a5d883f2ccdce1700862b5983cfd3473630aea [35/38] EXP sched: Alleged fix for v5.8 merge-window scheduler issue
> config: x86_64-randconfig-m001-20200621 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> smatch warnings:
> kernel/sched/core.c:2650 try_to_wake_up() error: uninitialized symbol 'cpu'.
> 
> # https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/commit/?id=59a5d883f2ccdce1700862b5983cfd3473630aea
> git remote add rcu https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
> git remote update rcu
> git checkout 59a5d883f2ccdce1700862b5983cfd3473630aea
> vim +/cpu +2650 kernel/sched/core.c
> 
> ^1da177e4c3f41 kernel/sched.c      Linus Torvalds 2005-04-16  2644  
> b5179ac70de85e kernel/sched/core.c Peter Zijlstra 2016-05-11  2645  	ttwu_queue(p, cpu, wake_flags);
> aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07  2646  unlock:
> 013fdb8086acaa kernel/sched.c      Peter Zijlstra 2011-04-05  2647  	raw_spin_unlock_irqrestore(&p->pi_lock, flags);
> aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07  2648  out:
> aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07  2649  	if (success)
> aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07 @2650  		ttwu_stat(p, cpu, wake_flags);
>                                                                                              ^^^
> This can be uninitialized on a couple "goto unlock;" paths.  Lines
> 2581 and 2622.  The KASan tool will warn about this at run time as well.
> I'm not sure why the build bot doesn't include the whole function for
> this bug report...

Indeed, lemme go fix.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [rcu:dev.2020.06.17a 35/38] kernel/sched/core.c:2650 try_to_wake_up() error: uninitialized symbol 'cpu'.
@ 2020-06-21  9:10 kernel test robot
  0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2020-06-21  9:10 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 2583 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Peter Zijlstra <peterz@infradead.org>
CC: "Paul E. McKenney" <paulmck@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2020.06.17a
head:   d3779e78b9848a707448dbb4a0cb6c4bb651fe9c
commit: 59a5d883f2ccdce1700862b5983cfd3473630aea [35/38] EXP sched: Alleged fix for v5.8 merge-window scheduler issue
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: x86_64-randconfig-m001-20200621 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
kernel/sched/core.c:2650 try_to_wake_up() error: uninitialized symbol 'cpu'.

# https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/commit/?id=59a5d883f2ccdce1700862b5983cfd3473630aea
git remote add rcu https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
git remote update rcu
git checkout 59a5d883f2ccdce1700862b5983cfd3473630aea
vim +/cpu +2650 kernel/sched/core.c

^1da177e4c3f41 kernel/sched.c      Linus Torvalds 2005-04-16  2644  
b5179ac70de85e kernel/sched/core.c Peter Zijlstra 2016-05-11  2645  	ttwu_queue(p, cpu, wake_flags);
aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07  2646  unlock:
013fdb8086acaa kernel/sched.c      Peter Zijlstra 2011-04-05  2647  	raw_spin_unlock_irqrestore(&p->pi_lock, flags);
aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07  2648  out:
aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07  2649  	if (success)
aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07 @2650  		ttwu_stat(p, cpu, wake_flags);
e3d85487fba422 kernel/sched/core.c Peter Zijlstra 2019-07-10  2651  	preempt_enable();
^1da177e4c3f41 kernel/sched.c      Linus Torvalds 2005-04-16  2652  
^1da177e4c3f41 kernel/sched.c      Linus Torvalds 2005-04-16  2653  	return success;
^1da177e4c3f41 kernel/sched.c      Linus Torvalds 2005-04-16  2654  }
^1da177e4c3f41 kernel/sched.c      Linus Torvalds 2005-04-16  2655  

:::::: The code at line 2650 was first introduced by commit
:::::: aacedf26fb7601222f2452cf0a54cab4fee160c5 sched/core: Optimize try_to_wake_up() for local wakeups

:::::: TO: Peter Zijlstra <peterz@infradead.org>
:::::: CC: Ingo Molnar <mingo@kernel.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33539 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-06-22 12:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-22 12:11 [rcu:dev.2020.06.17a 35/38] kernel/sched/core.c:2650 try_to_wake_up() error: uninitialized symbol 'cpu' Dan Carpenter
2020-06-22 12:11 ` Dan Carpenter
2020-06-22 12:11 ` Dan Carpenter
2020-06-22 12:27 ` Peter Zijlstra
2020-06-22 12:27   ` Peter Zijlstra
  -- strict thread matches above, loose matches on Subject: below --
2020-06-21  9:10 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.