[meta-browser][PATCH] chromium.inc: Use python3native.bbclass instead of pythonnative.bbclass

[meta-browser][PATCH] chromium.inc: Use python3native.bbclass instead of pythonnative.bbclass

[Chandana kalluri]

From dunfell onwards, python2 recipes and classes are not supported. Inherit
python3native.bbclass for chromium instead of pythonnative.bbclass

Signed-off-by: Sai Hari Chandana Kalluri <chandana.kalluri@xilinx.com>
---
 recipes-browser/chromium/chromium.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-browser/chromium/chromium.inc b/recipes-browser/chromium/chromium.inc
index 14d762f..a483ec4 100644
--- a/recipes-browser/chromium/chromium.inc
+++ b/recipes-browser/chromium/chromium.inc
@@ -18,7 +18,7 @@ TOOLCHAIN = "clang"
 # to build the native recipes (e.g. GN) with clang too.
 TOOLCHAIN_class-native = "clang"
 
-inherit pythonnative setuptools
+inherit python3native setuptools
 
 # Chromium itself is licensed under the 3-clause BSD license. However, it
 # depends upon several other projects whose copyright files are listed in
-- 
2.7.4

Re: [oe] [meta-browser][PATCH] chromium.inc: Use python3native.bbclass instead of pythonnative.bbclass

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]

Wait, did you actually test this? Chromium is not yet ready for python3,
and builds will fail.

Alex

On Tue, 23 Jun 2020 at 00:09, Chandana kalluri <ckalluri@xilinx.com> wrote:

> From dunfell onwards, python2 recipes and classes are not supported.
> Inherit
> python3native.bbclass for chromium instead of pythonnative.bbclass
>
> Signed-off-by: Sai Hari Chandana Kalluri <chandana.kalluri@xilinx.com>
> ---
>  recipes-browser/chromium/chromium.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-browser/chromium/chromium.inc
> b/recipes-browser/chromium/chromium.inc
> index 14d762f..a483ec4 100644
> --- a/recipes-browser/chromium/chromium.inc
> +++ b/recipes-browser/chromium/chromium.inc
> @@ -18,7 +18,7 @@ TOOLCHAIN = "clang"
>  # to build the native recipes (e.g. GN) with clang too.
>  TOOLCHAIN_class-native = "clang"
>
> -inherit pythonnative setuptools
> +inherit python3native setuptools
>
>  # Chromium itself is licensed under the 3-clause BSD license. However, it
>  # depends upon several other projects whose copyright files are listed in
> --
> 2.7.4
>
> 
>

[-- Attachment #2: Type: text/html, Size: 1618 bytes --]

Re: [oe] [meta-browser][PATCH] chromium.inc: Use python3native.bbclass instead of pythonnative.bbclass

[Denys Dmytriyenko]

Yeah, not gonna work - many people are waiting for this to happen, but alas:

https://bugs.chromium.org/p/chromium/issues/detail?id=942720


On Tue, Jun 23, 2020 at 12:16:51AM +0200, Alexander Kanavin wrote:
> Wait, did you actually test this? Chromium is not yet ready for python3,
> and builds will fail.
> 
> Alex
> 
> On Tue, 23 Jun 2020 at 00:09, Chandana kalluri <ckalluri@xilinx.com> wrote:
> 
> > From dunfell onwards, python2 recipes and classes are not supported.
> > Inherit
> > python3native.bbclass for chromium instead of pythonnative.bbclass
> >
> > Signed-off-by: Sai Hari Chandana Kalluri <chandana.kalluri@xilinx.com>
> > ---
> >  recipes-browser/chromium/chromium.inc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/recipes-browser/chromium/chromium.inc
> > b/recipes-browser/chromium/chromium.inc
> > index 14d762f..a483ec4 100644
> > --- a/recipes-browser/chromium/chromium.inc
> > +++ b/recipes-browser/chromium/chromium.inc
> > @@ -18,7 +18,7 @@ TOOLCHAIN = "clang"
> >  # to build the native recipes (e.g. GN) with clang too.
> >  TOOLCHAIN_class-native = "clang"
> >
> > -inherit pythonnative setuptools
> > +inherit python3native setuptools
> >
> >  # Chromium itself is licensed under the 3-clause BSD license. However, it
> >  # depends upon several other projects whose copyright files are listed in
> > --
> > 2.7.4
> >
> > 
> >

> 

Re: [oe] [meta-browser][PATCH] chromium.inc: Use python3native.bbclass instead of pythonnative.bbclass

[Alejandro Hernandez]

[-- Attachment #1: Type: text/plain, Size: 1882 bytes --]

Some of it is already ported, but it doesn't look like it will be fixed 
soon, its easier to depend on python-native but that creates a 
dependency on meta-python as well as it uses EOL code.

If you do that you have to manually patch lots of stuff on the v8 engine 
(and other components) which try calling /usr/bin/python specifically, 
but it will work.

Alejandro

On 6/22/20 3:32 PM, Denys Dmytriyenko wrote:
> Yeah, not gonna work - many people are waiting for this to happen, but alas:
>
> https://bugs.chromium.org/p/chromium/issues/detail?id=942720
>
>
> On Tue, Jun 23, 2020 at 12:16:51AM +0200, Alexander Kanavin wrote:
>> Wait, did you actually test this? Chromium is not yet ready for python3,
>> and builds will fail.
>>
>> Alex
>>
>> On Tue, 23 Jun 2020 at 00:09, Chandana kalluri <ckalluri@xilinx.com> wrote:
>>
>>>  From dunfell onwards, python2 recipes and classes are not supported.
>>> Inherit
>>> python3native.bbclass for chromium instead of pythonnative.bbclass
>>>
>>> Signed-off-by: Sai Hari Chandana Kalluri <chandana.kalluri@xilinx.com>
>>> ---
>>>   recipes-browser/chromium/chromium.inc | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/recipes-browser/chromium/chromium.inc
>>> b/recipes-browser/chromium/chromium.inc
>>> index 14d762f..a483ec4 100644
>>> --- a/recipes-browser/chromium/chromium.inc
>>> +++ b/recipes-browser/chromium/chromium.inc
>>> @@ -18,7 +18,7 @@ TOOLCHAIN = "clang"
>>>   # to build the native recipes (e.g. GN) with clang too.
>>>   TOOLCHAIN_class-native = "clang"
>>>
>>> -inherit pythonnative setuptools
>>> +inherit python3native setuptools
>>>
>>>   # Chromium itself is licensed under the 3-clause BSD license. However, it
>>>   # depends upon several other projects whose copyright files are listed in
>>> --
>>> 2.7.4
>>>
>>>
>>>
>
> 

[-- Attachment #2: Type: text/html, Size: 2943 bytes --]

Re: [oe] [meta-browser][PATCH] chromium.inc: Use python3native.bbclass instead of pythonnative.bbclass

[Chandana kalluri]

[-- Attachment #1: Type: text/plain, Size: 2686 bytes --]

I am building the meta-browser layer against poky/master and currently I am seeing parse errors as pythonnative and setuptools classes are no longer supported. Hence the patch.
How are everyone else building python2 chromium against poky/master which doesn’t have support for python2 recipes/classes anymore?

Thanks,
Chandana


From: Alejandro Hernandez Samaniego <alhe@linux.microsoft.com>
Sent: Monday, June 22, 2020 3:42 PM
To: Denys Dmytriyenko <denis@denix.org>; Alexander Kanavin <alex.kanavin@gmail.com>
Cc: Chandana Kalluri <ckalluri@xilinx.com>; OpenEmbedded Devel List <openembedded-devel@lists.openembedded.org>; Chandana Kalluri <ckalluri@xilinx.com>
Subject: Re: [oe] [meta-browser][PATCH] chromium.inc: Use python3native.bbclass instead of pythonnative.bbclass


Some of it is already ported, but it doesn't look like it will be fixed soon, its easier to depend on python-native but that creates a dependency on meta-python as well as it uses EOL code.

If you do that you have to manually patch lots of stuff on the v8 engine (and other components) which try calling /usr/bin/python specifically, but it will work.

Alejandro
On 6/22/20 3:32 PM, Denys Dmytriyenko wrote:

Yeah, not gonna work - many people are waiting for this to happen, but alas:



https://bugs.chromium.org/p/chromium/issues/detail?id=942720





On Tue, Jun 23, 2020 at 12:16:51AM +0200, Alexander Kanavin wrote:

Wait, did you actually test this? Chromium is not yet ready for python3,

and builds will fail.



Alex



On Tue, 23 Jun 2020 at 00:09, Chandana kalluri <ckalluri@xilinx.com><mailto:ckalluri@xilinx.com> wrote:



From dunfell onwards, python2 recipes and classes are not supported.

Inherit

python3native.bbclass for chromium instead of pythonnative.bbclass



Signed-off-by: Sai Hari Chandana Kalluri <chandana.kalluri@xilinx.com><mailto:chandana.kalluri@xilinx.com>

---

 recipes-browser/chromium/chromium.inc | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/recipes-browser/chromium/chromium.inc

b/recipes-browser/chromium/chromium.inc

index 14d762f..a483ec4 100644

--- a/recipes-browser/chromium/chromium.inc

+++ b/recipes-browser/chromium/chromium.inc

@@ -18,7 +18,7 @@ TOOLCHAIN = "clang"

 # to build the native recipes (e.g. GN) with clang too.

 TOOLCHAIN_class-native = "clang"



-inherit pythonnative setuptools

+inherit python3native setuptools



 # Chromium itself is licensed under the 3-clause BSD license. However, it

 # depends upon several other projects whose copyright files are listed in

--

2.7.4

















[-- Attachment #2: Type: text/html, Size: 7136 bytes --]

Re: [oe] [meta-browser][PATCH] chromium.inc: Use python3native.bbclass instead of pythonnative.bbclass

[Denys Dmytriyenko]

On Mon, Jun 22, 2020 at 10:53:09PM +0000, Chandana kalluri wrote:
> I am building the meta-browser layer against poky/master and currently I am 
> seeing parse errors as pythonnative and setuptools classes are no longer 
> supported. Hence the patch.

So, have you had any successful builds of chromium after your patches?


> How are everyone else building python2 chromium against poky/master which 
> doesn’t have support for python2 recipes/classes anymore?

You need meta-python2 layer to enable Python2 support.


> Thanks,
> Chandana
> 
> 
> From: Alejandro Hernandez Samaniego <alhe@linux.microsoft.com>
> Sent: Monday, June 22, 2020 3:42 PM
> To: Denys Dmytriyenko <denis@denix.org>; Alexander Kanavin <alex.kanavin@gmail.com>
> Cc: Chandana Kalluri <ckalluri@xilinx.com>; OpenEmbedded Devel List <openembedded-devel@lists.openembedded.org>; Chandana Kalluri <ckalluri@xilinx.com>
> Subject: Re: [oe] [meta-browser][PATCH] chromium.inc: Use python3native.bbclass instead of pythonnative.bbclass
> 
> 
> Some of it is already ported, but it doesn't look like it will be fixed soon, its easier to depend on python-native but that creates a dependency on meta-python as well as it uses EOL code.
> 
> If you do that you have to manually patch lots of stuff on the v8 engine (and other components) which try calling /usr/bin/python specifically, but it will work.
> 
> Alejandro
> On 6/22/20 3:32 PM, Denys Dmytriyenko wrote:
> 
> Yeah, not gonna work - many people are waiting for this to happen, but alas:
> 
> 
> 
> https://bugs.chromium.org/p/chromium/issues/detail?id=942720
> 
> 
> 
> 
> 
> On Tue, Jun 23, 2020 at 12:16:51AM +0200, Alexander Kanavin wrote:
> 
> Wait, did you actually test this? Chromium is not yet ready for python3,
> 
> and builds will fail.
> 
> 
> 
> Alex
> 
> 
> 
> On Tue, 23 Jun 2020 at 00:09, Chandana kalluri <ckalluri@xilinx.com><mailto:ckalluri@xilinx.com> wrote:
> 
> 
> 
> From dunfell onwards, python2 recipes and classes are not supported.
> 
> Inherit
> 
> python3native.bbclass for chromium instead of pythonnative.bbclass
> 
> 
> 
> Signed-off-by: Sai Hari Chandana Kalluri <chandana.kalluri@xilinx.com><mailto:chandana.kalluri@xilinx.com>
> 
> ---
> 
>  recipes-browser/chromium/chromium.inc | 2 +-
> 
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> 
> diff --git a/recipes-browser/chromium/chromium.inc
> 
> b/recipes-browser/chromium/chromium.inc
> 
> index 14d762f..a483ec4 100644
> 
> --- a/recipes-browser/chromium/chromium.inc
> 
> +++ b/recipes-browser/chromium/chromium.inc
> 
> @@ -18,7 +18,7 @@ TOOLCHAIN = "clang"
> 
>  # to build the native recipes (e.g. GN) with clang too.
> 
>  TOOLCHAIN_class-native = "clang"
> 
> 
> 
> -inherit pythonnative setuptools
> 
> +inherit python3native setuptools
> 
> 
> 
>  # Chromium itself is licensed under the 3-clause BSD license. However, it
> 
>  # depends upon several other projects whose copyright files are listed in
> 
> --
> 
> 2.7.4
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 

> 

Re: [oe] [meta-browser][PATCH] chromium.inc: Use python3native.bbclass instead of pythonnative.bbclass

[Chandana kalluri]

> -----Original Message-----
> From: Denys Dmytriyenko <denis@denix.org>
> Sent: Monday, June 22, 2020 4:18 PM
> To: Chandana Kalluri <ckalluri@xilinx.com>
> Cc: Alejandro Hernandez Samaniego <alhe@linux.microsoft.com>; Alexander
> Kanavin <alex.kanavin@gmail.com>; OpenEmbedded Devel List
> <openembedded-devel@lists.openembedded.org>
> Subject: Re: [oe] [meta-browser][PATCH] chromium.inc: Use
> python3native.bbclass instead of pythonnative.bbclass
> 
> On Mon, Jun 22, 2020 at 10:53:09PM +0000, Chandana kalluri wrote:
> > I am building the meta-browser layer against poky/master and currently
> > I am seeing parse errors as pythonnative and setuptools classes are no
> > longer supported. Hence the patch.
> 
> So, have you had any successful builds of chromium after your patches?
> 
I'm afraid I haven't gotten that far in building chromium recipes.
 I just started to upgrade our layers for dunfell and gatesgarth where I have been running into parse errors for this recipe due to invalid pythonnative class inheritance. 

> 
> > How are everyone else building python2 chromium against poky/master
> > which doesn’t have support for python2 recipes/classes anymore?
> 
> You need meta-python2 layer to enable Python2 support.
> 
I will try this out.
 
Thanks,
Chandana
> 
> > Thanks,
> > Chandana
> >
> >
> > From: Alejandro Hernandez Samaniego <alhe@linux.microsoft.com>
> > Sent: Monday, June 22, 2020 3:42 PM
> > To: Denys Dmytriyenko <denis@denix.org>; Alexander Kanavin
> > <alex.kanavin@gmail.com>
> > Cc: Chandana Kalluri <ckalluri@xilinx.com>; OpenEmbedded Devel List
> > <openembedded-devel@lists.openembedded.org>; Chandana Kalluri
> > <ckalluri@xilinx.com>
> > Subject: Re: [oe] [meta-browser][PATCH] chromium.inc: Use
> > python3native.bbclass instead of pythonnative.bbclass
> >
> >
> > Some of it is already ported, but it doesn't look like it will be fixed soon, its
> easier to depend on python-native but that creates a dependency on meta-
> python as well as it uses EOL code.
> >
> > If you do that you have to manually patch lots of stuff on the v8 engine
> (and other components) which try calling /usr/bin/python specifically, but it
> will work.
> >
> > Alejandro
> > On 6/22/20 3:32 PM, Denys Dmytriyenko wrote:
> >
> > Yeah, not gonna work - many people are waiting for this to happen, but
> alas:
> >
> >
> >
> > https://bugs.chromium.org/p/chromium/issues/detail?id=942720
> >
> >
> >
> >
> >
> > On Tue, Jun 23, 2020 at 12:16:51AM +0200, Alexander Kanavin wrote:
> >
> > Wait, did you actually test this? Chromium is not yet ready for
> > python3,
> >
> > and builds will fail.
> >
> >
> >
> > Alex
> >
> >
> >
> > On Tue, 23 Jun 2020 at 00:09, Chandana kalluri
> <ckalluri@xilinx.com><mailto:ckalluri@xilinx.com> wrote:
> >
> >
> >
> > From dunfell onwards, python2 recipes and classes are not supported.
> >
> > Inherit
> >
> > python3native.bbclass for chromium instead of pythonnative.bbclass
> >
> >
> >
> > Signed-off-by: Sai Hari Chandana Kalluri
> > <chandana.kalluri@xilinx.com><mailto:chandana.kalluri@xilinx.com>
> >
> > ---
> >
> >  recipes-browser/chromium/chromium.inc | 2 +-
> >
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >
> >
> > diff --git a/recipes-browser/chromium/chromium.inc
> >
> > b/recipes-browser/chromium/chromium.inc
> >
> > index 14d762f..a483ec4 100644
> >
> > --- a/recipes-browser/chromium/chromium.inc
> >
> > +++ b/recipes-browser/chromium/chromium.inc
> >
> > @@ -18,7 +18,7 @@ TOOLCHAIN = "clang"
> >
> >  # to build the native recipes (e.g. GN) with clang too.
> >
> >  TOOLCHAIN_class-native = "clang"
> >
> >
> >
> > -inherit pythonnative setuptools
> >
> > +inherit python3native setuptools
> >
> >
> >
> >  # Chromium itself is licensed under the 3-clause BSD license.
> > However, it
> >
> >  # depends upon several other projects whose copyright files are
> > listed in
> >
> > --
> >
> > 2.7.4
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> 
> >