All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Ond??ej Jirman <megous@megous.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	linux-sunxi@googlegroups.com,
	Thierry Reding <thierry.reding@gmail.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Rob Herring <robh+dt@kernel.org>,
	Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Icenowy Zheng <icenowy@aosc.io>,
	devicetree@vger.kernel.org, Samuel Holland <samuel@sholland.org>,
	Bhushan Shah <bshah@kde.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Luca Weiss <luca@z3ntu.xyz>, Martijn Braam <martijn@brixit.nl>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 3/5] drm: panel: Add Xingbangda XBD599 panel (ST7703 controller)
Date: Tue, 23 Jun 2020 15:35:30 +0200	[thread overview]
Message-ID: <20200623133529.GC2783@bug> (raw)
In-Reply-To: <20200622111752.jsz37zl7hidvkozw@core.my.home>

Hi!
> > > > Would it not be better to have one st7703 driver that suipports both
> > > > panels?
> > > >
> > > > The driver would need dedicated init functions depending on the panel.
> > > > But a lot could also be shared.
> > > 
> > > I guess I can move the code there. 
> > In the same process the river should then be renamed to follow other
> > sitronix based drivers.
> > So the next developer will recognize this and use the correct driver.
> 
> Are driver/module names considered kernel ABI? Or is it possible to
> change them?

I believe you can get away with changing them.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Ond??ej Jirman <megous@megous.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	linux-sunxi@googlegroups.com,
	Thierry Reding <thierry.reding@gmail.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Rob Herring <robh+dt@kernel.org>,
	Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Icenowy Zheng <icenowy@aosc.io>,
	devicetree@vger.kernel.org, Samuel Holland <samuel@sholland.org>,
	Bhushan Shah <bshah@kde.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Luca Weiss <luca@z3ntu.xyz>, Martijn Braam <martijn@brixit.nl>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 3/5] drm: panel: Add Xingbangda XBD599 panel (ST7703 controller)
Date: Tue, 23 Jun 2020 15:35:30 +0200	[thread overview]
Message-ID: <20200623133529.GC2783@bug> (raw)
In-Reply-To: <20200622111752.jsz37zl7hidvkozw@core.my.home>

Hi!
> > > > Would it not be better to have one st7703 driver that suipports both
> > > > panels?
> > > >
> > > > The driver would need dedicated init functions depending on the panel.
> > > > But a lot could also be shared.
> > > 
> > > I guess I can move the code there. 
> > In the same process the river should then be renamed to follow other
> > sitronix based drivers.
> > So the next developer will recognize this and use the correct driver.
> 
> Are driver/module names considered kernel ABI? Or is it possible to
> change them?

I believe you can get away with changing them.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-06-23 13:35 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-17  0:32 [PATCH v4 0/5] Add support for PinePhone LCD panel Ondrej Jirman
2020-06-17  0:32 ` Ondrej Jirman
2020-06-17  0:32 ` Ondrej Jirman
2020-06-17  0:32 ` [PATCH v4 1/5] dt-bindings: vendor-prefixes: Add Xingbangda Ondrej Jirman
2020-06-17  0:32   ` Ondrej Jirman
2020-06-17  0:32   ` Ondrej Jirman
2020-06-17  0:32 ` [PATCH v4 2/5] dt-bindings: panel: Add binding for Xingbangda XBD599 panel Ondrej Jirman
2020-06-17  0:32   ` Ondrej Jirman
2020-06-17  0:32   ` Ondrej Jirman
2020-06-17  0:32 ` [PATCH v4 3/5] drm: panel: Add Xingbangda XBD599 panel (ST7703 controller) Ondrej Jirman
2020-06-17  0:32   ` Ondrej Jirman
2020-06-17  0:32   ` Ondrej Jirman
2020-06-20 21:25   ` Sam Ravnborg
2020-06-20 21:25     ` Sam Ravnborg
2020-06-20 21:25     ` Sam Ravnborg
2020-06-20 22:30     ` Ondřej Jirman
2020-06-20 22:30       ` Ondřej Jirman
2020-06-22  8:08       ` Sam Ravnborg
2020-06-22  8:08         ` Sam Ravnborg
2020-06-22 11:17         ` Ondřej Jirman
2020-06-22 11:17           ` Ondřej Jirman
2020-06-23 13:35           ` Pavel Machek [this message]
2020-06-23 13:35             ` Pavel Machek
2020-06-17  0:32 ` [PATCH v4 4/5] arm64: dts: sun50i-a64-pinephone: Enable LCD support on PinePhone Ondrej Jirman
2020-06-17  0:32   ` Ondrej Jirman
2020-06-17  0:32   ` Ondrej Jirman
2020-06-17  0:32 ` [PATCH v4 5/5] arm64: dts: sun50i-a64-pinephone: Add touchscreen support Ondrej Jirman
2020-06-17  0:32   ` Ondrej Jirman
2020-06-17  0:32   ` Ondrej Jirman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200623133529.GC2783@bug \
    --to=pavel@ucw.cz \
    --cc=airlied@linux.ie \
    --cc=bshah@kde.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=icenowy@aosc.io \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=luca@z3ntu.xyz \
    --cc=martijn@brixit.nl \
    --cc=megous@megous.com \
    --cc=mripard@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=samuel@sholland.org \
    --cc=thierry.reding@gmail.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.