From: Christoph Hellwig <hch@lst.de>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: sagi@grimberg.me, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, axboe@fb.com,
baolin.wang7@gmail.com, kbusch@kernel.org, hch@lst.de
Subject: Re: [PATCH v2 1/2] nvme: Add Arbitration Burst support
Date: Wed, 24 Jun 2020 08:52:58 +0200 [thread overview]
Message-ID: <20200624065258.GA18130@lst.de> (raw)
In-Reply-To: <32d99c016d23d660f5be4a9754b5b9aafe81ab6c.1592980985.git.baolin.wang@linux.alibaba.com>
On Wed, Jun 24, 2020 at 02:49:57PM +0800, Baolin Wang wrote:
> >From the NVMe spec, "In order to make efficient use of the non-volatile
> memory, it is often advantageous to execute multiple commands from a
> Submission Queue in parallel. For Submission Queues that are using
> weighted round robin with urgent priority class or round robin
> arbitration, host software may configure an Arbitration Burst setting".
> Thus add Arbitration Burst setting support.
What is the value add of doing this in the kernel? Wouldn't a nvme-cli
subcommand to just set the arbitration burst to the recommended value,
either as a saved or current value be both more useful and also cause
less kernel bloat?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me,
baolin.wang7@gmail.com, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] nvme: Add Arbitration Burst support
Date: Wed, 24 Jun 2020 08:52:58 +0200 [thread overview]
Message-ID: <20200624065258.GA18130@lst.de> (raw)
In-Reply-To: <32d99c016d23d660f5be4a9754b5b9aafe81ab6c.1592980985.git.baolin.wang@linux.alibaba.com>
On Wed, Jun 24, 2020 at 02:49:57PM +0800, Baolin Wang wrote:
> >From the NVMe spec, "In order to make efficient use of the non-volatile
> memory, it is often advantageous to execute multiple commands from a
> Submission Queue in parallel. For Submission Queues that are using
> weighted round robin with urgent priority class or round robin
> arbitration, host software may configure an Arbitration Burst setting".
> Thus add Arbitration Burst setting support.
What is the value add of doing this in the kernel? Wouldn't a nvme-cli
subcommand to just set the arbitration burst to the recommended value,
either as a saved or current value be both more useful and also cause
less kernel bloat?
next prev parent reply other threads:[~2020-06-24 6:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 6:49 [PATCH v2 0/2] Some improvements for NVMe Baolin Wang
2020-06-24 6:49 ` Baolin Wang
2020-06-24 6:49 ` [PATCH v2 1/2] nvme: Add Arbitration Burst support Baolin Wang
2020-06-24 6:49 ` Baolin Wang
2020-06-24 6:52 ` Christoph Hellwig [this message]
2020-06-24 6:52 ` Christoph Hellwig
2020-06-24 7:58 ` Baolin Wang
2020-06-24 7:58 ` Baolin Wang
2020-06-26 8:26 ` Christoph Hellwig
2020-06-26 8:26 ` Christoph Hellwig
2020-06-24 6:49 ` [PATCH v2 2/2] nvme: Use USEC_PER_SEC instead of magic numbers Baolin Wang
2020-06-24 6:49 ` Baolin Wang
2020-06-26 8:28 ` Christoph Hellwig
2020-06-26 8:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624065258.GA18130@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=baolin.wang7@gmail.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.